)]}'
{"id":"openstack%2Fpython-glanceclient~583468","triplet_id":"openstack%2Fpython-glanceclient~master~I5aa71b3e2b9b19581e46ccf8a80eda5d637f17d1","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1783290","hashtags":[],"change_id":"I5aa71b3e2b9b19581e46ccf8a80eda5d637f17d1","subject":"Do not quote \u0027+\u0027 for token header","status":"MERGED","created":"2018-07-18 06:52:02.000000000","updated":"2018-07-25 20:39:53.000000000","submitted":"2018-07-25 20:39:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"583468-1532551193227-f867b297","meta_rev_id":"295e66a2e3fa2a82d776a610340580bcf219627c","_number":583468,"virtual_id_number":583468,"owner":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":2,"date":"2018-07-25 20:39:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2018-07-25 18:54:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2018-07-25 19:02:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2018-07-25 19:02:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-18 10:06:35.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2018-07-24 18:36:17.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2018-07-25 01:47:39.000000000","updated_by":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"reviewer":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"state":"REVIEWER"},{"updated":"2018-07-25 18:54:19.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2018-07-25 19:02:31.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2018-07-25 20:39:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c3951f27e7cf277514bdd1ac67e6617de6bc2a38","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-18 06:52:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba907ea5433ffd3a74f0b3e8778cbdb7979025c7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-18 07:21:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/68/583468/1/check/openstack-tox-pep8/493ce95/ : SUCCESS in 6m 11s\n- openstack-tox-py27 http://logs.openstack.org/68/583468/1/check/openstack-tox-py27/798164a/ : FAILURE in 6m 46s\n- openstack-tox-py35 http://logs.openstack.org/68/583468/1/check/openstack-tox-py35/56a4fe2/ : FAILURE in 5m 17s\n- build-openstack-sphinx-docs http://logs.openstack.org/68/583468/1/check/build-openstack-sphinx-docs/9236046/html/ : SUCCESS in 6m 25s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/68/583468/1/check/legacy-tempest-dsvm-neutron-src/e88ff45/ : FAILURE in 23m 33s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/68/583468/1/check/glanceclient-dsvm-functional-v1/2f66bba/ : FAILURE in 27m 07s\n- glanceclient-dsvm-functional http://logs.openstack.org/68/583468/1/check/glanceclient-dsvm-functional/d8bad6c/ : FAILURE in 22m 05s\n- openstack-tox-lower-constraints http://logs.openstack.org/68/583468/1/check/openstack-tox-lower-constraints/c53fefa/ : FAILURE in 6m 00s","accounts_in_message":[],"_revision_number":1},{"id":"2da16fd1dc3d1d63ef2f2bebcc97946cb562e78f","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-18 08:01:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c420f49c90f39b2a9b536aa1799f47cb7bb7a408","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-18 09:40:52.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/68/583468/2/check/openstack-tox-pep8/d0ba074/ : SUCCESS in 6m 02s\n- openstack-tox-py27 http://logs.openstack.org/68/583468/2/check/openstack-tox-py27/d3752a9/ : FAILURE in 7m 22s\n- openstack-tox-py35 http://logs.openstack.org/68/583468/2/check/openstack-tox-py35/4c612e3/ : FAILURE in 5m 35s\n- build-openstack-sphinx-docs http://logs.openstack.org/68/583468/2/check/build-openstack-sphinx-docs/3de4e9e/html/ : SUCCESS in 6m 22s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/68/583468/2/check/legacy-tempest-dsvm-neutron-src/f3733b4/ : SUCCESS in 1h 29m 41s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/68/583468/2/check/glanceclient-dsvm-functional-v1/420c5d5/ : FAILURE in 27m 45s\n- glanceclient-dsvm-functional http://logs.openstack.org/68/583468/2/check/glanceclient-dsvm-functional/522b210/ : FAILURE in 29m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/68/583468/2/check/openstack-tox-lower-constraints/238bd19/ : FAILURE in 7m 27s","accounts_in_message":[],"_revision_number":2},{"id":"0465a9a777209a24d4005f8882ba2dddd0af63ff","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2018-07-18 10:06:35.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThanks for the patch, find comments inline","accounts_in_message":[],"_revision_number":2},{"id":"589e7542040438d751425f7677d0118674bbf51f","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-19 01:00:59.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"e24fdb36bbdfd13d799bc26e302601a9a5b49cc8","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-07-23 10:15:44.000000000","message":"Patch Set 2:\n\n@wxy: can you file a bug for this?  We made a change recently to bring HTTP header handling into compliance with RFC 8187, which is what\u0027s forcing the url encoding of the token header.  I wonder whether the correct fix for this is in keystone?  In any case, it would be worth having a bug report where this can be discussed.  Thanks!","accounts_in_message":[],"_revision_number":2},{"id":"f6d63f0dfa39e6e1a3c6e1616484f378773aef5a","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-24 09:23:37.000000000","message":"Patch Set 2:\n\n\u003e @wxy: can you file a bug for this?  We made a change recently to\n \u003e bring HTTP header handling into compliance with RFC 8187, which is\n \u003e what\u0027s forcing the url encoding of the token header.  I wonder\n \u003e whether the correct fix for this is in keystone?  In any case, it\n \u003e would be worth having a bug report where this can be discussed. \n \u003e Thanks!\n\nadded a bug and my thought here:\nhttps://bugs.launchpad.net/python-glanceclient/+bug/1783290","accounts_in_message":[],"_revision_number":2},{"id":"ae14d3462093e802c1dd3d93597188e7adb8c6a9","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-07-24 18:36:17.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nBiggest issue I see is the test failures.","accounts_in_message":[],"_revision_number":2},{"id":"15cf1479b3bf706a7bcdda3f60f4f3e9ccd71eec","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-25 01:33:57.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"253aa5b130b4055ee3ae9ec34eb3bf10a918a875","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2018-07-25 01:47:39.000000000","message":"Patch Set 3:\n\nThis can works with OpenTelekomCloud, which still using PKI token, thanks wangxiyuan!","accounts_in_message":[],"_revision_number":3},{"id":"2b9f48abb65eb716ecd99596050c1972e331fdcf","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-25 02:16:22.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3bcb62b867d84214d21511daa1c20e3738005560","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-25 02:16:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e978198ce8cad234601a9179e11c461cca0f9817","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 03:49:07.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/68/583468/4/check/openstack-tox-pep8/9b5ee6e/ : SUCCESS in 6m 10s\n- openstack-tox-py27 http://logs.openstack.org/68/583468/4/check/openstack-tox-py27/40e15d1/ : SUCCESS in 5m 22s\n- openstack-tox-py35 http://logs.openstack.org/68/583468/4/check/openstack-tox-py35/27fbd60/ : FAILURE in 5m 11s\n- build-openstack-sphinx-docs http://logs.openstack.org/68/583468/4/check/build-openstack-sphinx-docs/e29b05a/html/ : SUCCESS in 4m 40s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/68/583468/4/check/legacy-tempest-dsvm-neutron-src/e459622/ : SUCCESS in 1h 31m 08s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/68/583468/4/check/glanceclient-dsvm-functional-v1/d73c0ce/ : SUCCESS in 36m 11s\n- glanceclient-dsvm-functional http://logs.openstack.org/68/583468/4/check/glanceclient-dsvm-functional/9d8e9ea/ : SUCCESS in 26m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/68/583468/4/check/openstack-tox-lower-constraints/cf71a50/ : FAILURE in 4m 34s","accounts_in_message":[],"_revision_number":4},{"id":"b3c4be695ff863c4f6358fe6304e02b1d1d1c512","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2018-07-25 08:24:13.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"0d8172709a2233cce16a539f15c9d0f90877afb4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 10:30:33.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/68/583468/5/check/openstack-tox-pep8/386bb44/ : SUCCESS in 4m 19s\n- openstack-tox-py27 http://logs.openstack.org/68/583468/5/check/openstack-tox-py27/ea98f32/ : SUCCESS in 4m 52s\n- openstack-tox-py35 http://logs.openstack.org/68/583468/5/check/openstack-tox-py35/d5d8875/ : SUCCESS in 5m 03s\n- build-openstack-sphinx-docs http://logs.openstack.org/68/583468/5/check/build-openstack-sphinx-docs/f57ae4b/html/ : SUCCESS in 4m 31s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/68/583468/5/check/legacy-tempest-dsvm-neutron-src/660c9e8/ : SUCCESS in 1h 36m 19s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/68/583468/5/check/glanceclient-dsvm-functional-v1/eec0d98/ : SUCCESS in 28m 28s\n- glanceclient-dsvm-functional http://logs.openstack.org/68/583468/5/check/glanceclient-dsvm-functional/9ea5751/ : SUCCESS in 27m 24s\n- openstack-tox-lower-constraints http://logs.openstack.org/68/583468/5/check/openstack-tox-lower-constraints/b2915a5/ : SUCCESS in 5m 33s","accounts_in_message":[],"_revision_number":5},{"id":"4d9b55e602aaed586cff4247dce9a527127c9fa3","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-07-25 18:54:19.000000000","message":"Patch Set 5: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"64a4410d11e4ea8902e5ea23804779f8004889e8","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-07-25 19:02:31.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nMakes sense.","accounts_in_message":[],"_revision_number":5},{"id":"b62bc874613f7ed3e55ab9d83a104aa6d1cda439","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 19:02:44.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"9bfdd2acc0b9189a7af181d708533d3320d2f574","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 20:39:53.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/68/583468/5/gate/openstack-tox-pep8/215806f/ : SUCCESS in 6m 57s\n- openstack-tox-py27 http://logs.openstack.org/68/583468/5/gate/openstack-tox-py27/7322f55/ : SUCCESS in 4m 55s\n- openstack-tox-py35 http://logs.openstack.org/68/583468/5/gate/openstack-tox-py35/94b5cdd/ : SUCCESS in 4m 40s\n- build-openstack-sphinx-docs http://logs.openstack.org/68/583468/5/gate/build-openstack-sphinx-docs/1c572f8/html/ : SUCCESS in 4m 31s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/68/583468/5/gate/legacy-tempest-dsvm-neutron-src/7bbbc73/ : SUCCESS in 1h 19m 25s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/68/583468/5/gate/glanceclient-dsvm-functional-v1/340da3b/ : SUCCESS in 24m 19s\n- glanceclient-dsvm-functional http://logs.openstack.org/68/583468/5/gate/glanceclient-dsvm-functional/033b56a/ : SUCCESS in 33m 01s\n- openstack-tox-lower-constraints http://logs.openstack.org/68/583468/5/gate/openstack-tox-lower-constraints/84cfa81/ : SUCCESS in 5m 16s","accounts_in_message":[],"_revision_number":5},{"id":"5478a2bdf2cef2b5f6d1964b0a4ee35dfac35a12","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 20:39:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"818362147d0622752d051bd78ae839497a602e44","revisions":{"7f019cedcee7dd166611d15514276af592c79379":{"kind":"REWORK","_number":1,"created":"2018-07-18 06:52:02.000000000","uploader":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"ref":"refs/changes/68/583468/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/68/583468/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/1"}}},"commit":{"parents":[{"commit":"71abbfca2a5927d19ad5a7187bb2112e907b301a","subject":"Merge \"Fix docs cli authorize environment variables\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/71abbfca2a5927d19ad5a7187bb2112e907b301a"}]}],"author":{"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","date":"2018-07-18 03:30:10.000000000","tz":480},"committer":{"name":"wangxiyuan","email":"wangxiyuan@huawei.com","date":"2018-07-18 06:51:44.000000000","tz":480},"subject":"Do not quote token","message":"Do not quote token\n\nThe token in request header may contain url char, such as \u0027+\u0027,\nif quote it, \u0027+\u0027 will change to \u0027%2B\u0027 which will lead to 401 error.\n\nOur CI doesn\u0027t notice this bug because Keystone use fernet token\nwhich doesn\u0027t contain url char by default. But token format in\nkeystone is plugable, some out-tree token formats may contain\nurl char (for example, PKI/PKIZ token).\n\nSo we should skip quote token to avoiding information changing.\n\nChange-Id: I5aa71b3e2b9b19581e46ccf8a80eda5d637f17d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7f019cedcee7dd166611d15514276af592c79379"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7f019cedcee7dd166611d15514276af592c79379"}]},"branch":"refs/heads/master"},"15c979ae506604373e1a468f6affc0b224c7095c":{"kind":"REWORK","_number":2,"created":"2018-07-18 08:01:58.000000000","uploader":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"ref":"refs/changes/68/583468/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/68/583468/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/2"}}},"commit":{"parents":[{"commit":"71abbfca2a5927d19ad5a7187bb2112e907b301a","subject":"Merge \"Fix docs cli authorize environment variables\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/71abbfca2a5927d19ad5a7187bb2112e907b301a"}]}],"author":{"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","date":"2018-07-18 03:30:10.000000000","tz":480},"committer":{"name":"wangxiyuan","email":"wangxiyuan@huawei.com","date":"2018-07-18 08:01:36.000000000","tz":480},"subject":"Do not quote token","message":"Do not quote token\n\nThe token in request header may contain url char, such as \u0027+\u0027,\nif quote it, \u0027+\u0027 will change to \u0027%2B\u0027 which will lead to 401 error.\n\nOur CI doesn\u0027t notice this bug because Keystone use fernet token\nwhich doesn\u0027t contain url char by default. But token format in\nkeystone is plugable, some out-tree token formats may contain\nurl char (for example, PKI/PKIZ token).\n\nSo we should skip quote token to avoiding information changing.\n\nChange-Id: I5aa71b3e2b9b19581e46ccf8a80eda5d637f17d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/15c979ae506604373e1a468f6affc0b224c7095c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/15c979ae506604373e1a468f6affc0b224c7095c"}]},"branch":"refs/heads/master"},"5baa31bd0817e7b813c07fba4181b5d216da7af4":{"kind":"REWORK","_number":3,"created":"2018-07-25 01:33:57.000000000","uploader":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"ref":"refs/changes/68/583468/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/68/583468/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/3"}}},"commit":{"parents":[{"commit":"ccbd86ba131d319e512bf4855e9b3152cc073fee","subject":"Merge \"Unit tests for multi-store support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ccbd86ba131d319e512bf4855e9b3152cc073fee"}]}],"author":{"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","date":"2018-07-18 03:30:10.000000000","tz":480},"committer":{"name":"wangxiyuan","email":"wangxiyuan@huawei.com","date":"2018-07-25 01:33:14.000000000","tz":480},"subject":"Do not quote token","message":"Do not quote token\n\nThe token in request header may contain url char, such as \u0027+\u0027,\nif quote it, \u0027+\u0027 will change to \u0027%2B\u0027 which will lead to 401 error.\n\nOur CI doesn\u0027t notice this bug because Keystone use fernet token\nwhich doesn\u0027t contain url char by default. But token format in\nkeystone is plugable, some out-tree token formats may contain\nurl char (for example, PKI/PKIZ token).\n\nSo we should skip quote token to avoiding information changing.\n\nCloses-bug: #1783290\nChange-Id: I5aa71b3e2b9b19581e46ccf8a80eda5d637f17d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5baa31bd0817e7b813c07fba4181b5d216da7af4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5baa31bd0817e7b813c07fba4181b5d216da7af4"}]},"branch":"refs/heads/master"},"84ea9afa884679dc2e38e581928c9a2bd666e613":{"kind":"REWORK","_number":4,"created":"2018-07-25 02:16:22.000000000","uploader":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"ref":"refs/changes/68/583468/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/68/583468/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/4"}}},"commit":{"parents":[{"commit":"ccbd86ba131d319e512bf4855e9b3152cc073fee","subject":"Merge \"Unit tests for multi-store support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ccbd86ba131d319e512bf4855e9b3152cc073fee"}]}],"author":{"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","date":"2018-07-18 03:30:10.000000000","tz":480},"committer":{"name":"wangxiyuan","email":"wangxiyuan@huawei.com","date":"2018-07-25 02:15:41.000000000","tz":480},"subject":"Do not quote token","message":"Do not quote token\n\nThe token in request header may contain url char, such as \u0027+\u0027,\nif quote it, \u0027+\u0027 will change to \u0027%2B\u0027 which will lead to 401 error.\n\nOur CI doesn\u0027t notice this bug because Keystone use fernet token\nwhich doesn\u0027t contain url char by default. But token format in\nkeystone is plugable, some out-tree token formats may contain\nurl char (for example, PKI/PKIZ token).\n\nSo we should skip quote token to avoiding information changing.\n\nCloses-bug: #1783290\nChange-Id: I5aa71b3e2b9b19581e46ccf8a80eda5d637f17d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/84ea9afa884679dc2e38e581928c9a2bd666e613"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/84ea9afa884679dc2e38e581928c9a2bd666e613"}]},"branch":"refs/heads/master"},"818362147d0622752d051bd78ae839497a602e44":{"kind":"REWORK","_number":5,"created":"2018-07-25 08:24:13.000000000","uploader":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"ref":"refs/changes/68/583468/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/68/583468/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/68/583468/5"}}},"commit":{"parents":[{"commit":"ccbd86ba131d319e512bf4855e9b3152cc073fee","subject":"Merge \"Unit tests for multi-store support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ccbd86ba131d319e512bf4855e9b3152cc073fee"}]}],"author":{"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","date":"2018-07-18 03:30:10.000000000","tz":480},"committer":{"name":"wangxiyuan","email":"wangxiyuan@huawei.com","date":"2018-07-25 08:22:43.000000000","tz":480},"subject":"Do not quote \u0027+\u0027 for token header","message":"Do not quote \u0027+\u0027 for token header\n\nThe token in request header may contain url char, such as \u0027+\u0027,\nif quote it, \u0027+\u0027 will change to \u0027%2B\u0027 which will lead to 401 error.\n\nOur CI doesn\u0027t notice this bug because Keystone use fernet token\nwhich doesn\u0027t contain url char by default. But token format in\nkeystone is plugable, some out-tree token formats may contain\nurl char (for example, PKI/PKIZ token).\n\nSo we should skip quote token to avoiding information changing.\n\nCloses-bug: #1783290\nChange-Id: I5aa71b3e2b9b19581e46ccf8a80eda5d637f17d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/818362147d0622752d051bd78ae839497a602e44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/818362147d0622752d051bd78ae839497a602e44"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}