)]}'
{"glanceclient/v2/images.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"45a53bef4ce152d178db773111ee766811b1e567","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                        allow_md5_fallback):"},{"line_number":250,"context_line":"                    check_md5sum \u003d True"},{"line_number":251,"context_line":"                else:"},{"line_number":252,"context_line":"                    raise ve"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        if do_checksum and check_md5sum:"},{"line_number":255,"context_line":"            if meta_checksum is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_afcdd030","line":252,"updated":"2018-09-07 13:49:10.000000000","message":"Should just be \"raise\", not \"raise ve\" to preserve traceback.","commit_id":"4484846e4f72fdfaec19ca7ecb55c6a4e69b4026"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ac8b8ecf4f9abc7e1e22e8a88c61b08d2fb431c","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                        allow_md5_fallback):"},{"line_number":250,"context_line":"                    check_md5sum \u003d True"},{"line_number":251,"context_line":"                else:"},{"line_number":252,"context_line":"                    raise ve"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        if do_checksum and check_md5sum:"},{"line_number":255,"context_line":"            if meta_checksum is not None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4f267ccd","line":252,"in_reply_to":"3f79a3b5_afcdd030","updated":"2018-09-07 14:00:54.000000000","message":"Right you are.","commit_id":"4484846e4f72fdfaec19ca7ecb55c6a4e69b4026"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"45a53bef4ce152d178db773111ee766811b1e567","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        utils.print_dict(stores_info)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"@utils.arg(\u0027--allow_md5_fallback\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":494,"context_line":"           default\u003dutils.env(\u0027OS_IMAGE_ALLOW_MD5_FALLBACK\u0027, default\u003dFalse),"},{"line_number":495,"context_line":"           help\u003d_(\u0027If os_hash_algo and os_hash_value properties are available \u0027"},{"line_number":496,"context_line":"                  \u0027on the image, they will be used to validate the downloaded \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_6fb25896","line":493,"range":{"start_line":493,"start_character":12,"end_line":493,"end_character":32},"updated":"2018-09-07 13:49:10.000000000","message":"I think this should be --allow-md5-fallback. Convention usually is to use dashes for args and underscores for metavar values.","commit_id":"4484846e4f72fdfaec19ca7ecb55c6a4e69b4026"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ac8b8ecf4f9abc7e1e22e8a88c61b08d2fb431c","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        utils.print_dict(stores_info)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"@utils.arg(\u0027--allow_md5_fallback\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":494,"context_line":"           default\u003dutils.env(\u0027OS_IMAGE_ALLOW_MD5_FALLBACK\u0027, default\u003dFalse),"},{"line_number":495,"context_line":"           help\u003d_(\u0027If os_hash_algo and os_hash_value properties are available \u0027"},{"line_number":496,"context_line":"                  \u0027on the image, they will be used to validate the downloaded \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ef1ae87a","line":493,"range":{"start_line":493,"start_character":12,"end_line":493,"end_character":32},"in_reply_to":"3f79a3b5_6fb25896","updated":"2018-09-07 14:00:54.000000000","message":"Good catch!","commit_id":"4484846e4f72fdfaec19ca7ecb55c6a4e69b4026"}]}
