)]}'
{"id":"openstack%2Fpython-glanceclient~60011","triplet_id":"openstack%2Fpython-glanceclient~master~I22b9117fa0dd28e351c2d6062237216424fd88cd","project":"openstack/python-glanceclient","branch":"master","topic":"bash-completion","hashtags":[],"change_id":"I22b9117fa0dd28e351c2d6062237216424fd88cd","subject":"Support bash completion","status":"ABANDONED","created":"2013-12-04 16:00:09.000000000","updated":"2014-01-16 06:03:17.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bac9a6ffd7a3b6f3c6478d5b8e5a709879733136","_number":60011,"virtual_id_number":60011,"owner":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":1,"date":"2013-12-09 15:02:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"date":"2013-12-09 15:16:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-12-11 05:36:17.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},{"value":-1,"date":"2014-01-05 17:38:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},{"date":"2014-01-05 17:38:20.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-05 22:12:05.000000000","updated_by":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"reviewer":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"state":"REVIEWER"},{"updated":"2013-12-09 15:02:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-12-11 05:36:17.000000000","updated_by":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"reviewer":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"state":"REVIEWER"},{"updated":"2014-01-05 17:38:20.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"}],"messages":[{"id":"2d820a1e9d7be9a6f88e732b42f39f8b194afb53","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-04 16:47:49.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-pep8/c97fa10 : SUCCESS in 1m 33s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/11/60011/1/check/gate-python-glanceclient-docs/0ef771b/doc/build/html/ : SUCCESS in 58s\n- gate-python-glanceclient-python26 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-python26/bd1e57b : SUCCESS in 1m 09s\n- gate-python-glanceclient-python27 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-python27/ffc8de5 : SUCCESS in 51s\n- gate-python-glanceclient-python33 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-python33/5ec5e02 : FAILURE in 13s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/11/60011/1/check/check-tempest-dsvm-full/cf891b6 : FAILURE in 47m 36s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/11/60011/1/check/check-tempest-dsvm-postgres-full/6beacdd : FAILURE in 40m 35s\n- check-tempest-dsvm-neutron http://logs.openstack.org/11/60011/1/check/check-tempest-dsvm-neutron/47dcee5 : FAILURE in 25m 57s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/11/60011/1/check/gate-tempest-dsvm-large-ops/8c0f90f : SUCCESS in 13m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/11/60011/1/check/gate-tempest-dsvm-neutron-large-ops/772d4da : SUCCESS in 19m 11s\n- check-grenade-dsvm http://logs.openstack.org/11/60011/1/check/check-grenade-dsvm/7511788 : SUCCESS in 23m 56s\n","accounts_in_message":[],"_revision_number":1},{"id":"d8e1a5c49cdbdc559629bff106a8e1df98a2c2a9","author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"date":"2013-12-05 11:05:10.000000000","message":"Patch Set 1:\n\nrecheck bug 1247194","accounts_in_message":[],"_revision_number":1},{"id":"47c3ba0533f199189fe7715d29cd389d8bb97615","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-05 11:53:09.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-pep8/36cd982 : SUCCESS in 47s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/11/60011/1/check/gate-python-glanceclient-docs/d3d0797/doc/build/html/ : SUCCESS in 48s\n- gate-python-glanceclient-python26 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-python26/6d0aa9b : SUCCESS in 1m 31s\n- gate-python-glanceclient-python27 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-python27/ca949f7 : SUCCESS in 49s\n- gate-python-glanceclient-python33 http://logs.openstack.org/11/60011/1/check/gate-python-glanceclient-python33/cb5cbbf : FAILURE in 13s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/11/60011/1/check/check-tempest-dsvm-full/858c5d6 : SUCCESS in 47m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/11/60011/1/check/check-tempest-dsvm-postgres-full/8fe518c : SUCCESS in 38m 42s\n- check-tempest-dsvm-neutron http://logs.openstack.org/11/60011/1/check/check-tempest-dsvm-neutron/eae2f69 : SUCCESS in 32m 14s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/11/60011/1/check/gate-tempest-dsvm-large-ops/1d2e1b0 : SUCCESS in 11m 33s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/11/60011/1/check/gate-tempest-dsvm-neutron-large-ops/9c77e9d : SUCCESS in 13m 04s\n- check-grenade-dsvm http://logs.openstack.org/11/60011/1/check/check-grenade-dsvm/1bcd254 : SUCCESS in 32m 08s\n","accounts_in_message":[],"_revision_number":1},{"id":"10ec9769dccc0f641d9494269de9eb978513584c","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-12-05 22:12:05.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nCould you include some information on how this works? I sourced glance.bash_completion and it seemed to work. \n\nAlso, novaclient has had this functionality for a few years and it has evolved a bit. There may be things in there we want to adopt.\n\nPlease let me know your thoughts :)","accounts_in_message":[],"_revision_number":1},{"id":"996fbae3e90c6e1f43eda1fbcb686f655027faf0","author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"date":"2013-12-06 10:22:12.000000000","message":"Patch Set 1:\n\nWhen you source glance.bash_completion it registers the _glance function to complete arguments of the glance command. Usually this script is put into the directory /etc/bash_completion.d/ so that you don\u0027t have to source it manually.\n\nEach time the tab key is pressed after the glance command, _glance is called, which gets the available options by running \u0027glance bash_completion\u0027 and chooses the appropriate completion using compgen.\n\nI have checked novaclient, it has 3 extra functions:\n- cache output of \"nova bash-complete\" to run faster\n- distinguish between flags and commands (based on already typed text)\n- use cached info from ~/.novaclient to complete ids, etc.\n\nI think the first two could be added to glance.bash_completion, the third not really since I couldn\u0027t find any cache for glanceclient.","accounts_in_message":[],"_revision_number":1},{"id":"c0374de9293cac036adf4e949b99e7b9d00c93b6","author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"date":"2013-12-09 14:27:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fc79dd26d82307f52b8ca6176684b48152a96e93","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-09 15:02:01.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/11/60011/2/check/gate-python-glanceclient-pep8/225878e : SUCCESS in 57s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/11/60011/2/check/gate-python-glanceclient-docs/eaa15ed/doc/build/html/ : SUCCESS in 59s\n- gate-python-glanceclient-python26 http://logs.openstack.org/11/60011/2/check/gate-python-glanceclient-python26/fa4adca : SUCCESS in 1m 06s\n- gate-python-glanceclient-python27 http://logs.openstack.org/11/60011/2/check/gate-python-glanceclient-python27/18018b7 : SUCCESS in 1m 02s\n- gate-python-glanceclient-python33 http://logs.openstack.org/11/60011/2/check/gate-python-glanceclient-python33/1652089 : FAILURE in 14s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/11/60011/2/check/check-tempest-dsvm-full/548db08 : SUCCESS in 34m 21s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/11/60011/2/check/check-tempest-dsvm-postgres-full/5e49059 : SUCCESS in 30m 54s\n- check-tempest-dsvm-neutron http://logs.openstack.org/11/60011/2/check/check-tempest-dsvm-neutron/0fa4492 : SUCCESS in 33m 00s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/11/60011/2/check/gate-tempest-dsvm-large-ops/0b31eb9 : SUCCESS in 16m 13s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/11/60011/2/check/gate-tempest-dsvm-neutron-large-ops/61dfb85 : SUCCESS in 13m 33s\n- check-grenade-dsvm http://logs.openstack.org/11/60011/2/check/check-grenade-dsvm/542cb5e : SUCCESS in 28m 58s\n","accounts_in_message":[],"_revision_number":2},{"id":"2f50a38a24f63b368baa780a73554d7111bd9894","author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"date":"2013-12-09 15:16:23.000000000","message":"Patch Set 2:\n\nNew in Patch Set 2:the completer function caches output of \"glance bash-completion\" to run faster, and distinguishes between flags and commands (based on already typed text).","accounts_in_message":[],"_revision_number":2},{"id":"d40d564f9d99abf3b9462c090e45063a7db9122f","author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"date":"2013-12-11 05:36:17.000000000","message":"Patch Set 2:\n\nPeter, \n\nSeems like we are both interested in seeing this feature in glanceclient... I have been working on adding this feature as well, also borrowing from novaclient. Please have a look at my change Iee96077a if you get a chance.","accounts_in_message":[],"_revision_number":2},{"id":"f68f94d76c7ea4e4ae662d6d708e7c007804318b","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2014-01-05 17:38:20.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nThis looks like its missing some necessary parts--but maybe I\u0027m just not aware of how bash completion is normally done. It seems like the list of options should be more restricted based on the arguments passed to the bash completion command.","accounts_in_message":[],"_revision_number":2},{"id":"068bc918c8d19d62bd5c24fb5b651c3ceea1a601","author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"date":"2014-01-08 13:38:27.000000000","message":"Patch Set 2: (1 inline comment)\n\nPlease see my inline comment.","accounts_in_message":[],"_revision_number":2},{"id":"8e30c417133d2bb690f3dc3e65c357d2260a8286","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-16 06:03:17.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"e6f1d628e6e150f315485194b059205f585fcb2c","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-16 06:03:17.000000000","message":"Patch Set 2:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5e59b61e3095e58af4a7eaadebe0a9b569b676b4","revisions":{"609fcbb70d57a36848a975c5a013a2423e19aad7":{"kind":"REWORK","_number":1,"created":"2013-12-04 16:00:09.000000000","uploader":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"ref":"refs/changes/11/60011/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/11/60011/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/1"}}},"commit":{"parents":[{"commit":"57a2b43f6a672446c8ed5351fbc65235bfd7c08c","subject":"Merge \"Readd missing Babel dependency after merge from Oslo(master/bdda833)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/57a2b43f6a672446c8ed5351fbc65235bfd7c08c"}]}],"author":{"name":"Peter Belanyi","email":"pbelanyi@redhat.com","date":"2013-12-04 15:55:56.000000000","tz":60},"committer":{"name":"Peter Belanyi","email":"pbelanyi@redhat.com","date":"2013-12-04 15:55:56.000000000","tz":60},"subject":"Support bash completion","message":"Support bash completion\n\nAdded support for bash completion, the implementation\nis based on python-cinderclient.\n\nChange-Id: I22b9117fa0dd28e351c2d6062237216424fd88cd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/609fcbb70d57a36848a975c5a013a2423e19aad7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/609fcbb70d57a36848a975c5a013a2423e19aad7"}]},"branch":"refs/heads/master"},"5e59b61e3095e58af4a7eaadebe0a9b569b676b4":{"kind":"REWORK","_number":2,"created":"2013-12-09 14:27:37.000000000","uploader":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"ref":"refs/changes/11/60011/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/11/60011/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/11/60011/2"}}},"commit":{"parents":[{"commit":"57a2b43f6a672446c8ed5351fbc65235bfd7c08c","subject":"Merge \"Readd missing Babel dependency after merge from Oslo(master/bdda833)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/57a2b43f6a672446c8ed5351fbc65235bfd7c08c"}]}],"author":{"name":"Peter Belanyi","email":"pbelanyi@redhat.com","date":"2013-12-04 15:55:56.000000000","tz":60},"committer":{"name":"Peter Belanyi","email":"pbelanyi@redhat.com","date":"2013-12-09 14:23:58.000000000","tz":60},"subject":"Support bash completion","message":"Support bash completion\n\nAdded support for bash completion, the implementation\nis based on python-cinderclient and python-novaclient.\n\nThe completer function caches output of \"glance bash-completion\"\nto run faster, and distinguishes between flags and commands\n(based on already typed text).\n\nChange-Id: I22b9117fa0dd28e351c2d6062237216424fd88cd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5e59b61e3095e58af4a7eaadebe0a9b569b676b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5e59b61e3095e58af4a7eaadebe0a9b569b676b4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}