)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"43562ee9d4248269b9b236966c69fa5c946f367d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ea9712a2_562e70d8","updated":"2022-08-04 06:52:59.000000000","message":"recheck network failure (test_hotplug_nic)","commit_id":"99d78e53d853e7dbfe96c6eba39ddf53732012f3"}],"glanceclient/v2/images.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"733beb04cc8e854bf80b7db35fc9b8751b68efe2","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        :param image_id: ID of the image to upload data for."},{"line_number":226,"context_line":"        :param image_data: File-like object supplying the data to upload."},{"line_number":227,"context_line":"        :param image_size: Unused - present for backwards compatibility"},{"line_number":228,"context_line":"        :param u_url: Upload url to upload the data to."},{"line_number":229,"context_line":"        :param backend: Backend store to upload image to."},{"line_number":230,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_07cddd2e","line":227,"range":{"start_line":227,"start_character":27,"end_line":227,"end_character":71},"updated":"2018-09-19 20:31:54.000000000","message":"This should be updated now as that description is inaccurate.","commit_id":"f51d01199792ec84efb0248152d6bd3ce9ca6dc6"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"aebb3e2eb4e39a926a6d99d6efe18390059a7c9e","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        :param image_id: ID of the image to upload data for."},{"line_number":226,"context_line":"        :param image_data: File-like object supplying the data to upload."},{"line_number":227,"context_line":"        :param image_size: Unused - present for backwards compatibility"},{"line_number":228,"context_line":"        :param u_url: Upload url to upload the data to."},{"line_number":229,"context_line":"        :param backend: Backend store to upload image to."},{"line_number":230,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e1276ab5","line":227,"range":{"start_line":227,"start_character":27,"end_line":227,"end_character":71},"in_reply_to":"3f79a3b5_07cddd2e","updated":"2018-09-20 01:39:30.000000000","message":"Thanks for the catch, Sean, updated.","commit_id":"f51d01199792ec84efb0248152d6bd3ce9ca6dc6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c5011b9c41c75647181b777446d879b24aec78b4","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        url \u003d u_url or \u0027/v2/images/%s/file\u0027 % image_id"},{"line_number":235,"context_line":"        hdrs \u003d {"},{"line_number":236,"context_line":"            \u0027Content-Type\u0027: \u0027application/octet-stream\u0027,"},{"line_number":237,"context_line":"            \u0027x-image-meta-size\u0027: str(image_size)"},{"line_number":238,"context_line":"        }"},{"line_number":239,"context_line":"        if backend is not None:"},{"line_number":240,"context_line":"            hdrs[\u0027x-image-meta-store\u0027] \u003d backend"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_7023fca8","line":237,"range":{"start_line":237,"start_character":12,"end_line":237,"end_character":48},"updated":"2019-03-04 09:29:26.000000000","message":"should we include it only if image_size is not None?\n(hardly possible though)","commit_id":"db2a423e17f26fb6908d79af903edf986066d493"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"19354729328e39a08bc77a370bdb524031e9a512","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        url \u003d u_url or \u0027/v2/images/%s/file\u0027 % image_id"},{"line_number":235,"context_line":"        hdrs \u003d {"},{"line_number":236,"context_line":"            \u0027Content-Type\u0027: \u0027application/octet-stream\u0027,"},{"line_number":237,"context_line":"            \u0027x-image-meta-size\u0027: str(image_size)"},{"line_number":238,"context_line":"        }"},{"line_number":239,"context_line":"        if backend is not None:"},{"line_number":240,"context_line":"            hdrs[\u0027x-image-meta-store\u0027] \u003d backend"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_ac3d71bd","line":237,"range":{"start_line":237,"start_character":12,"end_line":237,"end_character":48},"in_reply_to":"9fdfeff1_7023fca8","updated":"2019-03-05 12:36:28.000000000","message":"I think we indeed should. There is at least 2 situations where we would not know the image size when issuing upload:\n\n1) the fd is socket\n2) the image data is streamed to the client from the shell","commit_id":"db2a423e17f26fb6908d79af903edf986066d493"}]}
