)]}'
{"glanceclient/tests/unit/v2/test_shell_v2.py":[{"author":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"change_message_id":"c59941006031c4dee620484e33e2330180759c48","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            \u0027sort_dir\u0027: [\u0027desc\u0027, \u0027asc\u0027],"},{"line_number":265,"context_line":"            \u0027sort\u0027: None,"},{"line_number":266,"context_line":"            \u0027verbose\u0027: False,"},{"line_number":267,"context_line":"            \u0027include_stores\u0027: False,"},{"line_number":268,"context_line":"            \u0027os_hidden\u0027: False"},{"line_number":269,"context_line":"        }"},{"line_number":270,"context_line":"        args \u003d self._make_args(input)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_bbc5b25f","line":267,"range":{"start_line":267,"start_character":13,"end_line":267,"end_character":35},"updated":"2018-11-01 22:00:33.000000000","message":"it would be nice to include a test with include_stores set to True.","commit_id":"bb2938d99bc9e7118b6521f86c06e966f08e103d"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"d0792649717a4cc744f76b43957b31a67e53b4c7","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            \u0027sort_dir\u0027: [\u0027desc\u0027, \u0027asc\u0027],"},{"line_number":265,"context_line":"            \u0027sort\u0027: None,"},{"line_number":266,"context_line":"            \u0027verbose\u0027: False,"},{"line_number":267,"context_line":"            \u0027include_stores\u0027: False,"},{"line_number":268,"context_line":"            \u0027os_hidden\u0027: False"},{"line_number":269,"context_line":"        }"},{"line_number":270,"context_line":"        args \u003d self._make_args(input)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a2c68549","line":267,"range":{"start_line":267,"start_character":13,"end_line":267,"end_character":35},"in_reply_to":"3f79a3b5_bbc5b25f","updated":"2018-11-07 02:31:22.000000000","message":"Nice, added the UT for include_stores been set to True.\n\nAbout function test, verified:\nglance image-list --include-stores\nglance -v image-list --include-stores","commit_id":"bb2938d99bc9e7118b6521f86c06e966f08e103d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d0a394db685f84d50e84dbf842ce222575a607b0","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                                                filters\u003dexp_img_filters)"},{"line_number":288,"context_line":"            utils.print_list.assert_called_once_with({}, [\u0027ID\u0027, \u0027Name\u0027])"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def test_do_image_list_with_include_stores_true(self):"},{"line_number":291,"context_line":"        input \u003d {"},{"line_number":292,"context_line":"            \u0027limit\u0027: None,"},{"line_number":293,"context_line":"            \u0027page_size\u0027: 18,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a72189b4","line":290,"updated":"2018-11-08 20:17:33.000000000","message":"I think you should also add a test for test_do_image_list_verbose_with_include_stores_true().  That will protect your change from a regression if someone comes along and refactors the -v code.  Unfortunately, it looks like there\u0027s no current test_do_image_list_verbose(), so you\u0027ll have to add that one first and then add the new test.","commit_id":"e73d3e4ba52db09a30a244f5ffc507d126cd37c2"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"8bd95dd97dac0fbaf73e6e33f0af6f04eeccb57a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                                                filters\u003dexp_img_filters)"},{"line_number":288,"context_line":"            utils.print_list.assert_called_once_with({}, [\u0027ID\u0027, \u0027Name\u0027])"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def test_do_image_list_with_include_stores_true(self):"},{"line_number":291,"context_line":"        input \u003d {"},{"line_number":292,"context_line":"            \u0027limit\u0027: None,"},{"line_number":293,"context_line":"            \u0027page_size\u0027: 18,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_0405d478","line":290,"in_reply_to":"3f79a3b5_a72189b4","updated":"2018-11-09 01:59:04.000000000","message":"nice capture, it make sense to add test for verbose. done in patchset 8. Thanks.","commit_id":"e73d3e4ba52db09a30a244f5ffc507d126cd37c2"}]}