)]}'
{"glanceclient/common/http.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"18e672ff28ebb672c34ed38c73da49710bcedab0","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                san_list \u003d str(ext)"},{"line_number":368,"context_line":"                for san in \u0027\u0027.join(san_list.split()).split(\u0027,\u0027):"},{"line_number":369,"context_line":"                    if san.startswith(\u0027DNS:\u0027):"},{"line_number":370,"context_line":"                        if check_match(san[4:]):"},{"line_number":371,"context_line":"                            return True"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        # Server certificate does not match host"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9hXw%3D","line":370,"updated":"2013-12-10 16:44:57.000000000","message":"Minor style thing: how about replacing san[4:] with san.split(\u0027:\u0027, 1)[1]? Its one less \u0027magic number\u0027 and matches the host.split style above? (really not a big deal either way)","commit_id":"9b344aefdae098624e7f2d1455667381cc29675f"}],"tests/test_ssl.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"18e672ff28ebb672c34ed38c73da49710bcedab0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            conn \u003d http.VerifiedHTTPSConnection(\u0027alt2.example.com\u0027, 0)"},{"line_number":185,"context_line":"            conn.verify_callback(None, cert, 0, 0, 1)"},{"line_number":186,"context_line":"        except Exception:"},{"line_number":187,"context_line":"            self.fail(\u0027Unexpected exception.\u0027)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_ssl_cert_mismatch(self):"},{"line_number":190,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9hTE%3D","line":187,"updated":"2013-12-10 16:44:57.000000000","message":"possibly overkill ... but what would you say about verifying alt3.example.net raises an exception?","commit_id":"9b344aefdae098624e7f2d1455667381cc29675f"}],"tests/var/wildcard-san-certificate.crt":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"18e672ff28ebb672c34ed38c73da49710bcedab0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#        Issuer: C\u003dUS, ST\u003dCA, L\u003dState1, O\u003dOpenstack Test Org, OU\u003dOpenstack Test Unit, CN\u003d0.0.0.0"},{"line_number":7,"context_line":"#        Validity"},{"line_number":8,"context_line":"#            Not Before: Dec 10 15:31:22 2013 GMT"},{"line_number":9,"context_line":"#            Not After : Nov 16 15:31:22 2113 GMT"},{"line_number":10,"context_line":"#        Subject: C\u003dUS, ST\u003dCA, L\u003dState1, O\u003dOpenstack Test Org, OU\u003dOpenstack Test Unit, CN\u003d0.0.0.0"},{"line_number":11,"context_line":"#        Subject Public Key Info:"},{"line_number":12,"context_line":"#            Public Key Algorithm: rsaEncryption"}],"source_content_type":"application/pkix-cert","patch_set":2,"id":"AAAATn%2F9hbA%3D","line":9,"updated":"2013-12-10 16:44:57.000000000","message":"Nice :-)","commit_id":"9b344aefdae098624e7f2d1455667381cc29675f"}]}
