)]}'
{"glanceclient/common/http.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"de832a9cfb55d6473b33896a141ba24c799efc73","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            if kwargs.get(\u0027insecure\u0027, False) is True:"},{"line_number":178,"context_line":"                self.session.verify \u003d False"},{"line_number":179,"context_line":"            else:"},{"line_number":180,"context_line":"                if kwargs.get(\u0027cacert\u0027, None) is not \u0027\u0027:"},{"line_number":181,"context_line":"                    self.session.verify \u003d kwargs.get(\u0027cacert\u0027, True)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"            self.session.cert \u003d (kwargs.get(\u0027cert_file\u0027),"},{"line_number":184,"context_line":"                                 kwargs.get(\u0027key_file\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_b8be2efd","side":"PARENT","line":181,"range":{"start_line":180,"start_character":1,"end_line":181,"end_character":68},"updated":"2019-04-11 13:35:44.000000000","message":"Here we take \u0027cacert\u0027 value from kwargs and default to None if it doesn\u0027t exists. Then we make sure that it\u0027s not empty string (as in it is specified and specifically set to \u0027\u0027) and we do verification. The verification will only be skipped if the cacert is specifically defined as empty string as in Python `None is not \u0027\u0027` does resolve to True and the following line will be executed.","commit_id":"4aeddfe587f10e5cb4b6e29bf706872817b6d166"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"de832a9cfb55d6473b33896a141ba24c799efc73","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            if kwargs.get(\u0027insecure\u0027, False) is True:"},{"line_number":178,"context_line":"                self.session.verify \u003d False"},{"line_number":179,"context_line":"            else:"},{"line_number":180,"context_line":"                if kwargs.get(\u0027cacert\u0027, None):"},{"line_number":181,"context_line":"                    self.session.verify \u003d kwargs.get(\u0027cacert\u0027, True)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"            self.session.cert \u003d (kwargs.get(\u0027cert_file\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_d850dad7","line":180,"range":{"start_line":180,"start_character":16,"end_line":180,"end_character":46},"updated":"2019-04-11 13:35:44.000000000","message":"This changes the clause to not verify in the cases of cacert being None or not being defined as `if None:` yields false and the following line will not be executed.","commit_id":"c28af6faf2660664f347573239015dbc23803a79"}]}
