)]}'
{"id":"openstack%2Fpython-glanceclient~65036","triplet_id":"openstack%2Fpython-glanceclient~master~I91a137c5c3a9a3cc603804bef5eaea14ae281c08","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1265730","hashtags":[],"change_id":"I91a137c5c3a9a3cc603804bef5eaea14ae281c08","subject":"Fix glanceclient http.py string formatting error","status":"MERGED","created":"2014-01-06 06:52:48.000000000","updated":"2014-01-09 17:50:06.000000000","submitted":"2014-01-09 17:50:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"478ad33ec76f4bb02ddf948a2ed417866f7d5892","_number":65036,"virtual_id_number":65036,"owner":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},{"value":2,"date":"2014-01-09 17:50:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"all":[{"value":0,"date":"2014-01-07 08:48:20.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-01-08 08:17:31.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":2,"date":"2014-01-07 09:57:39.000000000","_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":2,"date":"2014-01-07 15:51:52.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-01-08 08:17:31.000000000","_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"date":"2014-01-07 08:40:30.000000000","_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":1,"date":"2014-01-07 15:51:52.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-07 08:40:30.000000000","updated_by":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"reviewer":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"state":"REVIEWER"},{"updated":"2014-01-07 15:51:52.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2014-01-08 08:17:31.000000000","updated_by":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"reviewer":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"state":"REVIEWER"},{"updated":"2014-01-09 17:50:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a7a3c832e0eff2ea81bf71f4d9607472e1aab2eb","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2014-01-06 07:00:04.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nHello Le Tian Ren, thanks for you working on this. I have one suggestion.","accounts_in_message":[],"_revision_number":1},{"id":"9ff4bd669d47e6b0ccf2b3bdb0f32af841138d8c","author":{"_account_id":9209,"name":"Lin Cai","email":"reachlin@gmail.com","username":"reachlin"},"date":"2014-01-06 07:36:42.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\nLooks great.","accounts_in_message":[],"_revision_number":1},{"id":"0fdea1bfeb255840a2eb76b8eed79e46df05366b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-06 07:39:15.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/36/65036/1/check/gate-python-glanceclient-pep8/073712b : SUCCESS in 53s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/36/65036/1/check/gate-python-glanceclient-docs/51da069/doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-python26 http://logs.openstack.org/36/65036/1/check/gate-python-glanceclient-python26/4dee274 : SUCCESS in 1m 13s\n- gate-python-glanceclient-python27 http://logs.openstack.org/36/65036/1/check/gate-python-glanceclient-python27/2f6146a : SUCCESS in 55s\n- gate-python-glanceclient-python33 http://logs.openstack.org/36/65036/1/check/gate-python-glanceclient-python33/39125d4 : FAILURE in 36s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/36/65036/1/check/check-tempest-dsvm-full/9adc4d9 : SUCCESS in 46m 22s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/36/65036/1/check/check-tempest-dsvm-postgres-full/0082554 : SUCCESS in 43m 13s\n- check-tempest-dsvm-neutron http://logs.openstack.org/36/65036/1/check/check-tempest-dsvm-neutron/5c960f4 : SUCCESS in 40m 29s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/36/65036/1/check/gate-tempest-dsvm-large-ops/e75c7df : SUCCESS in 15m 46s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/36/65036/1/check/gate-tempest-dsvm-neutron-large-ops/07955b0 : SUCCESS in 17m 04s\n- check-grenade-dsvm http://logs.openstack.org/36/65036/1/check/check-grenade-dsvm/38906ab : SUCCESS in 29m 16s\n","accounts_in_message":[],"_revision_number":1},{"id":"8985842e78dafaddecbc476927e02aa768cfff7d","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-06 07:47:56.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"8a4c62ed3d17acc3974bc1b556517d590d259e06","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2014-01-06 07:52:36.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6c2968e3d4e5b8339cef1bdcb0ab894f336cafe6","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-06 08:15:06.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"493225e028fc7e29bed5dad313a14c33f41d4595","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2014-01-06 08:23:29.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"7cc54170d5b9e55f04f688d5426362d0c9280a97","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-06 08:37:05.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ae6024f4b4e6adc64e6f58c63dfb796119d76e74","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2014-01-06 09:19:52.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ec58632ad7a5742add51d117ec1067598271cf9b","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-07 03:42:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"08b23a5e4f9ceb12d2fc3b4de6d90d8743f0e193","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2014-01-07 04:25:08.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"2af841a604ddff6f2a06d00b254170f44f8130db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 05:55:23.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/36/65036/2/check/gate-python-glanceclient-pep8/67e7d25 : SUCCESS in 42s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/36/65036/2/check/gate-python-glanceclient-docs/a718ecb/doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-glanceclient-python26 http://logs.openstack.org/36/65036/2/check/gate-python-glanceclient-python26/02af59e : SUCCESS in 1m 09s\n- gate-python-glanceclient-python27 http://logs.openstack.org/36/65036/2/check/gate-python-glanceclient-python27/9a7c109 : SUCCESS in 53s\n- gate-python-glanceclient-python33 http://logs.openstack.org/36/65036/2/check/gate-python-glanceclient-python33/3fa0773 : FAILURE in 19s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/36/65036/2/check/check-tempest-dsvm-full/0e5b019 : FAILURE in 1h 35m 27s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/36/65036/2/check/check-tempest-dsvm-postgres-full/afc238f : SUCCESS in 40m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/36/65036/2/check/check-tempest-dsvm-neutron/31586eb : SUCCESS in 41m 29s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/36/65036/2/check/gate-tempest-dsvm-large-ops/efa0c3f : SUCCESS in 15m 23s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/36/65036/2/check/gate-tempest-dsvm-neutron-large-ops/fd11f01 : SUCCESS in 16m 35s\n- check-grenade-dsvm http://logs.openstack.org/36/65036/2/check/check-grenade-dsvm/f90ad7b : SUCCESS in 32m 02s\n","accounts_in_message":[],"_revision_number":2},{"id":"c65b907fc23accf72491afedd5c13aa89e87dbe5","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-07 06:09:05.000000000","message":"Patch Set 2:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1258682\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1258682\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1258682","accounts_in_message":[],"_revision_number":2},{"id":"6965f16f271ec0e334d85b4b0be99d69ff6de417","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2014-01-07 06:31:44.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI\u0027m echoing zhiyan\u0027s comments, please take this link https://wiki.openstack.org/wiki/GitCommitMessages as a reference.","accounts_in_message":[],"_revision_number":2},{"id":"124eebbe630e32e366cf65d951376444487428d6","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-07 07:13:36.000000000","message":"Patch Set 2: (1 inline comment)\n\n@Zhi Yan Liu, I wrote like just because I read the community guide about commit messages. It tells me less is not more, more is more. And get let my reviewers\u0027 notice to review this patch.\n\nSo my patch messages contains: 1) what I changed, 2)why I change like this 3)any way to mitigate such apparent defects in the future.\n\nDoes my commit message really matters that it should get a -1. Any such precedents? Forgive my asking, I\u0027m a newbie in this community.\n https://wiki.openstack.org/wiki/GitCommitMessages,\n\nInformation in commit messages\n...","accounts_in_message":[],"_revision_number":2},{"id":"4d6220a1cbe4f3d6bed08ea133998ae1fbe180ef","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-07 07:53:40.000000000","message":"Patch Set 2:\n\nrecheck bug 1258682","accounts_in_message":[],"_revision_number":2},{"id":"a94c199bf479617cf1d47e2c8b6313c3a1d15fb3","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-07 08:13:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b3fc511427e9939a6a689365587152ecf17de5ce","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-01-07 08:13:07.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"6295fe2e268a7ee4166347be5f4ec2f03e8b2e8f","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2014-01-07 08:40:30.000000000","message":"Patch Set 3:\n\n\u003e\u003e\u003e Any such precedents?\n\nhttps://review.openstack.org/#/c/64840/ , comment #8.\n\nbtw, do you really think this change is so complicated that we need a very detail explaining as you did before? TBH this string formation issue and the solution is very clear to us. Of course I believe those three point (what and why to do that, and the ways to mitigate such defects in the future) are worth, but generally we do that moderately. welcome.","accounts_in_message":[],"_revision_number":3},{"id":"22a45171274b9401797f01e5c11fb92311e457d5","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-07 08:56:14.000000000","message":"Patch Set 3:\n\nOk. I just reserve my opinion.","accounts_in_message":[],"_revision_number":3},{"id":"5d8b7719f62ad51c041bcfef46becdea5052d67a","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-07 09:02:49.000000000","message":"Patch Set 3:\n\nrecheck bug 1258682","accounts_in_message":[],"_revision_number":3},{"id":"2657203124d695f37e02aa2a09453c185a21d497","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 09:42:05.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/36/65036/3/check/gate-python-glanceclient-pep8/91802b4 : SUCCESS in 56s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/36/65036/3/check/gate-python-glanceclient-docs/183eabd/doc/build/html/ : SUCCESS in 1m 45s\n- gate-python-glanceclient-python26 http://logs.openstack.org/36/65036/3/check/gate-python-glanceclient-python26/0087dc4 : SUCCESS in 1m 13s\n- gate-python-glanceclient-python27 http://logs.openstack.org/36/65036/3/check/gate-python-glanceclient-python27/c0ec311 : SUCCESS in 1m 00s\n- gate-python-glanceclient-python33 http://logs.openstack.org/36/65036/3/check/gate-python-glanceclient-python33/1801ee0 : FAILURE in 25s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/36/65036/3/check/check-tempest-dsvm-full/d452b80 : SUCCESS in 49m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/36/65036/3/check/check-tempest-dsvm-postgres-full/08a03e8 : SUCCESS in 53m 33s\n- check-tempest-dsvm-neutron http://logs.openstack.org/36/65036/3/check/check-tempest-dsvm-neutron/c4e85b4 : SUCCESS in 40m 51s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/36/65036/3/check/gate-tempest-dsvm-large-ops/9dd5601 : SUCCESS in 20m 23s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/36/65036/3/check/gate-tempest-dsvm-neutron-large-ops/35c64c4 : SUCCESS in 21m 22s\n- check-grenade-dsvm http://logs.openstack.org/36/65036/3/check/check-grenade-dsvm/138019a : SUCCESS in 43m 42s\n","accounts_in_message":[],"_revision_number":3},{"id":"104b9edf22baf24fb8e145c06cf2192efcb0bc86","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2014-01-07 09:57:39.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n(1 inline comment)\n\nThanks.","accounts_in_message":[],"_revision_number":3},{"id":"2509e07e9c994a7a379ca7d5c5214b990cc03a12","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2014-01-07 15:51:52.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"9ef70ad93c90fc778f0dd91d3a7453e491de5868","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-07 16:02:19.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"7b0e223cad8fc11ce0cd375bc61f1d748cadeb04","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-08 07:19:00.000000000","message":"Patch Set 3: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"0f4f94624cb7c7331203b390f465f5f3f23f7b54","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2014-01-08 08:17:31.000000000","message":"Patch Set 3:\n\nreverify no bug","accounts_in_message":[],"_revision_number":3},{"id":"9fc9bbf68278357cfae0472158cf9020392654af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-08 09:09:44.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"4462002fc51e671f026aa0cf069508cb274c51a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-08 09:51:36.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"a3f73dee34530f233e13dbc1a04daf5d23ccea6a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-08 11:39:40.000000000","message":"Patch Set 3: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/36/65036/3/gate/gate-python-glanceclient-docs/4134792/doc/build/html/ : SUCCESS in 46s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/36/65036/3/gate/gate-python-glanceclient-pep8/7ccd5a1 : SUCCESS in 1m 04s\n- gate-python-glanceclient-python26 http://logs.openstack.org/36/65036/3/gate/gate-python-glanceclient-python26/beaf3a5 : SUCCESS in 1m 11s\n- gate-python-glanceclient-python27 http://logs.openstack.org/36/65036/3/gate/gate-python-glanceclient-python27/b48b680 : SUCCESS in 1m 08s\n- gate-tempest-dsvm-full http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-full/3e9092d : FAILURE in 57m 37s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-postgres-full/899060a : SUCCESS in 52m 04s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-neutron/0cad46c : SUCCESS in 48m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-large-ops/00f069c : SUCCESS in 21m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-neutron-large-ops/80468e1 : SUCCESS in 21m 55s\n- gate-grenade-dsvm http://logs.openstack.org/36/65036/3/gate/gate-grenade-dsvm/a020c36 : SUCCESS in 1h 03m 10s\n","accounts_in_message":[],"_revision_number":3},{"id":"101b80bce696c5331b55fa5c2ad12301fe4d21a5","author":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"date":"2014-01-08 15:48:22.000000000","message":"Patch Set 3:\n\nreverify no bug","accounts_in_message":[],"_revision_number":3},{"id":"31a5d922ff056ae41707f8e7a5bd47f460c09869","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-08 18:56:41.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"da888a489f8cfa845398d3470ff49ca42954f042","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2014-01-08 18:56:41.000000000","message":"Patch Set 3:\n\nreverify bug 1260574","accounts_in_message":[],"_revision_number":3},{"id":"ae781891657a13d6f6cd74aad72815e0b54d4daf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-08 22:36:22.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"ba75751175ee05da9c170d9f8aa85d1aac8b4356","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 00:04:10.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"308624fddb0825d70abd2d3c641ebf8f8314046b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 17:50:06.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"3707694cc2395026ac650cb04d2c11dd92f072dc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-09 17:50:06.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/36/65036/3/gate/gate-python-glanceclient-docs/8f58c43/doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/36/65036/3/gate/gate-python-glanceclient-pep8/1da91ab : SUCCESS in 51s\n- gate-python-glanceclient-python26 http://logs.openstack.org/36/65036/3/gate/gate-python-glanceclient-python26/5b867fa : SUCCESS in 1m 24s\n- gate-python-glanceclient-python27 http://logs.openstack.org/36/65036/3/gate/gate-python-glanceclient-python27/343c864 : SUCCESS in 1m 07s\n- gate-tempest-dsvm-full http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-full/6d94897 : SUCCESS in 40m 31s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-postgres-full/7ad8db3 : SUCCESS in 39m 25s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-neutron/1532d55 : SUCCESS in 35m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-large-ops/906f5aa : SUCCESS in 13m 52s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/36/65036/3/gate/gate-tempest-dsvm-neutron-large-ops/23f9b1c : SUCCESS in 14m 39s\n- gate-grenade-dsvm http://logs.openstack.org/36/65036/3/gate/gate-grenade-dsvm/f2f2183 : SUCCESS in 37m 36s\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2ed01afac96af59304215e384fd9b0f0be992711","revisions":{"9a7e27422a82dc8a3e26b6d480f566d1bad9168c":{"kind":"REWORK","_number":1,"created":"2014-01-06 06:52:48.000000000","uploader":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"ref":"refs/changes/36/65036/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/65036/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/1"}}},"commit":{"parents":[{"commit":"80cf47e229cae248ee9b8cdb8d28d6206f8db3b0","subject":"Remove unused imports","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/80cf47e229cae248ee9b8cdb8d28d6206f8db3b0"}]}],"author":{"name":"Le Tian Ren","email":"renlet@cn.ibm.com","date":"2014-01-06 06:43:56.000000000","tz":480},"committer":{"name":"Le Tian Ren","email":"renlet@cn.ibm.com","date":"2014-01-06 06:43:56.000000000","tz":480},"subject":"Fix glanceclient http.py string formatting error","message":"Fix glanceclient http.py string formatting error\n\n* Proposed fixes of \"TypeError: not all arguments converted during string\nformatting\" are:\na) msg \u003d \u0027Unable to load CA from \"%s\" %s\u0027 % (self.cacert, e)\n\nb) msg \u003d \u0027Unable to load CA from \"{0}\" {1}\u0027.format(self.cacert, e)\n\nor if the original author intend to use tuple to format the msg\nc) msg \u003d \u0027Unable to load CA from \"%s\"\u0027 % ((self.cacert, e),)\n\nI prefer fix b), .format one, however consider L431, L416, I use a) to align\nwith those.\n\n* Add a UT case to cover the path where the bug is in, then the original\nversion cannot pass UT until it is fixed in this bug.\n\n* During fixing the bug, I find that pep8 and flake8 won\u0027t report such string\nformat error, at least by default settings, but pylint can\npylint http.py | grep \"format string\"\nE:438,22:VerifiedHTTPSConnection.setcontext: Too many arguments for format\nstring\nSo I suggest the community use editor with pylint integrated for static\nanalysis. Mine is vim + scrooloose/syntastic(which will use pylint for python\nby default). Eclipse also has pylint plugin.\n\nChange-Id: I91a137c5c3a9a3cc603804bef5eaea14ae281c08\nCloses-Bug: #1265730\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9a7e27422a82dc8a3e26b6d480f566d1bad9168c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9a7e27422a82dc8a3e26b6d480f566d1bad9168c"}]},"branch":"refs/heads/master"},"d3df6c43f93d1fd770163a0af528895e48f3d714":{"kind":"REWORK","_number":2,"created":"2014-01-07 03:42:34.000000000","uploader":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"ref":"refs/changes/36/65036/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/65036/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/2"}}},"commit":{"parents":[{"commit":"80cf47e229cae248ee9b8cdb8d28d6206f8db3b0","subject":"Remove unused imports","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/80cf47e229cae248ee9b8cdb8d28d6206f8db3b0"}]}],"author":{"name":"Le Tian Ren","email":"renlet@cn.ibm.com","date":"2014-01-06 06:43:56.000000000","tz":480},"committer":{"name":"Le Tian Ren","email":"renlet@cn.ibm.com","date":"2014-01-07 03:17:51.000000000","tz":480},"subject":"Fix glanceclient http.py string formatting error","message":"Fix glanceclient http.py string formatting error\n\n* Proposed fixes of \"TypeError: not all arguments converted during string\nformatting\" are:\na) msg \u003d \u0027Unable to load CA from \"%s\" %s\u0027 % (self.cacert, e)\n\nb) msg \u003d \u0027Unable to load CA from \"{0}\" {1}\u0027.format(self.cacert, e)\n\nor if the original author intend to use tuple to format the msg\nc) msg \u003d \u0027Unable to load CA from \"%s\"\u0027 % ((self.cacert, e),)\n\nI prefer fix b), .format one, however consider L431, L416, I use a) to align\nwith those.\n\n[Change after review]:\nZhi Yan Liu and Fei Long Wang give me comments on string formatting flavor,\nand suggest the dict way\nd) msg \u003d \u0027Unable to load CA from \"%(cacert)s\" %(exc)s\u0027 %\ndict(cacert\u003dself.cacert, exc\u003de)\nOne reason is that when multiple varibles are needed to\nsubstitute, this way can mitigate risk of disordered assignment. So I\u0027ll change\nin d) way. And I have no time to study the performance comparison among these 4\noptions.\n\n* Add a UT case to cover the path where the bug is in, then the original\nversion cannot pass UT until it is fixed in this bug.\n\n* During fixing the bug, I find that pep8 and flake8 won\u0027t report such string\nformat error, at least by default settings, but pylint can\npylint http.py | grep \"format string\"\nE:438,22:VerifiedHTTPSConnection.setcontext: Too many arguments for format\nstring\nSo I suggest the community use editor with pylint integrated for static\nanalysis. Mine is vim + scrooloose/syntastic(which will use pylint for python\nby default). Eclipse also has pylint plugin.\n\nChange-Id: I91a137c5c3a9a3cc603804bef5eaea14ae281c08\nCloses-Bug: #1265730\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d3df6c43f93d1fd770163a0af528895e48f3d714"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d3df6c43f93d1fd770163a0af528895e48f3d714"}]},"branch":"refs/heads/master"},"2ed01afac96af59304215e384fd9b0f0be992711":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2014-01-07 08:13:00.000000000","uploader":{"_account_id":9489,"name":"Le Tian Ren","email":"renlet@cn.ibm.com","username":"gpanda"},"ref":"refs/changes/36/65036/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/65036/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/65036/3"}}},"commit":{"parents":[{"commit":"80cf47e229cae248ee9b8cdb8d28d6206f8db3b0","subject":"Remove unused imports","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/80cf47e229cae248ee9b8cdb8d28d6206f8db3b0"}]}],"author":{"name":"Le Tian Ren","email":"renlet@cn.ibm.com","date":"2014-01-06 06:43:56.000000000","tz":480},"committer":{"name":"Le Tian Ren","email":"renlet@cn.ibm.com","date":"2014-01-07 08:09:01.000000000","tz":480},"subject":"Fix glanceclient http.py string formatting error","message":"Fix glanceclient http.py string formatting error\n\n* Fix \"TypeError: not all arguments converted during string formatting\"\n\n* Add a UT case to cover the path where the bug is in\n\nChange-Id: I91a137c5c3a9a3cc603804bef5eaea14ae281c08\nCloses-Bug: #1265730\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2ed01afac96af59304215e384fd9b0f0be992711"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2ed01afac96af59304215e384fd9b0f0be992711"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}