)]}'
{"id":"openstack%2Fpython-glanceclient~676715","triplet_id":"openstack%2Fpython-glanceclient~master~I029a76090dff9d011f36d2d5eaf094e7fdc6de58","project":"openstack/python-glanceclient","branch":"master","hashtags":[],"change_id":"I029a76090dff9d011f36d2d5eaf094e7fdc6de58","subject":"Use secure sha256 instead of sha1","status":"ABANDONED","created":"2019-08-15 15:05:21.000000000","updated":"2019-09-05 01:13:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e07c91a6373c5c94fb6ff7568d06ea87384e00fa","_number":676715,"virtual_id_number":676715,"owner":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"date":"2019-08-22 06:35:33.000000000","_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},{"value":1,"date":"2019-08-21 11:46:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":-1,"date":"2019-08-21 13:57:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-15 15:06:30.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-08-21 11:46:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-21 13:57:29.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"}],"messages":[{"id":"93814e249c30107e54a9a28e1b5cd2f194da1441","author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"date":"2019-08-15 15:05:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3eed1969a4ef768a2d64958a2cae927caa9e8155","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 16:47:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/f291cddf37384a7f9b0cb74af557ce1b : SUCCESS in 1h 41m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2b3a34472ff248bcbd19fd7b7e4c2e18 : SUCCESS in 1h 23m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e9e343c3bc054c48b98898a9b4acb63f : FAILURE in 22m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/83877fce2d4747f991b5112310219fc9 : FAILURE in 3m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f20ece8734574eadb0035ec9f4d7c4ac : SUCCESS in 3m 55s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/94efb796f79942698bb674fd4fe193bc : FAILURE in 25m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7f9e915c3e17443cbfed10ed87791881 : FAILURE in 22m 23s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e0aaf5618f004650903ec25ad605064e : FAILURE in 3m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bd2188e9f06d43f1846755cc36f1f0c6 : SUCCESS in 22m 44s\n- glanceclient-dsvm-functional-v1 https://zuul.opendev.org/t/openstack/build/9618feab000440808f12519e1f4bd71c : FAILURE in 28m 03s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/f1abaee00c054a79808a46781fe5b3dc : FAILURE in 29m 27s","accounts_in_message":[],"_revision_number":1},{"id":"236d8dca3eeb1c5f1e69f0c9f2be632c6c145616","author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"date":"2019-08-16 00:53:12.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"420119fe5fa15b7af4ef2cc6665ef720b4415212","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 02:51:14.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/fe3c3fad6d85466aad9440eb5cc23579 : SUCCESS in 1h 51m 23s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e1ddd864f5894e3ea766b4489af73ba4 : SUCCESS in 1h 23m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/84bc4db03ad1414ab7e919543cbe7f9c : FAILURE in 3m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6c73b9f1fdd44403a6345392b0a25366 : FAILURE in 3m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c6a66bc812c9426b8d5486ac501b2202 : SUCCESS in 3m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/9a232afbd18148f0be88d2dfa4602cc2 : FAILURE in 3m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/af1a6b54552c421dbf05658c98e58adf : FAILURE in 3m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/41769eb3d6cf49e4a286dd69778d24d8 : FAILURE in 4m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8015523f5f04e70979c0e7c8935625a : SUCCESS in 3m 52s\n- glanceclient-dsvm-functional-v1 https://zuul.opendev.org/t/openstack/build/3b61aabc57f549b193f11ff8a0e6c015 : FAILURE in 31m 53s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/fe2c4fd869e641e4b975e8cd135549a6 : FAILURE in 28m 49s","accounts_in_message":[],"_revision_number":1},{"id":"8c14e534200195dac285802ee8dd9c3d1d30a48e","author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"date":"2019-08-18 15:19:06.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"84e503f700eb2b10b55d7d9fe85e15215b1999af","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-18 16:54:05.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/d10441191d4548b4b5b549fc843c070b : SUCCESS in 1h 34m 19s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1f31c96e09ca4770b0a14fb5b95acba5 : SUCCESS in 1h 18m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/054dee9dcb4340ee8ecb1e844797d00a : FAILURE in 3m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/618121a12e09424ea7fa67e9d9bed56b : FAILURE in 3m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/641c9be5dadb4e2799c709a40b4c7d57 : SUCCESS in 3m 12s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/dbf49be2565b435e859acffc96b0fbf7 : FAILURE in 3m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/58b46280cdeb40f89bc6cc108d767501 : FAILURE in 2m 51s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/42278901c9a24c0699f640b66196a1ed : FAILURE in 3m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/946865ed77e549a59a67f7414bf3871e : SUCCESS in 2m 36s\n- glanceclient-dsvm-functional-v1 https://zuul.opendev.org/t/openstack/build/bcb3c7cd96f54eafa06f06aa5e8d125a : FAILURE in 31m 42s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/2ba5707cac7f426a8dbfea94ba3f3b90 : FAILURE in 28m 34s","accounts_in_message":[],"_revision_number":1},{"id":"6dafb65773b3aa2a23c07ace4403875ec47dac42","author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"date":"2019-08-21 09:54:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b62e45fce474a65a12264380c02160c09256c551","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 11:46:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/acaeff6b794a41738c87442db1b2d071 : SUCCESS in 1h 25m 23s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/754ef815cc844c89835e477abb3bdeb9 : SUCCESS in 1h 51m 41s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/163eb0f7dbdb4aeea7c6a252566ba852 : SUCCESS in 3m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f10c90f2982449258095fd18989946f2 : SUCCESS in 4m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b8c82fc6bc38466988e45ebfc821160e : SUCCESS in 3m 55s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1a1644d5f91445f29637c7b381ffff58 : SUCCESS in 3m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a5da7f2675364abf8df05065e2043820 : SUCCESS in 3m 30s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/87560157327043ce9735979e080d29dd : SUCCESS in 3m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7cc04e427054424a9466906a0da0ed07 : SUCCESS in 4m 20s\n- glanceclient-dsvm-functional-v1 https://zuul.opendev.org/t/openstack/build/6429469515f548f1aa5d870c4b69c437 : SUCCESS in 29m 34s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/cb5345c5958145a9a2e2369a9cda35c0 : SUCCESS in 32m 26s","accounts_in_message":[],"_revision_number":2},{"id":"e45d6045316f4bb19e9dd8d26f0692fa51115d88","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2019-08-21 13:57:29.000000000","message":"Patch Set 2: Code-Review-1\n\nThanks zhanghao,\n\nWhile this is perfectly fine change to do for any new caching, we likely should put bit more logic into it so the cached schemas that has been already saved in the files which name uses the hash from sha1 gets recognized (and preferably renamed).\n\nAs the function is not used for actually securing anything but rather for normalizing the file names, it\u0027s one and the same which hashing function we use here. Thus for bandit purposes we could just as well use ` # noqa` to get bandit skipping it (as we would still need to calculate the sha1 hash and the change itself would not yield to result you are looking for).","accounts_in_message":[],"_revision_number":2},{"id":"96a5f19abcf60858097cd786698b8cacbc3671de","author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"date":"2019-08-22 06:35:33.000000000","message":"Patch Set 2:\n\nHi Erno Kuvaja, thank you for your review，you are right, it is not a real security issue. I see that the contents of the cached json file are fixed，I think it may be unnecessary to rename all the files, because it will affect the efficiency of the code, and OpenStack does not support smooth upgrades. Currently, both nova and neutron clients use sha256, I think it is better to be modified and this modification will not affect the use of existing features，look forward to your reply.","accounts_in_message":[],"_revision_number":2},{"id":"e07c91a6373c5c94fb6ff7568d06ea87384e00fa","author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"date":"2019-09-05 01:13:40.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8dd5623eca42ed1c53357431c0a5eb94366def07","revisions":{"3abad07a646f3c1384b37bf92f0adbd284681493":{"kind":"REWORK","_number":1,"created":"2019-08-15 15:05:21.000000000","uploader":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"ref":"refs/changes/15/676715/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/15/676715/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/1"}}},"commit":{"parents":[{"commit":"31f2fdae9481c7fd840219887c27d6f696f819ab","subject":"Merge \"Modify the url of upper_constraints_file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/31f2fdae9481c7fd840219887c27d6f696f819ab"}]}],"author":{"name":"zhanghao2","email":"zhanghao2@cmss.chinamobile.com","date":"2019-05-24 10:05:12.000000000","tz":-240},"committer":{"name":"zhanghao2","email":"zhanghao2@cmss.chinamobile.com","date":"2019-08-15 14:56:35.000000000","tz":-240},"subject":"Use secure sha256 instead of sha1","message":"Use secure sha256 instead of sha1\n\nFix for bandit B303: Use of insecure MD2, MD4, MD5, or SHA1 hash function.\n\nChange-Id: I029a76090dff9d011f36d2d5eaf094e7fdc6de58\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3abad07a646f3c1384b37bf92f0adbd284681493"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3abad07a646f3c1384b37bf92f0adbd284681493"}]},"branch":"refs/heads/master"},"8dd5623eca42ed1c53357431c0a5eb94366def07":{"kind":"REWORK","_number":2,"created":"2019-08-21 09:54:08.000000000","uploader":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"ref":"refs/changes/15/676715/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/15/676715/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/15/676715/2"}}},"commit":{"parents":[{"commit":"31f2fdae9481c7fd840219887c27d6f696f819ab","subject":"Merge \"Modify the url of upper_constraints_file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/31f2fdae9481c7fd840219887c27d6f696f819ab"}]}],"author":{"name":"zhanghao2","email":"zhanghao2@cmss.chinamobile.com","date":"2019-07-31 23:15:40.000000000","tz":-240},"committer":{"name":"zhanghao2","email":"zhanghao2@cmss.chinamobile.com","date":"2019-07-31 23:16:09.000000000","tz":-240},"subject":"Use secure sha256 instead of sha1","message":"Use secure sha256 instead of sha1\n\nFix for bandit B303: Use of insecure MD2, MD4, MD5, or SHA1 hash function.\n\nChange-Id: I029a76090dff9d011f36d2d5eaf094e7fdc6de58\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8dd5623eca42ed1c53357431c0a5eb94366def07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8dd5623eca42ed1c53357431c0a5eb94366def07"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}