)]}'
{"id":"openstack%2Fpython-glanceclient~68403","triplet_id":"openstack%2Fpython-glanceclient~master~I0267159b71f3086780f3d32f4687e008357ac9e1","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1269821","hashtags":[],"change_id":"I0267159b71f3086780f3d32f4687e008357ac9e1","subject":"Move strip version method to the HTTP client class","status":"ABANDONED","created":"2014-01-22 15:12:22.000000000","updated":"2014-02-06 18:48:28.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"04f5a049f63a97b30460c3db34786cea5eb5a57b","_number":68403,"virtual_id_number":68403,"owner":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2014-01-30 17:34:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":-1,"date":"2014-02-04 02:57:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"date":"2014-02-04 02:57:22.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-27 05:17:09.000000000","updated_by":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"reviewer":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"state":"REVIEWER"},{"updated":"2014-01-30 17:34:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-02-04 02:57:22.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"}],"messages":[{"id":"da45c5810dfe8ef36d2ea6fa5c1f602740343421","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-22 19:07:23.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/03/68403/1/check/gate-python-glanceclient-pep8/5905c6a : FAILURE in 58s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/03/68403/1/check/gate-python-glanceclient-docs/a51a067/doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-glanceclient-python26 http://logs.openstack.org/03/68403/1/check/gate-python-glanceclient-python26/9a1bd5a : SUCCESS in 1m 10s\n- gate-python-glanceclient-python27 http://logs.openstack.org/03/68403/1/check/gate-python-glanceclient-python27/f39940a : SUCCESS in 1m 02s\n- gate-python-glanceclient-python33 http://logs.openstack.org/03/68403/1/check/gate-python-glanceclient-python33/575e10f : FAILURE in 18s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/03/68403/1/check/check-tempest-dsvm-full/c8af06f : SUCCESS in 1h 05m 09s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/03/68403/1/check/check-tempest-dsvm-postgres-full/4648738 : SUCCESS in 56m 51s\n- check-tempest-dsvm-neutron http://logs.openstack.org/03/68403/1/check/check-tempest-dsvm-neutron/66149ba : SUCCESS in 32m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/03/68403/1/check/gate-tempest-dsvm-large-ops/ebd2428 : SUCCESS in 13m 52s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/03/68403/1/check/gate-tempest-dsvm-neutron-large-ops/8e1bcbe : SUCCESS in 14m 06s\n- check-grenade-dsvm http://logs.openstack.org/03/68403/1/check/check-grenade-dsvm/9c25c9b : SUCCESS in 39m 49s\n","accounts_in_message":[],"_revision_number":1},{"id":"0ea4174de304ff583054d4174bd9f54626a542f1","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-01-24 22:35:07.000000000","message":"Patch Set 1: Rebased","accounts_in_message":[],"_revision_number":1},{"id":"9f9cdf31eeb00bc6918afad71ef0db19c3d07dfd","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2014-01-27 05:59:35.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nThe code looks good for me, just a nit comments.","accounts_in_message":[],"_revision_number":2},{"id":"42f762d0143313bfb8ce3f1461b1c42a8f362f83","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-01-30 16:17:18.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9f6e9fb55619b21f825ee466b2d00a06c61f88b3","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-01-30 16:44:09.000000000","message":"Patch Set 3: Rebased","accounts_in_message":[],"_revision_number":3},{"id":"98691f020d54500eae9a6794606ee68ebc0cd445","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-30 17:34:32.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/03/68403/4/check/gate-python-glanceclient-pep8/d1ae452 : SUCCESS in 57s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/03/68403/4/check/gate-python-glanceclient-docs/ed22345/doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-glanceclient-python26 http://logs.openstack.org/03/68403/4/check/gate-python-glanceclient-python26/aeab51c : SUCCESS in 1m 08s\n- gate-python-glanceclient-python27 http://logs.openstack.org/03/68403/4/check/gate-python-glanceclient-python27/12413b5 : SUCCESS in 1m 12s\n- gate-python-glanceclient-python33 http://logs.openstack.org/03/68403/4/check/gate-python-glanceclient-python33/a75bca4 : FAILURE in 13s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/03/68403/4/check/check-tempest-dsvm-full/45bc21d : SUCCESS in 50m 08s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/03/68403/4/check/check-tempest-dsvm-postgres-full/76ae65c : SUCCESS in 49m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/03/68403/4/check/check-tempest-dsvm-neutron/af9d47a : SUCCESS in 28m 38s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/03/68403/4/check/gate-tempest-dsvm-large-ops/139b6f3 : SUCCESS in 11m 47s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/03/68403/4/check/gate-tempest-dsvm-neutron-large-ops/69e16ca : SUCCESS in 12m 37s\n- check-grenade-dsvm http://logs.openstack.org/03/68403/4/check/check-grenade-dsvm/538cbca : SUCCESS in 41m 57s\n","accounts_in_message":[],"_revision_number":4},{"id":"37584a6017b3d2d34dc2fd5787ca296022fff002","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2014-02-04 02:57:22.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nWe recently merged https://review.openstack.org/#/c/53158/ which I think has code you may want to use for this.\n\nHowever, one of the notes on that review is that it seems somewhat surprising to have the glanceclient.common.http client class trimming the endpoint. In my opinion, it should accept the endpoint that it is given. Code that uses that client is free to use glanceclient.common.utils.strip_version to achieve this effect.","accounts_in_message":[],"_revision_number":4},{"id":"57202fb0f84b85c1485b4109dab4584781ae3c0b","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-02-06 18:48:28.000000000","message":"Patch Set 4: Abandoned\n\nhttps://review.openstack.org/#/c/53158/  should cover it well enough","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"cba54cb747125a34c20e8ca9d5412ff1556d0374","revisions":{"cc1e8127715e9022b02ff6a21aaa5e2cba9c4ae1":{"kind":"REWORK","_number":1,"created":"2014-01-22 15:12:22.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/03/68403/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/03/68403/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/1"}}},"commit":{"parents":[{"commit":"e4d1961c926b425e93fa2d8bdd37e5c1f19d574b","subject":"python3: Switch to mox3 instead of mox","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e4d1961c926b425e93fa2d8bdd37e5c1f19d574b"}]}],"author":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-01-22 15:06:27.000000000","tz":-420},"committer":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-01-22 15:11:45.000000000","tz":-420},"subject":"Move strip version method to the HTTP client class  * Applications using the glanceclient on the API level will be unaware of that implementation detail.  * If there is any change in this in the future, other applications will not need to change.  * Added some tests for the strip version method","message":"Move strip version method to the HTTP client class\n * Applications using the glanceclient on the API level will be unaware of that implementation\ndetail.\n * If there is any change in this in the future, other applications will not need to change.\n * Added some tests for the strip version method\n\nChange-Id: I0267159b71f3086780f3d32f4687e008357ac9e1\nCloses-Bug: #1269821\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cc1e8127715e9022b02ff6a21aaa5e2cba9c4ae1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cc1e8127715e9022b02ff6a21aaa5e2cba9c4ae1"}]},"branch":"refs/heads/master"},"e53b2d911ff80c3e7e9a6d8637f98b5e6011ce76":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2014-01-22 15:12:22.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/03/68403/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/03/68403/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/2"}}},"commit":{"parents":[{"commit":"ff7b58860239307a5a1c1d4bea52235e7003fc8b","subject":"Merge \"Handle endpoints with versions consistently\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ff7b58860239307a5a1c1d4bea52235e7003fc8b"}]}],"author":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-01-22 15:06:27.000000000","tz":-420},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2014-01-24 22:35:07.000000000","tz":0},"subject":"Move strip version method to the HTTP client class  * Applications using the glanceclient on the API level will be unaware of that implementation detail.  * If there is any change in this in the future, other applications will not need to change.  * Added some tests for the strip version method","message":"Move strip version method to the HTTP client class\n * Applications using the glanceclient on the API level will be unaware of that implementation\ndetail.\n * If there is any change in this in the future, other applications will not need to change.\n * Added some tests for the strip version method\n\nChange-Id: I0267159b71f3086780f3d32f4687e008357ac9e1\nCloses-Bug: #1269821\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e53b2d911ff80c3e7e9a6d8637f98b5e6011ce76"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e53b2d911ff80c3e7e9a6d8637f98b5e6011ce76"}]},"branch":"refs/heads/master"},"7d4b3a90a67ce2480e3bd8f167a7ad65e54a3cd5":{"kind":"REWORK","_number":3,"created":"2014-01-30 16:17:18.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/03/68403/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/03/68403/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/3"}}},"commit":{"parents":[{"commit":"e4d1961c926b425e93fa2d8bdd37e5c1f19d574b","subject":"python3: Switch to mox3 instead of mox","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e4d1961c926b425e93fa2d8bdd37e5c1f19d574b"}]}],"author":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-01-22 15:06:27.000000000","tz":-420},"committer":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-01-30 16:15:50.000000000","tz":-420},"subject":"Move strip version method to the HTTP client class","message":"Move strip version method to the HTTP client class\n\n * Applications using the glanceclient on the API level will be unaware of that implementation\ndetail.\n * If there is any change in this in the future, other applications will not need to change.\n * Added some tests for the strip version method\n\nChange-Id: I0267159b71f3086780f3d32f4687e008357ac9e1\nCloses-Bug: #1269821\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7d4b3a90a67ce2480e3bd8f167a7ad65e54a3cd5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7d4b3a90a67ce2480e3bd8f167a7ad65e54a3cd5"}]},"branch":"refs/heads/master"},"cba54cb747125a34c20e8ca9d5412ff1556d0374":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2014-01-30 16:17:18.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/03/68403/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/03/68403/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/03/68403/4"}}},"commit":{"parents":[{"commit":"ff7b58860239307a5a1c1d4bea52235e7003fc8b","subject":"Merge \"Handle endpoints with versions consistently\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ff7b58860239307a5a1c1d4bea52235e7003fc8b"}]}],"author":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-01-22 15:06:27.000000000","tz":-420},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2014-01-30 16:44:08.000000000","tz":0},"subject":"Move strip version method to the HTTP client class","message":"Move strip version method to the HTTP client class\n\n * Applications using the glanceclient on the API level will be unaware of that implementation\ndetail.\n * If there is any change in this in the future, other applications will not need to change.\n * Added some tests for the strip version method\n\nChange-Id: I0267159b71f3086780f3d32f4687e008357ac9e1\nCloses-Bug: #1269821\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cba54cb747125a34c20e8ca9d5412ff1556d0374"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cba54cb747125a34c20e8ca9d5412ff1556d0374"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}