)]}'
{"glanceclient/v2/shell.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"91912e3e9bcb601107b7433ddc08565caf8dd97a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        args.import_method \u003d \u0027glance-direct\u0027"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":214,"context_line":"        utils.exit(\"Import method copy-image can not be provided \""},{"line_number":215,"context_line":"                   \"while creating the image.\")"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    # determine whether the requested import method is valid"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ac584256","line":214,"range":{"start_line":214,"start_character":19,"end_line":214,"end_character":66},"updated":"2020-02-24 10:22:38.000000000","message":"Maybe \"Import method \u0027copy-image\u0027 can not be used \"? It\u0027s still there (provided) we just disallow it\u0027s usage and consistency of single quoting the method. ;)","commit_id":"45a332a0077f734a1eb85ad391acf36e03cea41a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55a08f1bc102fa78da17fc87735e76387d1e870b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        args.import_method \u003d \u0027glance-direct\u0027"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":214,"context_line":"        utils.exit(\"Import method copy-image can not be provided \""},{"line_number":215,"context_line":"                   \"while creating the image.\")"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    # determine whether the requested import method is valid"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_a57ff5a9","line":214,"range":{"start_line":214,"start_character":19,"end_line":214,"end_character":66},"in_reply_to":"1fa4df85_ac584256","updated":"2020-02-24 12:58:43.000000000","message":"Done","commit_id":"45a332a0077f734a1eb85ad391acf36e03cea41a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"91912e3e9bcb601107b7433ddc08565caf8dd97a","unresolved":false,"context_lines":[{"line_number":739,"context_line":"        utils.exit(\"Import method should be \u0027web-download\u0027 if URI is \""},{"line_number":740,"context_line":"                   \"provided.\")"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027 and not (stores or all_stores):"},{"line_number":743,"context_line":"        utils.exit(\"Provide either --stores or --all-stores for \""},{"line_number":744,"context_line":"                   \"copy-image import method.\")"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    # check image properties"},{"line_number":747,"context_line":"    image \u003d gc.images.get(args.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_4c18ae80","line":744,"range":{"start_line":742,"start_character":0,"end_line":744,"end_character":47},"updated":"2020-02-24 10:22:38.000000000","message":"I think we need to find a place to document this requirement clearly somewhere. Not necessarily blocker for this patch, but more of a note to remind us do so.\n\nNIT: \"\u0027copy-image\u0027 import method.\"","commit_id":"45a332a0077f734a1eb85ad391acf36e03cea41a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55a08f1bc102fa78da17fc87735e76387d1e870b","unresolved":false,"context_lines":[{"line_number":739,"context_line":"        utils.exit(\"Import method should be \u0027web-download\u0027 if URI is \""},{"line_number":740,"context_line":"                   \"provided.\")"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027 and not (stores or all_stores):"},{"line_number":743,"context_line":"        utils.exit(\"Provide either --stores or --all-stores for \""},{"line_number":744,"context_line":"                   \"copy-image import method.\")"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    # check image properties"},{"line_number":747,"context_line":"    image \u003d gc.images.get(args.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_253a25e7","line":744,"range":{"start_line":742,"start_character":0,"end_line":744,"end_character":47},"in_reply_to":"1fa4df85_4c18ae80","updated":"2020-02-24 12:58:43.000000000","message":"I will add this as a note in glance documentation.","commit_id":"45a332a0077f734a1eb85ad391acf36e03cea41a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"91912e3e9bcb601107b7433ddc08565caf8dd97a","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                       \"to an image in status \u0027queued\u0027\")"},{"line_number":763,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":764,"context_line":"        if image_status !\u003d \u0027active\u0027:"},{"line_number":765,"context_line":"            utils.exit(\"The \u0027copy-image\u0027 import method can only be applied \""},{"line_number":766,"context_line":"                       \"to an image in status \u0027active\u0027\")"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # finally, do the import"},{"line_number":769,"context_line":"    gc.images.image_import(args.id, args.import_method, args.uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_6f279cb8","line":766,"range":{"start_line":765,"start_character":67,"end_line":766,"end_character":55},"updated":"2020-02-24 10:22:38.000000000","message":"perhaps \"used on an image which status is \u0027active\u0027.\"?","commit_id":"45a332a0077f734a1eb85ad391acf36e03cea41a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55a08f1bc102fa78da17fc87735e76387d1e870b","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                       \"to an image in status \u0027queued\u0027\")"},{"line_number":763,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":764,"context_line":"        if image_status !\u003d \u0027active\u0027:"},{"line_number":765,"context_line":"            utils.exit(\"The \u0027copy-image\u0027 import method can only be applied \""},{"line_number":766,"context_line":"                       \"to an image in status \u0027active\u0027\")"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # finally, do the import"},{"line_number":769,"context_line":"    gc.images.image_import(args.id, args.import_method, args.uri,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_052129b5","line":766,"range":{"start_line":765,"start_character":67,"end_line":766,"end_character":55},"in_reply_to":"1fa4df85_6f279cb8","updated":"2020-02-24 12:58:43.000000000","message":"Done","commit_id":"45a332a0077f734a1eb85ad391acf36e03cea41a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"15832b28908679f26165783491c93972896251b4","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        args.import_method \u003d \u0027glance-direct\u0027"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":214,"context_line":"        utils.exit(\"Import method \u0027copy-image\u0027 can not be used \""},{"line_number":215,"context_line":"                   \"while creating the image.\")"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    # determine whether the requested import method is valid"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c77d236f","line":214,"range":{"start_line":214,"start_character":47,"end_line":214,"end_character":54},"updated":"2020-02-26 22:27:25.000000000","message":"nit: cannot (there really is a difference!)","commit_id":"fde58c8408b638b31ee7d8b252afa07171019663"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2225646362284a29b3406399e294aa8f1fdb0883","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        args.import_method \u003d \u0027glance-direct\u0027"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":214,"context_line":"        utils.exit(\"Import method \u0027copy-image\u0027 can not be used \""},{"line_number":215,"context_line":"                   \"while creating the image.\")"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    # determine whether the requested import method is valid"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_3f9e7754","line":214,"range":{"start_line":214,"start_character":47,"end_line":214,"end_character":54},"in_reply_to":"1fa4df85_c77d236f","updated":"2020-02-27 06:50:00.000000000","message":"Done","commit_id":"fde58c8408b638b31ee7d8b252afa07171019663"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"15832b28908679f26165783491c93972896251b4","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                       \"to an image in status \u0027queued\u0027\")"},{"line_number":763,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":764,"context_line":"        if image_status !\u003d \u0027active\u0027:"},{"line_number":765,"context_line":"            utils.exit(\"The \u0027copy-image\u0027 import method can only be used on \""},{"line_number":766,"context_line":"                       \"an image which status is \u0027active\u0027.\")"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # finally, do the import"},{"line_number":769,"context_line":"    gc.images.image_import(args.id, args.import_method, args.uri,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c7dc4348","line":766,"range":{"start_line":765,"start_character":23,"end_line":766,"end_character":59},"updated":"2020-02-26 22:27:25.000000000","message":"nit: For consistency, this could be revised to be the same format as the previous 2 exit messages.  If you want to stick with this, maybe \"an image of which the status is \u0027active\u0027.\" or \"an image whose status is \u0027active\u0027.\" or \"an image with status \u0027active\u0027.\"  As it stands, the bare \"which\" doesn\u0027t seem quite right.","commit_id":"fde58c8408b638b31ee7d8b252afa07171019663"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2225646362284a29b3406399e294aa8f1fdb0883","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                       \"to an image in status \u0027queued\u0027\")"},{"line_number":763,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":764,"context_line":"        if image_status !\u003d \u0027active\u0027:"},{"line_number":765,"context_line":"            utils.exit(\"The \u0027copy-image\u0027 import method can only be used on \""},{"line_number":766,"context_line":"                       \"an image which status is \u0027active\u0027.\")"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # finally, do the import"},{"line_number":769,"context_line":"    gc.images.image_import(args.id, args.import_method, args.uri,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_bfbb47c2","line":766,"range":{"start_line":765,"start_character":23,"end_line":766,"end_character":59},"in_reply_to":"1fa4df85_c7dc4348","updated":"2020-02-27 06:50:00.000000000","message":"Done","commit_id":"fde58c8408b638b31ee7d8b252afa07171019663"}]}