)]}'
{"id":"openstack%2Fpython-glanceclient~712461","triplet_id":"openstack%2Fpython-glanceclient~stable%2Ftrain~Idccff338fa84c46ca0e429bb533a2a5217205eef","project":"openstack/python-glanceclient","branch":"stable/train","topic":"bug/1838694","hashtags":[],"change_id":"Idccff338fa84c46ca0e429bb533a2a5217205eef","subject":"Cleanup session object","status":"MERGED","created":"2020-03-11 14:45:31.000000000","updated":"2020-03-18 13:53:45.000000000","submitted":"2020-03-18 13:50:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"712461-1584539449539-ee8e90f4","meta_rev_id":"5db6587e23d4d8b3b2fddad98a6046b84d28e9f7","_number":712461,"virtual_id_number":712461,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-18 13:50:49.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":2,"date":"2020-03-18 04:33:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2020-03-18 12:05:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2020-03-18 12:05:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"date":"2020-03-17 21:49:47.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-11 14:45:31.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-03-11 14:45:59.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2020-03-11 14:58:47.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2020-03-18 04:33:24.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2020-03-18 12:05:45.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-03-18 13:50:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fe93fe0ccbe1f52c32ab97c15c8f0aeb4de7c356","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2020-03-11 14:45:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aaa35ae8d93e9056fc2a2da2340a3e1e0dd59e14","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 16:40:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/00abe3bd2dec48e9a7064ead6f7d110c : SUCCESS in 1h 38m 12s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0946520287964fa68b7ac8d47ba0b78d : SUCCESS in 1h 25m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cf0bcbaccea84fc698d78f7632d196b2 : SUCCESS in 7m 48s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/93be5fd6239947d9adb64f025edad39a : SUCCESS in 6m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/78682e3e709f466db5de8cf5f1d4a534 : SUCCESS in 6m 44s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/85b62c05acfe47b385b553721f4c4901 : SUCCESS in 5m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b30032055e224fc8bcb182c7b9df88bf : SUCCESS in 5m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/334261375ce842ba89df9bf02954dbdc : SUCCESS in 6m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ea35fed607eb474491c21055017f8bc4 : SUCCESS in 6m 54s\n- glanceclient-dsvm-functional-v1 https://zuul.opendev.org/t/openstack/build/be0f461d8eb447a18f94b769085c0ff6 : FAILURE in 30m 31s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/72afb95dbbcb4b3e90a0ac34b1e4b193 : SUCCESS in 39m 52s","accounts_in_message":[],"_revision_number":1},{"id":"bd6e4afb87c0bf81d804966fd8c245c3469b20e5","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-03-11 17:36:03.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nComment inline.  We need someone with more zuul-fu than me to figure this out.","accounts_in_message":[],"_revision_number":1},{"id":"e07f13fddfd1a6094118024ee4e87b0aed4c2678","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-03-17 21:49:30.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"041eddccb2950b0a27874525719c1cca05eb4483","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-03-17 21:49:47.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"5d5c9fa5d48e66ebf58d98de065be9924c184e15","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 23:40:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/d8ae251235864886967c9dd3fc9c189d : SUCCESS in 1h 41m 01s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/30ba33aa441b4e689af902c9c1f4d1ac : SUCCESS in 1h 21m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2a472159555b441c996fd3542690411d : SUCCESS in 4m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e7f3973eedac4a27beae3b36ee736b6f : SUCCESS in 3m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/64ac3b549144437bb00122d6a2cf8e41 : SUCCESS in 3m 57s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a8b6a8e1ddf247ccb3b21125ca90d45b : SUCCESS in 3m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f461bf61166144d8a716d62b35693cdb : SUCCESS in 3m 36s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/99fbbc242e56470086f518bdd4396d5d : SUCCESS in 3m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a96e8d648b1043718472811bb7699496 : SUCCESS in 4m 00s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/27b4aed1346b40b5b85e472757a07a5f : SUCCESS in 32m 21s","accounts_in_message":[],"_revision_number":2},{"id":"a02f467bfc2604ad2ff6e3a70a93aedf00488ca1","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-03-18 04:33:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e4758cb183bb448ecb3f0d9ae4da89772d3b3c98","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-03-18 12:05:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThis is appropriate to backport.","accounts_in_message":[],"_revision_number":2},{"id":"c622f0a7f128e1c5c8a2513c68209f8da526d673","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-18 12:05:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"d5734c5a85533997c1ef88bb4e4e8c752f52ca96","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-18 13:50:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c1751a6085c69c826f084f900e5b21ca8d813f7d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-18 13:50:49.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/b0d65f98424641e09a0f5d733c67c44f : SUCCESS in 1h 38m 48s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/313a5929cbcc496fa34dee2dde93c504 : SUCCESS in 1h 25m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/05ac92cb4638488a981c60fae9c864ee : SUCCESS in 4m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3395cdcf3e0b4d7699407b64d9fbc8c8 : SUCCESS in 3m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/24535050299d4f42802ee437bb611ae1 : SUCCESS in 4m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/55dcc7f3e33042aaa7a513e89d4f4d1d : SUCCESS in 4m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5e1c6a1879ac4ea786c20df12940cba8 : SUCCESS in 4m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6b3dcf75c1e847b8b9547400e506968c : SUCCESS in 4m 11s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/516b74efdde144e6a67eca2e20a4aeac : SUCCESS in 32m 38s","accounts_in_message":[],"_revision_number":2},{"id":"0ce1a2e694d93998a8ef0a9ac320bc3d45ad0f00","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-18 13:53:45.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d72b3a4a92ed4a37b1421db5e7051b43 : SUCCESS in 2m 28s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1aba8f2d248040364e690dd8dc7f3a508baed631","revisions":{"5ba17b652ff62d27d1f90ae400862b224d60880b":{"kind":"REWORK","_number":1,"created":"2020-03-11 14:45:31.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/61/712461/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/61/712461/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/1"}}},"commit":{"parents":[{"commit":"5d833604b36b8396e9a74e8d21c9415da661307b","subject":"Update TOX/UPPER_CONSTRAINTS_FILE for stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5d833604b36b8396e9a74e8d21c9415da661307b"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-01 20:39:46.000000000","tz":-360},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2020-03-11 14:44:49.000000000","tz":60},"subject":"Cleanup session object","message":"Cleanup session object\n\nIf a session object is not provided to the get_http_client function (as\nis done via osc), the glance client uses it\u0027s own HTTPClient class. This\nclass creates a session but does not properly close it when it is done.\nThis can lead to resource warnings about unclosed sockets. This change\nadds a __del__() to the HTTPClient class to close out the session\ncorrectly.\n\nChange-Id: Idccff338fa84c46ca0e429bb533a2a5217205eef\nCloses-Bug: #1838694\n(cherry picked from commit 436f797e8db2fc11b7dace7cb7020e4d44a3d2d7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5ba17b652ff62d27d1f90ae400862b224d60880b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5ba17b652ff62d27d1f90ae400862b224d60880b"}]},"branch":"refs/heads/stable/train"},"1aba8f2d248040364e690dd8dc7f3a508baed631":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-03-17 21:49:47.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/61/712461/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/61/712461/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/61/712461/2"}}},"commit":{"parents":[{"commit":"fd83a8eee7d672076413369497a6602025166c4d","subject":"Remove v1 tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fd83a8eee7d672076413369497a6602025166c4d"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-01 20:39:46.000000000","tz":-360},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2020-03-17 21:49:47.000000000","tz":0},"subject":"Cleanup session object","message":"Cleanup session object\n\nIf a session object is not provided to the get_http_client function (as\nis done via osc), the glance client uses it\u0027s own HTTPClient class. This\nclass creates a session but does not properly close it when it is done.\nThis can lead to resource warnings about unclosed sockets. This change\nadds a __del__() to the HTTPClient class to close out the session\ncorrectly.\n\nChange-Id: Idccff338fa84c46ca0e429bb533a2a5217205eef\nCloses-Bug: #1838694\n(cherry picked from commit 436f797e8db2fc11b7dace7cb7020e4d44a3d2d7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1aba8f2d248040364e690dd8dc7f3a508baed631"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1aba8f2d248040364e690dd8dc7f3a508baed631"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}