)]}'
{"glanceclient/tests/unit/v2/test_shell_v2.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"27a7ee068d9d152a9c43079d5dd10ced51950038","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"                                       \u0027get_import_info\u0027) as mocked_info:"},{"line_number":1583,"context_line":"                    with mock.patch.object(self.gc.images,"},{"line_number":1584,"context_line":"                                           \u0027get_stores_info\u0027) as m_stores_info:"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"                        ignore_fields \u003d [\u0027self\u0027, \u0027access\u0027, \u0027schema\u0027]"},{"line_number":1587,"context_line":"                        expect_image \u003d dict([(field, field) for field in"},{"line_number":1588,"context_line":"                                             ignore_fields])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bc2e77f7","line":1585,"updated":"2020-07-31 15:01:19.000000000","message":"Just a bit of nitpicking: can we not write this as a single statement? \n\nwith mock.patch.object(...) as mocked_create, \\\n     mock.patch.object(...) as mocked_get, \\\n     mock.patch.object(...) as mocked_info:\n\n\nThis makes sure all the code does not end up at the far right of our screens, and we can write the lines without breaking them in the middle. Plus, a single \"with\" seems a bit more \"logical\" to me in this case.","commit_id":"77eab17cf9f3cf3f2578f73163cb816e425effa2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bf3616f974764403a1d0331fc8dbd0abfcc55b85","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"                                       \u0027get_import_info\u0027) as mocked_info:"},{"line_number":1583,"context_line":"                    with mock.patch.object(self.gc.images,"},{"line_number":1584,"context_line":"                                           \u0027get_stores_info\u0027) as m_stores_info:"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"                        ignore_fields \u003d [\u0027self\u0027, \u0027access\u0027, \u0027schema\u0027]"},{"line_number":1587,"context_line":"                        expect_image \u003d dict([(field, field) for field in"},{"line_number":1588,"context_line":"                                             ignore_fields])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_574d4898","line":1585,"in_reply_to":"9f560f44_bc2e77f7","updated":"2020-08-04 19:50:25.000000000","message":"I definitely agree that this format is less than desirable. It\u0027s also easy/cleaner to define a closure inside here which uses decorators on the objects:\n\n @mock.patch.object(thing)\n def _test(a):\n     .... stuff\n\n _test()","commit_id":"77eab17cf9f3cf3f2578f73163cb816e425effa2"}]}