)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"20a9b3b17ed017989e92f5ba37304815e97535a9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    - There were some rebase conflicts so, double check the"},{"line_number":35,"context_line":"      common/http.py module"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Co-Author:    Flaper Fesp \u003cflaper87@gmail.com\u003e"},{"line_number":38,"context_line":"Change-Id: I09f70eee3e2777f52ce040296015d41649c2586a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_8cd2da32","line":37,"updated":"2014-05-21 11:54:24.000000000","message":"This is my fault :D\n\nMind changing to: Flavio Percoco \u003cflaper87@....\u003e ?","commit_id":"d3ce8adf28cc5ac7812ef9bad1307e64a41d304d"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"962a5182fda54a8376dfe1a2073dfdec54273b9b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    - There were some rebase conflicts so, double check the"},{"line_number":35,"context_line":"      common/http.py module"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Co-Author:    Flaper Fesp \u003cflaper87@gmail.com\u003e"},{"line_number":38,"context_line":"Change-Id: I09f70eee3e2777f52ce040296015d41649c2586a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_958c6f37","line":37,"in_reply_to":"7adec928_8cd2da32","updated":"2014-06-02 06:13:17.000000000","message":"Done","commit_id":"d3ce8adf28cc5ac7812ef9bad1307e64a41d304d"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"dbb3c7fc011e1165c1e7095d0423f93011fd5b18","unresolved":false,"context_lines":[{"line_number":30,"context_line":"* Glanceclient\u0027s HTTPSConnection implementation will be used if"},{"line_number":31,"context_line":"  no-compression flag is set to True."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To Reviewers:"},{"line_number":34,"context_line":"    - There were some rebase conflicts so, double check the"},{"line_number":35,"context_line":"      common/http.py module"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_7ed94021","line":33,"updated":"2014-06-04 18:37:49.000000000","message":"Please remove this from this commit message (to avoid getting it in the history). Gerrit should have had a better metadata for each MP however, we will have to make do with review comments.\n\nSo, please put the suggestion as a comment at the summary section of the review.","commit_id":"df8ba4892a303fcdcabb9860e1929ceefe0af60b"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"c4fe40e3b969930fef83df0c86b6bfbbae289a67","unresolved":false,"context_lines":[{"line_number":30,"context_line":"* Glanceclient\u0027s HTTPSConnection implementation will be used if"},{"line_number":31,"context_line":"  no-compression flag is set to True."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To Reviewers:"},{"line_number":34,"context_line":"    - There were some rebase conflicts so, double check the"},{"line_number":35,"context_line":"      common/http.py module"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_a0f60b8d","line":33,"in_reply_to":"1ae5cdf2_7ed94021","updated":"2014-06-06 05:21:59.000000000","message":"Done","commit_id":"df8ba4892a303fcdcabb9860e1929ceefe0af60b"}],"glanceclient/common/http.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2250f4c417a0d0028a7c4c2ffb76a03f993e2257","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            raise exc.CommunicationError(message\u003dmessage)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not resp.ok:"},{"line_number":201,"context_line":"            LOG.error(\"Request returned failure status.\")"},{"line_number":202,"context_line":"            raise exc.from_response(resp, resp.content)"},{"line_number":203,"context_line":"        elif resp.status_code \u003d\u003d requests.codes.MULTIPLE_CHOICES:"},{"line_number":204,"context_line":"            raise exc.from_response(resp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_e70dfb36","line":201,"updated":"2014-06-10 10:39:14.000000000","message":"Could we please log the response code here?","commit_id":"63eebec280479bf6b3397cfad90f2c629cdd2531"},{"author":{"_account_id":10585,"name":"Jin Liu","email":"liujinbj@cn.ibm.com","username":"liujin"},"change_message_id":"1420af58dedcada1bff4eb9314694c4906ecc62e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import errno"},{"line_number":18,"context_line":"import hashlib"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_0abec3ae","side":"PARENT","line":15,"updated":"2014-06-23 08:25:38.000000000","message":"Could you add file basic description here as other files, such as\n\"\"\"\nBase utilities to build http operation.\n\"\"\"","commit_id":"3b694ca89f97ee0a68a58a1d1f7d8272db1aaabb"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"8bf0c985eba1acc951a797147b6a1e8f730fa28a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            curl.append(\u0027-d \\\u0027%s\\\u0027\u0027 % kwargs[\u0027body\u0027])"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        curl.append(\u0027%s%s\u0027 % (self.endpoint, url))"},{"line_number":153,"context_line":"        LOG.debug(strutils.safe_encode(\u0027 \u0027.join(curl), errors\u003d\u0027ignore\u0027))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @staticmethod"},{"line_number":156,"context_line":"    def log_http_response(resp, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"baada198_fbba4b09","side":"PARENT","line":153,"updated":"2014-06-30 14:46:20.000000000","message":"Why remove \u0027errors\u0027 argument, this could causes a bug, IMO.","commit_id":"abd0812d05e456e68af4d8bed04396a8815884b3"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"8bf0c985eba1acc951a797147b6a1e8f730fa28a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def log_curl_request(self, method, url, headers, data, kwargs):"},{"line_number":78,"context_line":"        curl \u003d [\u0027curl -i -X %s\u0027 % method]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        for (key, value) in self.session.headers.items():"},{"line_number":81,"context_line":"            header \u003d \u0027-H \\\u0027%s: %s\\\u0027\u0027 % (key, value)"},{"line_number":82,"context_line":"            curl.append(strutils.safe_encode(header))"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"baada198_bbc0d37d","line":80,"updated":"2014-06-30 14:46:20.000000000","message":"seems this loop logic is a bit duplication with below one (line #87).","commit_id":"47e20cc0466d0cf6514372ed32147b876677df34"}],"glanceclient/common/https.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"20a9b3b17ed017989e92f5ba37304815e97535a9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Red Hat, Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_cce6a2e8","line":1,"updated":"2014-05-21 11:54:24.000000000","message":"2014*","commit_id":"d3ce8adf28cc5ac7812ef9bad1307e64a41d304d"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"962a5182fda54a8376dfe1a2073dfdec54273b9b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Red Hat, Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_f57cd322","line":1,"in_reply_to":"7adec928_cce6a2e8","updated":"2014-06-02 06:13:17.000000000","message":"Done","commit_id":"d3ce8adf28cc5ac7812ef9bad1307e64a41d304d"}],"glanceclient/common/utils.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"8bf0c985eba1acc951a797147b6a1e8f730fa28a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":30,"context_line":"    import msvcrt"}],"source_content_type":"text/x-python","patch_set":20,"id":"baada198_b8f45988","line":27,"updated":"2014-06-30 14:46:20.000000000","message":"unused var?","commit_id":"47e20cc0466d0cf6514372ed32147b876677df34"}],"tests/test_exc.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"cea013deb3e6c9ed75c532f2472507f28d4a57db","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_from_response(self):"},{"line_number":24,"context_line":"        \"\"\"exc.from_response should return instance of an HTTP exception.\"\"\""},{"line_number":25,"context_line":"        out \u003d exc.from_response(utils.FakeResponse(status_code\u003d400))"},{"line_number":26,"context_line":"        self.assertTrue(out, exc.HTTPBadRequest)"}],"source_content_type":"text/x-python","patch_set":21,"id":"baada198_a91082a9","line":26,"updated":"2014-07-08 16:25:14.000000000","message":"In fact, it should be assertRaises. This test is not testing anything at this point.","commit_id":"13610f9062b3aa9c104b8a7a7fb672e1bcca0bf6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"acb2a4d4a63ad3416916a75028ea1ba4a115e91a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_from_response(self):"},{"line_number":24,"context_line":"        \"\"\"exc.from_response should return instance of an HTTP exception.\"\"\""},{"line_number":25,"context_line":"        out \u003d exc.from_response(utils.FakeResponse(status_code\u003d400))"},{"line_number":26,"context_line":"        self.assertTrue(out, exc.HTTPBadRequest)"}],"source_content_type":"text/x-python","patch_set":21,"id":"baada198_2e9dd159","line":26,"updated":"2014-07-03 18:00:07.000000000","message":"shouldn\u0027t this be assertEqual?","commit_id":"13610f9062b3aa9c104b8a7a7fb672e1bcca0bf6"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"f7d41ea7cd1bb91672cf418f6b515a00a2d56ee5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_from_response(self):"},{"line_number":24,"context_line":"        \"\"\"exc.from_response should return instance of an HTTP exception.\"\"\""},{"line_number":25,"context_line":"        out \u003d exc.from_response(utils.FakeResponse(status_code\u003d400))"},{"line_number":26,"context_line":"        self.assertTrue(out, exc.HTTPBadRequest)"}],"source_content_type":"text/x-python","patch_set":21,"id":"baada198_f948ef5d","line":26,"in_reply_to":"baada198_2e9dd159","updated":"2014-07-04 06:47:41.000000000","message":"You\u0027re right. I shall club this into future reviews. Thanks for pointing it out.","commit_id":"13610f9062b3aa9c104b8a7a7fb672e1bcca0bf6"}]}