)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05068bec7a270b7b5c3fa2c3ae10cf666dca4b14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0c6f400_3afd12d5","updated":"2022-02-03 05:38:20.000000000","message":"I think you should maintain two different sample responses\n1 for stores-info call which will return it without store properties\n2 for stores-info-detail which will return it with store properties","commit_id":"282ce9c209d60ecb496e3e66126b71791fe6a1d4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"63e734a820a0dfaabdad70ca4810ad4f8fafcaf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"35ddf287_671afab3","updated":"2022-02-09 14:26:50.000000000","message":"Looks good to me, thank you!","commit_id":"282ce9c209d60ecb496e3e66126b71791fe6a1d4"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"0ed8cecacb8840cef0b46d70d815f8c1f531c2c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"909fa656_fc83a1c8","updated":"2022-02-14 00:25:29.000000000","message":"Thanks for using \u0027store_true\u0027 as suggested by Rajat :)","commit_id":"282ce9c209d60ecb496e3e66126b71791fe6a1d4"}],"glanceclient/tests/unit/v2/test_shell_v2.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05068bec7a270b7b5c3fa2c3ae10cf666dca4b14","unresolved":true,"context_lines":[{"line_number":187,"context_line":"    }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_do_stores_info(self):"},{"line_number":190,"context_line":"        args \u003d self._make_args({\u0027detail\u0027: False})"},{"line_number":191,"context_line":"        with mock.patch.object(self.gc.images,"},{"line_number":192,"context_line":"                               \u0027get_stores_info\u0027) as mocked_list:"},{"line_number":193,"context_line":"            mocked_list.return_value \u003d self.stores_info_response"}],"source_content_type":"text/x-python","patch_set":2,"id":"845304c1_7420329d","line":190,"updated":"2022-02-03 05:38:20.000000000","message":"This does not verifies that you don\u0027t have store properties in response.\nIf detail is False then you should return the store response without store properties in it.","commit_id":"282ce9c209d60ecb496e3e66126b71791fe6a1d4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"63e734a820a0dfaabdad70ca4810ad4f8fafcaf8","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_do_stores_info(self):"},{"line_number":190,"context_line":"        args \u003d self._make_args({\u0027detail\u0027: False})"},{"line_number":191,"context_line":"        with mock.patch.object(self.gc.images,"},{"line_number":192,"context_line":"                               \u0027get_stores_info\u0027) as mocked_list:"},{"line_number":193,"context_line":"            mocked_list.return_value \u003d self.stores_info_response"}],"source_content_type":"text/x-python","patch_set":2,"id":"0c182d0c_15af5905","line":190,"in_reply_to":"845304c1_7420329d","updated":"2022-02-09 14:26:50.000000000","message":"My bad, sorry, Ignore this comment!","commit_id":"282ce9c209d60ecb496e3e66126b71791fe6a1d4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"05068bec7a270b7b5c3fa2c3ae10cf666dca4b14","unresolved":true,"context_lines":[{"line_number":214,"context_line":"                pass"},{"line_number":215,"context_line":"        mock_utils_exit.assert_called_once_with(expected_msg)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def test_do_stores_info_with_detail(self):"},{"line_number":218,"context_line":"        args \u003d self._make_args({\u0027detail\u0027: True})"},{"line_number":219,"context_line":"        with mock.patch.object(self.gc.images,"},{"line_number":220,"context_line":"                               \u0027get_stores_info_detail\u0027) as mocked_list:"},{"line_number":221,"context_line":"            mocked_list.return_value \u003d self.stores_info_detail_response"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            test_shell.do_stores_info(self.gc, args)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            mocked_list.assert_called_once_with()"},{"line_number":226,"context_line":"            utils.print_dict.assert_called_once_with("},{"line_number":227,"context_line":"                self.stores_info_detail_response)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @mock.patch(\u0027sys.stderr\u0027)"},{"line_number":230,"context_line":"    def test_image_create_missing_disk_format(self, __):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd2f62e0_855356c5","line":227,"range":{"start_line":217,"start_character":0,"end_line":227,"end_character":49},"updated":"2022-02-03 05:38:20.000000000","message":"here you should verify that you have store properties in response otherwise it is not different than what you are asserting in test \u0027test_do_stores_info\u0027 at line 189","commit_id":"282ce9c209d60ecb496e3e66126b71791fe6a1d4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"63e734a820a0dfaabdad70ca4810ad4f8fafcaf8","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                pass"},{"line_number":215,"context_line":"        mock_utils_exit.assert_called_once_with(expected_msg)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def test_do_stores_info_with_detail(self):"},{"line_number":218,"context_line":"        args \u003d self._make_args({\u0027detail\u0027: True})"},{"line_number":219,"context_line":"        with mock.patch.object(self.gc.images,"},{"line_number":220,"context_line":"                               \u0027get_stores_info_detail\u0027) as mocked_list:"},{"line_number":221,"context_line":"            mocked_list.return_value \u003d self.stores_info_detail_response"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            test_shell.do_stores_info(self.gc, args)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            mocked_list.assert_called_once_with()"},{"line_number":226,"context_line":"            utils.print_dict.assert_called_once_with("},{"line_number":227,"context_line":"                self.stores_info_detail_response)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @mock.patch(\u0027sys.stderr\u0027)"},{"line_number":230,"context_line":"    def test_image_create_missing_disk_format(self, __):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d16b8fcf_480ec222","line":227,"range":{"start_line":217,"start_character":0,"end_line":227,"end_character":49},"in_reply_to":"bd2f62e0_855356c5","updated":"2022-02-09 14:26:50.000000000","message":"ditto, Ignore this comment as well","commit_id":"282ce9c209d60ecb496e3e66126b71791fe6a1d4"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b32a6ab00e0439a1cd83c578b40ef4471fddcafd","unresolved":true,"context_lines":[{"line_number":574,"context_line":"    else:"},{"line_number":575,"context_line":"        utils.print_dict(import_info)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"@utils.arg(\u0027--detail\u0027, default\u003dFalse, required\u003dFalse,"},{"line_number":578,"context_line":"           help\u003d\u0027Shows details of stores. Admin only.\u0027)"},{"line_number":579,"context_line":"def do_stores_info(gc, args):"},{"line_number":580,"context_line":"    \"\"\"Print available backends from Glance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"6d46e5f4_48fe0ef6","line":577,"range":{"start_line":577,"start_character":0,"end_line":577,"end_character":53},"updated":"2022-01-20 14:59:54.000000000","message":"I think the idea of this command is when we pass --detail, it should automatically be True and False in the other case so we can add an action here\naction\u003d\u0027store_true\u0027","commit_id":"581ed2ad81fc7e2faa40b858bc2a826fff58245a"},{"author":{"_account_id":33765,"name":"Mridula Joshi","email":"mrjoshi@redhat.com","username":"mrjoshi"},"change_message_id":"698d66cba135c5e0a02f2883553fdb7312d73e51","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    else:"},{"line_number":575,"context_line":"        utils.print_dict(import_info)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"@utils.arg(\u0027--detail\u0027, default\u003dFalse, required\u003dFalse,"},{"line_number":578,"context_line":"           help\u003d\u0027Shows details of stores. Admin only.\u0027)"},{"line_number":579,"context_line":"def do_stores_info(gc, args):"},{"line_number":580,"context_line":"    \"\"\"Print available backends from Glance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1e3a6e47_33bb2d68","line":577,"range":{"start_line":577,"start_character":0,"end_line":577,"end_character":53},"in_reply_to":"6d46e5f4_48fe0ef6","updated":"2022-02-02 09:15:02.000000000","message":"Ack","commit_id":"581ed2ad81fc7e2faa40b858bc2a826fff58245a"}]}