)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"9b6d40d3b8b9420fb7e22f1f134c7d02a655bb55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73451942_593cd307","updated":"2022-03-07 20:45:59.000000000","message":"It would be interesting to know how this patch has been generated. We have been supporting both TOX_CONSTRAINTS_FILE and UPPER_CONSTRAINTS_FILE (in that order) since merging 51c5c674c5d54b1b9028ac0228903618730dae69 (Change-Id: I8aec0f3ab5b33c6ee1ccd0fafafc7c3e447082db).","commit_id":"8fb5d7050c483a195006a293e101d36327dc65b8"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a429be4abfff19a9858abd5e0fe4b43993fe2ffc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"501a5eb6_c09e2fd3","updated":"2022-03-09 22:07:28.000000000","message":"Thanks for your comment! We decided to support both the old and the new variable just in case someone out there (maybe a distro maintainer?) uses the old variable. I\u0027ll update this patch accordingly.","commit_id":"8fb5d7050c483a195006a293e101d36327dc65b8"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f1cf9360de22e0eed1178cf664c659b6e48067e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c740292d_03eb8f68","in_reply_to":"73451942_593cd307","updated":"2022-03-08 09:01:18.000000000","message":"In general, in most of the repositories UPPER_CONSTRAINTS_FILE was simply replaced with TOX_CONSTRAINTS_FILE [1] (devstack still supports both the old and the new environment variable).\n\nThough this works, so it\u0027s up to your team whether to keep this way, or simply delete the old, UPPER_CONSTRAINTS_FILE.\n\nHere you can see how this patch is generated: [2].\n\n[1] https://review.opendev.org/q/topic:create-yoga\n[2] https://opendev.org/openstack/project-config/src/branch/master/roles/copy-release-tools-scripts/files/release-tools/functions#L76-L118","commit_id":"8fb5d7050c483a195006a293e101d36327dc65b8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fead24f06097b13d8f267d7c87fa08f97723a025","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72e6f56a_55d77d62","updated":"2022-03-10 13:54:04.000000000","message":"Thank you!","commit_id":"a6ff8c231368a62dd9f6ad9c88663f4a05fa2838"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"5beb6662a882770426467308f36f8af5037be6d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15d4d0a1_f053316b","updated":"2022-03-10 06:25:47.000000000","message":"Thanks @Cyril for the update, looks good to me!","commit_id":"a6ff8c231368a62dd9f6ad9c88663f4a05fa2838"}],"tox.ini":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8b80eb80dab0a645e4e99290ea515881917d773c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# first one that is defined. If none of them is defined, we fallback to the"},{"line_number":14,"context_line":"# default value."},{"line_number":15,"context_line":"deps \u003d"},{"line_number":16,"context_line":"       -c{env:TOX_CONSTRAINTS_FILE:{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}}"},{"line_number":17,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":18,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":19,"context_line":"commands \u003d stestr run --slowest {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"beb63d37_d9c69275","side":"PARENT","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":63},"updated":"2022-02-24 16:22:59.000000000","message":"This is a bit different than the usual way. Nevertheless, I don\u0027t think we need the UPPER_CONSTRAINTS_FILE environment variable anymore.","commit_id":"98a0489dfe1cc1487580f21bc754210927883bcb"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6379b1f6c601a193fe5bcd28ade4473d081ce9bb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# first one that is defined. If none of them is defined, we fallback to the"},{"line_number":14,"context_line":"# default value."},{"line_number":15,"context_line":"deps \u003d"},{"line_number":16,"context_line":"       -c{env:TOX_CONSTRAINTS_FILE:{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}}"},{"line_number":17,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":18,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":19,"context_line":"commands \u003d stestr run --slowest {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"2519a4bd_f199aac9","side":"PARENT","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":63},"in_reply_to":"beb63d37_d9c69275","updated":"2022-03-09 22:09:02.000000000","message":"Ack","commit_id":"98a0489dfe1cc1487580f21bc754210927883bcb"}]}
