)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"4af0fb4bd6e0b8e2f319c526c68b1203ae22e4f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6fc9906_99ea7ad8","updated":"2022-08-26 14:34:41.000000000","message":"I add a suggestion about region parameter naming and a note about a missing optional parameter support.","commit_id":"1b2f6bcdbfa8320dcc8de5171c76b3bdadc41ce4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"62f6385e38ebc8c0b78d0d08d6a04352940ffbd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fdeb4fc_d991bb10","updated":"2022-08-29 05:41:16.000000000","message":"recheck","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"04adf25afeef3f091fc1e8868625877f9c83ba17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8fd68439_addcd295","updated":"2022-08-29 05:56:10.000000000","message":"report a blueprint and use that in commit message, also this requires a releasnote as well!","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e7e10168f37deaa56b7a3c53f987a6022a879a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"035f998a_9a5f9f19","updated":"2022-08-29 11:41:17.000000000","message":"Couple suggestions on top of Pierre-Samuel\u0027s great point.","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"4ff6e9b8ca64ac4e51875c966ac5ae05a69b1484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0447ad69_35156084","updated":"2022-08-29 07:09:05.000000000","message":"Hey Abhishek, thanks for your review.\n\nI\u0027ve updated the new patch by addressing your comments. Kindly please have a look.","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"d5fe594623d12e60259ce5c851ef23f0cf79e598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b1d876a9_a0dae93d","updated":"2022-08-29 08:58:52.000000000","message":"Small suggestion for parameter naming consistency otherwise LGTM","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2bccf3047512d3d91377aa704749b44df5dd9961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3f5fcd8_d602cd90","updated":"2022-08-29 11:47:51.000000000","message":"oops, one more","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"801475e148de1a5354fd5943a4e5c4afde594222","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"423ab307_5f9941f0","updated":"2022-08-29 14:00:51.000000000","message":"Updated the releasenote suggestion which i forgot to add in last patch set.","commit_id":"83d11fd30dd81fcfdefaf3f14a0f8e0ebfa801d3"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"50c1e17c33ade1e14e93250fac44928c9b92d17a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d12f452a_7c4293e7","updated":"2022-08-30 12:42:56.000000000","message":"In follow-up also increase the test coverage as well.","commit_id":"92cd70a2240dd5106ebfffecd6007942e898903a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0b103e727c85dc9ae06b8d5901ae3aa4303fa357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"20f06682_23ff4ddb","updated":"2022-08-30 12:32:15.000000000","message":"RP+1 as we really would want this reviewed today.","commit_id":"92cd70a2240dd5106ebfffecd6007942e898903a"}],"glanceclient/v2/images.py":[{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"4af0fb4bd6e0b8e2f319c526c68b1203ae22e4f4","unresolved":true,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":355,"context_line":"    def image_import(self, image_id, method\u003d\u0027glance-direct\u0027, uri\u003dNone,"},{"line_number":356,"context_line":"                     region\u003dNone, remote_image_id\u003dNone, backend\u003dNone,"},{"line_number":357,"context_line":"                     stores\u003dNone, allow_failure\u003dTrue, all_stores\u003dNone):"},{"line_number":358,"context_line":"        \"\"\"Import Image via method.\"\"\""},{"line_number":359,"context_line":"        headers \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"468e49b6_8342542b","line":356,"updated":"2022-08-26 14:34:41.000000000","message":"What\u0027s about using remote_region instead of region, it will keep a sort of consistency with remote_image_id?\n\nYou should also add the remote_service_interface parameter to implement the optional glance_service_interface parameter of the API.\n\nYou might refer to https://review.opendev.org/c/openstack/glance/+/853928/2/api-ref/source/v2/samples/image-import-gd-request.json for the input parameters.","commit_id":"1b2f6bcdbfa8320dcc8de5171c76b3bdadc41ce4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"b5ad236c8fb550e86f8a2d19bd767813599120a0","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":355,"context_line":"    def image_import(self, image_id, method\u003d\u0027glance-direct\u0027, uri\u003dNone,"},{"line_number":356,"context_line":"                     region\u003dNone, remote_image_id\u003dNone, backend\u003dNone,"},{"line_number":357,"context_line":"                     stores\u003dNone, allow_failure\u003dTrue, all_stores\u003dNone):"},{"line_number":358,"context_line":"        \"\"\"Import Image via method.\"\"\""},{"line_number":359,"context_line":"        headers \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"78deffcc_e700f9bf","line":356,"in_reply_to":"468e49b6_8342542b","updated":"2022-08-28 20:04:48.000000000","message":"Done","commit_id":"1b2f6bcdbfa8320dcc8de5171c76b3bdadc41ce4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"04adf25afeef3f091fc1e8868625877f9c83ba17","unresolved":true,"context_lines":[{"line_number":379,"context_line":"                data[\u0027method\u0027][\u0027glance_region\u0027] \u003d region"},{"line_number":380,"context_line":"                data[\u0027method\u0027][\u0027glance_image_id\u0027] \u003d remote_image_id"},{"line_number":381,"context_line":"            else:"},{"line_number":382,"context_line":"                raise exc.HTTPBadRequest(\u0027REGION is only supported with \u0027"},{"line_number":383,"context_line":"                                         \u0027method: \"glance-download\"\u0027)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        if uri:"},{"line_number":386,"context_line":"            if method \u003d\u003d \u0027web-download\u0027:"},{"line_number":387,"context_line":"                data[\u0027method\u0027][\u0027uri\u0027] \u003d uri"}],"source_content_type":"text/x-python","patch_set":2,"id":"9900f3ef_dda6d987","line":384,"range":{"start_line":382,"start_character":16,"end_line":384,"end_character":0},"updated":"2022-08-29 05:56:10.000000000","message":"is remote_image_id supported with other import methods?\nI think this message should include that as well","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"4ff6e9b8ca64ac4e51875c966ac5ae05a69b1484","unresolved":true,"context_lines":[{"line_number":379,"context_line":"                data[\u0027method\u0027][\u0027glance_region\u0027] \u003d region"},{"line_number":380,"context_line":"                data[\u0027method\u0027][\u0027glance_image_id\u0027] \u003d remote_image_id"},{"line_number":381,"context_line":"            else:"},{"line_number":382,"context_line":"                raise exc.HTTPBadRequest(\u0027REGION is only supported with \u0027"},{"line_number":383,"context_line":"                                         \u0027method: \"glance-download\"\u0027)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        if uri:"},{"line_number":386,"context_line":"            if method \u003d\u003d \u0027web-download\u0027:"},{"line_number":387,"context_line":"                data[\u0027method\u0027][\u0027uri\u0027] \u003d uri"}],"source_content_type":"text/x-python","patch_set":2,"id":"fea32cd2_1907f79e","line":384,"range":{"start_line":382,"start_character":16,"end_line":384,"end_character":0},"in_reply_to":"9900f3ef_dda6d987","updated":"2022-08-29 07:09:05.000000000","message":"No, Updated. Thanks !","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"70bf203b0362ab89e3a034c920565e4973d2ee9c","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                data[\u0027method\u0027][\u0027glance_region\u0027] \u003d region"},{"line_number":380,"context_line":"                data[\u0027method\u0027][\u0027glance_image_id\u0027] \u003d remote_image_id"},{"line_number":381,"context_line":"            else:"},{"line_number":382,"context_line":"                raise exc.HTTPBadRequest(\u0027REGION is only supported with \u0027"},{"line_number":383,"context_line":"                                         \u0027method: \"glance-download\"\u0027)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        if uri:"},{"line_number":386,"context_line":"            if method \u003d\u003d \u0027web-download\u0027:"},{"line_number":387,"context_line":"                data[\u0027method\u0027][\u0027uri\u0027] \u003d uri"}],"source_content_type":"text/x-python","patch_set":2,"id":"a0aefd1f_af56cdc6","line":384,"range":{"start_line":382,"start_character":16,"end_line":384,"end_character":0},"in_reply_to":"fea32cd2_1907f79e","updated":"2022-08-30 06:02:54.000000000","message":"Done","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2bccf3047512d3d91377aa704749b44df5dd9961","unresolved":true,"context_lines":[{"line_number":379,"context_line":"                data[\u0027method\u0027][\u0027glance_region\u0027] \u003d region"},{"line_number":380,"context_line":"                data[\u0027method\u0027][\u0027glance_image_id\u0027] \u003d remote_image_id"},{"line_number":381,"context_line":"            else:"},{"line_number":382,"context_line":"                raise exc.HTTPBadRequest(\u0027REMOTE REGION  and REMOTE IMAGE ID \u0027"},{"line_number":383,"context_line":"                                         \u0027are only supported with \u0027"},{"line_number":384,"context_line":"                                         \u0027method: \"glance-download\"\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        if uri:"},{"line_number":387,"context_line":"            if method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ad4cc6a0_2545d8c6","line":384,"range":{"start_line":382,"start_character":0,"end_line":384,"end_character":69},"updated":"2022-08-29 11:47:51.000000000","message":"Also applies to the REMOTE_SERVICE_INTERFACE. Based on our fail early principles these should be also eliminated already from the shell just like --uri is on line 257 of the v2/shell.py.","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"de6f1b3a96cddfd95f15f52c4ef826bb03c0d60e","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                data[\u0027method\u0027][\u0027glance_region\u0027] \u003d region"},{"line_number":380,"context_line":"                data[\u0027method\u0027][\u0027glance_image_id\u0027] \u003d remote_image_id"},{"line_number":381,"context_line":"            else:"},{"line_number":382,"context_line":"                raise exc.HTTPBadRequest(\u0027REMOTE REGION  and REMOTE IMAGE ID \u0027"},{"line_number":383,"context_line":"                                         \u0027are only supported with \u0027"},{"line_number":384,"context_line":"                                         \u0027method: \"glance-download\"\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        if uri:"},{"line_number":387,"context_line":"            if method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"901ed6a2_c99fd618","line":384,"range":{"start_line":382,"start_character":0,"end_line":384,"end_character":69},"in_reply_to":"ad4cc6a0_2545d8c6","updated":"2022-08-29 13:56:30.000000000","message":"Ack","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"4af0fb4bd6e0b8e2f319c526c68b1203ae22e4f4","unresolved":true,"context_lines":[{"line_number":756,"context_line":"                  \u0027\"image-stage\".\u0027))"},{"line_number":757,"context_line":"@utils.arg(\u0027--uri\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027, default\u003dNone,"},{"line_number":758,"context_line":"           help\u003d_(\u0027URI to download the external image.\u0027))"},{"line_number":759,"context_line":"@utils.arg(\u0027--region\u0027, metavar\u003d\u0027\u003cGLANCE_REGION\u003e\u0027, default\u003dNone,"},{"line_number":760,"context_line":"           help\u003d_(\u0027GLANCE_REGION to download the image.\u0027))"},{"line_number":761,"context_line":"@utils.arg(\u0027--remote-image-id\u0027, metavar\u003d\u0027\u003cREMOTE_IMAGE_ID\u003e\u0027, default\u003dNone,"},{"line_number":762,"context_line":"           help\u003d_(\u0027The IMAGE ID of the image of remote glance, which needs\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c71efa39_6cb74331","line":759,"updated":"2022-08-26 14:34:41.000000000","message":"Same suggestion: --remote-region for consistency\nAnd add --remote-service-interface","commit_id":"1b2f6bcdbfa8320dcc8de5171c76b3bdadc41ce4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"b5ad236c8fb550e86f8a2d19bd767813599120a0","unresolved":false,"context_lines":[{"line_number":756,"context_line":"                  \u0027\"image-stage\".\u0027))"},{"line_number":757,"context_line":"@utils.arg(\u0027--uri\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027, default\u003dNone,"},{"line_number":758,"context_line":"           help\u003d_(\u0027URI to download the external image.\u0027))"},{"line_number":759,"context_line":"@utils.arg(\u0027--region\u0027, metavar\u003d\u0027\u003cGLANCE_REGION\u003e\u0027, default\u003dNone,"},{"line_number":760,"context_line":"           help\u003d_(\u0027GLANCE_REGION to download the image.\u0027))"},{"line_number":761,"context_line":"@utils.arg(\u0027--remote-image-id\u0027, metavar\u003d\u0027\u003cREMOTE_IMAGE_ID\u003e\u0027, default\u003dNone,"},{"line_number":762,"context_line":"           help\u003d_(\u0027The IMAGE ID of the image of remote glance, which needs\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"6618f122_9f37afb0","line":759,"in_reply_to":"c71efa39_6cb74331","updated":"2022-08-28 20:04:48.000000000","message":"Done","commit_id":"1b2f6bcdbfa8320dcc8de5171c76b3bdadc41ce4"},{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"4af0fb4bd6e0b8e2f319c526c68b1203ae22e4f4","unresolved":true,"context_lines":[{"line_number":793,"context_line":"    all_stores \u003d getattr(args, \"os_all_stores\", None)"},{"line_number":794,"context_line":"    allow_failure \u003d getattr(args, \"os_allow_failure\", True)"},{"line_number":795,"context_line":"    uri \u003d getattr(args, \"uri\", None)"},{"line_number":796,"context_line":"    region \u003d getattr(args, \"region\", None)"},{"line_number":797,"context_line":"    remote_image_id \u003d getattr(args, \"remote-image-id\", None)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"    if not getattr(args, \u0027from_create\u0027, False):"}],"source_content_type":"text/x-python","patch_set":1,"id":"18b31671_932c316f","line":796,"updated":"2022-08-26 14:34:41.000000000","message":"I add this comment as a reminder, remote_region and remote_service_interface","commit_id":"1b2f6bcdbfa8320dcc8de5171c76b3bdadc41ce4"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"b5ad236c8fb550e86f8a2d19bd767813599120a0","unresolved":false,"context_lines":[{"line_number":793,"context_line":"    all_stores \u003d getattr(args, \"os_all_stores\", None)"},{"line_number":794,"context_line":"    allow_failure \u003d getattr(args, \"os_allow_failure\", True)"},{"line_number":795,"context_line":"    uri \u003d getattr(args, \"uri\", None)"},{"line_number":796,"context_line":"    region \u003d getattr(args, \"region\", None)"},{"line_number":797,"context_line":"    remote_image_id \u003d getattr(args, \"remote-image-id\", None)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"    if not getattr(args, \u0027from_create\u0027, False):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcdea968_b951673f","line":796,"in_reply_to":"18b31671_932c316f","updated":"2022-08-28 20:04:48.000000000","message":"Done","commit_id":"1b2f6bcdbfa8320dcc8de5171c76b3bdadc41ce4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"04adf25afeef3f091fc1e8868625877f9c83ba17","unresolved":true,"context_lines":[{"line_number":319,"context_line":"                       \"required for glance-download import method. \""},{"line_number":320,"context_line":"                       \"Please use --remote-region \u003cregion\u003e and \""},{"line_number":321,"context_line":"                       \"--remote-image-id \u003cremote-image-id\u003e.\")"},{"line_number":322,"context_line":"        if args.uri:"},{"line_number":323,"context_line":"            utils.exit(\"You cannot specify a --uri with the glance-download \""},{"line_number":324,"context_line":"                       \"import method.\")"},{"line_number":325,"context_line":"        if file_name:"},{"line_number":326,"context_line":"            utils.exit(\"You cannot specify a --file with the glance-download \""},{"line_number":327,"context_line":"                       \"import method.\")"},{"line_number":328,"context_line":"        if using_stdin:"},{"line_number":329,"context_line":"            utils.exit(\"You cannot pass data via stdin with the \""},{"line_number":330,"context_line":"                       \"glance-download import method.\")"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    # process"},{"line_number":333,"context_line":"    image \u003d gc.images.create(**fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c8afa8e0_c362fc8a","line":330,"range":{"start_line":322,"start_character":8,"end_line":330,"end_character":56},"updated":"2022-08-29 05:56:10.000000000","message":"I think this needs unit test coverage","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"4ff6e9b8ca64ac4e51875c966ac5ae05a69b1484","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                       \"required for glance-download import method. \""},{"line_number":320,"context_line":"                       \"Please use --remote-region \u003cregion\u003e and \""},{"line_number":321,"context_line":"                       \"--remote-image-id \u003cremote-image-id\u003e.\")"},{"line_number":322,"context_line":"        if args.uri:"},{"line_number":323,"context_line":"            utils.exit(\"You cannot specify a --uri with the glance-download \""},{"line_number":324,"context_line":"                       \"import method.\")"},{"line_number":325,"context_line":"        if file_name:"},{"line_number":326,"context_line":"            utils.exit(\"You cannot specify a --file with the glance-download \""},{"line_number":327,"context_line":"                       \"import method.\")"},{"line_number":328,"context_line":"        if using_stdin:"},{"line_number":329,"context_line":"            utils.exit(\"You cannot pass data via stdin with the \""},{"line_number":330,"context_line":"                       \"glance-download import method.\")"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    # process"},{"line_number":333,"context_line":"    image \u003d gc.images.create(**fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e91c1919_74cf9fe3","line":330,"range":{"start_line":322,"start_character":8,"end_line":330,"end_character":56},"in_reply_to":"c8afa8e0_c362fc8a","updated":"2022-08-29 07:09:05.000000000","message":"Done","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"04adf25afeef3f091fc1e8868625877f9c83ba17","unresolved":true,"context_lines":[{"line_number":852,"context_line":"            not (remote_region and remote_image_id):"},{"line_number":853,"context_line":"        utils.exit(\"Provide REMOTE_IMAGE_ID and remote-region for \""},{"line_number":854,"context_line":"                   \"\u0027glance-download\u0027 import method.\")"},{"line_number":855,"context_line":"    if remote_region and args.import_method !\u003d \u0027glance-download\u0027:"},{"line_number":856,"context_line":"        utils.exit(\"Import method should be \u0027glance-download\u0027 if \""},{"line_number":857,"context_line":"                   \"REMOTE REGION is provided.\")"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027 and not (stores or all_stores):"},{"line_number":860,"context_line":"        utils.exit(\"Provide either --stores or --all-stores for \""}],"source_content_type":"text/x-python","patch_set":2,"id":"f40c293d_e25a19b7","line":857,"range":{"start_line":855,"start_character":4,"end_line":857,"end_character":48},"updated":"2022-08-29 05:56:10.000000000","message":"same validation should go for remote_image_id as well, right?","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"4ff6e9b8ca64ac4e51875c966ac5ae05a69b1484","unresolved":false,"context_lines":[{"line_number":852,"context_line":"            not (remote_region and remote_image_id):"},{"line_number":853,"context_line":"        utils.exit(\"Provide REMOTE_IMAGE_ID and remote-region for \""},{"line_number":854,"context_line":"                   \"\u0027glance-download\u0027 import method.\")"},{"line_number":855,"context_line":"    if remote_region and args.import_method !\u003d \u0027glance-download\u0027:"},{"line_number":856,"context_line":"        utils.exit(\"Import method should be \u0027glance-download\u0027 if \""},{"line_number":857,"context_line":"                   \"REMOTE REGION is provided.\")"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027 and not (stores or all_stores):"},{"line_number":860,"context_line":"        utils.exit(\"Provide either --stores or --all-stores for \""}],"source_content_type":"text/x-python","patch_set":2,"id":"25607232_a0b6959d","line":857,"range":{"start_line":855,"start_character":4,"end_line":857,"end_character":48},"in_reply_to":"f40c293d_e25a19b7","updated":"2022-08-29 07:09:05.000000000","message":"Done","commit_id":"6867dd32846a80f974f352385f0a5aed9431e573"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e7e10168f37deaa56b7a3c53f987a6022a879a0","unresolved":true,"context_lines":[{"line_number":302,"context_line":"                       \"import method.\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    if args.import_method \u003d\u003d \u0027glance-download\u0027:"},{"line_number":305,"context_line":"        if backend and not (args.remote_region and args.remote_image_id):"},{"line_number":306,"context_line":"            utils.exit(\"--store option should only be provided with \""},{"line_number":307,"context_line":"                       \"--remote-region \u0026 --remote-image-id option for the \""},{"line_number":308,"context_line":"                       \"glance-download import method.\")"},{"line_number":309,"context_line":"        if stores and not (args.remote_region and args.remote_image_id):"},{"line_number":310,"context_line":"            utils.exit(\"--stores option should only be provided with \""},{"line_number":311,"context_line":"                       \"--remote-region \u0026 --remote-image-id option for the \""},{"line_number":312,"context_line":"                       \"glance-download import method.\")"},{"line_number":313,"context_line":"        if all_stores and not (args.remote_region and args.remote_image_id):"},{"line_number":314,"context_line":"            utils.exit(\"--all-stores option should only be provided with \""},{"line_number":315,"context_line":"                       \"--remote-region \u0026 --remote-image-id option for the \""},{"line_number":316,"context_line":"                       \"glance-download import method.\")"},{"line_number":317,"context_line":"        if not (args.remote_region and args.remote_image_id):"},{"line_number":318,"context_line":"            utils.exit(\"REMOTE GlANCE REGION and REMOTE IMAGE ID are \""},{"line_number":319,"context_line":"                       \"required for glance-download import method. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"2eeb2036_66eb77c7","line":316,"range":{"start_line":305,"start_character":0,"end_line":316,"end_character":56},"updated":"2022-08-29 11:41:17.000000000","message":"I don\u0027t think these are required. if we would move the next condition to the top (Which is IMO the most important one as those fields are required regardless of if any store options are provided or not) these conditions would never hit.\n\nThese errors just confuses the user to think that they can call \u0027glance-download\u0027 only without store options if they don\u0027t provide the remote-*, until they try and then we tell that those remote-* fields are mandatory. Just like we don\u0027t check here before if they have provided the \"remote_service_interface\" without the two mandatory ones (which would be equally pointless and confusing).","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"de6f1b3a96cddfd95f15f52c4ef826bb03c0d60e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                       \"import method.\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    if args.import_method \u003d\u003d \u0027glance-download\u0027:"},{"line_number":305,"context_line":"        if backend and not (args.remote_region and args.remote_image_id):"},{"line_number":306,"context_line":"            utils.exit(\"--store option should only be provided with \""},{"line_number":307,"context_line":"                       \"--remote-region \u0026 --remote-image-id option for the \""},{"line_number":308,"context_line":"                       \"glance-download import method.\")"},{"line_number":309,"context_line":"        if stores and not (args.remote_region and args.remote_image_id):"},{"line_number":310,"context_line":"            utils.exit(\"--stores option should only be provided with \""},{"line_number":311,"context_line":"                       \"--remote-region \u0026 --remote-image-id option for the \""},{"line_number":312,"context_line":"                       \"glance-download import method.\")"},{"line_number":313,"context_line":"        if all_stores and not (args.remote_region and args.remote_image_id):"},{"line_number":314,"context_line":"            utils.exit(\"--all-stores option should only be provided with \""},{"line_number":315,"context_line":"                       \"--remote-region \u0026 --remote-image-id option for the \""},{"line_number":316,"context_line":"                       \"glance-download import method.\")"},{"line_number":317,"context_line":"        if not (args.remote_region and args.remote_image_id):"},{"line_number":318,"context_line":"            utils.exit(\"REMOTE GlANCE REGION and REMOTE IMAGE ID are \""},{"line_number":319,"context_line":"                       \"required for glance-download import method. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ac9953ea_e6dff248","line":316,"range":{"start_line":305,"start_character":0,"end_line":316,"end_character":56},"in_reply_to":"2eeb2036_66eb77c7","updated":"2022-08-29 13:56:30.000000000","message":"Ack. will remove these checks.","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"d5fe594623d12e60259ce5c851ef23f0cf79e598","unresolved":true,"context_lines":[{"line_number":887,"context_line":""},{"line_number":888,"context_line":"    # finally, do the import"},{"line_number":889,"context_line":"    gc.images.image_import(args.id, args.import_method, uri\u003duri,"},{"line_number":890,"context_line":"                           region\u003dremote_region,"},{"line_number":891,"context_line":"                           remote_image_id\u003dremote_image_id,"},{"line_number":892,"context_line":"                           remote_service_interface\u003dremote_service_interface,"},{"line_number":893,"context_line":"                           backend\u003dbackend, stores\u003dstores,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c59c92bd_35ffb983","line":890,"range":{"start_line":890,"start_character":27,"end_line":890,"end_character":33},"updated":"2022-08-29 08:58:52.000000000","message":"I think that we should also keep remote_region as parameter name in image_import method instead of region for consistency with remote_image_id and remote_service_interface.","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"de6f1b3a96cddfd95f15f52c4ef826bb03c0d60e","unresolved":false,"context_lines":[{"line_number":887,"context_line":""},{"line_number":888,"context_line":"    # finally, do the import"},{"line_number":889,"context_line":"    gc.images.image_import(args.id, args.import_method, uri\u003duri,"},{"line_number":890,"context_line":"                           region\u003dremote_region,"},{"line_number":891,"context_line":"                           remote_image_id\u003dremote_image_id,"},{"line_number":892,"context_line":"                           remote_service_interface\u003dremote_service_interface,"},{"line_number":893,"context_line":"                           backend\u003dbackend, stores\u003dstores,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b5e8b6f_b34021e7","line":890,"range":{"start_line":890,"start_character":27,"end_line":890,"end_character":33},"in_reply_to":"1adae309_b42c7ef3","updated":"2022-08-29 13:56:30.000000000","message":"Done","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e7e10168f37deaa56b7a3c53f987a6022a879a0","unresolved":true,"context_lines":[{"line_number":887,"context_line":""},{"line_number":888,"context_line":"    # finally, do the import"},{"line_number":889,"context_line":"    gc.images.image_import(args.id, args.import_method, uri\u003duri,"},{"line_number":890,"context_line":"                           region\u003dremote_region,"},{"line_number":891,"context_line":"                           remote_image_id\u003dremote_image_id,"},{"line_number":892,"context_line":"                           remote_service_interface\u003dremote_service_interface,"},{"line_number":893,"context_line":"                           backend\u003dbackend, stores\u003dstores,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1adae309_b42c7ef3","line":890,"range":{"start_line":890,"start_character":27,"end_line":890,"end_character":33},"in_reply_to":"c59c92bd_35ffb983","updated":"2022-08-29 11:41:17.000000000","message":"Agreed!","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"70bf203b0362ab89e3a034c920565e4973d2ee9c","unresolved":true,"context_lines":[{"line_number":845,"context_line":"                   \"REMOTE REGION is provided.\")"},{"line_number":846,"context_line":"    if remote_image_id and args.import_method !\u003d \u0027glance-download\u0027:"},{"line_number":847,"context_line":"        utils.exit(\"Import method should be \u0027glance-download\u0027 if \""},{"line_number":848,"context_line":"                   \"REMOTE IMAGE ID is provided.\")"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027 and not (stores or all_stores):"},{"line_number":851,"context_line":"        utils.exit(\"Provide either --stores or --all-stores for \""}],"source_content_type":"text/x-python","patch_set":5,"id":"c94395e0_072636ab","line":848,"updated":"2022-08-30 06:02:54.000000000","message":"I think same validation is required for remote-service-interface, right?","commit_id":"83d11fd30dd81fcfdefaf3f14a0f8e0ebfa801d3"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"923708e1e0c7b1e41a1b14f9e135939812f0c8ff","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                   \"REMOTE REGION is provided.\")"},{"line_number":846,"context_line":"    if remote_image_id and args.import_method !\u003d \u0027glance-download\u0027:"},{"line_number":847,"context_line":"        utils.exit(\"Import method should be \u0027glance-download\u0027 if \""},{"line_number":848,"context_line":"                   \"REMOTE IMAGE ID is provided.\")"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027 and not (stores or all_stores):"},{"line_number":851,"context_line":"        utils.exit(\"Provide either --stores or --all-stores for \""}],"source_content_type":"text/x-python","patch_set":5,"id":"fcdcbecc_5d8867da","line":848,"in_reply_to":"c94395e0_072636ab","updated":"2022-08-30 11:28:38.000000000","message":"Done","commit_id":"83d11fd30dd81fcfdefaf3f14a0f8e0ebfa801d3"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0b103e727c85dc9ae06b8d5901ae3aa4303fa357","unresolved":true,"context_lines":[{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    if args.import_method \u003d\u003d \u0027web-download\u0027 and not args.uri:"},{"line_number":834,"context_line":"        utils.exit(\"Provide URI for web-download import method.\")"},{"line_number":835,"context_line":"    if args.uri and args.import_method !\u003d \u0027web-download\u0027:"},{"line_number":836,"context_line":"        utils.exit(\"Import method should be \u0027web-download\u0027 if URI is \""},{"line_number":837,"context_line":"                   \"provided.\")"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    if args.import_method \u003d\u003d \u0027glance-download\u0027 and \\"},{"line_number":840,"context_line":"            not (remote_region and remote_image_id):"},{"line_number":841,"context_line":"        utils.exit(\"Provide REMOTE_IMAGE_ID and remote-region for \""},{"line_number":842,"context_line":"                   \"\u0027glance-download\u0027 import method.\")"},{"line_number":843,"context_line":"    if remote_region and args.import_method !\u003d \u0027glance-download\u0027:"},{"line_number":844,"context_line":"        utils.exit(\"Import method should be \u0027glance-download\u0027 if \""},{"line_number":845,"context_line":"                   \"REMOTE REGION is provided.\")"},{"line_number":846,"context_line":"    if remote_image_id and args.import_method !\u003d \u0027glance-download\u0027:"},{"line_number":847,"context_line":"        utils.exit(\"Import method should be \u0027glance-download\u0027 if \""},{"line_number":848,"context_line":"                   \"REMOTE IMAGE ID is provided.\")"},{"line_number":849,"context_line":"    if remote_service_interface and args.import_method !\u003d \u0027glance-download\u0027:"},{"line_number":850,"context_line":"        utils.exit(\"Import method should be \u0027glance-download\u0027 if \""},{"line_number":851,"context_line":"                   \"REMOTE SERVICE INTERFACE is provided.\")"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    if args.import_method \u003d\u003d \u0027copy-image\u0027 and not (stores or all_stores):"},{"line_number":854,"context_line":"        utils.exit(\"Provide either --stores or --all-stores for \""}],"source_content_type":"text/x-python","patch_set":6,"id":"1b13ab21_40bd3d6d","line":851,"range":{"start_line":835,"start_character":0,"end_line":851,"end_character":59},"updated":"2022-08-30 12:32:15.000000000","message":"NIT: would be great if these error messages were consistent with majority and used the \"--\" CLI option rather than variations (L#841 \u0026 L#848) of the metavar name. As these are just error messages on the CLI we can easily align them in follow up after the rel deadline.","commit_id":"92cd70a2240dd5106ebfffecd6007942e898903a"}],"releasenotes/notes/add-support-for-glance-download-import-method-10525254db3e8e7a.yaml":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4e7e10168f37deaa56b7a3c53f987a6022a879a0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for newly added ``glance-download`` import method"},{"line_number":5,"context_line":"    to support downloading image from another glance/region."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8bd31ea0_7b990ea3","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":60},"updated":"2022-08-29 11:41:17.000000000","message":"Perhaps something like \"\"\"Add support for new ``glance-download`` image-import method to import image from another glance/region in federated deployment.\"\"\" just to avoid repetition of \u0027support\u0027 and to highlight that the federated deployment is prerequisite for this feature to work.","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"801475e148de1a5354fd5943a4e5c4afde594222","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for newly added ``glance-download`` import method"},{"line_number":5,"context_line":"    to support downloading image from another glance/region."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"087b5b23_44d7de94","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":60},"in_reply_to":"8bd31ea0_7b990ea3","updated":"2022-08-29 14:00:51.000000000","message":"Done","commit_id":"6fa36d874a91a8ee9bcfdc46e43f8914ace95b44"}]}