)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"030e1cbf113b081e74f3e61e4e23ea5af4de5654","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31edd8d1_fd5fef3f","updated":"2023-01-12 11:40:31.000000000","message":"I\u0027m pretty sure that\u0027s the intended behaviour how the tox.ini has been built. The doc/requirements has only requirements to build the docs from the sources, not install the package itself. Is there any reason why we should be installing the client to build it\u0027s docs?","commit_id":"8b24ef9e418a63b905e4aa8d9e53ecb392a8338e"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8f0e84624a5390c6ba0ca80a3f48b3b0a2ee7476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ec1386e_b1f51cfb","updated":"2023-01-12 11:38:07.000000000","message":"The CI failure on this patch is fixed by https://review.opendev.org/c/openstack/python-glanceclient/+/867932 , which cannot be merged because of a CI failure fixed by... this patch.","commit_id":"8b24ef9e418a63b905e4aa8d9e53ecb392a8338e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"32dd5b945f9ae284457bf977b88a9c63bb8ec466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ca031395_9ec89552","updated":"2023-01-12 05:43:00.000000000","message":"recheck","commit_id":"8b24ef9e418a63b905e4aa8d9e53ecb392a8338e"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a115afda226bb0e9c0c3825d07e619e840475b96","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ee6ddb3_21fbaf70","in_reply_to":"31edd8d1_fd5fef3f","updated":"2023-01-12 12:29:07.000000000","message":"So, this is what we have been doing for ages with tox \u003c4.0.0. See the error in the Launchpad bug: autodoc actually uses the imports.\n\nYou can try to run \"tox -redocs\" with tox 3.x and tox 4.x to see what is installed in the env: there is a behavioral change when switching to 4.x.","commit_id":"8b24ef9e418a63b905e4aa8d9e53ecb392a8338e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ada1402a36ac0c2169de820c857b3bf77fb8f357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7afd2e7a_1c06e0db","updated":"2023-01-12 15:36:27.000000000","message":"I think the voting form changed in this version of gerrit.  I keep hitting +1 for review priority instead of +1 for workflow.","commit_id":"6c95122777c8449056115292b492ec3e1e0d6e50"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"be70f6fcd6266079b9bb316b21b4e08599d25f46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fa81216_0765a980","updated":"2023-01-12 15:35:13.000000000","message":"LGTM.","commit_id":"6c95122777c8449056115292b492ec3e1e0d6e50"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"736d872bd2b43f6f11d25814f39f44509ae825ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0946a71_9cacefe1","updated":"2023-01-12 15:13:50.000000000","message":"Thank you!!","commit_id":"6c95122777c8449056115292b492ec3e1e0d6e50"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a50d71f79ff1c59bb1b92a333c1a500aa41c6914","unresolved":true,"context_lines":[{"line_number":55,"context_line":"[testenv:docs]"},{"line_number":56,"context_line":"basepython \u003d python3"},{"line_number":57,"context_line":"deps \u003d"},{"line_number":58,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":59,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":60,"context_line":"commands \u003d"},{"line_number":61,"context_line":"  sphinx-build -W -b html doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"046f0e5c_0a1d3074","line":58,"updated":"2023-01-13 19:10:50.000000000","message":"This is happening because you\u0027re not actually installing python-glanceclient. It\u0027s merely getting added because it\u0027s in $PWD and Python adds $PWD to PYTHONPATH meaning it\u0027s also on $PYTHONPATH. You can verify this by looking at the logs with tox 4:\n\n  ❯ tox -e py38                                                                                                                                                                                                                                                                                                                                                                                                                               \n  py38: install_deps\u003e python -I -m pip install -r /tmp/python-glanceclient/requirements.txt -r /tmp/python-glanceclient/test-requirements.txt -c https://releases.openstack.org/constraints/upper/master                                                                                                                                                                  \n  py38: commands[0]\u003e stestr run --slowest \n\nIf you remove \u0027skipsdist \u003d True\u0027 above, this will no longer be necessary.\n\n  ❯ tox -e py38\n  .pkg-cpython38: install_requires\u003e python -I -m pip install \u0027setuptools\u003e\u003d40.8.0\u0027 wheel\n  .pkg-cpython38: _optional_hooks\u003e python /tmp/python-glanceclient/.venv/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__\n  .pkg-cpython38: get_requires_for_build_editable\u003e python /tmp/python-glanceclient/.venv/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__\n  .pkg-cpython38: install_requires_for_build_editable\u003e python -I -m pip install \u0027pbr\u003e\u003d2.0.0\u0027 wheel\n  .pkg-cpython38: build_editable\u003e python /tmp/python-glanceclient/.venv/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__\n  py38: install_package_deps\u003e python -I -m pip install \u0027PrettyTable\u003e\u003d0.7.1\u0027 \u0027keystoneauth1\u003e\u003d3.6.2\u0027 \u0027oslo.i18n\u003e\u003d3.15.3\u0027 \u0027oslo.utils\u003e\u003d3.33.0\u0027 \u0027pbr!\u003d2.1.0,\u003e\u003d2.0.0\u0027 \u0027pyOpenSSL\u003e\u003d17.1.0\u0027 \u0027requests\u003e\u003d2.14.2\u0027 \u0027warlock\u003e\u003d1.2.0\u0027 \u0027wrapt\u003e\u003d1.7.0\u0027\n  py38: install_package\u003e python -I -m pip install --force-reinstall --no-deps /tmp/python-glanceclient/.tox/.tmp/package/1/python_glanceclient-4.2.1.dev1-0.editable-py3-none-any.whl\n  py38: commands[0]\u003e stestr run --slowest","commit_id":"6c95122777c8449056115292b492ec3e1e0d6e50"}]}