)]}'
{"id":"openstack%2Fpython-glanceclient~9020","triplet_id":"openstack%2Fpython-glanceclient~master~Icd3fe97c6341bb04da27adc55a85f1ab6b525c46","project":"openstack/python-glanceclient","branch":"master","topic":"master","hashtags":[],"change_id":"Icd3fe97c6341bb04da27adc55a85f1ab6b525c46","subject":"Split reading of versioninfo out into a method","status":"MERGED","created":"2012-06-26 19:01:08.000000000","updated":"2012-06-27 22:56:30.000000000","submitted":"2012-06-27 22:56:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"28451e7307a4f91b414e16c5df0de336b254bbd2","_number":9020,"virtual_id_number":9020,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2012-06-27 22:56:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"recommended":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"all":[{"value":0,"date":"2012-06-27 22:42:16.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-06-26 19:06:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":1,"date":"2012-06-27 20:54:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},{"value":2,"date":"2012-06-27 21:04:16.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":1,"date":"2012-06-27 22:42:16.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},{"value":1,"date":"2012-06-27 21:04:16.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-06-26 19:06:37.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2012-06-27 20:54:38.000000000","updated_by":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"reviewer":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"state":"REVIEWER"},{"updated":"2012-06-27 21:04:16.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2012-06-27 22:56:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"562c26140c727d014ff134156256801292bc7ff2","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-06-26 19:03:43.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4964d98d5270136fe03836f2f67fd22c70bb64fc","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2012-06-26 19:03:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4c3c29a7230856084f5666e8f5cc5cd7fa3976c3","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2012-06-26 19:05:51.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5081c2c4ffa6c5d6e9426e59b1c6b2056d6aaffa","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-06-26 19:06:37.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"7d51eb04a5dd37bc0d5b3e917f4ffd201aad70da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-06-26 19:19:03.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-python-glanceclient-merge/58/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-pep8/44/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-python26/42/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-python27/43/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/6254/consoleFull : FAILURE\n","accounts_in_message":[],"_revision_number":3},{"id":"161f6c3e8c84ffd30ad6f799d13a87f0e9a1ba30","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-06-26 19:43:00.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nWill approve once https://review.openstack.org/#/c/9021/ happens.","accounts_in_message":[],"_revision_number":3},{"id":"6386e93a52df379fe7bd62b19bf195b7dc8880b9","author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"date":"2012-06-27 20:54:38.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nLooks good, will work once https://review.openstack.org/#/c/9021/ merges.","accounts_in_message":[],"_revision_number":3},{"id":"fe6b089632c1ba78872b1b884cb020d93820a3f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-06-27 21:04:16.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"d7d75706b2c309a20ec0ec46127eea0439cce794","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-06-27 21:04:16.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"020cc73a99195780494a4c4bc1274e0278933cb3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-06-27 21:58:45.000000000","message":"Patch Set 3: Fails\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-python-glanceclient-merge/65/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-pep8/50/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-python26/48/testReport : FAILURE\n- https://jenkins.openstack.org/job/gate-python-glanceclient-python27/49/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/6607/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"5800e138e2be9fc7c6faa09c6234d0f54529f3c1","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2012-06-27 22:42:16.000000000","message":"Patch Set 3: Approved\n\nReapproving - network hiccup during test.","accounts_in_message":[],"_revision_number":3},{"id":"b89c3698729af96e233d02f6c2d14d6715cf89c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-06-27 22:42:17.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"e27c1f476829c39dfd7e32a3b676124c9e7466ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-06-27 22:56:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"158209b8ff41c52f27f5937238678f68be673364","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-06-27 22:56:30.000000000","message":"Patch Set 3: Verified\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-python-glanceclient-merge/66/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-pep8/51/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-python26/49/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-glanceclient-python27/50/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/6622/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"089d509f350b01c8345cfb7b9b33510a60043861","revisions":{"0db0ec6f7dcee9e86d9676ddad9237875d90b2c3":{"kind":"REWORK","_number":1,"created":"2012-06-26 19:01:08.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/20/9020/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/20/9020/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/1"}}},"commit":{"parents":[{"commit":"993a7b7dd670f9ea9ade230bd48519b83af85dbf","subject":"Merge \"Add support for tag-based version numbers.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/993a7b7dd670f9ea9ade230bd48519b83af85dbf"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2012-06-26 18:58:07.000000000","tz":-300},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2012-06-26 18:59:17.000000000","tz":-300},"subject":"Split reading of versioninfo out into a method","message":"Split reading of versioninfo out into a method\n\nMake the read_versioninfo to match write_versioninfo.\n\nAdditionally, there is an edge case where if the code is installed from a\ngithub zipball, versioning info is missing. Now that we\u0027re using this,\nthere should be virtual no instances where a zipball will be easier or\nless cost than an sdist created tarball, all of which should be public and\naccessible, but during the transition, we need to account for the codepath.\n\nChange-Id: Icd3fe97c6341bb04da27adc55a85f1ab6b525c46\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0db0ec6f7dcee9e86d9676ddad9237875d90b2c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0db0ec6f7dcee9e86d9676ddad9237875d90b2c3"}]},"branch":"refs/heads/master"},"a1afd100e5e64e6f36acf433887afe2cc12af1d0":{"kind":"REWORK","_number":2,"created":"2012-06-26 19:03:52.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/20/9020/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/20/9020/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/2"}}},"commit":{"parents":[{"commit":"993a7b7dd670f9ea9ade230bd48519b83af85dbf","subject":"Merge \"Add support for tag-based version numbers.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/993a7b7dd670f9ea9ade230bd48519b83af85dbf"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2012-06-26 18:58:07.000000000","tz":-300},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2012-06-26 19:03:38.000000000","tz":-300},"subject":"Split reading of versioninfo out into a method","message":"Split reading of versioninfo out into a method\n\nMake the read_versioninfo to match write_versioninfo.\n\nAdditionally, there is an edge case where if the code is installed from a\ngithub zipball, versioning info is missing. Now that we\u0027re using this,\nthere should be virtual no instances where a zipball will be easier or\nless cost than an sdist created tarball, all of which should be public and\naccessible, but during the transition, we need to account for the codepath.\n\nChange-Id: Icd3fe97c6341bb04da27adc55a85f1ab6b525c46\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a1afd100e5e64e6f36acf433887afe2cc12af1d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a1afd100e5e64e6f36acf433887afe2cc12af1d0"}]},"branch":"refs/heads/master"},"089d509f350b01c8345cfb7b9b33510a60043861":{"kind":"REWORK","_number":3,"created":"2012-06-26 19:05:51.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/20/9020/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/20/9020/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/20/9020/3"}}},"commit":{"parents":[{"commit":"993a7b7dd670f9ea9ade230bd48519b83af85dbf","subject":"Merge \"Add support for tag-based version numbers.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/993a7b7dd670f9ea9ade230bd48519b83af85dbf"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2012-06-26 18:58:07.000000000","tz":-300},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2012-06-26 19:05:36.000000000","tz":-300},"subject":"Split reading of versioninfo out into a method","message":"Split reading of versioninfo out into a method\n\nMake the read_versioninfo to match write_versioninfo.\n\nAdditionally, there is an edge case where if the code is installed from a\ngithub zipball, versioning info is missing. Now that we\u0027re using this,\nthere should be virtual no instances where a zipball will be easier or\nless cost than an sdist created tarball, all of which should be public and\naccessible, but during the transition, we need to account for the codepath.\n\nChange-Id: Icd3fe97c6341bb04da27adc55a85f1ab6b525c46\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/089d509f350b01c8345cfb7b9b33510a60043861"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/089d509f350b01c8345cfb7b9b33510a60043861"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}