)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"71dde5154ca8bb2d92bc6eef745cc8f431e88b6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52442fe5_70dc1248","updated":"2024-07-09 15:49:45.000000000","message":"OK I think we\u0027ll push this after merging https://review.opendev.org/c/openstack/python-glanceclient/+/922866 then.","commit_id":"106cfe5633498d13a518e7d1db74a5efabe509fc"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"4921dd6caccd0d7af3159e15119c1fadd1c28e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75f60f3f_cd7bf2f3","updated":"2024-06-19 13:59:25.000000000","message":"Thanks for your patch!\n\nThis does seem to fix our issue, but 4 tests are now broken with Py312 on the CI:\n\ntest_v1_requests_cert_verification_no_compression\ntest_v2_requests_cert_verification\ntest_v1_requests_cert_verification\ntest_v2_requests_cert_verification_no_compression\n\nOn my machine, two tests are failing:\n\nglanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_verification\nglanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_verification_no_compression\n\nDid you look into this?\n\nAlso, this will require a patch to openstack/requirements, I think.","commit_id":"106cfe5633498d13a518e7d1db74a5efabe509fc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9a3fed0fcfbbcd0fa13d685ff452d9b18f17b01e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f6b6597_f48f3999","updated":"2024-07-08 15:14:26.000000000","message":"recheck getting a new set of py312 test results","commit_id":"106cfe5633498d13a518e7d1db74a5efabe509fc"},{"author":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"change_message_id":"49f1cb1312e27c43529fb2499dd66c1bb1563d19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47abcf8f_9506cc54","in_reply_to":"75f60f3f_cd7bf2f3","updated":"2024-06-19 14:45:45.000000000","message":"\u003e Thanks for your patch!\n\u003e \n\u003e This does seem to fix our issue, but 4 tests are now broken with Py312 on the CI:\n\u003e \n\u003e test_v1_requests_cert_verification_no_compression\n\u003e test_v2_requests_cert_verification\n\u003e test_v1_requests_cert_verification\n\u003e test_v2_requests_cert_verification_no_compression\n\nI\u0027m getting the same failures with py312 on master, i.e. this patch doesn\u0027t change anything there (and I don\u0027t see why it would, as it only touches other tests).\n\n\u003e Also, this will require a patch to openstack/requirements, I think.\n\nIf you mean allowing urllib3-2, then note that this test doesn\u0027t fix all the issues with urllib3-2.  There are also some SSL-related test failures that I can\u0027t figure out, though I do suspect they may be just wrong assumptions in tests.","commit_id":"106cfe5633498d13a518e7d1db74a5efabe509fc"},{"author":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"change_message_id":"1a6c9dbdbb0bd436a9705086164149e216d6947a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa39c806_a469da8d","updated":"2024-08-27 13:48:13.000000000","message":"Gentle ping. Is it ok to land this now?","commit_id":"4c45265a5c26ddfa413b6bd4032b344d21f37f70"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f17cb69745d5043bac1a687ded1d4e95de47563c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55c2d972_3d09fcd2","updated":"2024-08-30 15:21:33.000000000","message":"Without this patch, the following tests are failing using Python3.12 and urllib3 2.2.2:\n\nglanceclient.tests.unit.test_http.TestClient.test_log_request_id_once(session)\nglanceclient.tests.unit.test_http.TestClient.test_http_chunked_response(session)\nglanceclient.tests.unit.test_http.TestClient.test_log_request_id_once(httpclient)\nglanceclient.tests.unit.test_http.TestClient.test_http_chunked_response(httpclient)\nglanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_verification\nglanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_verification_no_compression\n\nWith this patch, the following tests are failing:\nglanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_verification\nglanceclient.tests.unit.test_ssl.TestHTTPSVerifyCert.test_v2_requests_valid_cert_verification_no_compression\n\nWe should probably merge this and then figure out why the other tests are failing.","commit_id":"4c45265a5c26ddfa413b6bd4032b344d21f37f70"}]}