)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f110d4b73d59c245a48966a9db73c68d7bcaa350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d07e5bbc_099df7f0","updated":"2024-07-09 16:47:04.000000000","message":"Looks good!","commit_id":"0746dc6396c5fad60e682d7b6d150adb4fc086e6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"74a45a3fa4626cab8a9dbf0dced82621fa1b811f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d0f063e_234ab621","updated":"2024-07-09 18:33:44.000000000","message":"Question inline.","commit_id":"0746dc6396c5fad60e682d7b6d150adb4fc086e6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ef0e6b73e3baa5a1a0cf46418a0f28fba9dd8f8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b6fc0eae_cb75c51b","updated":"2024-07-10 19:50:13.000000000","message":"This looks better to me, but let\u0027s see what Abhishek thinks.","commit_id":"fa495fe34c0dc65ed235c6585b4109ebefc98ad8"}],"glanceclient/tests/unit/test_ssl.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"74a45a3fa4626cab8a9dbf0dced82621fa1b811f","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        context.verify_mode \u003d ssl.CERT_REQUIRED"},{"line_number":50,"context_line":"        context.load_verify_locations(cacert)"},{"line_number":51,"context_line":"        context.load_cert_chain(cert_file, key_file)"},{"line_number":52,"context_line":"        with context.wrap_socket(_sock, server_side\u003dTrue) as sock:"},{"line_number":53,"context_line":"            return sock, addr"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class TestHTTPSVerifyCert(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"8daa5072_04688b7f","line":53,"range":{"start_line":52,"start_character":6,"end_line":53,"end_character":29},"updated":"2024-07-09 18:33:44.000000000","message":"This looks strange to me ... the return is the last statement in the \"with\" block, so won\u0027t __exit__ be called on the context manager before control goes back to whatever has called this function?  Not sure what that will do to sock.  I wonder if you should just return the wrapped _sock, like the old code did:\n\n    sock \u003d context.wrap_socket(_sock, server_side\u003dTrue)\n    return sock, addr","commit_id":"0746dc6396c5fad60e682d7b6d150adb4fc086e6"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"2f32b9ba3a64ae3b4934e9a8d0e794b1b28fa8d4","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        context.verify_mode \u003d ssl.CERT_REQUIRED"},{"line_number":50,"context_line":"        context.load_verify_locations(cacert)"},{"line_number":51,"context_line":"        context.load_cert_chain(cert_file, key_file)"},{"line_number":52,"context_line":"        with context.wrap_socket(_sock, server_side\u003dTrue) as sock:"},{"line_number":53,"context_line":"            return sock, addr"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class TestHTTPSVerifyCert(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"687ec5ef_f778345f","line":53,"range":{"start_line":52,"start_character":6,"end_line":53,"end_character":29},"in_reply_to":"8daa5072_04688b7f","updated":"2024-07-10 14:51:00.000000000","message":"I\u0027m not sure :) Sounds like a trick question from a job interview! I\u0027ll do as you suggested.","commit_id":"0746dc6396c5fad60e682d7b6d150adb4fc086e6"}]}