)]}'
{"gnocchiclient/shell.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"733a226ccd12cec20e568b0c4e8b60a6e224d4ba","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"resource create\": resource_cli.CliResourceCreate,"},{"line_number":46,"context_line":"        \"resource update\": resource_cli.CliResourceUpdate,"},{"line_number":47,"context_line":"        \"resource delete\": resource_cli.CliResourceDelete,"},{"line_number":48,"context_line":"        \"resource list-type\": resource_cli.CliResourceType,"},{"line_number":49,"context_line":"        \"archive-policy list\": archive_policy_cli.CliArchivePolicyList,"},{"line_number":50,"context_line":"        \"archive-policy show\": archive_policy_cli.CliArchivePolicyShow,"},{"line_number":51,"context_line":"        \"archive-policy create\": archive_policy_cli.CliArchivePolicyCreate,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_65724413","line":48,"updated":"2016-01-05 15:53:06.000000000","message":"i have a slight preference for maintaining simple verb as the action.\n\ncan we call it gnocchi resource-type list? and client.resource_type.list?\n\nthoughts?","commit_id":"23abc0a164d65484b49e020665e2034e3ecdfae2"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5ba282b890eeab35e358a61ef264225e7953d9a9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"resource create\": resource_cli.CliResourceCreate,"},{"line_number":46,"context_line":"        \"resource update\": resource_cli.CliResourceUpdate,"},{"line_number":47,"context_line":"        \"resource delete\": resource_cli.CliResourceDelete,"},{"line_number":48,"context_line":"        \"resource list-type\": resource_cli.CliResourceType,"},{"line_number":49,"context_line":"        \"archive-policy list\": archive_policy_cli.CliArchivePolicyList,"},{"line_number":50,"context_line":"        \"archive-policy show\": archive_policy_cli.CliArchivePolicyShow,"},{"line_number":51,"context_line":"        \"archive-policy create\": archive_policy_cli.CliArchivePolicyCreate,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_5047c0bb","line":48,"in_reply_to":"fa69d971_65724413","updated":"2016-01-05 16:11:33.000000000","message":"resource-type is not an object you can manipulate (yet?) so I find it odd. But why not. Maybe at least it should list-types otherwise?","commit_id":"23abc0a164d65484b49e020665e2034e3ecdfae2"}],"gnocchiclient/tests/functional/test_resource.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f31bf21011e308bef9e611575726ffb0928e27c1","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertNotIn(self.RESOURCE_ID2, resource_ids)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # LIST THE RESOUCES TYPES"},{"line_number":178,"context_line":"        resource_type \u003d (\u0027ceph_account\u0027, \u0027network\u0027, \u0027instance\u0027, \u0027generic\u0027,"},{"line_number":179,"context_line":"                         \u0027ipmi\u0027, \u0027image\u0027, \u0027swift_account\u0027, \u0027volume\u0027,"},{"line_number":180,"context_line":"                         \u0027instance_network_interface\u0027,"},{"line_number":181,"context_line":"                         \u0027instance_disk\u0027, \u0027stack\u0027, \u0027identity\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_908b5568","line":178,"updated":"2016-01-18 14:39:57.000000000","message":"can we change this so we check some of these exist in result.\n\nright now if we add a type to gnocchi, this will fail. i\u0027m not a fan of tightly coupled this is.","commit_id":"e21e3d5ad76bd6635f2ae349f0d2045c15b4fbce"},{"author":{"_account_id":9526,"name":"Zi Lian Ji","email":"jizilian@cn.ibm.com","username":"jizilian"},"change_message_id":"85ed7023ad75bdfe953c4be1bbd8a7887c267407","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertNotIn(self.RESOURCE_ID2, resource_ids)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # LIST THE RESOUCES TYPES"},{"line_number":178,"context_line":"        resource_type \u003d (\u0027ceph_account\u0027, \u0027network\u0027, \u0027instance\u0027, \u0027generic\u0027,"},{"line_number":179,"context_line":"                         \u0027ipmi\u0027, \u0027image\u0027, \u0027swift_account\u0027, \u0027volume\u0027,"},{"line_number":180,"context_line":"                         \u0027instance_network_interface\u0027,"},{"line_number":181,"context_line":"                         \u0027instance_disk\u0027, \u0027stack\u0027, \u0027identity\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_f3e73baa","line":178,"in_reply_to":"da6ed579_908b5568","updated":"2016-01-18 14:57:42.000000000","message":"Hi Gordon\n\nThanks for your comments.\n\"\nfor one_type in resource_type:\n            self.assertIn(one_type, type_from_list)\n\"\nI think if we add new one, it will not fail. But if we remove one, it will fail. :)\n\nI agree with you. Will change it to check the subset.\n\nThanks","commit_id":"e21e3d5ad76bd6635f2ae349f0d2045c15b4fbce"}],"gnocchiclient/v1/resource.py":[{"author":{"_account_id":18137,"name":"Xia Linjuan","email":"ljxiash@cn.ibm.com","username":"xialinjuan"},"change_message_id":"ba89a86c7c2539575ddc6aaa8912959c59434498","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def list_type(self):"},{"line_number":173,"context_line":"        \"\"\"List the resource types"},{"line_number":174,"context_line":"        \"\"\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return self._get(self.url).json()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_9528b1e3","line":174,"range":{"start_line":174,"start_character":8,"end_line":174,"end_character":11},"updated":"2016-01-06 03:02:28.000000000","message":"why not in one line?","commit_id":"23abc0a164d65484b49e020665e2034e3ecdfae2"}],"gnocchiclient/v1/resource_cli.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8c918cd4f74cda3c90110d8de1d910c3397fdd24","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def take_action(self, parsed_args):"},{"line_number":234,"context_line":"        resources \u003d self.app.client.resource.list_type()"},{"line_number":235,"context_line":"        return self.COLS, [(k, v) for (k, v) in resources.items()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_43614304","line":235,"updated":"2016-01-05 12:48:20.000000000","message":"return self.COLS, resources","commit_id":"23abc0a164d65484b49e020665e2034e3ecdfae2"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7f077ab1cb42ea720c48c80ee2efa79340c864d4","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def take_action(self, parsed_args):"},{"line_number":234,"context_line":"        resources \u003d self.app.client.resource.list_type()"},{"line_number":235,"context_line":"        return self.COLS, [(k, v) for (k, v) in resources.items()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e31f176a","line":235,"in_reply_to":"fa69d971_43614304","updated":"2016-01-05 12:49:02.000000000","message":"return self.cols, list(resources.items())\n\nsorry :)","commit_id":"23abc0a164d65484b49e020665e2034e3ecdfae2"}]}