)]}'
{"gnocchiclient/v1/metric_cli.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6c9a7255b28e797ecc48c41a3e1ce09dbfb42751","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            metavar\u003d\"METRIC_NAME\","},{"line_number":86,"context_line":"                            help\u003d\"Name of the metric\")"},{"line_number":87,"context_line":"        parser.add_argument(\"--unit\", \"-u\","},{"line_number":88,"context_line":"                            default\u003d\u0027None\u0027,"},{"line_number":89,"context_line":"                            help\u003d\"unit of the metric\")"},{"line_number":90,"context_line":"        return parser"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_ab9fc601","line":88,"updated":"2016-05-25 13:00:38.000000000","message":"this is a strange default. i don\u0027t think we should be setting unit as \u0027None\u0027 (string)","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"3e80604c6d739d417d0656709377dab6f2aa73aa","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            metavar\u003d\"METRIC_NAME\","},{"line_number":86,"context_line":"                            help\u003d\"Name of the metric\")"},{"line_number":87,"context_line":"        parser.add_argument(\"--unit\", \"-u\","},{"line_number":88,"context_line":"                            default\u003d\u0027None\u0027,"},{"line_number":89,"context_line":"                            help\u003d\"unit of the metric\")"},{"line_number":90,"context_line":"        return parser"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_75ddb313","line":88,"in_reply_to":"bab6814e_1ff8c848","updated":"2016-05-25 14:19:10.000000000","message":"If I remove the line \u0027default\u003d\u0027None\u0027,\u0027 that means None when no unit be added in comand line.\ngnocchi  metric create cpu_test009 --resource-id 9d7a06ec-be68-4738-b5ef-39ef0e481c68  --archive-policy-name low\nInvalid input: expected unicode for dictionary value @ data[u\u0027cpu_test009\u0027][u\u0027unit\u0027] (HTTP 400)\n\nAnd do you mean that we must add the unit argument when we create metric?","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b8ecf641c3c4817872523f299d450b50e69787e1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            metavar\u003d\"METRIC_NAME\","},{"line_number":86,"context_line":"                            help\u003d\"Name of the metric\")"},{"line_number":87,"context_line":"        parser.add_argument(\"--unit\", \"-u\","},{"line_number":88,"context_line":"                            default\u003d\u0027None\u0027,"},{"line_number":89,"context_line":"                            help\u003d\"unit of the metric\")"},{"line_number":90,"context_line":"        return parser"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_551b4f80","line":88,"in_reply_to":"bab6814e_75ddb313","updated":"2016-05-25 14:22:21.000000000","message":"I mean that you must on line 95/96 do:\n\nif parsed_args.unit:\n  metric[\u0027unit\u0027] \u003d parsed_args.unit\n\n\nSo if no unit is passed with --unit, nothing is set in the dict \"metric\" – so no error from the API","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"542ca24da89d551af276a5d12add8c25830d037a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            metavar\u003d\"METRIC_NAME\","},{"line_number":86,"context_line":"                            help\u003d\"Name of the metric\")"},{"line_number":87,"context_line":"        parser.add_argument(\"--unit\", \"-u\","},{"line_number":88,"context_line":"                            default\u003d\u0027None\u0027,"},{"line_number":89,"context_line":"                            help\u003d\"unit of the metric\")"},{"line_number":90,"context_line":"        return parser"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_1ff8c848","line":88,"in_reply_to":"bab6814e_ab9fc601","updated":"2016-05-25 13:53:28.000000000","message":"Yeah so there\u0027s no need for a default if it\u0027s none :)","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"542ca24da89d551af276a5d12add8c25830d037a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _take_action(self, metric, parsed_args):"},{"line_number":93,"context_line":"        if parsed_args.name:"},{"line_number":94,"context_line":"            metric[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":95,"context_line":"            metric[\u0027unit\u0027] \u003d parsed_args.unit"},{"line_number":96,"context_line":"        metric \u003d utils.get_client(self).metric.create(metric)"},{"line_number":97,"context_line":"        utils.format_archive_policy(metric[\"archive_policy\"])"},{"line_number":98,"context_line":"        utils.format_move_dict_to_root(metric, \"archive_policy\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_bf9ffc01","line":95,"updated":"2016-05-25 13:53:28.000000000","message":"It can have a unit with no name","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b8ecf641c3c4817872523f299d450b50e69787e1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _take_action(self, metric, parsed_args):"},{"line_number":93,"context_line":"        if parsed_args.name:"},{"line_number":94,"context_line":"            metric[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":95,"context_line":"            metric[\u0027unit\u0027] \u003d parsed_args.unit"},{"line_number":96,"context_line":"        metric \u003d utils.get_client(self).metric.create(metric)"},{"line_number":97,"context_line":"        utils.format_archive_policy(metric[\"archive_policy\"])"},{"line_number":98,"context_line":"        utils.format_move_dict_to_root(metric, \"archive_policy\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_35820b95","line":95,"in_reply_to":"bab6814e_154a67ac","updated":"2016-05-25 14:22:21.000000000","message":"See line 93 :)","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"14b8c7da6bfa6e605bf377ea3e5c5f4b84a8090f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _take_action(self, metric, parsed_args):"},{"line_number":93,"context_line":"        if parsed_args.name:"},{"line_number":94,"context_line":"            metric[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":95,"context_line":"            metric[\u0027unit\u0027] \u003d parsed_args.unit"},{"line_number":96,"context_line":"        metric \u003d utils.get_client(self).metric.create(metric)"},{"line_number":97,"context_line":"        utils.format_archive_policy(metric[\"archive_policy\"])"},{"line_number":98,"context_line":"        utils.format_move_dict_to_root(metric, \"archive_policy\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_1bfefcad","line":95,"in_reply_to":"bab6814e_35820b95","updated":"2016-05-26 02:00:41.000000000","message":"Another error from the API:\nInvalid input: required key not provided @ data[u\u0027cpu_test009\u0027][\u0027unit\u0027] (HTTP 400)","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"3e80604c6d739d417d0656709377dab6f2aa73aa","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _take_action(self, metric, parsed_args):"},{"line_number":93,"context_line":"        if parsed_args.name:"},{"line_number":94,"context_line":"            metric[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":95,"context_line":"            metric[\u0027unit\u0027] \u003d parsed_args.unit"},{"line_number":96,"context_line":"        metric \u003d utils.get_client(self).metric.create(metric)"},{"line_number":97,"context_line":"        utils.format_archive_policy(metric[\"archive_policy\"])"},{"line_number":98,"context_line":"        utils.format_move_dict_to_root(metric, \"archive_policy\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_154a67ac","line":95,"in_reply_to":"bab6814e_bf9ffc01","updated":"2016-05-25 14:19:10.000000000","message":"Sorry, I cat not understand your this comment. :)","commit_id":"c6f95507b694f5beaa43ad2c2553c6719b70574e"}]}