)]}'
{"id":"openstack%2Fpython-gnocchiclient~408882","triplet_id":"openstack%2Fpython-gnocchiclient~master~Ib47c9fe31ada2831c0562b9255158f74ba9ddcca","project":"openstack/python-gnocchiclient","branch":"master","topic":"bug/gengchc","hashtags":[],"change_id":"Ib47c9fe31ada2831c0562b9255158f74ba9ddcca","subject":"Replace six.iteritems() with .items()","status":"ABANDONED","created":"2016-12-09 01:44:05.000000000","updated":"2016-12-09 09:43:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a61a0e9ea4e20e67bf425d1eb1701ea9941a1200","_number":408882,"virtual_id_number":408882,"owner":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-12-09 02:10:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2016-12-09 09:43:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-09 02:10:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-12-09 09:43:55.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"}],"messages":[{"id":"a97c6ba6d5b0c35a7ec31d4cfb86a4d29be128b6","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2016-12-09 01:44:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7cc3c939f14c80e4514e091c7fbdee5d2f46fa3f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-09 01:50:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-gnocchiclient-docs-ubuntu-xenial http://docs-draft.openstack.org/82/408882/1/check/gate-python-gnocchiclient-docs-ubuntu-xenial/bffde9e//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-gnocchiclient-pep8-ubuntu-xenial http://logs.openstack.org/82/408882/1/check/gate-python-gnocchiclient-pep8-ubuntu-xenial/029b36b/ : FAILURE in 1m 44s\n- gate-python-gnocchiclient-python27-ubuntu-xenial http://logs.openstack.org/82/408882/1/check/gate-python-gnocchiclient-python27-ubuntu-xenial/f43753b/ : SUCCESS in 5m 44s\n- gate-python-gnocchiclient-python34 http://logs.openstack.org/82/408882/1/check/gate-python-gnocchiclient-python34/d7c27f4/ : SUCCESS in 5m 44s\n- gate-python-gnocchiclient-python35 http://logs.openstack.org/82/408882/1/check/gate-python-gnocchiclient-python35/bbf91c1/ : SUCCESS in 3m 44s\n- gate-python-gnocchiclient-pypy http://logs.openstack.org/82/408882/1/check/gate-python-gnocchiclient-pypy/5522520/ : FAILURE in 1m 54s (non-voting)\n- check-osc-plugins http://logs.openstack.org/82/408882/1/check/check-osc-plugins/855c876/ : FAILURE in 3m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9477b11462a4b21ca8bcbf5436537f17fa3238b0","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2016-12-09 02:04:41.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"8236b769c3ce8110cdeea8864ee8b780ee7d8385","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-09 02:10:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-gnocchiclient-docs-ubuntu-xenial http://docs-draft.openstack.org/82/408882/2/check/gate-python-gnocchiclient-docs-ubuntu-xenial/f962c29//doc/build/html/ : SUCCESS in 3m 55s\n- gate-python-gnocchiclient-pep8-ubuntu-xenial http://logs.openstack.org/82/408882/2/check/gate-python-gnocchiclient-pep8-ubuntu-xenial/2274acd/ : SUCCESS in 3m 04s\n- gate-python-gnocchiclient-python27-ubuntu-xenial http://logs.openstack.org/82/408882/2/check/gate-python-gnocchiclient-python27-ubuntu-xenial/688b0bf/ : SUCCESS in 5m 51s\n- gate-python-gnocchiclient-python34 http://logs.openstack.org/82/408882/2/check/gate-python-gnocchiclient-python34/5099891/ : SUCCESS in 4m 28s\n- gate-python-gnocchiclient-python35 http://logs.openstack.org/82/408882/2/check/gate-python-gnocchiclient-python35/829a7b9/ : SUCCESS in 5m 31s\n- gate-python-gnocchiclient-pypy http://logs.openstack.org/82/408882/2/check/gate-python-gnocchiclient-pypy/a255c02/ : FAILURE in 2m 40s (non-voting)\n- check-osc-plugins http://logs.openstack.org/82/408882/2/check/check-osc-plugins/92fc549/ : FAILURE in 3m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d9ed380ee9e559ca86fbc282d4e4c2d057a26229","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-12-09 09:43:55.000000000","message":"Patch Set 2: Code-Review-2\n\nNop, we don\u0027t want that, thanks.","accounts_in_message":[],"_revision_number":2},{"id":"57c24843c0367c5013f69024c84c49cd57b6fec9","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-12-09 09:43:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f81a67d1c4ce808e6e72c5237b485dfc1ea35185","revisions":{"e26e13cd8b70f9b27c2838fe389b4ec9885b432e":{"kind":"REWORK","_number":1,"created":"2016-12-09 01:44:05.000000000","uploader":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"ref":"refs/changes/82/408882/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-gnocchiclient","ref":"refs/changes/82/408882/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/1"}}},"commit":{"parents":[{"commit":"fa4c7ab4d06a0ceb094d2d715d1755db3fe6bd84","subject":"Delete the useless code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-gnocchiclient/commit/fa4c7ab4d06a0ceb094d2d715d1755db3fe6bd84"}]}],"author":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 02:02:30.000000000","tz":480},"committer":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 02:02:30.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ib47c9fe31ada2831c0562b9255158f74ba9ddcca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-gnocchiclient/commit/e26e13cd8b70f9b27c2838fe389b4ec9885b432e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-gnocchiclient/commit/e26e13cd8b70f9b27c2838fe389b4ec9885b432e"}]},"branch":"refs/heads/master"},"f81a67d1c4ce808e6e72c5237b485dfc1ea35185":{"kind":"REWORK","_number":2,"created":"2016-12-09 02:04:41.000000000","uploader":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"ref":"refs/changes/82/408882/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-gnocchiclient","ref":"refs/changes/82/408882/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-gnocchiclient refs/changes/82/408882/2"}}},"commit":{"parents":[{"commit":"fa4c7ab4d06a0ceb094d2d715d1755db3fe6bd84","subject":"Delete the useless code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-gnocchiclient/commit/fa4c7ab4d06a0ceb094d2d715d1755db3fe6bd84"}]}],"author":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 02:02:30.000000000","tz":480},"committer":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 02:04:38.000000000","tz":0},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ib47c9fe31ada2831c0562b9255158f74ba9ddcca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-gnocchiclient/commit/f81a67d1c4ce808e6e72c5237b485dfc1ea35185"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-gnocchiclient/commit/f81a67d1c4ce808e6e72c5237b485dfc1ea35185"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
