)]}'
{"id":"openstack%2Fpython-heatclient~435213","triplet_id":"openstack%2Fpython-heatclient~master~I6bc841b78e6121f2daae89a10061c40b6c5022fb","project":"openstack/python-heatclient","branch":"master","topic":"bug/1665321","hashtags":[],"change_id":"I6bc841b78e6121f2daae89a10061c40b6c5022fb","subject":"Add include credentials support in SessionClient","status":"ABANDONED","created":"2017-02-17 03:41:04.000000000","updated":"2024-01-08 07:17:48.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0cf7b57856af57ef89efff732e86706af9f2fdb4","_number":435213,"virtual_id_number":435213,"owner":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"date":"2017-05-21 13:16:41.000000000","_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},{"value":1,"date":"2017-02-24 02:04:00.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"all":[{"value":-1,"date":"2017-05-19 07:56:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2018-07-20 15:30:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":0,"date":"2017-05-17 09:21:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-17 03:41:16.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2017-02-24 02:04:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-05-17 09:21:44.000000000","updated_by":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"reviewer":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"state":"REVIEWER"},{"updated":"2017-05-19 07:56:24.000000000","updated_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"reviewer":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"state":"REVIEWER"},{"updated":"2018-07-20 15:30:29.000000000","updated_by":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"reviewer":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"state":"REVIEWER"}],"messages":[{"id":"fe621075c1dbedb5b237f470700b880dedb3ffbc","author":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"date":"2017-02-17 03:41:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fab3d974466840a999998f0aeff94f01a0997b48","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2017-02-17 03:41:16.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"cbf708d7d7bfdc50aa142491505efcebbd143a8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-17 04:11:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-heatclient-python35 http://logs.openstack.org/13/435213/1/check/gate-python-heatclient-python35/b6e6505/ : SUCCESS in 2m 29s\n- gate-python-heatclient-pypy http://logs.openstack.org/13/435213/1/check/gate-python-heatclient-pypy/862f2be/ : SUCCESS in 3m 32s (non-voting)\n- check-osc-plugins http://logs.openstack.org/13/435213/1/check/check-osc-plugins/1fb5fde/ : SUCCESS in 5m 49s (non-voting)\n- gate-python-heatclient-pep8-ubuntu-xenial http://logs.openstack.org/13/435213/1/check/gate-python-heatclient-pep8-ubuntu-xenial/56bb612/ : FAILURE in 4m 10s\n- gate-python-heatclient-python27-ubuntu-xenial http://logs.openstack.org/13/435213/1/check/gate-python-heatclient-python27-ubuntu-xenial/07505ff/ : SUCCESS in 3m 02s\n- gate-heatclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/13/435213/1/check/gate-heatclient-dsvm-functional-ubuntu-xenial/ecc1b68/ : SUCCESS in 28m 15s","accounts_in_message":[],"_revision_number":1},{"id":"c3a0cde27b0c92f0b5e756449a0127460bd0c9b8","author":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"date":"2017-02-17 05:07:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6f508a70e614a1ddbaced663fd5f9c0ee6edc2c8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-17 05:37:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-heatclient-python35 http://logs.openstack.org/13/435213/2/check/gate-python-heatclient-python35/71e4d3b/ : SUCCESS in 1m 55s\n- gate-python-heatclient-pypy http://logs.openstack.org/13/435213/2/check/gate-python-heatclient-pypy/4fe72a1/ : SUCCESS in 3m 47s (non-voting)\n- check-osc-plugins http://logs.openstack.org/13/435213/2/check/check-osc-plugins/bb87608/ : SUCCESS in 3m 08s (non-voting)\n- gate-python-heatclient-pep8-ubuntu-xenial http://logs.openstack.org/13/435213/2/check/gate-python-heatclient-pep8-ubuntu-xenial/41bdf5c/ : SUCCESS in 4m 26s\n- gate-python-heatclient-python27-ubuntu-xenial http://logs.openstack.org/13/435213/2/check/gate-python-heatclient-python27-ubuntu-xenial/7bb5733/ : SUCCESS in 3m 21s\n- gate-heatclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/13/435213/2/check/gate-heatclient-dsvm-functional-ubuntu-xenial/00edcab/ : SUCCESS in 29m 21s","accounts_in_message":[],"_revision_number":2},{"id":"aef0b327377f69d4a03c73cfa26bb19ea13c7f9f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-23 19:52:59.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"e9e8829e6b606945adac574205246b372931551c","author":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"date":"2017-02-24 01:43:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"13093c4e29d06ddc9c93734706f2c310bf058cc4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-24 02:04:00.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-heatclient-python35 http://logs.openstack.org/13/435213/3/check/gate-python-heatclient-python35/e3b8964/ : SUCCESS in 1m 59s\n- gate-python-heatclient-pypy http://logs.openstack.org/13/435213/3/check/gate-python-heatclient-pypy/0e27579/ : SUCCESS in 5m 28s (non-voting)\n- check-osc-plugins http://logs.openstack.org/13/435213/3/check/check-osc-plugins/8d51ebb/ : SUCCESS in 5m 14s (non-voting)\n- gate-python-heatclient-pep8-ubuntu-xenial http://logs.openstack.org/13/435213/3/check/gate-python-heatclient-pep8-ubuntu-xenial/58233c5/ : SUCCESS in 5m 27s\n- gate-python-heatclient-python27-ubuntu-xenial http://logs.openstack.org/13/435213/3/check/gate-python-heatclient-python27-ubuntu-xenial/c4d3573/ : SUCCESS in 2m 47s\n- gate-heatclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/13/435213/3/check/gate-heatclient-dsvm-functional-ubuntu-xenial/d904a26/ : SUCCESS in 18m 24s","accounts_in_message":[],"_revision_number":3},{"id":"ba4c4736f3f11269e78f352673fa31027cdfaf65","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2017-05-17 09:21:25.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1d4e4d8c724696b024fb9543eb52c33ea422a7f8","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2017-05-19 07:56:24.000000000","message":"Patch Set 3: Code-Review-1\n\nCan you please elaborate on the need to use the --include-pass when using keystone sessions? AFAIK there would be X-Auth-Token in header. \n\nI think  you should osc cli and not heat cli which is deprecated. Though the bug report is correct, this change does not seem correct to me at this point.\n\nWe should get rid of httpclient like nova and other projects.\n\n[1] https://git.openstack.org/cgit/openstack/python-novaclient/tree/novaclient/client.py#n164","accounts_in_message":[],"_revision_number":3},{"id":"fa65f16c3e17a8717e8052dbbb1b322d49109e66","author":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"date":"2017-05-21 13:16:41.000000000","message":"Patch Set 3:\n\nHi Rabi, Thanks for the feedback\n\nThis --include-password is necessary for including credential headers which are required for deferred_auth \u0027password\u0027 method in heat. I know that we can now use \u0027trust\u0027 authentication but we are still stuck with using the old password authentication and hence need this fix. (Same goes for using osc vs heatclient, Hopefully we will move to osc someday :) )\n\nI agree on the point of moving away from these httpclient but at this point a bug fix would be better to patch this issue here. (Replacing httpclient can be discussed as a bp later)","accounts_in_message":[],"_revision_number":3},{"id":"c509864f43041f64b97af31c79ec7af7c979e003","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2017-05-22 04:22:41.000000000","message":"Patch Set 3:\n\n\u003e I know that we can now use \u0027trust\u0027 authentication but we are still stuck with using the old password authentication and hence need this fix.\n\nOK. But AFAIK \u0027password\u0027 deferred_auth would not work with keystone v3, as it would expect domain details to authenticate the user when using stored context and we don\u0027t store the domain information in user_creds.\n\nTherefore I would think, it would be better you move to use trusts and we remove the \u0027deferred_auth\u003dpassword\u0027 option completely.","accounts_in_message":[],"_revision_number":3},{"id":"bc7b1889ce5fc59bb04d98090551289e71721942","author":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"date":"2017-06-13 00:11:22.000000000","message":"Patch Set 3:\n\nI think the deferred_auth\u003dpassword works fine with keystone v3 and is a supported feature for heat.\n\nBut yeah if you think this patch is not needed then lets cancel this.\n\nAs for the removal of deferred_auth\u003dpassword this should be added as a new blueprint I guess because removing it might be a big change.\nThanks","accounts_in_message":[],"_revision_number":3},{"id":"9e9f1ceeef2370cd0d36a9421052b3a1f7461826","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2018-05-07 11:34:43.000000000","message":"Patch Set 3:\n\nHi as we now migrated from Launchpad to StoryBoard ( https://storyboard.openstack.org/#!/project_group/82 ), we needs to link from your patch to StoryBoard, as for how to provide the link, please reference `How to connect from gerrit to StoryBoard` section in https://etherpad.openstack.org/p/Heat-StoryBoard-Migration-Info\nPlease help to add those keys to your commit message. Thank you.","accounts_in_message":[],"_revision_number":3},{"id":"2c8c199df7a2fceaa6d45a2312bfcba6b80e8280","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2018-07-20 15:30:29.000000000","message":"Patch Set 3: -Code-Review","accounts_in_message":[],"_revision_number":3},{"id":"0cf7b57856af57ef89efff732e86706af9f2fdb4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-01-08 07:17:48.000000000","message":"Abandoned\n\nthis hasn\u0027t been updated for 5 years and is stale.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6ee7402cca7903870a941b6f2d67da18b4f32b31","revisions":{"37957a33f850f2b48c1becc78c23b08ed4b568a5":{"kind":"REWORK","_number":1,"created":"2017-02-17 03:41:04.000000000","uploader":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"ref":"refs/changes/13/435213/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-heatclient","ref":"refs/changes/13/435213/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/1"}}},"commit":{"parents":[{"commit":"07ea7d95b8c54dc9960f93c0cb278f614cf14989","subject":"Merge \"Handle log message interpolation by the logger\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/07ea7d95b8c54dc9960f93c0cb278f614cf14989"}]}],"author":{"name":"Kashif Siddiqui","email":"static.kash@gmail.com","date":"2017-02-17 02:26:31.000000000","tz":540},"committer":{"name":"Kashif Siddiqui","email":"static.kash@gmail.com","date":"2017-02-17 03:40:17.000000000","tz":540},"subject":"Add include credentials support in SessionClient","message":"Add include credentials support in SessionClient\n\nhttp._construct_http_client returns two kinds of clients, HTTPClient if\nsession not provided and SessionClient if session is provided. By\ndefault heat creates a session from user credentials so SessionClient\nis returned by this method most of the time. However the SessionClient\ndoesn\u0027t include credentials or include_pass key. Hence even if the user\npasses \u0027--include_pass\u0027 in heat call for eg.\n`heat --include_pass stack-create -f template.yaml stack1`\nthe credentials were not being pass in request headers. A workaround\nfor this was to manually pass --os-auth-token and --os-no-client-auth\nwhich forces creation of HTTPClient by _construct_http_client which\nsupports include_pass\n\nTo resolve this, Update the _construct_http_client to include\ncredentials params in SessionClient and implement credentials_headers\nlogic in SessionClient to pass credentials in headers.\nSessionClient __init__ is overridden to pop out these credentials\nbefore calling super so we don\u0027t break legacy code.\n\nChange-Id: I6bc841b78e6121f2daae89a10061c40b6c5022fb\nCloses-Bug: #1665321\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/37957a33f850f2b48c1becc78c23b08ed4b568a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/37957a33f850f2b48c1becc78c23b08ed4b568a5"}]},"branch":"refs/heads/master"},"99722853cfa33d52bea1ffddef64de37e60469c6":{"kind":"REWORK","_number":2,"created":"2017-02-17 05:07:31.000000000","uploader":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"ref":"refs/changes/13/435213/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-heatclient","ref":"refs/changes/13/435213/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/2"}}},"commit":{"parents":[{"commit":"07ea7d95b8c54dc9960f93c0cb278f614cf14989","subject":"Merge \"Handle log message interpolation by the logger\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/07ea7d95b8c54dc9960f93c0cb278f614cf14989"}]}],"author":{"name":"Kashif Siddiqui","email":"static.kash@gmail.com","date":"2017-02-17 02:26:31.000000000","tz":540},"committer":{"name":"Kashif Siddiqui","email":"static.kash@gmail.com","date":"2017-02-17 05:07:13.000000000","tz":540},"subject":"Add include credentials support in SessionClient","message":"Add include credentials support in SessionClient\n\nhttp._construct_http_client returns two kinds of clients, HTTPClient if\nsession not provided and SessionClient if session is provided. By\ndefault heat creates a session from user credentials so SessionClient\nis returned by this method most of the time. However the SessionClient\ndoesn\u0027t include credentials or include_pass key. Hence even if the user\npasses \u0027--include_pass\u0027 in heat call for eg.\n`heat --include_pass stack-create -f template.yaml stack1`\nthe credentials were not being pass in request headers. A workaround\nfor this was to manually pass --os-auth-token and --os-no-client-auth\nwhich forces creation of HTTPClient by _construct_http_client which\nsupports include_pass\n\nTo resolve this, Update the _construct_http_client to include\ncredentials params in SessionClient and implement credentials_headers\nlogic in SessionClient to pass credentials in headers.\nSessionClient __init__ is overridden to pop out these credentials\nbefore calling super so we don\u0027t break legacy code.\n\nChange-Id: I6bc841b78e6121f2daae89a10061c40b6c5022fb\nCloses-Bug: #1665321\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/99722853cfa33d52bea1ffddef64de37e60469c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/99722853cfa33d52bea1ffddef64de37e60469c6"}]},"branch":"refs/heads/master"},"6ee7402cca7903870a941b6f2d67da18b4f32b31":{"kind":"REWORK","_number":3,"created":"2017-02-24 01:43:30.000000000","uploader":{"_account_id":20963,"name":"Kashif Siddiqui","email":"static.kash@gmail.com","username":"kashif.siddiqui"},"ref":"refs/changes/13/435213/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-heatclient","ref":"refs/changes/13/435213/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-heatclient refs/changes/13/435213/3"}}},"commit":{"parents":[{"commit":"b1c819f7d9faac2b702bfc505ac706fd436484a4","subject":"Use endpoint_type with session client","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/b1c819f7d9faac2b702bfc505ac706fd436484a4"}]}],"author":{"name":"Kashif Siddiqui","email":"static.kash@gmail.com","date":"2017-02-17 02:26:31.000000000","tz":540},"committer":{"name":"Kashif Siddiqui","email":"static.kash@gmail.com","date":"2017-02-24 01:40:20.000000000","tz":540},"subject":"Add include credentials support in SessionClient","message":"Add include credentials support in SessionClient\n\nhttp._construct_http_client returns two kinds of clients, HTTPClient if\nsession not provided and SessionClient if session is provided. By\ndefault heat creates a session from user credentials so SessionClient\nis returned by this method most of the time. However the SessionClient\ndoesn\u0027t include credentials or include_pass key. Hence even if the user\npasses \u0027--include_pass\u0027 in heat call for eg.\n`heat --include_pass stack-create -f template.yaml stack1`\nthe credentials were not being pass in request headers. A workaround\nfor this was to manually pass --os-auth-token and --os-no-client-auth\nwhich forces creation of HTTPClient by _construct_http_client which\nsupports include_pass\n\nTo resolve this, Update the _construct_http_client to include\ncredentials params in SessionClient and implement credentials_headers\nlogic in SessionClient to pass credentials in headers.\nSessionClient __init__ is overridden to pop out these credentials\nbefore calling super so we don\u0027t break legacy code.\n\nChange-Id: I6bc841b78e6121f2daae89a10061c40b6c5022fb\nCloses-Bug: #1665321\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/6ee7402cca7903870a941b6f2d67da18b4f32b31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/6ee7402cca7903870a941b6f2d67da18b4f32b31"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}