)]}'
{"id":"openstack%2Fpython-heatclient~452118","triplet_id":"openstack%2Fpython-heatclient~master~I3913e8876b34e112140788d7a405da6eedfb5f29","project":"openstack/python-heatclient","branch":"master","topic":"replace_six_iteritems","hashtags":[],"change_id":"I3913e8876b34e112140788d7a405da6eedfb5f29","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-03-31 09:47:05.000000000","updated":"2017-06-12 09:06:53.000000000","submitted":"2017-06-12 09:06:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3239b61ac3b68191110fa918bb19fb6f27726cb0","_number":452118,"virtual_id_number":452118,"owner":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":0,"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"value":0,"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},{"value":2,"date":"2017-06-12 09:06:53.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"recommended":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"all":[{"value":1,"date":"2017-06-02 03:18:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":2,"date":"2017-06-12 08:34:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"value":2,"date":"2017-04-09 16:10:21.000000000","_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"all":[{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":1,"date":"2017-06-12 08:35:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"value":0,"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-09 16:10:21.000000000","updated_by":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"reviewer":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"state":"REVIEWER"},{"updated":"2017-06-02 03:18:05.000000000","updated_by":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"reviewer":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"state":"REVIEWER"},{"updated":"2017-06-12 08:35:50.000000000","updated_by":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"reviewer":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"state":"REVIEWER"},{"updated":"2017-06-12 09:06:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c4d756069388c1708e88a24cb502f0d38ea431b4","author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"date":"2017-03-31 09:47:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d92d916509f54d9a37db3bd00658d18218fc4027","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-31 10:07:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-heatclient-python35 http://logs.openstack.org/18/452118/1/check/gate-python-heatclient-python35/ee59870/ : SUCCESS in 3m 40s\n- gate-python-heatclient-pypy http://logs.openstack.org/18/452118/1/check/gate-python-heatclient-pypy/a09b214/ : SUCCESS in 3m 20s (non-voting)\n- check-osc-plugins http://logs.openstack.org/18/452118/1/check/check-osc-plugins/26aa07f/ : SUCCESS in 3m 51s (non-voting)\n- gate-python-heatclient-pep8-ubuntu-xenial http://logs.openstack.org/18/452118/1/check/gate-python-heatclient-pep8-ubuntu-xenial/d279300/ : SUCCESS in 4m 37s\n- gate-python-heatclient-python27-ubuntu-xenial http://logs.openstack.org/18/452118/1/check/gate-python-heatclient-python27-ubuntu-xenial/bcbce7b/ : SUCCESS in 2m 55s\n- gate-heatclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/18/452118/1/check/gate-heatclient-dsvm-functional-ubuntu-xenial/74a3f5f/ : SUCCESS in 18m 09s","accounts_in_message":[],"_revision_number":1},{"id":"0a32e83e6eae0a5b5e56c7716a3065171f279815","author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"date":"2017-04-09 16:10:21.000000000","message":"Patch Set 1: Code-Review+2\n\nHeh. Looks like it is \"next\" step in this nice story of the migrations to py3 :)","accounts_in_message":[],"_revision_number":1},{"id":"61228c12743b7b019d51cb585f3bf030f9d2ca76","author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"date":"2017-06-02 03:18:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7b53f255b51c3f6aa3e5918ceca5465ce00c21b9","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2017-06-12 08:34:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b73a63137006658bfc56855d05266a952c804100","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-12 08:34:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"aa8002d58f98c1d24f6ae206ced0d2980b5baa41","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2017-06-12 08:34:25.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"4ce88a8a6fbde1f8fbf9a185c06d138a27ff966d","author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"date":"2017-06-12 08:35:50.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c6d2f6e4f4f8aa297e85b50fdfbac70356310233","date":"2017-06-12 09:06:53.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"8dc1ffd6a36dd96f560931c61d7b098667316d9e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-12 09:06:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-heatclient-python35 http://logs.openstack.org/18/452118/1/gate/gate-python-heatclient-python35/8ce5acd/ : SUCCESS in 3m 50s\n- gate-python-heatclient-pep8-ubuntu-xenial http://logs.openstack.org/18/452118/1/gate/gate-python-heatclient-pep8-ubuntu-xenial/705d41e/ : SUCCESS in 4m 22s\n- gate-python-heatclient-python27-ubuntu-xenial http://logs.openstack.org/18/452118/1/gate/gate-python-heatclient-python27-ubuntu-xenial/58f0c9c/ : SUCCESS in 3m 47s\n- gate-heatclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/18/452118/1/gate/gate-heatclient-dsvm-functional-ubuntu-xenial/f010738/ : SUCCESS in 23m 56s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"61aa092ce5cdee495e6faf63c36419e5583d3627","revisions":{"61aa092ce5cdee495e6faf63c36419e5583d3627":{"kind":"REWORK","_number":1,"created":"2017-03-31 09:47:05.000000000","uploader":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"ref":"refs/changes/18/452118/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-heatclient","ref":"refs/changes/18/452118/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/18/452118/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/18/452118/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-heatclient refs/changes/18/452118/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-heatclient refs/changes/18/452118/1"}}},"commit":{"parents":[{"commit":"954e475a6a0a12432ec325d7579460fabcf3f40a","subject":"Build event stack_name from links","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/954e475a6a0a12432ec325d7579460fabcf3f40a"}]}],"author":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-03-31 09:45:17.000000000","tz":330},"committer":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-03-31 09:46:54.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I3913e8876b34e112140788d7a405da6eedfb5f29\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/61aa092ce5cdee495e6faf63c36419e5583d3627"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-heatclient/commit/61aa092ce5cdee495e6faf63c36419e5583d3627"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"954e475a6a0a12432ec325d7579460fabcf3f40a","is_merged_in_target_branch":true,"change_id":"I09ab1cc2c6aaab02036b124b1dfa561dd6132083","change_number":450774,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}