)]}'
{"heatclient/tests/test_utils.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"619e90cc4e429d492feb730543e1f275c631fe68","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def test_format_parameter_bad_parameter(self):"},{"line_number":70,"context_line":"        params \u003d [\u0027KeyName\u003dheat_key;UpstreamDNS8.8.8.8\u0027]"},{"line_number":71,"context_line":"        self.assertRaises(exc.CommandError,"},{"line_number":72,"context_line":"                          utils.format_parameters, params)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_format_multiple_bad_parameter(self):"},{"line_number":75,"context_line":"        params \u003d [\u0027KeyName\u003dheat_key\u0027, \u0027UpstreamDNS8.8.8.8\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FnNQ%3D","line":72,"updated":"2013-09-23 23:12:00.000000000","message":"(a thought about improving the tests while we\u0027re here, not affecting review score) We should check that the error message is the one we expect here. assertRaises returns the exception, so that should not be difficult.","commit_id":"58ada03ba4ab2357ff48a9b148431642b665b002"}],"heatclient/v1/shell.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"619e90cc4e429d492feb730543e1f275c631fe68","unresolved":false,"context_lines":[{"line_number":104,"context_line":"           help\u003d\u0027Enable rollback on create/update failure\u0027)"},{"line_number":105,"context_line":"@utils.arg(\u0027-P\u0027, \u0027--parameters\u0027, metavar\u003d\u0027\u003cKEY1\u003dVALUE1;KEY2\u003dVALUE2...\u003e\u0027,"},{"line_number":106,"context_line":"           help\u003d\u0027Parameter values used to create the stack. \u0027"},{"line_number":107,"context_line":"           \u0027If specified multiple times, semicolon delimiter is ignored.\u0027,"},{"line_number":108,"context_line":"           action\u003d\u0027append\u0027)"},{"line_number":109,"context_line":"@utils.arg(\u0027name\u0027, metavar\u003d\u0027\u003cSTACK_NAME\u003e\u0027,"},{"line_number":110,"context_line":"           help\u003d\u0027Name of the stack to create.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FnNM%3D","line":107,"updated":"2013-09-23 23:12:00.000000000","message":"I think it would help users if we make it clear that the argument is additive if specified multiple times.","commit_id":"58ada03ba4ab2357ff48a9b148431642b665b002"}]}
