)]}'
{"heatclient/common/http.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"27fdd1e89a1af37850fee516b0bd80a7b9b25158","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from heatclient.openstack.common.py3kcompat import urlutils"},{"line_number":22,"context_line":"from six.moves import http_client as httplib"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FLuE%3D","line":21,"updated":"2013-10-21 20:00:46.000000000","message":"I do not understand why we want to use this piece of olso incubator. The same thing can be accomplished with:\n\n    from six.moves.urllib import parse as urlparse\n\nIs there something non-obvious I\u0027m missing that makes us want to use the py3kcompat module instead?","commit_id":"1562e919f449d6af23d583aeed7d59c0bb3bc7a9"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a69c007dd06b31d21194b21eeaf10add5a2c03b7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from heatclient.openstack.common.py3kcompat import urlutils"},{"line_number":22,"context_line":"from six.moves import http_client as httplib"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FI3g%3D","line":21,"in_reply_to":"AAAATH%2F%2FLeI%3D","updated":"2013-10-22 16:28:48.000000000","message":"Ah ok, IMO that change should have been rejected until it was submitted to the six library directly. I talked to Chuck, and that is part of his plan but he has not even tried to do it yet. Anyway, oslo is not something we are _REQUIRED_ to consume, and IMO we should actually do things with six as-is, even if it means a little code refactoring. But, I see that the module is pervasive throughout OpenStack, so I guess we\u0027ll just have to live with it for now.","commit_id":"1562e919f449d6af23d583aeed7d59c0bb3bc7a9"},{"author":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"change_message_id":"0476e186fb1f18bc01d870575f6b439ed62fa683","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from heatclient.openstack.common.py3kcompat import urlutils"},{"line_number":22,"context_line":"from six.moves import http_client as httplib"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FLeI%3D","line":21,"in_reply_to":"AAAATH%2F%2FLuE%3D","updated":"2013-10-21 21:41:16.000000000","message":"It is unified solution for urllib/urllib2. Here is another review, urlutils will cover more cases.\nhttps://review.openstack.org/#/c/52907/","commit_id":"1562e919f449d6af23d583aeed7d59c0bb3bc7a9"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"27fdd1e89a1af37850fee516b0bd80a7b9b25158","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    import json"},{"line_number":32,"context_line":"except ImportError:"},{"line_number":33,"context_line":"    import simplejson as json"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from heatclient import exc"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FLt0%3D","line":34,"updated":"2013-10-21 20:00:46.000000000","message":"Please do this in a separate patch. It is not the same thing as the rest of the change.","commit_id":"1562e919f449d6af23d583aeed7d59c0bb3bc7a9"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a69c007dd06b31d21194b21eeaf10add5a2c03b7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    import json"},{"line_number":32,"context_line":"except ImportError:"},{"line_number":33,"context_line":"    import simplejson as json"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from heatclient import exc"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FI3A%3D","line":34,"in_reply_to":"AAAATH%2F%2FLdU%3D","updated":"2013-10-22 16:28:48.000000000","message":"It is important to me that we separate code by what its intended effect is. I understand that if it was still here you\u0027d have to fix it. However, the removal is a completely separate change that can just be done as its own patch, and thus, should be done as its own patch. Just base the rest of this patch on that patch.","commit_id":"1562e919f449d6af23d583aeed7d59c0bb3bc7a9"},{"author":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"change_message_id":"0476e186fb1f18bc01d870575f6b439ed62fa683","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    import json"},{"line_number":32,"context_line":"except ImportError:"},{"line_number":33,"context_line":"    import simplejson as json"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from heatclient import exc"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FLdU%3D","line":34,"in_reply_to":"AAAATH%2F%2FLt0%3D","updated":"2013-10-21 21:41:16.000000000","message":"Since the urlparse is used originally, urlparse appears here. I need to modify the urlparse to urlutils. This clauses can be removed safely, it is not necessary to modify it , then remove it separately.","commit_id":"1562e919f449d6af23d583aeed7d59c0bb3bc7a9"}]}