)]}'
{"heatclient/shell.py":[{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"594bfbd6c0408a4906191d42eaa6eb77dc3dc5f8","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        else:"},{"line_number":232,"context_line":"            kc_args[\u0027username\u0027] \u003d kwargs.get(\u0027username\u0027)"},{"line_number":233,"context_line":"            kc_args[\u0027password\u0027] \u003d kwargs.get(\u0027password\u0027)"},{"line_number":234,"context_line":"            return ksclient.Client(**kc_args)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _get_endpoint(self, client, **kwargs):"},{"line_number":237,"context_line":"        \"\"\"Get an endpoint using the provided keystone client.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BweY%3D","line":234,"updated":"2013-11-20 16:01:12.000000000","message":"I think you can remove return from if and put it at the end of this fuction","commit_id":"6a62df6336acff7b783a623e8512c6f18e7dfdb5"},{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"27f823d5e45378c96cbd75971fdcb9eb9b28f5db","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        :param tenant_id: unique identifier of tenant"},{"line_number":220,"context_line":"        :param tenant_name: name of tenant"},{"line_number":221,"context_line":"        :param auth_url: endpoint to authenticate against"},{"line_number":222,"context_line":"        :param auth_token: token to use instead of username/password"},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        kc_args \u003d {\u0027auth_url\u0027: kwargs.get(\u0027auth_url\u0027),"},{"line_number":225,"context_line":"                   \u0027insecure\u0027: kwargs.get(\u0027insecure\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BgIo%3D","line":222,"updated":"2013-11-25 12:31:04.000000000","message":"It looks like it should be \u0027token\u0027 instead of \u0027auth_token\u0027.","commit_id":"8c052c110889fcdb453d759e8e20aeb88ecb20b6"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"63c4b40267d41b04d651a2470cdbd75ce18fe5bf","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        :param tenant_id: unique identifier of tenant"},{"line_number":220,"context_line":"        :param tenant_name: name of tenant"},{"line_number":221,"context_line":"        :param auth_url: endpoint to authenticate against"},{"line_number":222,"context_line":"        :param auth_token: token to use instead of username/password"},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        kc_args \u003d {\u0027auth_url\u0027: kwargs.get(\u0027auth_url\u0027),"},{"line_number":225,"context_line":"                   \u0027insecure\u0027: kwargs.get(\u0027insecure\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BfPU%3D","line":222,"in_reply_to":"AAAATn%2F%2Bf%2F0%3D","updated":"2013-11-25 15:28:30.000000000","message":"Actually, you spotted a bug, thanks!  When splitting my changes into patches, the auth_token/token change got messed up, see line 319 where I\u0027m assigning the wrong value.","commit_id":"8c052c110889fcdb453d759e8e20aeb88ecb20b6"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"1f016020409511b010e08ee9de664ea5305b3be6","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        :param tenant_id: unique identifier of tenant"},{"line_number":220,"context_line":"        :param tenant_name: name of tenant"},{"line_number":221,"context_line":"        :param auth_url: endpoint to authenticate against"},{"line_number":222,"context_line":"        :param auth_token: token to use instead of username/password"},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        kc_args \u003d {\u0027auth_url\u0027: kwargs.get(\u0027auth_url\u0027),"},{"line_number":225,"context_line":"                   \u0027insecure\u0027: kwargs.get(\u0027insecure\u0027)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Bf%2F0%3D","line":222,"in_reply_to":"AAAATn%2F%2BgIo%3D","updated":"2013-11-25 13:02:56.000000000","message":"Yeah, I fixed it in a later patch:\n\nhttps://review.openstack.org/#/c/57438/3/heatclient/shell.py","commit_id":"8c052c110889fcdb453d759e8e20aeb88ecb20b6"}],"heatclient/tests/test_shell.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"e4182ee0c044d689e0955c228a501354c125ed71","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"class ShellTestCommon(ShellBase):"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    # Patch os.environ to avoid required auth info."},{"line_number":272,"context_line":"    def setUp(self):"},{"line_number":273,"context_line":"        super(ShellTestCommon, self).setUp()"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2ByFQ%3D","line":271,"updated":"2013-11-20 09:24:49.000000000","message":"We don\u0027t seem to be calling _set_fake_env here any more, so does this comment still apply?","commit_id":"2c0c9c504d445d6b5a275552d6ea6e63a7129e91"}]}