)]}'
{"heatclient/shell.py":[{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"b2b5eafbab1f02eb0c90b3a54a0ff10b22cb92ca","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                options.add(option)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        commands.remove(\u0027bash-completion\u0027)"},{"line_number":403,"context_line":"        commands.remove(\u0027bash_completion\u0027)"},{"line_number":404,"context_line":"        print(\u0027 \u0027.join(commands | options))"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @utils.arg(\u0027command\u0027, metavar\u003d\u0027\u003csubcommand\u003e\u0027, nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9HyA%3D","line":403,"updated":"2013-12-16 16:02:50.000000000","message":"Double statement. Commands is a set and there is only one element \u0027bash-completion\u0027. Maybe you meant options.remove(\u0027bash-completion\u0027)? But from what I check options does not contain \u0027bash-completion\u0027.","commit_id":"992d6f5350952fc6501184b02c477134048952d6"},{"author":{"_account_id":6917,"name":"Bartosz Górski","email":"bartosz@codilime.com","username":"bartosz-gorski"},"change_message_id":"afb62d1f909235b5725c4acd875bdbe1a8e19f5d","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                options.add(option)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        commands.remove(\u0027bash-completion\u0027)"},{"line_number":403,"context_line":"        commands.remove(\u0027bash_completion\u0027)"},{"line_number":404,"context_line":"        print(\u0027 \u0027.join(commands | options))"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @utils.arg(\u0027command\u0027, metavar\u003d\u0027\u003csubcommand\u003e\u0027, nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9GnY%3D","line":403,"in_reply_to":"AAAATn%2F9G%2BQ%3D","updated":"2013-12-16 19:09:18.000000000","message":"You are right. I did not spot the difference between strings (\u0027-\u0027 and \u0027_\u0027). Sorry for that.","commit_id":"992d6f5350952fc6501184b02c477134048952d6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"cf37cd07f072ce01425cf546046ca3bbd48e0b5f","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                options.add(option)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        commands.remove(\u0027bash-completion\u0027)"},{"line_number":403,"context_line":"        commands.remove(\u0027bash_completion\u0027)"},{"line_number":404,"context_line":"        print(\u0027 \u0027.join(commands | options))"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @utils.arg(\u0027command\u0027, metavar\u003d\u0027\u003csubcommand\u003e\u0027, nargs\u003d\u0027?\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9G%2BQ%3D","line":403,"in_reply_to":"AAAATn%2F9HyA%3D","updated":"2013-12-16 18:12:30.000000000","message":"please check line 201, the do_bash_completion it self will be added as bash-completion (in _find_actions), bash_completion is added in line 212\n\nthanks for your review","commit_id":"992d6f5350952fc6501184b02c477134048952d6"}],"tools/heat.bash_completion":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"fcf5239709e64d2e5d449de1096f663aad4b6af7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"_heat_opts_exp\u003d\"\" # lazy init"},{"line_number":6,"context_line":"_heat()"},{"line_number":7,"context_line":"{"},{"line_number":8,"context_line":"\tlocal cur prev kbc"},{"line_number":9,"context_line":"\tCOMPREPLY\u003d()"},{"line_number":10,"context_line":"\tcur\u003d\"${COMP_WORDS[COMP_CWORD]}\""},{"line_number":11,"context_line":"\tprev\u003d\"${COMP_WORDS[COMP_CWORD-1]}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F9JRs%3D","line":8,"updated":"2013-12-16 11:06:32.000000000","message":"i\u0027m not sure if we follow that convention for shell script in heatclient but it would be nice not to have tab in there (at least that would make gerrit happy).","commit_id":"fd79223383662ec47cfa1b8b59054db89b24bbfd"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"abaed48b3c309b15760b6bb8946722fe0554f318","unresolved":false,"context_lines":[{"line_number":5,"context_line":"_heat_opts_exp\u003d\"\" # lazy init"},{"line_number":6,"context_line":"_heat()"},{"line_number":7,"context_line":"{"},{"line_number":8,"context_line":"\tlocal cur prev kbc"},{"line_number":9,"context_line":"\tCOMPREPLY\u003d()"},{"line_number":10,"context_line":"\tcur\u003d\"${COMP_WORDS[COMP_CWORD]}\""},{"line_number":11,"context_line":"\tprev\u003d\"${COMP_WORDS[COMP_CWORD-1]}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F9ITY%3D","line":8,"in_reply_to":"AAAATn%2F9JRs%3D","updated":"2013-12-16 14:46:45.000000000","message":"yes, you are right. thanks","commit_id":"fd79223383662ec47cfa1b8b59054db89b24bbfd"}]}