)]}'
{"heatclient/common/http.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"35af9d2d4ff1ca545aae40298ad0fc0a1a4cfaf9","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            allow_redirects \u003d True"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        try:"},{"line_number":157,"context_line":"            if self.proxy_url:"},{"line_number":158,"context_line":"                resp \u003d requests.request("},{"line_number":159,"context_line":"                    method,"},{"line_number":160,"context_line":"                    self.endpoint_url + url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9c7w%3D","line":157,"updated":"2014-02-06 20:17:30.000000000","message":"Rather than an if else, could you always pass proxies\u003dself.proxy_url and make sure proxy_url contains some value which ensures the non-proxy case doesn\u0027t break?","commit_id":"9d86e920d662ed274a088eb3b3fd0d1c52f52a90"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"df15a20f94965e85d59b9732a7e7610af85df507","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            allow_redirects \u003d True"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        try:"},{"line_number":157,"context_line":"            if self.proxy_url:"},{"line_number":158,"context_line":"                resp \u003d requests.request("},{"line_number":159,"context_line":"                    method,"},{"line_number":160,"context_line":"                    self.endpoint_url + url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9Xyw%3D","line":157,"in_reply_to":"AAAAUH%2F9c7w%3D","updated":"2014-02-07 15:14:48.000000000","message":"Hi Steve,\nYou\u0027re right, I should change it and update unit tests instead of if-else statement","commit_id":"9d86e920d662ed274a088eb3b3fd0d1c52f52a90"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"a28500bab149187f46932f71e05ac89bfa0ddc78","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_proxy_url(self):"},{"line_number":242,"context_line":"        scheme \u003d urlutils.urlparse(self.endpoint).scheme"},{"line_number":243,"context_line":"        proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":244,"context_line":"        if proxy_url:"},{"line_number":245,"context_line":"            proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":246,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2F3Bg%3D","line":243,"updated":"2014-02-10 11:02:44.000000000","message":"you can just \n\nreturn os.environ.get(\u0027{0}_proxy\u0027.format(scheme)) \n\nhere, it will return None if not found","commit_id":"425006f6952d28ff85535ac187a8a9d913f08b28"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"aa30890af718d043243c667ad0fc2954277745b4","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_proxy_url(self):"},{"line_number":242,"context_line":"        scheme \u003d urlutils.urlparse(self.endpoint).scheme"},{"line_number":243,"context_line":"        proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":244,"context_line":"        if proxy_url:"},{"line_number":245,"context_line":"            proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":246,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2F25I%3D","line":243,"in_reply_to":"AAAAUX%2F%2F3Bg%3D","updated":"2014-02-10 11:25:35.000000000","message":"Thanks, Chmouel","commit_id":"425006f6952d28ff85535ac187a8a9d913f08b28"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"a28500bab149187f46932f71e05ac89bfa0ddc78","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        scheme \u003d urlutils.urlparse(self.endpoint).scheme"},{"line_number":243,"context_line":"        proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":244,"context_line":"        if proxy_url:"},{"line_number":245,"context_line":"            proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":246,"context_line":"        return None"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def head(self, url, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2F3Bw%3D","line":245,"updated":"2014-02-10 11:02:44.000000000","message":"i think you meant return proxy_url here","commit_id":"425006f6952d28ff85535ac187a8a9d913f08b28"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"a28500bab149187f46932f71e05ac89bfa0ddc78","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":244,"context_line":"        if proxy_url:"},{"line_number":245,"context_line":"            proxy_url \u003d os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":246,"context_line":"        return None"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def head(self, url, **kwargs):"},{"line_number":249,"context_line":"        return self.client_request(\"HEAD\", url, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUX%2F%2F3BY%3D","line":246,"updated":"2014-02-10 11:02:44.000000000","message":"you don\u0027t need return none you can just omit those return at the end since the function would exit with None by default.","commit_id":"425006f6952d28ff85535ac187a8a9d913f08b28"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"858cba92dd53f27a3cb6e4fb55f29f9089c20525","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        resp, body \u003d self.json_request(method, url, **kwargs)"},{"line_number":239,"context_line":"        return resp"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_proxy_url(self):"},{"line_number":242,"context_line":"        scheme \u003d urlutils.urlparse(self.endpoint).scheme"},{"line_number":243,"context_line":"        return os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2F24g%3D","line":241,"updated":"2014-02-10 11:29:37.000000000","message":"what do you think about having a test testing get_proxy_url ? (that would have catch the previous bug in the previous iteration)","commit_id":"81780a521e01f1a76d4617cc07786e982270d459"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"fc58b07bf9cc06d8ea1722cb6afafe273ad7af3c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        resp, body \u003d self.json_request(method, url, **kwargs)"},{"line_number":239,"context_line":"        return resp"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_proxy_url(self):"},{"line_number":242,"context_line":"        scheme \u003d urlutils.urlparse(self.endpoint).scheme"},{"line_number":243,"context_line":"        return os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2F20s%3D","line":241,"in_reply_to":"AAAAUX%2F%2F21g%3D","updated":"2014-02-10 11:38:12.000000000","message":"thanks a lot.","commit_id":"81780a521e01f1a76d4617cc07786e982270d459"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ca9061b615c25fd27ba71db1761cabfb087aba94","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        resp, body \u003d self.json_request(method, url, **kwargs)"},{"line_number":239,"context_line":"        return resp"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_proxy_url(self):"},{"line_number":242,"context_line":"        scheme \u003d urlutils.urlparse(self.endpoint).scheme"},{"line_number":243,"context_line":"        return os.environ.get(\u0027{0}_proxy\u0027.format(scheme))"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2F21g%3D","line":241,"in_reply_to":"AAAAUX%2F%2F24g%3D","updated":"2014-02-10 11:36:25.000000000","message":"Sure, I\u0027ll do it. I should to mark this review-request as \u0027work in progress\u0027 before tests will be implemented.","commit_id":"81780a521e01f1a76d4617cc07786e982270d459"}]}