)]}'
{"heatclient/common/http.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"725b5c5c2674b171fb9cc6d969e32d9a9cb79294","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if not isinstance(value, six.string_types):"},{"line_number":88,"context_line":"                value \u003d value.decode(\u0027utf-8\u0027)"},{"line_number":89,"context_line":"            header \u003d \u0027-H \\\u0027%s: %s\\\u0027\u0027 % (strutils.safe_decode(key),"},{"line_number":90,"context_line":"                                        strutils.safe_decode(value))"},{"line_number":91,"context_line":"            curl.append(header)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        conn_params_fmt \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FkiI%3D","line":90,"updated":"2014-03-05 10:10:04.000000000","message":"It looks weird to decode the value twice. safe_decode() must decode the value, it\u0027s the purpose of this function: safe *decode*. Just pass incoming\u003d\"utf-8\" to safe_decode().\n\nWe take a look at safe_decode() with Cyril, and this function is broken on Python 3: it only accepts Unicode, and raises an error for bytes string. This function should be fixed.","commit_id":"07d9b51d09fe708642781880b2c423a6fd8d12e5"}],"heatclient/tests/test_common_http.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"725b5c5c2674b171fb9cc6d969e32d9a9cb79294","unresolved":false,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def test_curl_log_i18n_headers(self):"},{"line_number":569,"context_line":"        self.m.StubOutWithMock(logging.Logger, \u0027debug\u0027)"},{"line_number":570,"context_line":"        kwargs \u003d {\u0027headers\u0027: {\u0027Key\u0027: b\u0027foo\\xe3\\x8a\\x8e\u0027}}"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        mock_logging_debug \u003d logging.Logger.debug("},{"line_number":573,"context_line":"            u\"curl -i -X GET -H \u0027Key: foo㊎\u0027 http://somewhere\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2Fkgc%3D","line":570,"updated":"2014-03-05 10:10:04.000000000","message":"It would be nice to write also a test with Unicode key, to check that Unicode is also supported: {six.u(\u0027Key\u0027): six.u(\u0027foo\\u328e\u0027)}","commit_id":"07d9b51d09fe708642781880b2c423a6fd8d12e5"}]}