)]}'
{"id":"openstack%2Fpython-ironic-inspector-client~205031","triplet_id":"openstack%2Fpython-ironic-inspector-client~master~I8a7c7349ea73f16e71519a80f2911632d7d276f4","project":"openstack/python-ironic-inspector-client","branch":"master","topic":"func","hashtags":[],"change_id":"I8a7c7349ea73f16e71519a80f2911632d7d276f4","subject":"Create own functional tests for the client","status":"MERGED","created":"2015-07-23 12:14:36.000000000","updated":"2015-07-30 08:37:57.000000000","submitted":"2015-07-30 08:37:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f46dae17ae10e3eb7e6208529546cfb7c9297d70","_number":205031,"virtual_id_number":205031,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},{"value":2,"date":"2015-07-30 08:37:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":0,"date":"2015-07-27 08:59:40.000000000","_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},{"value":0,"date":"2015-07-27 09:02:23.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"recommended":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"all":[{"value":1,"date":"2015-07-30 07:51:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-07-30 07:50:55.000000000","_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":2,"date":"2015-07-29 13:08:11.000000000","_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":0,"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},{"value":1,"date":"2015-07-30 08:23:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"value":0,"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-27 08:59:40.000000000","updated_by":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"reviewer":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"state":"REVIEWER"},{"updated":"2015-07-30 07:50:55.000000000","updated_by":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"reviewer":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"state":"REVIEWER"},{"updated":"2015-07-30 07:51:01.000000000","updated_by":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"reviewer":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"state":"REVIEWER"},{"updated":"2015-07-30 08:37:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3ffe43f32c0f9dfce6bf75517fd28f46a9e00f0e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-07-23 12:14:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"36eb5f6fa76418474e61bfbcded164ae0b46c9a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-23 13:36:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironic-inspector-client-python34 http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-python34/b8c0cbb/ : SUCCESS in 1m 31s\n- gate-python-ironic-inspector-client-requirements http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-requirements/e01a469/ : SUCCESS in 22s\n- gate-python-ironic-inspector-client-pep8 http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-pep8/d102ef6/ : SUCCESS in 2m 08s\n- gate-python-ironic-inspector-client-python27 http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-python27/cce2700/ : SUCCESS in 1m 16s\n- gate-python-ironic-inspector-client-tox-func http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-tox-func/2a225a5/ : SUCCESS in 2m 42s\n- gate-python-ironic-inspector-client-dsvm-nv http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-dsvm-nv/4bd0775/ : FAILURE in 18m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d97abe92d98361c212c78d85caad2aeb9fec3f0a","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2015-07-27 08:59:40.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"07521fe58e43d7a558d04b2de29e56ed15cbde00","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-07-27 09:02:23.000000000","message":"Patch Set 1:\n\nthe dsvm gate won\u0027t pass until https://review.openstack.org/#/c/203629/ merges...","accounts_in_message":[],"_revision_number":1},{"id":"e58246407cfc0f771811c3c270619a015e4101f2","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2015-07-27 09:13:48.000000000","message":"Patch Set 1:\n\nThanks for the update, I thought that patch is already merged.","accounts_in_message":[],"_revision_number":1},{"id":"8f9cdeb6839a7136b4ff2116575d92b866364cac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-27 09:16:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironic-inspector-client-python34 http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-python34/7518bce/ : SUCCESS in 1m 42s\n- gate-python-ironic-inspector-client-requirements http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-requirements/519ece6/ : SUCCESS in 21s\n- gate-python-ironic-inspector-client-pep8 http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-pep8/22d937a/ : SUCCESS in 1m 40s\n- gate-python-ironic-inspector-client-python27 http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-python27/140e8fe/ : SUCCESS in 1m 29s\n- gate-python-ironic-inspector-client-tox-func http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-tox-func/1a80a22/ : SUCCESS in 3m 32s\n- gate-python-ironic-inspector-client-dsvm-nv http://logs.openstack.org/31/205031/1/check/gate-python-ironic-inspector-client-dsvm-nv/9ed6aa7/ : FAILURE in 9m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"be967f1478abb769b62634f2c3de31f0519aef92","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-07-29 12:02:49.000000000","message":"Patch Set 1:\n\nfolks, could you please review it? this change does not depend on dsvm gate...","accounts_in_message":[],"_revision_number":1},{"id":"b94ddcc2e58ad155fdc61f8d8f1715eb87bdfd1a","author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"date":"2015-07-29 13:08:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d0dc0d7ca9f7e78c2c12872da0f0d65103d5cfd7","author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"date":"2015-07-30 07:50:55.000000000","message":"Patch Set 1: Code-Review+2\n\nDmitry, thank you for the patch. LGTM. BTW, these tests are doing same things as test/functional, right? Then, Why is the name of first test \"test_bmc\"? As the test in this patch set, \"test_introspect_get_status\" sounds better :)","accounts_in_message":[],"_revision_number":1},{"id":"688f1e0e3134f00a25ddce85895a5ce0233890de","author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"date":"2015-07-30 07:51:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"96f53e36f2dd39170a6d9d099144f024781e3f72","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-07-30 07:54:45.000000000","message":"Patch Set 1:\n\nWell, initially I was planning to have different tests (in server, not here) that test different ways of lookup (by BMC address, by MAC address, something invented in the future).\n\nPlease someone approve this change when Zuul works again.","accounts_in_message":[],"_revision_number":1},{"id":"e4557992dfca13716204070164df540b00aa98af","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-07-30 08:23:30.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"efb32fca1c53f7de87e9f65086c1146e1659a44a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-30 08:23:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0a2bdea5266241ce9149e97be34ade2d774dacfb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-30 08:37:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironic-inspector-client-python34 http://logs.openstack.org/31/205031/1/gate/gate-python-ironic-inspector-client-python34/c62a86d/ : SUCCESS in 1m 57s\n- gate-python-ironic-inspector-client-requirements http://logs.openstack.org/31/205031/1/gate/gate-python-ironic-inspector-client-requirements/79614bf/ : SUCCESS in 12s\n- gate-python-ironic-inspector-client-pep8 http://logs.openstack.org/31/205031/1/gate/gate-python-ironic-inspector-client-pep8/fdbdf25/ : SUCCESS in 2m 57s\n- gate-python-ironic-inspector-client-python27 http://logs.openstack.org/31/205031/1/gate/gate-python-ironic-inspector-client-python27/b3dacd0/ : SUCCESS in 2m 56s\n- gate-python-ironic-inspector-client-tox-func http://logs.openstack.org/31/205031/1/gate/gate-python-ironic-inspector-client-tox-func/98f7319/ : SUCCESS in 4m 19s","accounts_in_message":[],"_revision_number":1},{"id":"503795183ccace6e80cd8dc71e8583cfcbf92d66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-30 08:37:57.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7d443fb0c170e3a07befe835b0ee6b4ef2312960","revisions":{"7d443fb0c170e3a07befe835b0ee6b4ef2312960":{"kind":"REWORK","_number":1,"created":"2015-07-23 12:14:36.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/31/205031/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironic-inspector-client","ref":"refs/changes/31/205031/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironic-inspector-client refs/changes/31/205031/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironic-inspector-client refs/changes/31/205031/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironic-inspector-client refs/changes/31/205031/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironic-inspector-client refs/changes/31/205031/1"}}},"commit":{"parents":[{"commit":"1e3d33420b359a81618e19001babf69eedd6d458","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironic-inspector-client/commit/1e3d33420b359a81618e19001babf69eedd6d458"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-07-23 12:13:38.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-07-23 12:13:38.000000000","tz":120},"subject":"Create own functional tests for the client","message":"Create own functional tests for the client\n\nTests from ironic_inspector no longer use client.\nThis patch temporary brings back dependency on ironic-inspector\nfrom git master, should be changed after ironic-inspector 2.1.0\nis released.\n\nChange-Id: I8a7c7349ea73f16e71519a80f2911632d7d276f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironic-inspector-client/commit/7d443fb0c170e3a07befe835b0ee6b4ef2312960"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironic-inspector-client/commit/7d443fb0c170e3a07befe835b0ee6b4ef2312960"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}