)]}'
{"README.rst":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"797a080338db001d938da14385eb29437ad1998a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  **Ironic Inspector** will switch to manual power on and assigning IPMI"},{"line_number":82,"context_line":"  credentials on introspection. See `Setting IPMI Credentials`_ for details."},{"line_number":83,"context_line":"* ``manage_boot`` - whether to manage boot for this node during introspection."},{"line_number":84,"context_line":"  Defaults to the server default (which is ``True``)."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"CLI::"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_549f1f03","line":84,"updated":"2016-07-18 12:50:32.000000000","message":"Nit: maybe explicitly note manage_boot isn\u0027t exposed: ...(which is ``True``); intentionally not exposed thru CLI (missing use case).","commit_id":"43eb0da80b808be8f68abf7a8779dfe2e47962d3"}],"ironic_inspector_client/client.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b4bd09edee6d9e4dfc369d3ec91d5b0deb96646a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def introspect(uuid, base_url\u003dNone, auth_token\u003dNone,"},{"line_number":30,"context_line":"               new_ipmi_password\u003dNone, new_ipmi_username\u003dNone,"},{"line_number":31,"context_line":"               api_version\u003dDEFAULT_API_VERSION, session\u003dNone, manage_boot\u003dTrue,"},{"line_number":32,"context_line":"               **kwargs):"},{"line_number":33,"context_line":"    \"\"\"Start introspection for a node."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_ba6fb9fa","line":31,"range":{"start_line":31,"start_character":62,"end_line":31,"end_character":79},"updated":"2016-08-01 13:09:23.000000000","message":"this list is frozen and should not be updated","commit_id":"c7351daba82d307d0eaf61a7f54624f45b6b45cc"}],"ironic_inspector_client/v1.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"797a080338db001d938da14385eb29437ad1998a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        :param new_ipmi_username: if new_ipmi_password is set, this values sets"},{"line_number":61,"context_line":"                                  new IPMI user name. Defaults to one in"},{"line_number":62,"context_line":"                                  driver_info."},{"line_number":63,"context_line":"        :param manage_boot: whether to manage boot during introspection of"},{"line_number":64,"context_line":"                            this node."},{"line_number":65,"context_line":"        :raises: ClientError on error reported from a server"},{"line_number":66,"context_line":"        :raises: VersionNotSupported if requested api_version is not supported"},{"line_number":67,"context_line":"        :raises: *requests* library exception on connection problems."}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_8f417e3c","line":64,"range":{"start_line":63,"start_character":8,"end_line":64,"end_character":38},"updated":"2016-07-18 12:50:32.000000000","message":"Please, add \"type\"/description of possible values e.g \"Possible values: True, False, None-use server default.\"","commit_id":"43eb0da80b808be8f68abf7a8779dfe2e47962d3"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"cb0f290f707ae31c8844296d2628b14cfebec4cd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class ClientV1(http.BaseClient):"},{"line_number":41,"context_line":"    \"\"\"Client for API v1.\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, manage_boot\u003dTrue, **kwargs):"},{"line_number":44,"context_line":"        \"\"\"Create a client."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param kwargs: arguments to pass to the BaseClient constructor."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_ddac8037","line":43,"range":{"start_line":43,"start_character":23,"end_line":43,"end_character":39},"updated":"2016-07-29 09:52:09.000000000","message":"This should be None by default to promote the server default.","commit_id":"c7351daba82d307d0eaf61a7f54624f45b6b45cc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b4bd09edee6d9e4dfc369d3ec91d5b0deb96646a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class ClientV1(http.BaseClient):"},{"line_number":41,"context_line":"    \"\"\"Client for API v1.\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, manage_boot\u003dTrue, **kwargs):"},{"line_number":44,"context_line":"        \"\"\"Create a client."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param kwargs: arguments to pass to the BaseClient constructor."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1a7b65c2","line":43,"range":{"start_line":43,"start_character":23,"end_line":43,"end_character":39},"in_reply_to":"bacf61ea_8c0da7ea","updated":"2016-08-01 13:09:23.000000000","message":"+1","commit_id":"c7351daba82d307d0eaf61a7f54624f45b6b45cc"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"e8d24e2f0de2cf04e2f6bdec3c2ef54af05ba521","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class ClientV1(http.BaseClient):"},{"line_number":41,"context_line":"    \"\"\"Client for API v1.\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, manage_boot\u003dTrue, **kwargs):"},{"line_number":44,"context_line":"        \"\"\"Create a client."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param kwargs: arguments to pass to the BaseClient constructor."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8c0da7ea","line":43,"range":{"start_line":43,"start_character":23,"end_line":43,"end_character":39},"in_reply_to":"bacf61ea_9ed02df8","updated":"2016-07-29 16:32:19.000000000","message":"But that\u0027s for the server part, isn\u0027t it?\nImagine someone configured False on the server as a default instead.\nThe client code would enforce True(unless explicitly set e.g on CLI).\n\nIf None is the default here, the server setting isn\u0027t overridden unless requested explicitly (as per original commit by Dmitry).","commit_id":"c7351daba82d307d0eaf61a7f54624f45b6b45cc"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"88c857d1cd0d57b756ff0bff913d131863329b6c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class ClientV1(http.BaseClient):"},{"line_number":41,"context_line":"    \"\"\"Client for API v1.\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, manage_boot\u003dTrue, **kwargs):"},{"line_number":44,"context_line":"        \"\"\"Create a client."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        :param kwargs: arguments to pass to the BaseClient constructor."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9ed02df8","line":43,"range":{"start_line":43,"start_character":23,"end_line":43,"end_character":39},"in_reply_to":"bacf61ea_ddac8037","updated":"2016-07-29 15:58:19.000000000","message":"As per the spec https://review.openstack.org/#/c/305864/7/specs/approved/inspector-boot-management.rst Line number 100, the default value is True.","commit_id":"c7351daba82d307d0eaf61a7f54624f45b6b45cc"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"cb0f290f707ae31c8844296d2628b14cfebec4cd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        :param new_ipmi_username: if new_ipmi_password is set, this values sets"},{"line_number":61,"context_line":"                                  new IPMI user name. Defaults to one in"},{"line_number":62,"context_line":"                                  driver_info."},{"line_number":63,"context_line":"        :param manage_boot: whether to manage boot during introspection of"},{"line_number":64,"context_line":"                            this node."},{"line_number":65,"context_line":"        :raises: ClientError on error reported from a server"},{"line_number":66,"context_line":"        :raises: VersionNotSupported if requested api_version is not supported"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_fdb18490","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":74},"updated":"2016-07-29 09:52:09.000000000","message":"None value description still missing.","commit_id":"c7351daba82d307d0eaf61a7f54624f45b6b45cc"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"88c857d1cd0d57b756ff0bff913d131863329b6c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        :param new_ipmi_username: if new_ipmi_password is set, this values sets"},{"line_number":61,"context_line":"                                  new IPMI user name. Defaults to one in"},{"line_number":62,"context_line":"                                  driver_info."},{"line_number":63,"context_line":"        :param manage_boot: whether to manage boot during introspection of"},{"line_number":64,"context_line":"                            this node."},{"line_number":65,"context_line":"        :raises: ClientError on error reported from a server"},{"line_number":66,"context_line":"        :raises: VersionNotSupported if requested api_version is not supported"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3e14a19e","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":74},"in_reply_to":"bacf61ea_fdb18490","updated":"2016-07-29 15:58:19.000000000","message":"ditto","commit_id":"c7351daba82d307d0eaf61a7f54624f45b6b45cc"}]}