)]}'
{"ironic_inspector_client/v1.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"732d9b1e41ff9b0f07ba87f3b7c2197dcf31c5f4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_5256072a","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"updated":"2016-12-13 15:13:00.000000000","message":"I\u0027d rename uuid to node_id... but meh... most important the docs now make sense","commit_id":"0588a8e9b585142b4450727e755dddda22461af5"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"5946e75009631512cd2906d47a67644535ba3162","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_7563ed1a","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"in_reply_to":"1a6eadb0_5256072a","updated":"2016-12-13 15:18:05.000000000","message":"rename could potentially break someone","commit_id":"0588a8e9b585142b4450727e755dddda22461af5"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"7e1c01bfbc7e2eefc7784ea1307130b7e4c070f6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_e8964493","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"in_reply_to":"1a6eadb0_7563ed1a","updated":"2016-12-13 15:23:54.000000000","message":"aah, yeah, deprecation :-/ OK cool","commit_id":"0588a8e9b585142b4450727e755dddda22461af5"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a646fe0a11318e33a691a264d0fb68e830ecdcb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_84d36603","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"updated":"2017-01-23 14:17:29.000000000","message":"Nit: Shouldn\u0027t we rename this parameter to node_id or something? This is a positional argument so it shouldn\u0027t break anyone. As I see its been discussed before, I\u0027m cool with a follow up.","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"de9b93ddc78c99ef4fa1bd9425279053227e4a12","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_a719bc7b","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"in_reply_to":"5a3905b3_136150a9","updated":"2017-01-26 15:46:41.000000000","message":"Now both node_id and uuid become optional. So we should check that at least one of the is set.\n\nif not uuid:\n    raise....","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e96cd36c75e7a7d313770e1a23bffc2ddc188979","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_3d5322e3","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"in_reply_to":"5a3905b3_136150a9","updated":"2017-01-26 14:26:39.000000000","message":"Reported as https://bugs.launchpad.net/python-ironic-inspector-client/+bug/1659562","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a221e6678569d1df3e985c34659306d0ec4a21e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_f8276eb3","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"in_reply_to":"5a3905b3_84d36603","updated":"2017-01-23 14:23:19.000000000","message":"It being a positional argument does not prevent people from potentially using it via a keyword :(\n\n client.introspect(uuid\u003d\u0027foobar\u0027)\n\nthis needs another round of deprecations, I guess","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d2f4e2913059893f854699b94ed6be0a8b7470eb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        super(ClientV1, self).__init__(**kwargs)"},{"line_number":88,"context_line":"        self.rules \u003d RulesAPI(self.request)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def introspect(self, uuid, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Start introspection for a node."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param uuid: node UUID or name"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_136150a9","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":29},"in_reply_to":"5a3905b3_f8276eb3","updated":"2017-01-24 10:15:33.000000000","message":"Woah, didn\u0027t know you could do that :( I thought positional arguments were safe... \n\nI guess we need to do something like:\n\n def introspect(self, node_id\u003dNone, new_ipmi_password\u003dNone, new_ipmi_username\u003dNone, uuid\u003dNone):\n\n node_id \u003d node_id or uuid\n if uuid: \n    DeprecationWarning","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a646fe0a11318e33a691a264d0fb68e830ecdcb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                  \u0027new_ipmi_password\u0027: new_ipmi_password}"},{"line_number":118,"context_line":"        self.request(\u0027post\u0027, \u0027/introspection/%s\u0027 % uuid, params\u003dparams)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def reprocess(self, uuid):"},{"line_number":121,"context_line":"        \"\"\"Reprocess stored introspection data."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        :param uuid: node UUID or name."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_a4d062f7","line":120,"range":{"start_line":120,"start_character":24,"end_line":120,"end_character":28},"updated":"2017-01-23 14:17:29.000000000","message":"Ditto","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a646fe0a11318e33a691a264d0fb68e830ecdcb","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        response \u003d self.request(\u0027get\u0027, \u0027/introspection\u0027, params\u003dparams)"},{"line_number":171,"context_line":"        return response.json()[\u0027introspection\u0027]"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def get_status(self, uuid):"},{"line_number":174,"context_line":"        \"\"\"Get introspection status for a node."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        :param uuid: node UUID or name."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_e4d6eaef","line":173,"range":{"start_line":173,"start_character":25,"end_line":173,"end_character":29},"updated":"2017-01-23 14:17:29.000000000","message":"Ditto","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a646fe0a11318e33a691a264d0fb68e830ecdcb","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        return self.request(\u0027get\u0027, \u0027/introspection/%s\u0027 % uuid).json()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def wait_for_finish(self, uuids, retry_interval\u003dDEFAULT_RETRY_INTERVAL,"},{"line_number":196,"context_line":"                        max_retries\u003dDEFAULT_MAX_RETRIES,"},{"line_number":197,"context_line":"                        sleep_function\u003dtime.sleep):"},{"line_number":198,"context_line":"        \"\"\"Wait for introspection finishing for given nodes."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_04069685","line":195,"range":{"start_line":195,"start_character":30,"end_line":195,"end_character":35},"updated":"2017-01-23 14:17:29.000000000","message":"Ditto","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a646fe0a11318e33a691a264d0fb68e830ecdcb","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        raise WaitTimeoutError(_(\"Timeout while waiting for introspection \""},{"line_number":237,"context_line":"                                 \"of nodes %s\") % new_active_uuids)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def get_data(self, uuid, raw\u003dFalse):"},{"line_number":240,"context_line":"        \"\"\"Get introspection data from the last introspection of a node."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        :param uuid: node UUID or name."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_44fc1e72","line":239,"range":{"start_line":239,"start_character":23,"end_line":239,"end_character":27},"updated":"2017-01-23 14:17:29.000000000","message":"Ditto","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a646fe0a11318e33a691a264d0fb68e830ecdcb","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        else:"},{"line_number":259,"context_line":"            return resp.json()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def abort(self, uuid):"},{"line_number":262,"context_line":"        \"\"\"Abort running introspection for a node."},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        :param uuid: node UUID or name."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_c4f00e94","line":261,"range":{"start_line":261,"start_character":20,"end_line":261,"end_character":24},"updated":"2017-01-23 14:17:29.000000000","message":"Ditto","commit_id":"b6baf26a2096326fb225a97384e3908b1ab1a716"}]}