)]}'
{"ironic_inspector_client/common/http.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"f5b18d5f61eaf600405a0afff745248b29cd542a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    ivar service_type: requested service type"},{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def __init__(self, service_type):"},{"line_number":93,"context_line":"        self.service_type \u003d service_type"},{"line_number":94,"context_line":"        msg \u003d _(\u0027Endpoint of type %s was not found in the service catalog \u0027"},{"line_number":95,"context_line":"                \u0027and was not provided explicitly\u0027) % service_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_1f515c63","line":92,"range":{"start_line":92,"start_character":23,"end_line":92,"end_character":35},"updated":"2017-11-30 17:26:35.000000000","message":"nit: based on the usage below and probably as a precaution I\u0027d suggest making this a kwarg actually","commit_id":"e9bcb68bab4df80106960c0e43a12e1bf7da89a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e358abd5da73b547aef9c510a435400ff039c51d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    ivar service_type: requested service type"},{"line_number":90,"context_line":"    \"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def __init__(self, service_type):"},{"line_number":93,"context_line":"        self.service_type \u003d service_type"},{"line_number":94,"context_line":"        msg \u003d _(\u0027Endpoint of type %s was not found in the service catalog \u0027"},{"line_number":95,"context_line":"                \u0027and was not provided explicitly\u0027) % service_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_4d2de1a6","line":92,"range":{"start_line":92,"start_character":23,"end_line":92,"end_character":35},"in_reply_to":"ff82abbf_1f515c63","updated":"2017-12-01 11:44:37.000000000","message":"Why? It\u0027s a regular mandatory argument.","commit_id":"e9bcb68bab4df80106960c0e43a12e1bf7da89a5"}],"ironic_inspector_client/test/test_common_http.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"f5b18d5f61eaf600405a0afff745248b29cd542a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            interface\u003dNone, region_name\u003dNone)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_endpoint_not_found(self):"},{"line_number":145,"context_line":"        self.session.get_endpoint.side_effect \u003d exceptions.EndpointNotFound()"},{"line_number":146,"context_line":"        self.assertRaises(http.EndpointNotFound, self.get_client)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.session.get_endpoint.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_e2a65b54","line":145,"range":{"start_line":145,"start_character":48,"end_line":145,"end_character":77},"updated":"2017-11-30 17:26:35.000000000","message":"This seems left over; it works because EnpointNotFound is a subtype of CatalogError[1]; to exercise the except block[2] would be nicer to use the CatalogError here\n\n[1] https://github.com/openstack/keystoneauth/blob/edeb84715c80c5299c0f78c872d6507d9093ad82/keystoneauth1/exceptions/catalog.py#L25\n[2] https://review.openstack.org/#/c/521069/2/ironic_inspector_client/common/http.py@135","commit_id":"e9bcb68bab4df80106960c0e43a12e1bf7da89a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e358abd5da73b547aef9c510a435400ff039c51d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            interface\u003dNone, region_name\u003dNone)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_endpoint_not_found(self):"},{"line_number":145,"context_line":"        self.session.get_endpoint.side_effect \u003d exceptions.EndpointNotFound()"},{"line_number":146,"context_line":"        self.assertRaises(http.EndpointNotFound, self.get_client)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.session.get_endpoint.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_581b6172","line":145,"range":{"start_line":145,"start_character":48,"end_line":145,"end_character":77},"in_reply_to":"ff82abbf_e2a65b54","updated":"2017-12-01 11:44:37.000000000","message":"Strictly speaking, EndpointNotFound is what is going to be raised. I\u0027m not sure keystoneauth ever raises the base CatalogError exception itself. We could test all its subclasses, but it looks an overkill.","commit_id":"e9bcb68bab4df80106960c0e43a12e1bf7da89a5"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"f5b18d5f61eaf600405a0afff745248b29cd542a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        mock_req.assert_called_once_with(mock.ANY,"},{"line_number":161,"context_line":"                                         \u0027http://some/host/v1/foo/bar\u0027, \u0027get\u0027,"},{"line_number":162,"context_line":"                                         raise_exc\u003dFalse, headers\u003dself.headers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_explicit_version(self):"},{"line_number":165,"context_line":"        res \u003d self.get_client(version\u003d\u00271.2\u0027).request(\u0027get\u0027, \u0027/foo/bar\u0027)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_fdeb60d9","line":163,"updated":"2017-11-30 17:26:35.000000000","message":"nit: misses coverage when both the session and inspector_url are provided (but this was the case even before I guess)","commit_id":"e9bcb68bab4df80106960c0e43a12e1bf7da89a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e358abd5da73b547aef9c510a435400ff039c51d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        mock_req.assert_called_once_with(mock.ANY,"},{"line_number":161,"context_line":"                                         \u0027http://some/host/v1/foo/bar\u0027, \u0027get\u0027,"},{"line_number":162,"context_line":"                                         raise_exc\u003dFalse, headers\u003dself.headers)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_explicit_version(self):"},{"line_number":165,"context_line":"        res \u003d self.get_client(version\u003d\u00271.2\u0027).request(\u0027get\u0027, \u0027/foo/bar\u0027)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_5834c1de","line":163,"in_reply_to":"ff82abbf_fdeb60d9","updated":"2017-12-01 11:44:37.000000000","message":"Done","commit_id":"e9bcb68bab4df80106960c0e43a12e1bf7da89a5"}]}