)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a08d4c3f007f3d023c9645b727bf09c3ca00c30b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add quiet flag to Introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Failed introspection in OC returns 0, add quiet flag"},{"line_number":10,"context_line":"to handle the correct return when is desirible."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If30fdb9b8dbe29eb6803dafcde9380444e497e3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_8ba0a1f4","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":28},"updated":"2018-11-16 16:53:43.000000000","message":"nit: this sounds confusing to me. After reading this I am not sure I understand the purpose of the --quiet flag and how it interplays with the zero rc...\n\nI wonder if you could explain this in somewhat more layman\u0027s terms...? ;-)","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"}],"doc/source/cli/index.rst":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28b7381aa3637b5fd5cd51e5d1b320d7427ebcb0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"then displays the results as a table."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag can only be used together with the ``--wait`` flag,"},{"line_number":40,"context_line":"otherwise will throw an error."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Query introspection status"},{"line_number":43,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f79a3b5_d74a1723","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":29},"updated":"2018-11-28 01:49:07.000000000","message":"this part can be removed, I have expected some explanation on the check-errors on what it\u0027s doing, but follow up works for me.","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"610fdde0840d3c12f1ad0c8b8c0bfda9d1f89195","unresolved":false,"context_lines":[{"line_number":37,"context_line":"then displays the results as a table."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag can only be used together with the ``--wait`` flag,"},{"line_number":40,"context_line":"otherwise will throw an error."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Query introspection status"},{"line_number":43,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f79a3b5_fcb0522a","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":29},"in_reply_to":"3f79a3b5_d74a1723","updated":"2018-11-28 13:15:36.000000000","message":"Done","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"}],"ironic_inspector_client/shell.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a08d4c3f007f3d023c9645b727bf09c3ca00c30b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"                            help\u003d\u0027wait for introspection to finish; the result\u0027"},{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--quiet\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027Only show error and warning messages\u0027)"},{"line_number":78,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0b3ed1b5","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":36},"updated":"2018-11-16 16:53:43.000000000","message":"I beg your pardon for possibly stupid concern... The `quiet` option reads to me like  an inhibitor e.g. with --quiet I\u0027d expect the tool be report less. However looking in the code, it seems like --quiet actually makes the client noisier.\n\nCould you please elaborate?","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"093f807c9871f429f2bc8008dd02da23243a5e64","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"                            help\u003d\u0027wait for introspection to finish; the result\u0027"},{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--quiet\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027Only show error and warning messages\u0027)"},{"line_number":78,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_685bb960","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":36},"in_reply_to":"3f79a3b5_0b3ed1b5","updated":"2018-11-19 12:59:44.000000000","message":"The idea to add the quiet flag like for the grep command, if an error occur the exit status would be different from 0","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a08d4c3f007f3d023c9645b727bf09c3ca00c30b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--quiet\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027Only show error and warning messages\u0027)"},{"line_number":78,"context_line":"        return parser"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b05b885f","line":77,"range":{"start_line":77,"start_character":34,"end_line":77,"end_character":36},"updated":"2018-11-16 16:53:43.000000000","message":"nit: other options seem to be lowcased","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"093f807c9871f429f2bc8008dd02da23243a5e64","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--quiet\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027Only show error and warning messages\u0027)"},{"line_number":78,"context_line":"        return parser"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_88fad50d","line":77,"range":{"start_line":77,"start_character":34,"end_line":77,"end_character":36},"in_reply_to":"3f79a3b5_b05b885f","updated":"2018-11-19 12:59:44.000000000","message":"sure","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a08d4c3f007f3d023c9645b727bf09c3ca00c30b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            result \u003d [(uuid, s.get(\u0027error\u0027))"},{"line_number":89,"context_line":"                      for uuid, s in result.items()]"},{"line_number":90,"context_line":"            if parsed_args.quiet:"},{"line_number":91,"context_line":"                for node_info in result[1]:"},{"line_number":92,"context_line":"                    if node_info[1] is not None:"},{"line_number":93,"context_line":"                        raise Exception(_(\"Introspection failed for one or \""},{"line_number":94,"context_line":"                                          \"more nodes\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d015e44c","line":91,"range":{"start_line":91,"start_character":39,"end_line":91,"end_character":42},"updated":"2018-11-16 16:53:43.000000000","message":"I may misunderstand the logic behind this loop. Is it that we iterate over element #1  ?\n\nWithout really knowing the code, would something like this suffice?\n\n  if any(r[1] for r in result):\n    raise ...","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a08d4c3f007f3d023c9645b727bf09c3ca00c30b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            result \u003d [(uuid, s.get(\u0027error\u0027))"},{"line_number":89,"context_line":"                      for uuid, s in result.items()]"},{"line_number":90,"context_line":"            if parsed_args.quiet:"},{"line_number":91,"context_line":"                for node_info in result[1]:"},{"line_number":92,"context_line":"                    if node_info[1] is not None:"},{"line_number":93,"context_line":"                        raise Exception(_(\"Introspection failed for one or \""},{"line_number":94,"context_line":"                                          \"more nodes\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d0472479","line":91,"range":{"start_line":91,"start_character":39,"end_line":91,"end_character":42},"updated":"2018-11-16 16:53:43.000000000","message":"Is it guaranteed that `result` is always 2+ elements long?\n\nAlso, can `.items()` exhibit non-stable ordering so that element #1 could end up being different on each run?","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"093f807c9871f429f2bc8008dd02da23243a5e64","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            result \u003d [(uuid, s.get(\u0027error\u0027))"},{"line_number":89,"context_line":"                      for uuid, s in result.items()]"},{"line_number":90,"context_line":"            if parsed_args.quiet:"},{"line_number":91,"context_line":"                for node_info in result[1]:"},{"line_number":92,"context_line":"                    if node_info[1] is not None:"},{"line_number":93,"context_line":"                        raise Exception(_(\"Introspection failed for one or \""},{"line_number":94,"context_line":"                                          \"more nodes\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c869ad23","line":91,"range":{"start_line":91,"start_character":39,"end_line":91,"end_character":42},"in_reply_to":"3f79a3b5_d0472479","updated":"2018-11-19 12:59:44.000000000","message":"my bad, there is no need for the [1] there \u003d(","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a08d4c3f007f3d023c9645b727bf09c3ca00c30b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            if parsed_args.quiet:"},{"line_number":91,"context_line":"                for node_info in result[1]:"},{"line_number":92,"context_line":"                    if node_info[1] is not None:"},{"line_number":93,"context_line":"                        raise Exception(_(\"Introspection failed for one or \""},{"line_number":94,"context_line":"                                          \"more nodes\"))"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            result \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0b10114c","line":93,"range":{"start_line":93,"start_character":68,"end_line":93,"end_character":71},"updated":"2018-11-16 16:53:43.000000000","message":"would it make sense to report UUID of the failed node(s)?","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"093f807c9871f429f2bc8008dd02da23243a5e64","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            if parsed_args.quiet:"},{"line_number":91,"context_line":"                for node_info in result[1]:"},{"line_number":92,"context_line":"                    if node_info[1] is not None:"},{"line_number":93,"context_line":"                        raise Exception(_(\"Introspection failed for one or \""},{"line_number":94,"context_line":"                                          \"more nodes\"))"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            result \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_685ad985","line":93,"range":{"start_line":93,"start_character":68,"end_line":93,"end_character":71},"in_reply_to":"3f79a3b5_0b10114c","updated":"2018-11-19 12:59:44.000000000","message":"sure","commit_id":"acbbf37df8c2e7379698c9373be5583418e4a6d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5029bd9eed3819d77cead0eefce662c5ab5120","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                      for uuid, s in result.items()]"},{"line_number":92,"context_line":"            if parsed_args.check_errors:"},{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if result[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error !\u003d []:"},{"line_number":95,"context_line":"                    uuids \u003d \" \".join(node_info[0] for node_info in nodes_error)"},{"line_number":96,"context_line":"                    raise Exception(_(\"Introspection failed for %(nodes)s\") %"},{"line_number":97,"context_line":"                                    {\u0027nodes\u0027: uuids})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b853433b","line":94,"updated":"2018-11-20 16:54:49.000000000","message":"nit:\n\n if nodes_error:\n\nis more pythonic","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0947a5559bd145e14c1c7fe820d9e1f8adc27fab","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                      for uuid, s in result.items()]"},{"line_number":92,"context_line":"            if parsed_args.check_errors:"},{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if result[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error !\u003d []:"},{"line_number":95,"context_line":"                    uuids \u003d \" \".join(node_info[0] for node_info in nodes_error)"},{"line_number":96,"context_line":"                    raise Exception(_(\"Introspection failed for %(nodes)s\") %"},{"line_number":97,"context_line":"                                    {\u0027nodes\u0027: uuids})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_83712f49","line":94,"in_reply_to":"3f79a3b5_b853433b","updated":"2018-11-21 07:53:47.000000000","message":"Done","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5029bd9eed3819d77cead0eefce662c5ab5120","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            if parsed_args.check_errors:"},{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if result[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error !\u003d []:"},{"line_number":95,"context_line":"                    uuids \u003d \" \".join(node_info[0] for node_info in nodes_error)"},{"line_number":96,"context_line":"                    raise Exception(_(\"Introspection failed for %(nodes)s\") %"},{"line_number":97,"context_line":"                                    {\u0027nodes\u0027: uuids})"},{"line_number":98,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_58522f38","line":95,"updated":"2018-11-20 16:54:49.000000000","message":"\", \".join(..)\n\nmore importantly, you definitely need to include error messages here, so something like\n\n \", \".join(\"%s (%s)\" % node_info for ...)","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0947a5559bd145e14c1c7fe820d9e1f8adc27fab","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            if parsed_args.check_errors:"},{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if result[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error !\u003d []:"},{"line_number":95,"context_line":"                    uuids \u003d \" \".join(node_info[0] for node_info in nodes_error)"},{"line_number":96,"context_line":"                    raise Exception(_(\"Introspection failed for %(nodes)s\") %"},{"line_number":97,"context_line":"                                    {\u0027nodes\u0027: uuids})"},{"line_number":98,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e387c309","line":95,"in_reply_to":"3f79a3b5_58522f38","updated":"2018-11-21 07:53:47.000000000","message":"Done","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5029bd9eed3819d77cead0eefce662c5ab5120","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if result[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error !\u003d []:"},{"line_number":95,"context_line":"                    uuids \u003d \" \".join(node_info[0] for node_info in nodes_error)"},{"line_number":96,"context_line":"                    raise Exception(_(\"Introspection failed for %(nodes)s\") %"},{"line_number":97,"context_line":"                                    {\u0027nodes\u0027: uuids})"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            result \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_784dab91","line":96,"updated":"2018-11-20 16:54:49.000000000","message":"\"Introspection failed for some nodes: %s\"","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0947a5559bd145e14c1c7fe820d9e1f8adc27fab","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if result[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error !\u003d []:"},{"line_number":95,"context_line":"                    uuids \u003d \" \".join(node_info[0] for node_info in nodes_error)"},{"line_number":96,"context_line":"                    raise Exception(_(\"Introspection failed for %(nodes)s\") %"},{"line_number":97,"context_line":"                                    {\u0027nodes\u0027: uuids})"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            result \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0302ff71","line":96,"in_reply_to":"3f79a3b5_784dab91","updated":"2018-11-21 07:53:47.000000000","message":"Done","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"839a9730c2e11575a64fe0a2cef174ad49555d54","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            if parsed_args.check_errors:"},{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if r[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error:"},{"line_number":95,"context_line":"                    uuids \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":96,"context_line":"                                      for node_info in nodes_error)"},{"line_number":97,"context_line":"                    raise Exception(_("},{"line_number":98,"context_line":"                        \"Introspection failed for some nodes: %s\") % uuids"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e7c58c0a","line":95,"updated":"2018-11-21 10:56:51.000000000","message":"nit: \"uuid\" is not exactly correct now","commit_id":"2ee21a4f81226ae17902304c85ff740ff056dd0a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dde4e992774138538bc32eb81d943fa02e1ea7d2","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            if parsed_args.check_errors:"},{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if r[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error:"},{"line_number":95,"context_line":"                    uuids \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":96,"context_line":"                                      for node_info in nodes_error)"},{"line_number":97,"context_line":"                    raise Exception(_("},{"line_number":98,"context_line":"                        \"Introspection failed for some nodes: %s\") % uuids"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4d4fc1be","line":95,"in_reply_to":"3f79a3b5_e7c58c0a","updated":"2018-11-21 12:33:20.000000000","message":"Done","commit_id":"2ee21a4f81226ae17902304c85ff740ff056dd0a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"839a9730c2e11575a64fe0a2cef174ad49555d54","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                      for node_info in nodes_error)"},{"line_number":97,"context_line":"                    raise Exception(_("},{"line_number":98,"context_line":"                        \"Introspection failed for some nodes: %s\") % uuids"},{"line_number":99,"context_line":"                        )"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            result \u003d []"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_87c61814","line":99,"updated":"2018-11-21 10:56:51.000000000","message":"nit: I\u0027d prefer the closing bracket on the previous line","commit_id":"2ee21a4f81226ae17902304c85ff740ff056dd0a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dde4e992774138538bc32eb81d943fa02e1ea7d2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                      for node_info in nodes_error)"},{"line_number":97,"context_line":"                    raise Exception(_("},{"line_number":98,"context_line":"                        \"Introspection failed for some nodes: %s\") % uuids"},{"line_number":99,"context_line":"                        )"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            result \u003d []"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2d428594","line":99,"in_reply_to":"3f79a3b5_87c61814","updated":"2018-11-21 12:33:20.000000000","message":"Done","commit_id":"2ee21a4f81226ae17902304c85ff740ff056dd0a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1de3c97851c71f5835ec3c2b4391bbf229a66c8c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors ocurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occur the result is\u0027"},{"line_number":79,"context_line":"                            \u0027 not displayed\u0027)"},{"line_number":80,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ba2690b8","line":77,"updated":"2018-11-26 09:40:28.000000000","message":"just spelling s/ocurred/occurred","commit_id":"35916e1d3f33e5780f6be94b717484673e7e7e6a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"279ae7d3babcf840be0d7ce19a691712eee29090","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors ocurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occur the result is\u0027"},{"line_number":79,"context_line":"                            \u0027 not displayed\u0027)"},{"line_number":80,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_bab690da","line":77,"in_reply_to":"3f79a3b5_ba2690b8","updated":"2018-11-26 09:53:49.000000000","message":"Done","commit_id":"35916e1d3f33e5780f6be94b717484673e7e7e6a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1de3c97851c71f5835ec3c2b4391bbf229a66c8c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors ocurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occur the result is\u0027"},{"line_number":79,"context_line":"                            \u0027 not displayed\u0027)"},{"line_number":80,"context_line":"        return parser"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1a3544dc","line":78,"updated":"2018-11-26 09:40:28.000000000","message":"spelling also here s/occur/occurs","commit_id":"35916e1d3f33e5780f6be94b717484673e7e7e6a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"279ae7d3babcf840be0d7ce19a691712eee29090","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors ocurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occur the result is\u0027"},{"line_number":79,"context_line":"                            \u0027 not displayed\u0027)"},{"line_number":80,"context_line":"        return parser"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5aa73ca5","line":78,"in_reply_to":"3f79a3b5_1a3544dc","updated":"2018-11-26 09:53:49.000000000","message":"Done","commit_id":"35916e1d3f33e5780f6be94b717484673e7e7e6a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"96dea605b6460688f727c703a5bee0ff93055a5b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"                            help\u003d\u0027wait for introspection to finish; the result\u0027"},{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors occurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occurs the result is\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b574619c","line":75,"range":{"start_line":75,"start_character":29,"end_line":75,"end_character":43},"updated":"2018-11-26 10:22:15.000000000","message":"May be make --check-errors valid only if --wait is given?\nAlso, may be note this options dependency in the docs/reno?","commit_id":"a2f5a9504f61febc94b6247e6a2dfa7cee8287a3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5f77ed6ff0ab34f18d0b3fe0b3ecae0d4c789a33","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"                            help\u003d\u0027wait for introspection to finish; the result\u0027"},{"line_number":74,"context_line":"                            \u0027 will be displayed in the end\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors occurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occurs the result is\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1059a35a","line":75,"range":{"start_line":75,"start_character":29,"end_line":75,"end_character":43},"in_reply_to":"3f79a3b5_b574619c","updated":"2018-11-26 12:13:10.000000000","message":"++ for both","commit_id":"a2f5a9504f61febc94b6247e6a2dfa7cee8287a3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"96dea605b6460688f727c703a5bee0ff93055a5b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors occurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occurs the result is\u0027"},{"line_number":79,"context_line":"                            \u0027 not displayed\u0027)"},{"line_number":80,"context_line":"        return parser"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_55170d43","line":79,"range":{"start_line":78,"start_character":65,"end_line":79,"end_character":43},"updated":"2018-11-26 10:22:15.000000000","message":"nit: will the exception message be displayed?","commit_id":"a2f5a9504f61febc94b6247e6a2dfa7cee8287a3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5f77ed6ff0ab34f18d0b3fe0b3ecae0d4c789a33","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        parser.add_argument(\u0027--check-errors\u0027,"},{"line_number":76,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":77,"context_line":"                            help\u003d\u0027check if errors occurred during the\u0027"},{"line_number":78,"context_line":"                            \u0027 introspection; if any error occurs the result is\u0027"},{"line_number":79,"context_line":"                            \u0027 not displayed\u0027)"},{"line_number":80,"context_line":"        return parser"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_50095b31","line":79,"range":{"start_line":78,"start_character":65,"end_line":79,"end_character":43},"in_reply_to":"3f79a3b5_55170d43","updated":"2018-11-26 12:13:10.000000000","message":"Maybe change this to \"if any error occurs, only the errors are displayed\"?","commit_id":"a2f5a9504f61febc94b6247e6a2dfa7cee8287a3"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"96dea605b6460688f727c703a5bee0ff93055a5b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            result \u003d [(uuid, s.get(\u0027error\u0027))"},{"line_number":91,"context_line":"                      for uuid, s in result.items()]"},{"line_number":92,"context_line":"            if parsed_args.check_errors:"},{"line_number":93,"context_line":"                nodes_error \u003d [r for r in result if r[1] is not None]"},{"line_number":94,"context_line":"                if nodes_error:"},{"line_number":95,"context_line":"                    uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":96,"context_line":"                                             for node_info in nodes_error)"},{"line_number":97,"context_line":"                    raise Exception("},{"line_number":98,"context_line":"                        _(\"Introspection failed for some nodes: %s\")"},{"line_number":99,"context_line":"                        % uuids_errors)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_95f84518","line":96,"range":{"start_line":93,"start_character":15,"end_line":96,"end_character":74},"updated":"2018-11-26 10:22:15.000000000","message":"Just a nit - may be we could (arguably) simplify this piece of code:\n\n    uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info\n                                          for node_info in result if result[1])\n    if uuids_errors:\n        raise ...","commit_id":"a2f5a9504f61febc94b6247e6a2dfa7cee8287a3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb5d26e100374ae0f49e1262d0a75d32a0c3d323","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if parsed_args.check_errors:"},{"line_number":99,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in [r for r in result"},{"line_number":101,"context_line":"                                                           if r[1] is not None]"},{"line_number":102,"context_line":"                                         )"},{"line_number":103,"context_line":"                if uuids_errors:"},{"line_number":104,"context_line":"                    raise Exception("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_475f4edd","line":101,"updated":"2018-11-27 08:54:53.000000000","message":"the nested list is not really needed, you can use \"if node_info[1] is not None\"","commit_id":"c65a04868ffffaa7ad8eefd91c165c7b1a0e37f5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"76e602dc75229dffb42b4142930ce48ac51d1734","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if parsed_args.check_errors:"},{"line_number":99,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in [r for r in result"},{"line_number":101,"context_line":"                                                           if r[1] is not None]"},{"line_number":102,"context_line":"                                         )"},{"line_number":103,"context_line":"                if uuids_errors:"},{"line_number":104,"context_line":"                    raise Exception("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_273fb223","line":101,"in_reply_to":"3f79a3b5_475f4edd","updated":"2018-11-27 09:10:40.000000000","message":"Done","commit_id":"c65a04868ffffaa7ad8eefd91c165c7b1a0e37f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bb5d26e100374ae0f49e1262d0a75d32a0c3d323","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in [r for r in result"},{"line_number":101,"context_line":"                                                           if r[1] is not None]"},{"line_number":102,"context_line":"                                         )"},{"line_number":103,"context_line":"                if uuids_errors:"},{"line_number":104,"context_line":"                    raise Exception("},{"line_number":105,"context_line":"                        _(\"Introspection failed for some nodes: %s\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_e7ff7aae","line":102,"updated":"2018-11-27 08:54:53.000000000","message":"nit: I\u0027d prefer the bracket on the previous line","commit_id":"c65a04868ffffaa7ad8eefd91c165c7b1a0e37f5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"76e602dc75229dffb42b4142930ce48ac51d1734","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in [r for r in result"},{"line_number":101,"context_line":"                                                           if r[1] is not None]"},{"line_number":102,"context_line":"                                         )"},{"line_number":103,"context_line":"                if uuids_errors:"},{"line_number":104,"context_line":"                    raise Exception("},{"line_number":105,"context_line":"                        _(\"Introspection failed for some nodes: %s\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_87348648","line":102,"in_reply_to":"3f79a3b5_e7ff7aae","updated":"2018-11-27 09:10:40.000000000","message":"Done","commit_id":"c65a04868ffffaa7ad8eefd91c165c7b1a0e37f5"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"eead88d82d69e6cf0379cf50de63206032208e5f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib.command import command"},{"line_number":23,"context_line":"from osc_lib import exceptions"},{"line_number":24,"context_line":"from osc_lib.i18n import _"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d2847a10","line":21,"updated":"2018-11-27 09:46:21.000000000","message":"nit: why new line?","commit_id":"d9be450c78bf60b3e56cb1f8ed33aee700f14150"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"414c7301cf29ae1de97de5536586b768a5084a1a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib.command import command"},{"line_number":23,"context_line":"from osc_lib import exceptions"},{"line_number":24,"context_line":"from osc_lib.i18n import _"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_1b18ca80","line":21,"in_reply_to":"3f79a3b5_d2847a10","updated":"2018-11-27 14:34:47.000000000","message":"vim is trolling me \u003d(","commit_id":"d9be450c78bf60b3e56cb1f8ed33aee700f14150"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"eead88d82d69e6cf0379cf50de63206032208e5f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if parsed_args.check_errors:"},{"line_number":99,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in result"},{"line_number":101,"context_line":"                                         if node_info[1] is not None)"},{"line_number":102,"context_line":"                if uuids_errors:"},{"line_number":103,"context_line":"                    raise Exception("},{"line_number":104,"context_line":"                        _(\"Introspection failed for some nodes: %s\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d2d79af3","line":101,"range":{"start_line":101,"start_character":57,"end_line":101,"end_character":67},"updated":"2018-11-27 09:46:21.000000000","message":"nit: even if empty line is possible here (is it?), do we want to treat it as error indication and/or print out?","commit_id":"d9be450c78bf60b3e56cb1f8ed33aee700f14150"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"414c7301cf29ae1de97de5536586b768a5084a1a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if parsed_args.check_errors:"},{"line_number":99,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in result"},{"line_number":101,"context_line":"                                         if node_info[1] is not None)"},{"line_number":102,"context_line":"                if uuids_errors:"},{"line_number":103,"context_line":"                    raise Exception("},{"line_number":104,"context_line":"                        _(\"Introspection failed for some nodes: %s\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_beff44fd","line":101,"range":{"start_line":101,"start_character":57,"end_line":101,"end_character":67},"in_reply_to":"3f79a3b5_d2d79af3","updated":"2018-11-27 14:34:47.000000000","message":"It can happen I would say, I think is more safe to check that is not None \u003d)\n\nhttps://github.com/openstack/python-ironic-inspector-client/blob/master/ironic_inspector_client/v1.py#L184","commit_id":"d9be450c78bf60b3e56cb1f8ed33aee700f14150"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28b7381aa3637b5fd5cd51e5d1b320d7427ebcb0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":78,"context_line":"                            help\u003d\u0027check if errors occurred during the\u0027"},{"line_number":79,"context_line":"                            \u0027 introspection; if any error occurs only the\u0027"},{"line_number":80,"context_line":"                            \u0027 errors are displayed\u0027)"},{"line_number":81,"context_line":"        return parser"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_775303de","line":80,"updated":"2018-11-28 01:49:07.000000000","message":"maybe mention --wait is required in the help message?","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"610fdde0840d3c12f1ad0c8b8c0bfda9d1f89195","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                            action\u003d\u0027store_true\u0027,"},{"line_number":78,"context_line":"                            help\u003d\u0027check if errors occurred during the\u0027"},{"line_number":79,"context_line":"                            \u0027 introspection; if any error occurs only the\u0027"},{"line_number":80,"context_line":"                            \u0027 errors are displayed\u0027)"},{"line_number":81,"context_line":"        return parser"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_dcdc7673","line":80,"in_reply_to":"3f79a3b5_775303de","updated":"2018-11-28 13:15:36.000000000","message":"Done","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d98ffa037a934ebda12377565a3acef42f86b3a8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if parsed_args.check_errors and not parsed_args.wait:"},{"line_number":85,"context_line":"            raise exceptions.CommandError("},{"line_number":86,"context_line":"                _(\"--check-errors can only be used with --wait\"))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        client \u003d self.app.client_manager.baremetal_introspection"},{"line_number":89,"context_line":"        for uuid in parsed_args.node:"},{"line_number":90,"context_line":"            client.introspect(uuid)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_06e5bfce","line":87,"updated":"2018-11-28 08:47:36.000000000","message":"Dunno, I\u0027d prefer them to be separate :)","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28b7381aa3637b5fd5cd51e5d1b320d7427ebcb0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if parsed_args.check_errors and not parsed_args.wait:"},{"line_number":85,"context_line":"            raise exceptions.CommandError("},{"line_number":86,"context_line":"                _(\"--check-errors can only be used with --wait\"))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        client \u003d self.app.client_manager.baremetal_introspection"},{"line_number":89,"context_line":"        for uuid in parsed_args.node:"},{"line_number":90,"context_line":"            client.introspect(uuid)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_7721c34d","line":87,"updated":"2018-11-28 01:49:07.000000000","message":"Thought about another approach, e.g. a --wait-and-check-errors, so we can create a mutually exclusive group, just thinking loudly here :)","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28b7381aa3637b5fd5cd51e5d1b320d7427ebcb0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            result \u003d [(uuid, s.get(\u0027error\u0027))"},{"line_number":96,"context_line":"                      for uuid, s in result.items()]"},{"line_number":97,"context_line":"            if parsed_args.check_errors:"},{"line_number":98,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":99,"context_line":"                                         for node_info in result"},{"line_number":100,"context_line":"                                         if node_info[1] is not None)"},{"line_number":101,"context_line":"                if uuids_errors:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_d76c5735","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":34},"updated":"2018-11-28 01:49:07.000000000","message":"I wonder if \u0027\\n\u0027 may have a better readability here.","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"610fdde0840d3c12f1ad0c8b8c0bfda9d1f89195","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            result \u003d [(uuid, s.get(\u0027error\u0027))"},{"line_number":96,"context_line":"                      for uuid, s in result.items()]"},{"line_number":97,"context_line":"            if parsed_args.check_errors:"},{"line_number":98,"context_line":"                uuids_errors \u003d \", \".join(\"%s (%s)\" % node_info"},{"line_number":99,"context_line":"                                         for node_info in result"},{"line_number":100,"context_line":"                                         if node_info[1] is not None)"},{"line_number":101,"context_line":"                if uuids_errors:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_fcd7f24b","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":34},"in_reply_to":"3f79a3b5_d76c5735","updated":"2018-11-28 13:15:36.000000000","message":"Done","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"}],"releasenotes/notes/introspection-check-errors-587ebb2c00038b5a.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d98ffa037a934ebda12377565a3acef42f86b3a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    If any error occurs no output is displayed and the exit status for the"},{"line_number":7,"context_line":"    command is different from 0 (success)."},{"line_number":8,"context_line":"    If ``--check-errors`` is used without the ``--wait`` a CommandError is"},{"line_number":9,"context_line":"    thrown."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_a625eb17","line":9,"updated":"2018-11-28 08:47:36.000000000","message":"++","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28b7381aa3637b5fd5cd51e5d1b320d7427ebcb0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    waiting for the introspection to finish for the selected nodes."},{"line_number":6,"context_line":"    If any error occurs no output is displayed and the exit status for the"},{"line_number":7,"context_line":"    command is different from 0 (success)."},{"line_number":8,"context_line":"    If ``--check-errors`` is used without the ``--wait`` a CommandError is"},{"line_number":9,"context_line":"    thrown."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_77f9c37e","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":11},"updated":"2018-11-28 01:49:07.000000000","message":"I guess this is too specific as a release note.. we can just note --check-errors can only be used with --wait.","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"610fdde0840d3c12f1ad0c8b8c0bfda9d1f89195","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    waiting for the introspection to finish for the selected nodes."},{"line_number":6,"context_line":"    If any error occurs no output is displayed and the exit status for the"},{"line_number":7,"context_line":"    command is different from 0 (success)."},{"line_number":8,"context_line":"    If ``--check-errors`` is used without the ``--wait`` a CommandError is"},{"line_number":9,"context_line":"    thrown."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_dcb5561b","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":11},"in_reply_to":"3f79a3b5_77f9c37e","updated":"2018-11-28 13:15:36.000000000","message":"Done","commit_id":"129594ef55b0c2bf93eab70f67524e68eb9217c4"}],"releasenotes/notes/releasenotes/notes/introspection-check-errors-851f12c395729183.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5029bd9eed3819d77cead0eefce662c5ab5120","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introspection command got --check-errors flag to verify if any error"},{"line_number":5,"context_line":"    occurred when waitting for the introspection to finish for the selected"},{"line_number":6,"context_line":"    nodes. If any error occurs no output is displayed and the exit status"},{"line_number":7,"context_line":"    for the command is different from 0 (success)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_182a7796","line":4,"updated":"2018-11-20 16:54:49.000000000","message":"nit: \"Adds ``--check-errors`` flag\" (we use present tense + formatting)","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0947a5559bd145e14c1c7fe820d9e1f8adc27fab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introspection command got --check-errors flag to verify if any error"},{"line_number":5,"context_line":"    occurred when waitting for the introspection to finish for the selected"},{"line_number":6,"context_line":"    nodes. If any error occurs no output is displayed and the exit status"},{"line_number":7,"context_line":"    for the command is different from 0 (success)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_e3234311","line":4,"in_reply_to":"3f79a3b5_182a7796","updated":"2018-11-21 07:53:47.000000000","message":"Done","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f5029bd9eed3819d77cead0eefce662c5ab5120","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Introspection command got --check-errors flag to verify if any error"},{"line_number":5,"context_line":"    occurred when waitting for the introspection to finish for the selected"},{"line_number":6,"context_line":"    nodes. If any error occurs no output is displayed and the exit status"},{"line_number":7,"context_line":"    for the command is different from 0 (success)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_382df3ac","line":7,"updated":"2018-11-20 16:54:49.000000000","message":"nit: period in the end","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0947a5559bd145e14c1c7fe820d9e1f8adc27fab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Introspection command got --check-errors flag to verify if any error"},{"line_number":5,"context_line":"    occurred when waitting for the introspection to finish for the selected"},{"line_number":6,"context_line":"    nodes. If any error occurs no output is displayed and the exit status"},{"line_number":7,"context_line":"    for the command is different from 0 (success)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_03275f1f","line":7,"in_reply_to":"3f79a3b5_382df3ac","updated":"2018-11-21 07:53:47.000000000","message":"Done","commit_id":"e8409187591bf29d155e078b02bc2456a95fa9fc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1de3c97851c71f5835ec3c2b4391bbf229a66c8c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``--check-errors`` flag to verify if any error occurred when"},{"line_number":5,"context_line":"    waitting for the introspection to finish for the selected nodes."},{"line_number":6,"context_line":"    If any error occurs no output is displayed and the exit status for the"},{"line_number":7,"context_line":"    command is different from 0 (success)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_ba99b0cf","line":5,"updated":"2018-11-26 09:40:28.000000000","message":"s/waitting/waiting","commit_id":"35916e1d3f33e5780f6be94b717484673e7e7e6a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"279ae7d3babcf840be0d7ce19a691712eee29090","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``--check-errors`` flag to verify if any error occurred when"},{"line_number":5,"context_line":"    waitting for the introspection to finish for the selected nodes."},{"line_number":6,"context_line":"    If any error occurs no output is displayed and the exit status for the"},{"line_number":7,"context_line":"    command is different from 0 (success)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_3ac7e03f","line":5,"in_reply_to":"3f79a3b5_ba99b0cf","updated":"2018-11-26 09:53:49.000000000","message":"Done","commit_id":"35916e1d3f33e5780f6be94b717484673e7e7e6a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"45721de81ad92af2d41c0a4eeccb558b28b2b4be","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    If any error occurs no output is displayed and the exit status for the"},{"line_number":7,"context_line":"    command is different from 0 (success)."},{"line_number":8,"context_line":"    If ``--check-errors`` is used without the ``--wait`` a CommandError is"},{"line_number":9,"context_line":"    throw."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_b308e0d6","line":9,"updated":"2018-11-27 11:53:19.000000000","message":"Nit: thrown :)","commit_id":"d9be450c78bf60b3e56cb1f8ed33aee700f14150"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"414c7301cf29ae1de97de5536586b768a5084a1a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    If any error occurs no output is displayed and the exit status for the"},{"line_number":7,"context_line":"    command is different from 0 (success)."},{"line_number":8,"context_line":"    If ``--check-errors`` is used without the ``--wait`` a CommandError is"},{"line_number":9,"context_line":"    throw."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_7e0d2c34","line":9,"in_reply_to":"3f79a3b5_b308e0d6","updated":"2018-11-27 14:34:47.000000000","message":"Done","commit_id":"d9be450c78bf60b3e56cb1f8ed33aee700f14150"}]}