)]}'
{"doc/source/cli/index.rst":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9a4bca4cd4c5e6e681d93ab2f97197ce9078fcc7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"then displays the results as a table."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag verifies if any error occurred during the"},{"line_number":40,"context_line":"introspection of the selected nodes while waiting for the results, if an errors"},{"line_number":41,"context_line":"occurred no output is displayed, otherwise it shows the result as table."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. note::"},{"line_number":44,"context_line":"    ``--check-errors`` can only be used with ``--wait``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_1a741d8a","line":41,"range":{"start_line":40,"start_character":70,"end_line":41,"end_character":8},"updated":"2018-11-29 02:24:46.000000000","message":"nit: any error occurred in the introspection result of selected nodes,","commit_id":"c5e1fc1eea4a67941a61867ee864221636c36a3e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d4cd97cd29e8a7eb1c48736688902b5cd46b2d60","unresolved":false,"context_lines":[{"line_number":37,"context_line":"then displays the results as a table."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag verifies if any error occurred during the"},{"line_number":40,"context_line":"introspection of the selected nodes while waiting for the results, if an errors"},{"line_number":41,"context_line":"occurred no output is displayed, otherwise it shows the result as table."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. note::"},{"line_number":44,"context_line":"    ``--check-errors`` can only be used with ``--wait``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c36a404f","line":41,"range":{"start_line":40,"start_character":70,"end_line":41,"end_character":8},"in_reply_to":"3f79a3b5_1a741d8a","updated":"2018-11-29 08:11:35.000000000","message":"Done","commit_id":"c5e1fc1eea4a67941a61867ee864221636c36a3e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3fa71e5c9a4a64100e7b957dcc14f57c674b9533","unresolved":false,"context_lines":[{"line_number":37,"context_line":"then displays the results as a table."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag verifies if any error occurred during the"},{"line_number":40,"context_line":"introspection of the selected nodes while waiting for the results, if any error"},{"line_number":41,"context_line":"occurred in the introspection result of selected nodes no output is displayed,"},{"line_number":42,"context_line":"otherwise it shows the result as a table."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_bb2b8fe7","line":40,"range":{"start_line":40,"start_character":65,"end_line":40,"end_character":68},"updated":"2018-11-30 11:03:35.000000000","message":"nit: may be start a new sentence?","commit_id":"99bf9c91d267a134ac599d3afa29dff5f6d52669"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e069b1ee37e934c99bb3a9b4e5ef435fe60575ad","unresolved":false,"context_lines":[{"line_number":37,"context_line":"then displays the results as a table."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag verifies if any error occurred during the"},{"line_number":40,"context_line":"introspection of the selected nodes while waiting for the results, if any error"},{"line_number":41,"context_line":"occurred in the introspection result of selected nodes no output is displayed,"},{"line_number":42,"context_line":"otherwise it shows the result as a table."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_a7c37059","line":40,"range":{"start_line":40,"start_character":65,"end_line":40,"end_character":68},"in_reply_to":"3f79a3b5_bb2b8fe7","updated":"2018-11-30 15:08:48.000000000","message":"Definitely a new sentence.","commit_id":"99bf9c91d267a134ac599d3afa29dff5f6d52669"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3fa71e5c9a4a64100e7b957dcc14f57c674b9533","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag verifies if any error occurred during the"},{"line_number":40,"context_line":"introspection of the selected nodes while waiting for the results, if any error"},{"line_number":41,"context_line":"occurred in the introspection result of selected nodes no output is displayed,"},{"line_number":42,"context_line":"otherwise it shows the result as a table."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_3b3f7f24","line":41,"range":{"start_line":41,"start_character":49,"end_line":41,"end_character":54},"updated":"2018-11-30 11:03:35.000000000","message":"nit: comma?","commit_id":"99bf9c91d267a134ac599d3afa29dff5f6d52669"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3fa71e5c9a4a64100e7b957dcc14f57c674b9533","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag verifies if any error occurred during the"},{"line_number":40,"context_line":"introspection of the selected nodes while waiting for the results, if any error"},{"line_number":41,"context_line":"occurred in the introspection result of selected nodes no output is displayed,"},{"line_number":42,"context_line":"otherwise it shows the result as a table."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_9b32535b","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":8},"updated":"2018-11-30 11:03:35.000000000","message":"nit: is found?","commit_id":"99bf9c91d267a134ac599d3afa29dff5f6d52669"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"91592aec8c70097af8be84f60200da0ee7bca94a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The ``--check-errors`` flag verifies if any error occurred during the"},{"line_number":40,"context_line":"introspection of the selected nodes while waiting for the results. If any error"},{"line_number":41,"context_line":"has occurred in the introspection result of selected nodes no output is"},{"line_number":42,"context_line":"displayed, otherwise it shows the result as a table."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_60e76912","line":41,"range":{"start_line":41,"start_character":58,"end_line":41,"end_character":59},"updated":"2018-12-03 01:21:59.000000000","message":"I feel a break here would be better, but it seems too short to be followed by another sentence, not sure if we should have one.","commit_id":"c4a597318e8a4cb4fd58717a7aecd1b8847a4f88"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"91592aec8c70097af8be84f60200da0ee7bca94a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"displayed, otherwise it shows the result as a table."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".. note::"},{"line_number":45,"context_line":"    ``--check-errors`` can only be used with ``--wait``"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Query introspection status"},{"line_number":48,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_20b3b10e","line":45,"range":{"start_line":45,"start_character":54,"end_line":45,"end_character":55},"updated":"2018-12-03 01:21:59.000000000","message":"missing a period.","commit_id":"c4a597318e8a4cb4fd58717a7aecd1b8847a4f88"}],"ironic_inspector_client/shell.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3fa71e5c9a4a64100e7b957dcc14f57c674b9533","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if parsed_args.check_errors:"},{"line_number":99,"context_line":"                uuids_errors \u003d \"\\n\".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in result"},{"line_number":101,"context_line":"                                         if node_info[1] is not None)"},{"line_number":102,"context_line":"                if uuids_errors:"},{"line_number":103,"context_line":"                    raise Exception("},{"line_number":104,"context_line":"                        _(\"Introspection failed for some nodes: %s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5b159b94","line":101,"range":{"start_line":101,"start_character":57,"end_line":101,"end_character":67},"updated":"2018-11-30 11:03:35.000000000","message":"nit: I know we discussed this versus just `if node_info[1]` on irc, but I can\u0027t recall the outcome. Is `is` still better here?","commit_id":"99bf9c91d267a134ac599d3afa29dff5f6d52669"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e069b1ee37e934c99bb3a9b4e5ef435fe60575ad","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if parsed_args.check_errors:"},{"line_number":99,"context_line":"                uuids_errors \u003d \"\\n\".join(\"%s (%s)\" % node_info"},{"line_number":100,"context_line":"                                         for node_info in result"},{"line_number":101,"context_line":"                                         if node_info[1] is not None)"},{"line_number":102,"context_line":"                if uuids_errors:"},{"line_number":103,"context_line":"                    raise Exception("},{"line_number":104,"context_line":"                        _(\"Introspection failed for some nodes: %s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8774343a","line":101,"range":{"start_line":101,"start_character":57,"end_line":101,"end_character":67},"in_reply_to":"3f79a3b5_5b159b94","updated":"2018-11-30 15:08:48.000000000","message":"I feel like is not none is a little more defensive in this case. LTGM","commit_id":"99bf9c91d267a134ac599d3afa29dff5f6d52669"}]}