)]}'
{"zuul.d/python-ironic-inspector-client-jobs.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c866ddea883914247ce6fe46a4db138ec88283b5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":42,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: direct"},{"line_number":43,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: agent"},{"line_number":44,"context_line":"        IRONIC_ENABLED_RESCUE_INTERFACES: \"fake,agent,no-rescue\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        Q_AGENT: openvswitch"},{"line_number":47,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_62e0ac27","line":44,"updated":"2019-10-24 17:35:30.000000000","message":"It passes, but ideally we don\u0027t want to run it everywhere.","commit_id":"6640d8c62a1ad4886db00de47188114136695d0f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"22897e881fcb08d01886a0b681186483b0a840b6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":42,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: direct"},{"line_number":43,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: agent"},{"line_number":44,"context_line":"        IRONIC_ENABLED_RESCUE_INTERFACES: \"fake,agent,no-rescue\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        Q_AGENT: openvswitch"},{"line_number":47,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_c2a07545","line":44,"in_reply_to":"3fa7e38b_62e0ac27","updated":"2019-10-25 08:47:23.000000000","message":"True, and I had mixed feelings about adding this here, or remove the agent default rescue interface entirely.\nAt the moment we have only 2 jobs running with this as parent, and they\u0027re both contained here, we can always change the behavior in case we add more jobs or if we want simply not run the agent at all.","commit_id":"6640d8c62a1ad4886db00de47188114136695d0f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"88a57cb731012075186bf3175fd9ee2b49da4650","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":42,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: direct"},{"line_number":43,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: agent"},{"line_number":44,"context_line":"        IRONIC_ENABLED_RESCUE_INTERFACES: \"fake,agent,no-rescue\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        Q_AGENT: openvswitch"},{"line_number":47,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_8ffb6fbc","line":44,"in_reply_to":"3fa7e38b_662ae091","updated":"2019-10-28 09:26:52.000000000","message":"right, ok, I will remove the config then","commit_id":"6640d8c62a1ad4886db00de47188114136695d0f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"cf95168572bdefc60a508485812651ebd7430a61","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":42,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: direct"},{"line_number":43,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: agent"},{"line_number":44,"context_line":"        IRONIC_ENABLED_RESCUE_INTERFACES: \"fake,agent,no-rescue\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        Q_AGENT: openvswitch"},{"line_number":47,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_662ae091","line":44,"in_reply_to":"3fa7e38b_c2a07545","updated":"2019-10-28 06:16:30.000000000","message":"Actually rescue is not tested here (see line 25), I suggest we just remove the rescue interface to avoid confusion.","commit_id":"6640d8c62a1ad4886db00de47188114136695d0f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"86b666497b64f5ca77b74080c6b00faf2880f93b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"},{"line_number":41,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":42,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: direct"},{"line_number":43,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: \"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        Q_AGENT: openvswitch"},{"line_number":46,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2d6e0000","line":43,"updated":"2019-10-28 15:28:04.000000000","message":"Let\u0027s do it in a follow-up.","commit_id":"656ae7e2433f490dd10a6e7ed15f605dad6e3463"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"25b121132447d2ae4426369bd03b3ed362a1a808","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        IRONIC_VM_LOG_DIR: \u0027{{ devstack_base_dir }}/ironic-bm-logs\u0027"},{"line_number":41,"context_line":"        IRONIC_VM_SPECS_RAM: 384"},{"line_number":42,"context_line":"        IRONIC_DEFAULT_DEPLOY_INTERFACE: direct"},{"line_number":43,"context_line":"        IRONIC_DEFAULT_RESCUE_INTERFACE: \"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        Q_AGENT: openvswitch"},{"line_number":46,"context_line":"        Q_ML2_TENANT_NETWORK_TYPE: vxlan"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4d849c5e","line":43,"updated":"2019-10-28 14:58:56.000000000","message":"actually you can remove this line, it defaults to \"\" in the devstack script.","commit_id":"656ae7e2433f490dd10a6e7ed15f605dad6e3463"}]}
