)]}'
{"ironicclient/tests/v1/test_node_shell.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c3f680b1c23e4f8fae7f2c531a59e067db3987be","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        args.node \u003d [\u0027node_uuid1\u0027, \u0027node_uuid2\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        n_shell.do_node_delete(client_mock, args)"},{"line_number":66,"context_line":"        client_mock.node.delete.assert_called(\u0027node_uuid1\u0027)"},{"line_number":67,"context_line":"        client_mock.node.delete.assert_called(\u0027node_uuid2\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_do_node_vendor_passthru_with_args(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_6c6614ef","line":66,"updated":"2014-09-11 08:50:49.000000000","message":"I beleive there is no method assert_called in MagicMock (result of this will be also MagicMock). You can use assert_has_calls([mock.call(\u0027node_uuid1\u0027), mock.call(\u0027node_uuid2\u0027)])","commit_id":"021c944d0a20b40ca50016aca36f9b650e9fde1b"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"4bba99d7087049c30a8bb4a057016cdcd1668669","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        args.node \u003d [\u0027node_uuid1\u0027, \u0027node_uuid2\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        n_shell.do_node_delete(client_mock, args)"},{"line_number":66,"context_line":"        client_mock.node.delete.assert_called(\u0027node_uuid1\u0027)"},{"line_number":67,"context_line":"        client_mock.node.delete.assert_called(\u0027node_uuid2\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_do_node_vendor_passthru_with_args(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_f85b8551","line":66,"in_reply_to":"fa98f980_0a963d3f","updated":"2014-09-12 01:10:19.000000000","message":"Done. But when I tested this patch on my machine, error didn\u0027t occur... If you haven\u0027t find this bug, it would be in danger.","commit_id":"021c944d0a20b40ca50016aca36f9b650e9fde1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"335911ebf3110da1f8a0756cf0955ba7092fc143","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        args.node \u003d [\u0027node_uuid1\u0027, \u0027node_uuid2\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        n_shell.do_node_delete(client_mock, args)"},{"line_number":66,"context_line":"        client_mock.node.delete.assert_called(\u0027node_uuid1\u0027)"},{"line_number":67,"context_line":"        client_mock.node.delete.assert_called(\u0027node_uuid2\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_do_node_vendor_passthru_with_args(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_0a963d3f","line":66,"in_reply_to":"fa98f980_6c6614ef","updated":"2014-09-11 16:16:21.000000000","message":"+1 That\u0027s correct...\n\nAnd the way mock handles non-existent attributes is actually pretty error-prone, see: http://paste.openstack.org/show/110202/\n\n...\n\nUsually the way it\u0027s tested it by checking the \"call_args_list\" from the mock object, e.g:\n\n n_shell.do_node_delete(client_mock, args)\n expected \u003d [mock.call(\u0027node_uuid1\u0027),\n             mock.call(\u0027node_uuid2\u0027)]\n self.assertEqual(expected, client_mock.node.delete.call_args_list)","commit_id":"021c944d0a20b40ca50016aca36f9b650e9fde1b"}]}