)]}'
{"ironicclient/tests/v1/test_node_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8db78d0176787df74f7f1fccc3c9fec7e3297463","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        n_shell.do_node_set_provision_state(client_mock, args)"},{"line_number":94,"context_line":"        client_mock.node.set_provision_state.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027node_uuid\u0027, \u0027rebuild\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_do_node_vendor_passthru_without_args(self):"},{"line_number":98,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":99,"context_line":"        args \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_33f60e5e","line":96,"updated":"2014-09-12 02:08:16.000000000","message":"Would it be useful to have a test for a bad provision state?\n\nAlso, if you don\u0027t mind, you inserted these tests between two vendor_passthru tests. Maybe move them below test_do_node_vendor_passthru_without_args().","commit_id":"83630d2e38c0fdd79f76384cea45b68c57547069"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"2be67593a773edd613f6521ff3c7f056191e1864","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        n_shell.do_node_set_provision_state(client_mock, args)"},{"line_number":94,"context_line":"        client_mock.node.set_provision_state.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027node_uuid\u0027, \u0027rebuild\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_do_node_vendor_passthru_without_args(self):"},{"line_number":98,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":99,"context_line":"        args \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_94223da1","line":96,"in_reply_to":"fa98f980_2575e197","updated":"2014-09-12 07:31:52.000000000","message":"I found that it\u0027s impossible to write a test with invalid state, because \"do_node_set_provision_state\" method pass the data without checking the status, then Ironic API throws Exception when invalid status is passed.","commit_id":"83630d2e38c0fdd79f76384cea45b68c57547069"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"632e4576734d690c8d81098fd46d90f6d85fa342","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        n_shell.do_node_set_provision_state(client_mock, args)"},{"line_number":94,"context_line":"        client_mock.node.set_provision_state.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027node_uuid\u0027, \u0027rebuild\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_do_node_vendor_passthru_without_args(self):"},{"line_number":98,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":99,"context_line":"        args \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_2575e197","line":96,"in_reply_to":"fa98f980_33f60e5e","updated":"2014-09-12 02:34:44.000000000","message":"Sure, I\u0027ll add a test with invalid state. Wao, I mistook the place. I\u0027ll move them before test_do_node_vendor_passthru_with_args.","commit_id":"83630d2e38c0fdd79f76384cea45b68c57547069"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71ea48485d30df20186e68c18c67bb5f627bebd6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        n_shell.do_node_set_provision_state(client_mock, args)"},{"line_number":94,"context_line":"        client_mock.node.set_provision_state.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027node_uuid\u0027, \u0027rebuild\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_do_node_vendor_passthru_without_args(self):"},{"line_number":98,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":99,"context_line":"        args \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_1d5398e2","line":96,"in_reply_to":"fa98f980_94223da1","updated":"2014-09-15 15:08:56.000000000","message":"Ah yes, sorry about that. That\u0027s fine. Just move the tests so they don\u0027t separate the two vendor_passthru tests. Thx.","commit_id":"83630d2e38c0fdd79f76384cea45b68c57547069"}]}