)]}'
{"id":"openstack%2Fpython-ironicclient~122236","triplet_id":"openstack%2Fpython-ironicclient~master~Ieecf23de335b15df5811d57ecf9ddd3a30919fa2","project":"openstack/python-ironicclient","branch":"master","topic":"bug/1370583","hashtags":[],"change_id":"Ieecf23de335b15df5811d57ecf9ddd3a30919fa2","subject":"Replace calls to Mock.assert_not_called","status":"MERGED","created":"2014-09-17 20:14:39.000000000","updated":"2014-09-18 10:55:10.000000000","submitted":"2014-09-18 10:55:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"205206b57da3a4e373853c35d91ad02407420378","_number":122236,"virtual_id_number":122236,"owner":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-09-18 10:55:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":0,"date":"2014-09-18 09:31:14.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-09-17 20:30:55.000000000","_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":2,"date":"2014-09-18 09:32:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":1,"date":"2014-09-18 09:32:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-17 20:30:55.000000000","updated_by":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"reviewer":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"state":"REVIEWER"},{"updated":"2014-09-18 09:32:05.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2014-09-18 10:55:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3be25f92b1b6b35fca75f694c76675b9edb85c09","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2014-09-17 20:14:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08c98c6c8b3342e8b95fe9451bdbb1b85f7b06a2","author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"date":"2014-09-17 20:30:55.000000000","message":"Patch Set 1: Code-Review+2\n\nWow, we like making up methods, don\u0027t we?? :)","accounts_in_message":[],"_revision_number":1},{"id":"e005f222b5e1a266655cafaab605409b3eb6a333","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-17 22:01:20.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- check-tripleo-ironic-undercloud-precise-nonha http://logs.openstack.org/36/122236/1/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/43d07e9 : SUCCESS in 1h 18m 01s","accounts_in_message":[],"_revision_number":1},{"id":"47d999da284162c9bc3fccabc7f1a89fde336dfe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-17 22:44:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-ironicclient-python33 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-python33/0d2d5f8 : SUCCESS in 3m 49s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-pep8/7d70e73 : SUCCESS in 1m 41s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/36/122236/1/check/gate-python-ironicclient-docs/8a5049f/doc/build/html/ : SUCCESS in 3m 16s\n- gate-python-ironicclient-python26 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-python26/7a67e6e : SUCCESS in 1m 51s\n- gate-python-ironicclient-python27 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-python27/f4e4d35 : SUCCESS in 1m 56s\n- gate-python-ironicclient-pypy http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-pypy/dfd2ce4 : NOT_REGISTERED\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/36/122236/1/check/check-tempest-dsvm-ironic-pxe_ssh/d29bb7f : SUCCESS in 34m 27s","accounts_in_message":[],"_revision_number":1},{"id":"a169741b5277f4ddcefeee4f1ad1049476fb6ebd","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2014-09-18 09:31:14.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"35a48356d173ae42c45e9c5473e6351fb33960e9","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2014-09-18 09:32:05.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\noh, we need to do something about it... maybe hacking rule?","accounts_in_message":[],"_revision_number":1},{"id":"e1c4467cab2d6c0362b3f479bb26e6448b358a22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 10:17:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-ironicclient-python33 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-python33/1923aa9 : SUCCESS in 3m 48s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-pep8/524b28f : SUCCESS in 1m 41s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/36/122236/1/check/gate-python-ironicclient-docs/a2c41ab/doc/build/html/ : SUCCESS in 2m 14s\n- gate-python-ironicclient-python26 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-python26/f987638 : SUCCESS in 1m 53s\n- gate-python-ironicclient-python27 http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-python27/69e610b : SUCCESS in 3m 17s\n- gate-python-ironicclient-pypy http://logs.openstack.org/36/122236/1/check/gate-python-ironicclient-pypy/12e23d6 : SUCCESS in 2m 17s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/36/122236/1/check/check-tempest-dsvm-ironic-pxe_ssh/e37f3f9 : SUCCESS in 34m 11s","accounts_in_message":[],"_revision_number":1},{"id":"6e601eaaf63696dd8d25cec3d240c8ab13e72e51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 10:17:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3289f3661271d0201c269f844f80e8cd6a509e68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 10:44:14.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- check-tripleo-ironic-undercloud-precise-nonha http://logs.openstack.org/36/122236/1/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/ad1635c : SUCCESS in 1h 12m 56s","accounts_in_message":[],"_revision_number":1},{"id":"4272305522c96ab1559de2a0cd1ce57716904de6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 10:55:10.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"a7090a563df086e9f1dc272a536104d1ead4bf91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 10:55:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded.\n\n- gate-python-ironicclient-python33 http://logs.openstack.org/36/122236/1/gate/gate-python-ironicclient-python33/1e6c682 : SUCCESS in 3m 27s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/36/122236/1/gate/gate-python-ironicclient-docs/308857e/doc/build/html/ : SUCCESS in 3m 29s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/36/122236/1/gate/gate-python-ironicclient-pep8/f10f38d : SUCCESS in 1m 40s\n- gate-python-ironicclient-python26 http://logs.openstack.org/36/122236/1/gate/gate-python-ironicclient-python26/bbbe6b0 : SUCCESS in 2m 07s\n- gate-python-ironicclient-python27 http://logs.openstack.org/36/122236/1/gate/gate-python-ironicclient-python27/5bab559 : SUCCESS in 1m 43s\n- gate-python-ironicclient-pypy http://logs.openstack.org/36/122236/1/gate/gate-python-ironicclient-pypy/208fdd1 : SUCCESS in 2m 47s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/36/122236/1/gate/gate-tempest-dsvm-ironic-pxe_ssh/eb3a42c : SUCCESS in 36m 33s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"727800dcae54b333811c22f6f3420753d6fd4879","revisions":{"727800dcae54b333811c22f6f3420753d6fd4879":{"kind":"REWORK","_number":1,"created":"2014-09-17 20:14:39.000000000","uploader":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"ref":"refs/changes/36/122236/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/36/122236/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/36/122236/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/36/122236/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/36/122236/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/36/122236/1"}}},"commit":{"parents":[{"commit":"b27fb0b31315a440d9e9103ab789652e912ddea8","subject":"Merge \"Add unit test for \"ironic port-update\" shell cmd\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/b27fb0b31315a440d9e9103ab789652e912ddea8"}]}],"author":{"name":"Ruby Loo","email":"rloo@yahoo-inc.com","date":"2014-09-17 20:07:01.000000000","tz":0},"committer":{"name":"Ruby Loo","email":"rloo@yahoo-inc.com","date":"2014-09-17 20:07:01.000000000","tz":0},"subject":"Replace calls to Mock.assert_not_called","message":"Replace calls to Mock.assert_not_called\n\nMock.assert_not_called() isn\u0027t a valid mock method. This replaces\nthose calls with self.assertFalse(\u003cmocked-obj\u003e.called).\n\nIt also fixes one of the tests that was incorrectly (trying to) assert\nusing the wrong mock object.\n\nChange-Id: Ieecf23de335b15df5811d57ecf9ddd3a30919fa2\nCloses-Bug: #1370583\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/727800dcae54b333811c22f6f3420753d6fd4879"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/727800dcae54b333811c22f6f3420753d6fd4879"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}