)]}'
{"ironicclient/tests/v1/test_node_shell.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c8ded091a18dde095402294abeaa87c609c1f349","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        args.power_state \u003d \u0027on\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":88,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027on\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_do_node_set_power_state_off(self):"},{"line_number":91,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_1d3920f3","line":88,"updated":"2014-09-26 06:49:36.000000000","message":"we should verify some behavior, such as should we check if the set_power_state method is called with special input arguments from client shell?","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"67b89d3885c580f2e8e1293c152fe12b82482025","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        args.power_state \u003d \u0027on\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":88,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027on\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_do_node_set_power_state_off(self):"},{"line_number":91,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_20c31858","line":88,"in_reply_to":"da9df570_1d2040ab","updated":"2014-09-26 08:09:27.000000000","message":"I mean, should we add some line to check if the set_power_state is called, such as:\n\n    client_mock.node.set_power_state.assert_called_once_with(...)\n\nHow do you think about?","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"17fbda1cb5280bb8baa7c6d961551c04b2792cae","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        args.power_state \u003d \u0027on\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":88,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027on\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_do_node_set_power_state_off(self):"},{"line_number":91,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_1d2040ab","line":88,"in_reply_to":"da9df570_1d3920f3","updated":"2014-09-26 06:54:46.000000000","message":"\"special\" means invalid arguments? for example, \"ironic node_set_power_state dummystate\" If so, it\u0027s impossible. Because, do_node_set_power_state method pass the data without checking the power status, then Ironic API throws Exception when invalid status is passed.","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f6fdaf4eab2277b7e83e91f76db24ce95c4ff6c8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        args.power_state \u003d \u0027on\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":88,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027on\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_do_node_set_power_state_off(self):"},{"line_number":91,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_baf1e302","line":88,"in_reply_to":"da9df570_20c31858","updated":"2014-09-26 22:36:54.000000000","message":"I agree, we need to assert the function is called correctly.","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"4cf17889fefaf307d8ae3303199dbb3499537a05","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        args.power_state \u003d \u0027on\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":88,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027on\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_do_node_set_power_state_off(self):"},{"line_number":91,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_76b908e9","line":88,"in_reply_to":"da9df570_baf1e302","updated":"2014-09-29 04:30:48.000000000","message":"It\u0027s perfectly my mistake. I\u0027ll fix them.","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c8ded091a18dde095402294abeaa87c609c1f349","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        args.power_state \u003d \u0027off\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":97,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027off\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_do_node_set_power_state_reboot(self):"},{"line_number":100,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_dd531837","line":97,"updated":"2014-09-26 06:49:36.000000000","message":"ditto","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c8ded091a18dde095402294abeaa87c609c1f349","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        args.power_state \u003d \u0027reboot\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":106,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027reboot\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_do_node_vendor_passthru_with_args(self):"},{"line_number":109,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_fd337c11","line":106,"updated":"2014-09-26 06:49:36.000000000","message":"ditto","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f6fdaf4eab2277b7e83e91f76db24ce95c4ff6c8","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":106,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027reboot\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_do_node_vendor_passthru_with_args(self):"},{"line_number":109,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":110,"context_line":"        args \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_3a0173af","line":107,"updated":"2014-09-26 22:36:54.000000000","message":"All three of the tests here are basically the same test just called with different parameter, maybe we can make a single helper method and just call it with the different parameters (\"on\", \"off\", \"reboot\")","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"4cf17889fefaf307d8ae3303199dbb3499537a05","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        n_shell.do_node_set_power_state(client_mock, args)"},{"line_number":106,"context_line":"        client_mock.set_power_state(\u0027node_uuid\u0027, \u0027reboot\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_do_node_vendor_passthru_with_args(self):"},{"line_number":109,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":110,"context_line":"        args \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_36306056","line":107,"in_reply_to":"da9df570_3a0173af","updated":"2014-09-29 04:30:48.000000000","message":"thank you, I\u0027ll do so.","commit_id":"6587bbd6bb37ccf329dcefa0b20cb5e4ece15049"}]}