)]}'
{"id":"openstack%2Fpython-ironicclient~128198","triplet_id":"openstack%2Fpython-ironicclient~master~I23ebbf20d836f0afc507be5c9dbbe1d759a3cddb","project":"openstack/python-ironicclient","branch":"master","topic":"128198","hashtags":[],"change_id":"I23ebbf20d836f0afc507be5c9dbbe1d759a3cddb","subject":"Correct node CREATION_ATTRIBUTE \"uuid\"","status":"MERGED","created":"2014-10-14 07:44:44.000000000","updated":"2014-10-14 21:04:48.000000000","submitted":"2014-10-14 21:04:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"16d7ea374689ad26f7d927ae59cbd45e152d89b4","_number":128198,"virtual_id_number":128198,"owner":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-10-14 21:04:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-10-14 19:33:47.000000000","_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":2,"date":"2014-10-14 20:19:25.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":2,"date":"2014-10-14 20:32:01.000000000","_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":1,"date":"2014-10-14 20:32:01.000000000","_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-14 07:50:01.000000000","updated_by":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"reviewer":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"state":"REVIEWER"},{"updated":"2014-10-14 20:19:25.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2014-10-14 20:32:01.000000000","updated_by":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"reviewer":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"state":"REVIEWER"},{"updated":"2014-10-14 21:04:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"150fb6d295c4191bee4fd47b1dd32cfcf9495cbf","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-10-14 07:44:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87df671a6dbd2c5b0cf8a162bcabcddc9481217f","author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"date":"2014-10-14 07:50:01.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Deva, it lgtm.","accounts_in_message":[],"_revision_number":1},{"id":"1adc02d5eb7137903644837c76f4f486b98fe570","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 08:14:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-ironicclient-python33 http://logs.openstack.org/98/128198/1/check/gate-python-ironicclient-python33/9dc2b59 : SUCCESS in 3m 44s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/98/128198/1/check/gate-python-ironicclient-pep8/19264e0 : SUCCESS in 1m 59s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/98/128198/1/check/gate-python-ironicclient-docs/bc781f0/doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-ironicclient-python26 http://logs.openstack.org/98/128198/1/check/gate-python-ironicclient-python26/d67fbe1 : SUCCESS in 1m 31s\n- gate-python-ironicclient-python27 http://logs.openstack.org/98/128198/1/check/gate-python-ironicclient-python27/35a6a18 : SUCCESS in 1m 58s\n- gate-python-ironicclient-pypy http://logs.openstack.org/98/128198/1/check/gate-python-ironicclient-pypy/752f9fd : SUCCESS in 2m 10s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/98/128198/1/check/check-tempest-dsvm-ironic-pxe_ssh/7c51550 : SUCCESS in 29m 51s","accounts_in_message":[],"_revision_number":1},{"id":"048a8ee1cd88a8d11112a6d3fb8e2f3be51ec8a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 08:32:32.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- check-tripleo-ironic-undercloud-precise-nonha http://logs.openstack.org/98/128198/1/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/993f3e5 : SUCCESS in 47m 46s","accounts_in_message":[],"_revision_number":1},{"id":"a5438887be3c81b92df67e7f745032bf7e08f97a","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2014-10-14 15:40:39.000000000","message":"Patch Set 1: Code-Review-1\n\nGood catch Deva!\n\nCouple of questions:\n1. Should we have a bug for this, since it is a bug that someone might be wondering about\n2. Would be nice to have a unit test for this\n\nOk, one more question (outside the scope of this, but was wondering). Did we decide not to allow supplying the node UUID in the CLI?","accounts_in_message":[],"_revision_number":1},{"id":"98b55a597cc34a604b06c496be78a002cefef4e8","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-10-14 19:32:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c3d05f1e497187efbcb3ee7de8e91a719681ad55","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2014-10-14 19:33:47.000000000","message":"Patch Set 2:\n\n@Ruby, done and done :)\n\nAs far as the CLI allowing a node UUID parameter, I don\u0027t see why not.","accounts_in_message":[],"_revision_number":2},{"id":"c18a5b5205a3f9c2973d18dd4423b88198154af3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 20:07:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ironicclient-python33 http://logs.openstack.org/98/128198/2/check/gate-python-ironicclient-python33/d687788 : SUCCESS in 3m 19s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/98/128198/2/check/gate-python-ironicclient-pep8/939adb0 : SUCCESS in 2m 04s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/98/128198/2/check/gate-python-ironicclient-docs/553f721/doc/build/html/ : SUCCESS in 4m 33s\n- gate-python-ironicclient-python26 http://logs.openstack.org/98/128198/2/check/gate-python-ironicclient-python26/1dc7897 : SUCCESS in 1m 30s\n- gate-python-ironicclient-python27 http://logs.openstack.org/98/128198/2/check/gate-python-ironicclient-python27/f809abf : SUCCESS in 1m 43s\n- gate-python-ironicclient-pypy http://logs.openstack.org/98/128198/2/check/gate-python-ironicclient-pypy/6ba655f : SUCCESS in 1m 25s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/98/128198/2/check/check-tempest-dsvm-ironic-pxe_ssh/919ad57 : SUCCESS in 33m 54s","accounts_in_message":[],"_revision_number":2},{"id":"261b9b3cef0cbab7896d2503fc0e792a5d0730ab","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2014-10-14 20:19:25.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks!\n\nI\u0027ve opened https://bugs.launchpad.net/python-ironicclient/+bug/1381214 to add uuid to the node-create CLI subcommand.","accounts_in_message":[],"_revision_number":2},{"id":"26ebe40c7b1d7899cfb43cb32233c5cfa8298aee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 20:20:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (check-tripleo pipeline).\n\n- check-tripleo-ironic-undercloud-precise-nonha http://logs.openstack.org/98/128198/2/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/1c9ef5c : SUCCESS in 47m 04s","accounts_in_message":[],"_revision_number":2},{"id":"0bd12122314f58ab106f5b0ee3debbb327e50c7e","author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"date":"2014-10-14 20:32:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4392c6f0d2d531f5826eb391870bbd849c679641","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 20:32:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"555608a1c8631e42174d53de1be23fe4d20fe277","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 21:04:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ironicclient-python33 http://logs.openstack.org/98/128198/2/gate/gate-python-ironicclient-python33/5e34063 : SUCCESS in 3m 15s\n- gate-python-ironicclient-docs http://docs-draft.openstack.org/98/128198/2/gate/gate-python-ironicclient-docs/6df543e/doc/build/html/ : SUCCESS in 1m 45s\n- gate-python-ironicclient-pep8 http://logs.openstack.org/98/128198/2/gate/gate-python-ironicclient-pep8/69b6947 : SUCCESS in 2m 04s\n- gate-python-ironicclient-python26 http://logs.openstack.org/98/128198/2/gate/gate-python-ironicclient-python26/d9120ad : SUCCESS in 3m 37s\n- gate-python-ironicclient-python27 http://logs.openstack.org/98/128198/2/gate/gate-python-ironicclient-python27/9c15a84 : SUCCESS in 2m 08s\n- gate-python-ironicclient-pypy http://logs.openstack.org/98/128198/2/gate/gate-python-ironicclient-pypy/fff3a52 : SUCCESS in 2m 11s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/98/128198/2/gate/gate-tempest-dsvm-ironic-pxe_ssh/7d17c1f : SUCCESS in 31m 15s","accounts_in_message":[],"_revision_number":2},{"id":"609efa30555c88b82ca0f193c26f28acb55ff6d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 21:04:48.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e611ae5f206d846e72684ba16c345653232c45c3","revisions":{"ec9e8ddc4d53316054538a569fc63caed3445b1e":{"kind":"REWORK","_number":1,"created":"2014-10-14 07:44:44.000000000","uploader":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"ref":"refs/changes/98/128198/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/98/128198/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/1"}}},"commit":{"parents":[{"commit":"e37735b93cfe76e35c616274fb9e48c5909f7528","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e37735b93cfe76e35c616274fb9e48c5909f7528"}]}],"author":{"name":"Devananda van der Veen","email":"devananda.vdv@gmail.com","date":"2014-10-14 07:42:09.000000000","tz":-420},"committer":{"name":"Devananda van der Veen","email":"devananda.vdv@gmail.com","date":"2014-10-14 07:44:43.000000000","tz":-420},"subject":"Correct node CREATION_ATTRIBUTE \"uuid\"","message":"Correct node CREATION_ATTRIBUTE \"uuid\"\n\nIronic\u0027s REST API allows a client to supply a UUID when registering a node.\nHowever, the client was incorrectly passing this value as the \"node_id\"\nproperty, rather than the \"uuid\" property, resulting in the API service\nignoring the parameter and generating a new UUID anyway.\n\nThis corrects the behavior by passing the appropriately named parameter\nif the user specified a UUID when registering a new node.\n\nChange-Id: I23ebbf20d836f0afc507be5c9dbbe1d759a3cddb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ec9e8ddc4d53316054538a569fc63caed3445b1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/ec9e8ddc4d53316054538a569fc63caed3445b1e"}]},"branch":"refs/heads/master"},"e611ae5f206d846e72684ba16c345653232c45c3":{"kind":"REWORK","_number":2,"created":"2014-10-14 19:32:52.000000000","uploader":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"ref":"refs/changes/98/128198/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ironicclient","ref":"refs/changes/98/128198/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ironicclient refs/changes/98/128198/2"}}},"commit":{"parents":[{"commit":"e37735b93cfe76e35c616274fb9e48c5909f7528","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e37735b93cfe76e35c616274fb9e48c5909f7528"}]}],"author":{"name":"Devananda van der Veen","email":"devananda.vdv@gmail.com","date":"2014-10-14 07:42:09.000000000","tz":-420},"committer":{"name":"Devananda van der Veen","email":"devananda.vdv@gmail.com","date":"2014-10-14 19:23:10.000000000","tz":-420},"subject":"Correct node CREATION_ATTRIBUTE \"uuid\"","message":"Correct node CREATION_ATTRIBUTE \"uuid\"\n\nIronic\u0027s REST API allows a client to supply a UUID when registering a node.\nHowever, the client was incorrectly passing this value as the \"node_id\"\nproperty, rather than the \"uuid\" property, resulting in the API service\nignoring the parameter and generating a new UUID anyway.\n\nThis corrects the behavior by passing the appropriately named parameter\nif the user specified a UUID when registering a new node.\n\nCloses-bug: #1381203\nChange-Id: I23ebbf20d836f0afc507be5c9dbbe1d759a3cddb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e611ae5f206d846e72684ba16c345653232c45c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ironicclient/commit/e611ae5f206d846e72684ba16c345653232c45c3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}