)]}'
{"ironicclient/v1/node_shell.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"d1ba9ebf64ac3451cf399681d642cab49df998f0","unresolved":false,"context_lines":[{"line_number":255,"context_line":"@cliutils.arg(\u0027node\u0027, metavar\u003d\u0027\u003cnode id\u003e\u0027, help\u003d\"UUID of node\")"},{"line_number":256,"context_line":"@cliutils.arg("},{"line_number":257,"context_line":"    \u0027maintenance_state\u0027,"},{"line_number":258,"context_line":"    metavar\u003d\u0027\u003cpower state\u003e\u0027,"},{"line_number":259,"context_line":"    choices\u003d[\u0027on\u0027, \u0027off\u0027],"},{"line_number":260,"context_line":"    help\u003d\"Supported states: \u0027on\u0027 or \u0027off\u0027\")"},{"line_number":261,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_1aab34d7","line":258,"updated":"2014-10-21 20:52:16.000000000","message":"\"power state\" should be \"maintenance state\", right?","commit_id":"e9e6b081bc34710fd3bf18ef7c82a16b753715a4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fe61021fd00549be0f57c9b3dce3f8a86a10dfb4","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    \u0027--reason\u0027,"},{"line_number":263,"context_line":"    metavar\u003d\u0027\u003creason\u003e\u0027,"},{"line_number":264,"context_line":"    default\u003dNone,"},{"line_number":265,"context_line":"    help\u003d\u0027The reason for setting maintenance mode on\u0027)"},{"line_number":266,"context_line":"def do_node_set_maintenance(cc, args):"},{"line_number":267,"context_line":"    \"\"\"Set maintenance mode on or off.\"\"\""},{"line_number":268,"context_line":"    if args.reason and args.maintenance_state \u003d\u003d \u0027off\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_fc7cabb7","line":265,"updated":"2014-10-21 23:13:29.000000000","message":"How about \"The reason for setting maintenance [mode|state] to \u0027on\u0027; not valid when setting to \u0027off\u0027 \"\n\nI\u0027m not sure I like that, but I think it needs something to indicate that it shouldn\u0027t be specified for \u0027off\u0027.","commit_id":"feaf8385b117cfe0f66d52d6378d0068151b3e04"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3782e877dab2d9a5be84003021cf6c7063c546a3","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    \u0027--reason\u0027,"},{"line_number":263,"context_line":"    metavar\u003d\u0027\u003creason\u003e\u0027,"},{"line_number":264,"context_line":"    default\u003dNone,"},{"line_number":265,"context_line":"    help\u003d\u0027The reason for setting maintenance mode on\u0027)"},{"line_number":266,"context_line":"def do_node_set_maintenance(cc, args):"},{"line_number":267,"context_line":"    \"\"\"Set maintenance mode on or off.\"\"\""},{"line_number":268,"context_line":"    if args.reason and args.maintenance_state \u003d\u003d \u0027off\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_a0c9ff79","line":265,"in_reply_to":"9aa7fdbe_fc7cabb7","updated":"2014-10-22 16:00:44.000000000","message":"+1","commit_id":"feaf8385b117cfe0f66d52d6378d0068151b3e04"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fe61021fd00549be0f57c9b3dce3f8a86a10dfb4","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        raise exceptions.CommandError(_(\u0027Cannot set \"reason\" when turning off \u0027"},{"line_number":270,"context_line":"                                        \u0027maintenance mode.\u0027))"},{"line_number":271,"context_line":"    cc.node.set_maintenance(args.node, args.maintenance_state,"},{"line_number":272,"context_line":"                            maint_reason\u003dargs.reason)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"@cliutils.arg(\u0027node\u0027, metavar\u003d\u0027\u003cnode id\u003e\u0027, help\u003d\"UUID of node\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_3cf2b36f","line":272,"updated":"2014-10-21 23:13:29.000000000","message":"I think we should stick with either \u0027maintenance state\u0027 or \u0027maintenance mode\u0027, but not use both.","commit_id":"feaf8385b117cfe0f66d52d6378d0068151b3e04"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3782e877dab2d9a5be84003021cf6c7063c546a3","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        raise exceptions.CommandError(_(\u0027Cannot set \"reason\" when turning off \u0027"},{"line_number":270,"context_line":"                                        \u0027maintenance mode.\u0027))"},{"line_number":271,"context_line":"    cc.node.set_maintenance(args.node, args.maintenance_state,"},{"line_number":272,"context_line":"                            maint_reason\u003dargs.reason)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"@cliutils.arg(\u0027node\u0027, metavar\u003d\u0027\u003cnode id\u003e\u0027, help\u003d\"UUID of node\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_40b053f4","line":272,"in_reply_to":"9aa7fdbe_3cf2b36f","updated":"2014-10-22 16:00:44.000000000","message":"+1 I always use \"mode\" but I\u0027m ok with state as well","commit_id":"feaf8385b117cfe0f66d52d6378d0068151b3e04"}]}