)]}'
{"ironicclient/tests/v1/test_node_shell.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"07fdaf742f31fcf4019c2919e014e16a41c795c6","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        args.uuid \u003d \u0027fef99cb8-a0d1-43df-b084-17b3b42b3cbd\u0027"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        n_shell.do_node_create(client_mock, args)"},{"line_number":149,"context_line":"        client_mock.node.create.assert_called_once_with(uuid\u003dargs.uuid)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_do_node_show(self):"},{"line_number":152,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_2d1eb270","line":149,"updated":"2014-12-03 02:42:12.000000000","message":"It is better that we add more case here:\n\n1. to test the invalid uuid as input, if the expect exception can be  raised\n\n2. to test the result, if the created node uuid \u003d\u003d the input uuid value","commit_id":"403926334c606cb82222727df0e16db683b673a7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e0c2a73356f84d13fcaa05bdbdc738b112375767","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        args.uuid \u003d \u0027fef99cb8-a0d1-43df-b084-17b3b42b3cbd\u0027"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        n_shell.do_node_create(client_mock, args)"},{"line_number":149,"context_line":"        client_mock.node.create.assert_called_once_with(uuid\u003dargs.uuid)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_do_node_show(self):"},{"line_number":152,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_78bdc3b0","line":149,"in_reply_to":"5a890539_2d1eb270","updated":"2014-12-03 15:07:15.000000000","message":"Haomeng, that would be nice, but... \n1. the client doesn\u0027t check for invalid uuid, and the unit test doesn\u0027t actually send the request to ironic\n2. the unit test framework doesn\u0027t support the return of results (or at least, none of the other tests do that)","commit_id":"403926334c606cb82222727df0e16db683b673a7"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"475dbece2288616d082171884a9d7cf2a2fed320","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        args.uuid \u003d \u0027fef99cb8-a0d1-43df-b084-17b3b42b3cbd\u0027"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        n_shell.do_node_create(client_mock, args)"},{"line_number":149,"context_line":"        client_mock.node.create.assert_called_once_with(uuid\u003dargs.uuid)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_do_node_show(self):"},{"line_number":152,"context_line":"        client_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_83820050","line":149,"in_reply_to":"5a890539_78bdc3b0","updated":"2014-12-03 15:16:06.000000000","message":"Agree.\n\n1. I think it\u0027s fine to let the server validate the UUID, return an error if invalid (and yes, it does already do this, contrary to discussion in IRC, see https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L389 and also line 820, these do magic validation).\n\n2. The unit tests can\u0027t talk to the server, there\u0027s no way to create a node here.","commit_id":"403926334c606cb82222727df0e16db683b673a7"}]}