)]}'
{"ironicclient/v1/node_shell.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"760242eb0f9af901932ad0437503e9b9d24eb483","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027],"},{"line_number":290,"context_line":"    help\u003d\"Supported states: \u0027active\u0027 or \u0027deleted\u0027 or \u0027rebuild\u0027\")"},{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision/delete/recreate an instance on/from/on the node.\"\"\""},{"line_number":293,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_fd113c54","line":292,"updated":"2014-11-19 09:33:07.000000000","message":"maybe better to use \u0027rebuild\u0027 instead of recreate?","commit_id":"6f00be26019db0cf2b59e24e825e1aa5614ed1a1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4e74d276676743bc4199522a6d4aef4c3fb018c2","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027],"},{"line_number":290,"context_line":"    help\u003d\"Supported states: \u0027active\u0027 or \u0027deleted\u0027 or \u0027rebuild\u0027\")"},{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision/delete/recreate an instance on/from/on the node.\"\"\""},{"line_number":293,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_cbb90dee","line":292,"in_reply_to":"5a890539_9d675825","updated":"2014-11-19 14:51:42.000000000","message":"I am not fond of using a/b/c and in this case, it is used twice which makes it hard to read.\n\nHow about something like \u0027Provision an instance on, rebuild an instance on, or delete an instance from, a node\u0027.\n\nDon\u0027t forget to update the commit msg to reflect whatever you change here.","commit_id":"6f00be26019db0cf2b59e24e825e1aa5614ed1a1"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"ff4e784ae33a0e970b739332900564773054e8b4","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027],"},{"line_number":290,"context_line":"    help\u003d\"Supported states: \u0027active\u0027 or \u0027deleted\u0027 or \u0027rebuild\u0027\")"},{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision/delete/recreate an instance on/from/on the node.\"\"\""},{"line_number":293,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_81cd1360","line":292,"in_reply_to":"5a890539_cbb90dee","updated":"2014-11-20 01:13:15.000000000","message":"Thank you Ruby, but your suggestion \"Provision an instance on, rebuild an instance on, or delete an instance from, a node\" is over 79 characters, then dockstring error occurs. When preventing docstring error, this looks so odd... anyway, I\u0027ll try to fix it, so could you please check it again?","commit_id":"6f00be26019db0cf2b59e24e825e1aa5614ed1a1"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"de5ac28bea8fcbca90f58be6508c1954d62f878f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    choices\u003d[\u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027],"},{"line_number":290,"context_line":"    help\u003d\"Supported states: \u0027active\u0027 or \u0027deleted\u0027 or \u0027rebuild\u0027\")"},{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision/delete/recreate an instance on/from/on the node.\"\"\""},{"line_number":293,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_9d675825","line":292,"in_reply_to":"5a890539_fd113c54","updated":"2014-11-19 10:01:51.000000000","message":"Definitely. I\u0027ll fix it.","commit_id":"6f00be26019db0cf2b59e24e825e1aa5614ed1a1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d820e9842752281d6b9df6dd103f67b67abc3364","unresolved":false,"context_lines":[{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision an instance on, rebuild an instance on,"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    or delete an instance from, a node."},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_d4afd229","line":294,"updated":"2014-11-20 09:56:26.000000000","message":"that\u0027s not looking nice honestly, especially if you render it. What about just\n\n \"Provision, rebuild or delete an instance\"\n\n?","commit_id":"ac24aa9197a300c728f894b58e42fc7e0942e7c7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0699b5e5f43b79c7aa2a16b15e5511b2c2fc773e","unresolved":false,"context_lines":[{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision an instance on, rebuild an instance on,"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    or delete an instance from, a node."},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_5353ef38","line":294,"in_reply_to":"5a890539_02a3d39e","updated":"2014-11-20 14:35:47.000000000","message":"I\u0027m fine with Dmitry\u0027s suggestion. The idea is to give a short description. If someone looks at the details, they\u0027ll see the node argument ;)\n\nI didn\u0027t look/try it out to see how the multiline version looks, but yeah, I don\u0027t think we\u0027re suppose to have the first line in a docstring be \u003e 79 chars, so the choices are as Dmitry mentioned.","commit_id":"ac24aa9197a300c728f894b58e42fc7e0942e7c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef88b893185f184cfeeacec910281f40ef6b750c","unresolved":false,"context_lines":[{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision an instance on, rebuild an instance on,"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    or delete an instance from, a node."},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_02a3d39e","line":294,"in_reply_to":"5a890539_1a0341b9","updated":"2014-11-20 13:12:47.000000000","message":"Well, it\u0027s not 100% correct. It is now, but we\u0027re moving to be more independent of Nova, so one day (maybe even this cycle) we\u0027ll have Ironic doing provisioning without Nova at all.\n\nThat said, I think \"on a node\" is quite obvious. If you want to keep it, what about:\n\n Provision, rebuild or delete an instance on a node\n\n? Maybe not ideal from language point of view, but should fit into a short description. Otherwise you have to use something multiline:\n\n Provision, rebuild or delete an instance\n\n Provision an instance on, rebuild an instance on\n or delete an instance from, a node.\n\nAnyway, summary should not be broken.","commit_id":"ac24aa9197a300c728f894b58e42fc7e0942e7c7"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"206261ed6ee776752b0c61946f77c7beb88d7585","unresolved":false,"context_lines":[{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision an instance on, rebuild an instance on,"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    or delete an instance from, a node."},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_e97b95f2","line":294,"in_reply_to":"5a890539_5353ef38","updated":"2014-11-25 08:14:03.000000000","message":"That\u0027s right, now I remember, Ironic\u0027s stand-alone will be promoted.So I\u0027ll adopt Dmitry\u0027s 1st suggestion \"Provision, rebuild or delete an instance\". Dmitry, Ruby, thank you.","commit_id":"ac24aa9197a300c728f894b58e42fc7e0942e7c7"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"8bb958aa0ea993a64b8f27af7f7f36098b3c5bac","unresolved":false,"context_lines":[{"line_number":291,"context_line":"def do_node_set_provision_state(cc, args):"},{"line_number":292,"context_line":"    \"\"\"Provision an instance on, rebuild an instance on,"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    or delete an instance from, a node."},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":"    cc.node.set_provision_state(args.node, args.provision_state)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_1a0341b9","line":294,"in_reply_to":"5a890539_d4afd229","updated":"2014-11-20 10:40:51.000000000","message":"In my opinion, the point of ironic\u0027s baremetal provisioning feature is that Nova instance is associated to ironic node, so we should describe about it.","commit_id":"ac24aa9197a300c728f894b58e42fc7e0942e7c7"}]}