)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"49cf9eface08ba4ea149ef8c287f62aa46bdf64e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Metavars are only used in the help strings displayed to the user. To"},{"line_number":19,"context_line":"improve readability (and avoid confusion with variable or argument names),"},{"line_number":20,"context_line":"hyphens and underscores were replaced with spaces."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Help strings were updated. Among other things, they are treated like"},{"line_number":23,"context_line":"sentences with the first letter in upper case, and a period at the end."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_c24bed84","line":20,"updated":"2015-02-19 16:59:30.000000000","message":"I\u0027m used to metavars being all uppercase with underscores.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"66622c8c6b5d0e53ad4d3e095ef96e0254defe08","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Metavars are only used in the help strings displayed to the user. To"},{"line_number":19,"context_line":"improve readability (and avoid confusion with variable or argument names),"},{"line_number":20,"context_line":"hyphens and underscores were replaced with spaces."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Help strings were updated. Among other things, they are treated like"},{"line_number":23,"context_line":"sentences with the first letter in upper case, and a period at the end."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_0f8d067c","line":20,"in_reply_to":"da86d52c_49a5589d","updated":"2015-02-20 02:35:45.000000000","message":"Hmm. Good point about two arguments. I\u0027ll use lowercase with hyphens, since keystone and nova use that. Let me know what you think ;)","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"30f10508d41f78b35869fb16cd8396fec36861cc","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Metavars are only used in the help strings displayed to the user. To"},{"line_number":19,"context_line":"improve readability (and avoid confusion with variable or argument names),"},{"line_number":20,"context_line":"hyphens and underscores were replaced with spaces."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Help strings were updated. Among other things, they are treated like"},{"line_number":23,"context_line":"sentences with the first letter in upper case, and a period at the end."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_49a5589d","line":20,"in_reply_to":"da86d52c_867d7fe9","updated":"2015-02-19 20:40:24.000000000","message":"I don\u0027t care if uppercase or not.  But I do think the metavar should be a single word.  \u0027mac_address\u0027 vs \u0027mac address\u0027.  When reading the help text and using a space it might make someone think that two arguments are to be supplied.\n\nMaybe a benefit to uppercase is less chance people confuse them with the variable name.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"31622e58c85d86895cb95f152f110b98f981ebc3","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Metavars are only used in the help strings displayed to the user. To"},{"line_number":19,"context_line":"improve readability (and avoid confusion with variable or argument names),"},{"line_number":20,"context_line":"hyphens and underscores were replaced with spaces."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Help strings were updated. Among other things, they are treated like"},{"line_number":23,"context_line":"sentences with the first letter in upper case, and a period at the end."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_867d7fe9","line":20,"in_reply_to":"da86d52c_c24bed84","updated":"2015-02-19 20:30:21.000000000","message":"I don\u0027t really care what we use as long as it is consistent. As mentioned, I only changed them to use space because people were confusing them with the variable names. They were lowercase before I started :-)\n\nFWIW, I did a quick grep and the client for glance uses (mostly) uppercase+underscores; keystone uses lowercase+hyphen, nova uses lowercase+ [-,_, ].\n\nSince the metavars I\u0027ve seen in OpenStack are all of the for \u0027\u003c...\u003e\u0027, it seems (to me) odd to use all uppercase between the brackets. That would be like doubly emphasizing *THIS*, if you know what I mean.\n\nLet me know if you think that \u003cUPPERCASE-WORDS\u003e is *BETTER*.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"}],"ironicclient/v1/driver_shell.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"49cf9eface08ba4ea149ef8c287f62aa46bdf64e","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"@cliutils.arg(\u0027driver_name\u0027, metavar\u003d\u0027\u003cdriver\u003e\u0027,"},{"line_number":43,"context_line":"              help\u003d\u0027Name of driver.\u0027)"},{"line_number":44,"context_line":"def do_driver_show(cc, args):"},{"line_number":45,"context_line":"    \"\"\"Show a driver.\"\"\""},{"line_number":46,"context_line":"    driver \u003d cc.driver.get(args.driver_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_220da98f","line":43,"updated":"2015-02-19 16:59:30.000000000","message":"I prefer \u0027Name of the driver\u0027.  Sounds better to me.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"31622e58c85d86895cb95f152f110b98f981ebc3","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"@cliutils.arg(\u0027driver_name\u0027, metavar\u003d\u0027\u003cdriver\u003e\u0027,"},{"line_number":43,"context_line":"              help\u003d\u0027Name of driver.\u0027)"},{"line_number":44,"context_line":"def do_driver_show(cc, args):"},{"line_number":45,"context_line":"    \"\"\"Show a driver.\"\"\""},{"line_number":46,"context_line":"    driver \u003d cc.driver.get(args.driver_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_86c01fe1","line":43,"in_reply_to":"da86d52c_220da98f","updated":"2015-02-19 20:30:21.000000000","message":"This consistency thing is difficult. I think I removed \u0027the\u0027 \u0026 \u0027a\u0027 because there are places where we use eg \u0027UUID of node\u0027.\n\nI agree that having \u0027the\u0027 reads better.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"}],"ironicclient/v1/node_shell.py":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"b5db8acdb30e7da78aaf38c82ae35f6512677c0a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    choices\u003d[\u0027POST\u0027, \u0027PUT\u0027, \u0027GET\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],"},{"line_number":214,"context_line":"    help\u003d\"The HTTP method to use in the request. Valid HTTP \""},{"line_number":215,"context_line":"         \"methods are: \u0027POST\u0027, \u0027PUT\u0027, \u0027GET\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027. \""},{"line_number":216,"context_line":"         \"Defaults to \u0027POST\u0027.\")"},{"line_number":217,"context_line":"def do_node_vendor_passthru(cc, args):"},{"line_number":218,"context_line":"    \"\"\"Call a vendor-passthru extension for a node.\"\"\""},{"line_number":219,"context_line":"    arguments \u003d utils.args_array_to_dict({\u0027args\u0027: args.arguments[0]},"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_dd83f900","line":216,"updated":"2015-02-18 19:50:13.000000000","message":"We still need to support --http_method.","commit_id":"4641881df5cba7723ea663e8324bf08398c6dc55"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9ac48851b8ef00297cd4296389053623bccb5751","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    choices\u003d[\u0027POST\u0027, \u0027PUT\u0027, \u0027GET\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],"},{"line_number":214,"context_line":"    help\u003d\"The HTTP method to use in the request. Valid HTTP \""},{"line_number":215,"context_line":"         \"methods are: \u0027POST\u0027, \u0027PUT\u0027, \u0027GET\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027. \""},{"line_number":216,"context_line":"         \"Defaults to \u0027POST\u0027.\")"},{"line_number":217,"context_line":"def do_node_vendor_passthru(cc, args):"},{"line_number":218,"context_line":"    \"\"\"Call a vendor-passthru extension for a node.\"\"\""},{"line_number":219,"context_line":"    arguments \u003d utils.args_array_to_dict({\u0027args\u0027: args.arguments[0]},"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_026c25cf","line":216,"in_reply_to":"da86d52c_dd83f900","updated":"2015-02-19 16:42:00.000000000","message":"Whoops. Thanks for noticing that. (How did I miss it?!)","commit_id":"4641881df5cba7723ea663e8324bf08398c6dc55"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"49cf9eface08ba4ea149ef8c287f62aa46bdf64e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    \u0027device\u0027,"},{"line_number":372,"context_line":"    metavar\u003d\u0027\u003cboot device\u003e\u0027,"},{"line_number":373,"context_line":"    choices\u003d[\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027, \u0027safe\u0027],"},{"line_number":374,"context_line":"    help\u003d\"\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027 or \u0027safe\u0027.\")"},{"line_number":375,"context_line":"@cliutils.arg("},{"line_number":376,"context_line":"    \u0027--persistent\u0027,"},{"line_number":377,"context_line":"    dest\u003d\u0027persistent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c2c84d24","line":374,"updated":"2015-02-19 16:59:30.000000000","message":"What, No Oxford comma!?!?!?! ;)\n\nI guess I like Oxford comma, but either way is fine.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"31622e58c85d86895cb95f152f110b98f981ebc3","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    \u0027device\u0027,"},{"line_number":372,"context_line":"    metavar\u003d\u0027\u003cboot device\u003e\u0027,"},{"line_number":373,"context_line":"    choices\u003d[\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027, \u0027safe\u0027],"},{"line_number":374,"context_line":"    help\u003d\"\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027 or \u0027safe\u0027.\")"},{"line_number":375,"context_line":"@cliutils.arg("},{"line_number":376,"context_line":"    \u0027--persistent\u0027,"},{"line_number":377,"context_line":"    dest\u003d\u0027persistent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e6771bd2","line":374,"in_reply_to":"da86d52c_c2c84d24","updated":"2015-02-19 20:30:21.000000000","message":"I prefer Oxford commas, but most documentation I\u0027ve seen in Ironic doesn\u0027t use it so I was trying to be consistent. But yeah, you\u0027re right, I\u0027m going to use it anyway!","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"30f10508d41f78b35869fb16cd8396fec36861cc","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    \u0027device\u0027,"},{"line_number":372,"context_line":"    metavar\u003d\u0027\u003cboot device\u003e\u0027,"},{"line_number":373,"context_line":"    choices\u003d[\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027, \u0027safe\u0027],"},{"line_number":374,"context_line":"    help\u003d\"\u0027pxe\u0027, \u0027disk\u0027, \u0027cdrom\u0027, \u0027bios\u0027 or \u0027safe\u0027.\")"},{"line_number":375,"context_line":"@cliutils.arg("},{"line_number":376,"context_line":"    \u0027--persistent\u0027,"},{"line_number":377,"context_line":"    dest\u003d\u0027persistent\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_69a21caf","line":374,"in_reply_to":"da86d52c_e6771bd2","updated":"2015-02-19 20:40:24.000000000","message":"Woo hoo! :)","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"}],"ironicclient/v1/port_shell.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"49cf9eface08ba4ea149ef8c287f62aa46bdf64e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    cliutils.print_dict(data, wrap\u003d72)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@cliutils.arg(\u0027port\u0027, metavar\u003d\u0027\u003cid\u003e\u0027, help\u003d\"UUID of port.\")"},{"line_number":33,"context_line":"@cliutils.arg("},{"line_number":34,"context_line":"    \u0027--address\u0027,"},{"line_number":35,"context_line":"    dest\u003d\u0027address\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a2f43955","line":32,"updated":"2015-02-19 16:59:30.000000000","message":"Maybe:  metavar\u003d\"\u003cMAC_ADDRESS\u003e\"","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"30f10508d41f78b35869fb16cd8396fec36861cc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    cliutils.print_dict(data, wrap\u003d72)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@cliutils.arg(\u0027port\u0027, metavar\u003d\u0027\u003cid\u003e\u0027, help\u003d\"UUID of port.\")"},{"line_number":33,"context_line":"@cliutils.arg("},{"line_number":34,"context_line":"    \u0027--address\u0027,"},{"line_number":35,"context_line":"    dest\u003d\u0027address\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c9ddc842","line":32,"in_reply_to":"da86d52c_6975bc96","updated":"2015-02-19 20:40:24.000000000","message":"Ah, makes sense.  Maybe the help could explain that it depends on --address?  But that might be out of scope for this patch.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"31622e58c85d86895cb95f152f110b98f981ebc3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    cliutils.print_dict(data, wrap\u003d72)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@cliutils.arg(\u0027port\u0027, metavar\u003d\u0027\u003cid\u003e\u0027, help\u003d\"UUID of port.\")"},{"line_number":33,"context_line":"@cliutils.arg("},{"line_number":34,"context_line":"    \u0027--address\u0027,"},{"line_number":35,"context_line":"    dest\u003d\u0027address\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_6975bc96","line":32,"in_reply_to":"da86d52c_a2f43955","updated":"2015-02-19 20:30:21.000000000","message":"It\u0027s either the UUID of the port or the MAC address of the port. That\u0027s why I changed it to \u0027id\u0027. \"UUID or MAC address\" seemed too long and I wasn\u0027t sure if people would get confused by that, since it is only a MAC address if --address is specified.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"49cf9eface08ba4ea149ef8c287f62aa46bdf64e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    help\u003d\"Show detailed information about ports.\")"},{"line_number":54,"context_line":"@cliutils.arg("},{"line_number":55,"context_line":"    \u0027--address\u0027,"},{"line_number":56,"context_line":"    metavar\u003d\u0027\u003caddress\u003e\u0027,"},{"line_number":57,"context_line":"    help\u003d\u0027MAC address of port, to get the port which has this address.\u0027)"},{"line_number":58,"context_line":"@cliutils.arg("},{"line_number":59,"context_line":"    \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c2bdad69","line":56,"updated":"2015-02-19 16:59:30.000000000","message":"Why change this?","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"30f10508d41f78b35869fb16cd8396fec36861cc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    help\u003d\"Show detailed information about ports.\")"},{"line_number":54,"context_line":"@cliutils.arg("},{"line_number":55,"context_line":"    \u0027--address\u0027,"},{"line_number":56,"context_line":"    metavar\u003d\u0027\u003caddress\u003e\u0027,"},{"line_number":57,"context_line":"    help\u003d\u0027MAC address of port, to get the port which has this address.\u0027)"},{"line_number":58,"context_line":"@cliutils.arg("},{"line_number":59,"context_line":"    \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_29c5845b","line":56,"in_reply_to":"da86d52c_09ab60d6","updated":"2015-02-19 20:40:24.000000000","message":"I guess I would prefer macaddress as this is only displayed for help.\n\nI\u0027m used to it being MAC_ADDRESS when the help prints, but if that is not standard procedure it probably makes sense to leave it alone.\n\nMetavar is something to be displayed to user for them to hopefully quickly figure out the type for the argument value.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"31622e58c85d86895cb95f152f110b98f981ebc3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    help\u003d\"Show detailed information about ports.\")"},{"line_number":54,"context_line":"@cliutils.arg("},{"line_number":55,"context_line":"    \u0027--address\u0027,"},{"line_number":56,"context_line":"    metavar\u003d\u0027\u003caddress\u003e\u0027,"},{"line_number":57,"context_line":"    help\u003d\u0027MAC address of port, to get the port which has this address.\u0027)"},{"line_number":58,"context_line":"@cliutils.arg("},{"line_number":59,"context_line":"    \u0027--limit\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_09ab60d6","line":56,"in_reply_to":"da86d52c_c2bdad69","updated":"2015-02-19 20:30:21.000000000","message":"cuz macaddress is incorrect. It is MAC address. But since we\u0027re using --address, and the help shows \u0027MAC address\u0027, I didn\u0027t think it would help much to have \u0027MAC address\u0027. Let me know if you\u0027d prefer \u0027MAC address\u0027.","commit_id":"087c7f94ae5e21fcf54009037f12f52373582604"}]}