)]}'
{"ironicclient/shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0dd85f54b21921108b48772dcef9a7f46617bb5a","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        parser.add_argument(\u0027--ironic-api-version\u0027,"},{"line_number":188,"context_line":"                            default\u003dcliutils.env("},{"line_number":189,"context_line":"                                \u0027IRONIC_API_VERSION\u0027, default\u003d\u00271\u0027),"},{"line_number":190,"context_line":"                            help\u003d\u0027Defaults to env[IRONIC_API_VERSION] \u0027"},{"line_number":191,"context_line":"                            \u0027or 1\u0027)"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_d963ea3f","line":189,"updated":"2015-02-26 01:14:19.000000000","message":"ugh, now it looks yucky compared to the line below. Oh well.\n\nAh, well, if you have to do another revision and feel like it, maybe indent the \u0027or 1\u0027 too.","commit_id":"f32b13fe25d0e74689d063c6ded2829408f02903"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0dd85f54b21921108b48772dcef9a7f46617bb5a","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        elif (args.os_username and"},{"line_number":431,"context_line":"            args.os_password and"},{"line_number":432,"context_line":"            args.os_auth_url and"},{"line_number":433,"context_line":"              (project_id or project_name)):"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            keystone_session \u003d kssession.Session.load_from_cli_options(args)"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_d9f12a6c","line":433,"updated":"2015-02-26 01:14:19.000000000","message":"I have to say, I have no idea what pep8 error this is fixing, but the two lines above it look yucky now. Maybe indent those also so they are aligned? Or is that a no-no?","commit_id":"f32b13fe25d0e74689d063c6ded2829408f02903"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6554fbd77c2df444a329245e1844d4c2fe5cdd27","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            }"},{"line_number":430,"context_line":"        elif (args.os_username and"},{"line_number":431,"context_line":"            args.os_password and"},{"line_number":432,"context_line":"            args.os_auth_url and"},{"line_number":433,"context_line":"              (project_id or project_name)):"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            keystone_session \u003d kssession.Session.load_from_cli_options(args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_f20a8388","line":432,"updated":"2015-02-26 02:57:46.000000000","message":"You didn\u0027t want to indent these? :-(","commit_id":"01279c43c10a76444a591a44634d63bf2799d722"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73c9a16be41077e018b2d58888965d3d3b920e88","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            }"},{"line_number":430,"context_line":"        elif (args.os_username and"},{"line_number":431,"context_line":"            args.os_password and"},{"line_number":432,"context_line":"            args.os_auth_url and"},{"line_number":433,"context_line":"              (project_id or project_name)):"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            keystone_session \u003d kssession.Session.load_from_cli_options(args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b5745968","line":432,"in_reply_to":"ba7be1f8_6894e68a","updated":"2015-02-26 16:28:27.000000000","message":"I\u0027m not quite sure what you mean with your comment. They aren\u0027t covered by what you did, but you did make this \u0027ugly\u0027 with your change.\n\nThe following line used to be aligned with the two above lines, and you indented it for one of the E12* thingies, so now the above two lines look odd.","commit_id":"01279c43c10a76444a591a44634d63bf2799d722"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a65eb393105767496223d9a0432393984181f338","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            }"},{"line_number":430,"context_line":"        elif (args.os_username and"},{"line_number":431,"context_line":"            args.os_password and"},{"line_number":432,"context_line":"            args.os_auth_url and"},{"line_number":433,"context_line":"              (project_id or project_name)):"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            keystone_session \u003d kssession.Session.load_from_cli_options(args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_98706ca5","line":432,"in_reply_to":"ba7be1f8_b5745968","updated":"2015-02-26 16:39:48.000000000","message":"Lines 431 and 432 violate E128, which I didn\u0027t try to fix.  But I will fix these two lines.  Thanks!","commit_id":"01279c43c10a76444a591a44634d63bf2799d722"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"19ac6eb5e76a1d23dfee33b734190704d5d167a0","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            }"},{"line_number":430,"context_line":"        elif (args.os_username and"},{"line_number":431,"context_line":"            args.os_password and"},{"line_number":432,"context_line":"            args.os_auth_url and"},{"line_number":433,"context_line":"              (project_id or project_name)):"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            keystone_session \u003d kssession.Session.load_from_cli_options(args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_6894e68a","line":432,"in_reply_to":"ba7be1f8_f20a8388","updated":"2015-02-26 04:31:08.000000000","message":"I don\u0027t think that those are covered by the E12? codes I did.  I ran autopep8 on only the exact codes.","commit_id":"01279c43c10a76444a591a44634d63bf2799d722"}],"ironicclient/tests/v1/test_node_shell.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0dd85f54b21921108b48772dcef9a7f46617bb5a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        n_shell.do_node_create(client_mock, args)"},{"line_number":115,"context_line":"        kwargs \u003d {"},{"line_number":116,"context_line":"                  \u0027driver_info\u0027: {\u0027arg1\u0027: \u0027val1\u0027, \u0027arg2\u0027: \u0027val2\u0027}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        client_mock.node.create.assert_called_once_with(**kwargs)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_do_node_create_with_properties(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_79759ec9","line":117,"updated":"2015-02-26 01:14:19.000000000","message":"I would prefer these to be under the opening \u0027{\u0027 because it is easier for me to match them that way. I don\u0027t know what others think, but given that it was previously one off from that...","commit_id":"f32b13fe25d0e74689d063c6ded2829408f02903"}]}