)]}'
{"ironicclient/osc/v1/baremetal.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"003d0b76fdfd99e9ee8dd301ea873c6a8ba33f84","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        parser \u003d super(CreateBaremetalPortNode, self).get_parser(prog_name)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027node_uuid\u0027,"},{"line_number":121,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":122,"context_line":"            help\u003d\u0027UUID of the node that this port belongs to.\u0027)"},{"line_number":123,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":32,"id":"5aef4532_0996f1ef","line":120,"updated":"2016-03-08 08:47:01.000000000","message":"according to the spec it should be --node","commit_id":"a9b090e4e9732f781071e32e878c30d72e42a260"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6abacfce87ef33be02bd2adb2117a1c9c4e12ddd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        parser \u003d super(CreateBaremetalPortNode, self).get_parser(prog_name)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027node_uuid\u0027,"},{"line_number":121,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":122,"context_line":"            help\u003d\u0027UUID of the node that this port belongs to.\u0027)"},{"line_number":123,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":32,"id":"5aef4532_a578abf3","line":120,"in_reply_to":"5aef4532_0996f1ef","updated":"2016-03-08 16:52:56.000000000","message":"Not for this one. \n\n* openstack baremetal node create port \u003cuuid\u003e \u003caddress\u003e\n\n  This is an alias for\n  \u0027openstack baremetal port create \u003caddress\u003e --node \u003cuuid\u003e\u0027\n\n  --extra \u003ckey\u003dvalue\u003e       Arbitrary key\u003dvalue metadata. Can be specified\n                            multiple times.","commit_id":"a9b090e4e9732f781071e32e878c30d72e42a260"}],"ironicclient/osc/v1/baremetal_port.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f2f693d919c509cafd299cd35e0489f7ce59af15","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a4dcd0f_8de09127","line":3,"updated":"2015-08-13 05:47:42.000000000","message":"I\u0027m not sure those copyright and author information necessary or not. Because I got a comment regarding the copyright concern in my code review, and removed the copyright [1].\n\n[1] L.127 https://review.openstack.org/#/c/187082/10/ironic/drivers/modules/irmc/vendor.py","commit_id":"a95ca58ae177a19fa7288cd970691302464c2d17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e563b276f404c02c611cad879eb75435f531b2b5","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        field_list \u003d [\u0027address\u0027, \u0027extra\u0027, \u0027node_uuid\u0027]"},{"line_number":55,"context_line":"        fields \u003d dict((k, v) for (k, v) in vars(parsed_args).items()"},{"line_number":56,"context_line":"                      if k in field_list and not (v is None))"},{"line_number":57,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":58,"context_line":"        port \u003d baremetal_client.port.create(**fields)._info"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba15a1d1_66b4bbf1","line":56,"updated":"2015-09-22 15:29:39.000000000","message":"nit: v is not None","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"0905c2c927b8f10e2d9d3722ca9ae54ebf838c63","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        field_list \u003d [\u0027address\u0027, \u0027extra\u0027, \u0027node_uuid\u0027]"},{"line_number":55,"context_line":"        fields \u003d dict((k, v) for (k, v) in vars(parsed_args).items()"},{"line_number":56,"context_line":"                      if k in field_list and not (v is None))"},{"line_number":57,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":58,"context_line":"        port \u003d baremetal_client.port.create(**fields)._info"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba15a1d1_1715b9e3","line":56,"in_reply_to":"ba15a1d1_66b4bbf1","updated":"2015-09-23 17:08:36.000000000","message":"Done","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e563b276f404c02c611cad879eb75435f531b2b5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        fields \u003d dict((k, v) for (k, v) in vars(parsed_args).items()"},{"line_number":56,"context_line":"                      if k in field_list and not (v is None))"},{"line_number":57,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":58,"context_line":"        port \u003d baremetal_client.port.create(**fields)._info"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        port.pop(\u0027links\u0027, None)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba15a1d1_86b78ff4","line":58,"updated":"2015-09-22 15:29:39.000000000","message":"I don\u0027t think we should be using private attributes. better use something like https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/port_shell.py#L23","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"0905c2c927b8f10e2d9d3722ca9ae54ebf838c63","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        fields \u003d dict((k, v) for (k, v) in vars(parsed_args).items()"},{"line_number":56,"context_line":"                      if k in field_list and not (v is None))"},{"line_number":57,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":58,"context_line":"        port \u003d baremetal_client.port.create(**fields)._info"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        port.pop(\u0027links\u0027, None)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba15a1d1_37431d44","line":58,"in_reply_to":"ba15a1d1_86b78ff4","updated":"2015-09-23 17:08:36.000000000","message":"Done. Also, this call should also be without \u0027**\u0027?","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"416ad196fe5e4fda9f815a213ab1dfbdde859e8b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            metavar\u003d\u0027\u003caddress\u003e\u0027,"},{"line_number":40,"context_line":"            help\u003d\u0027MAC address for this port.\u0027)"},{"line_number":41,"context_line":"        parser.add_argument("},{"line_number":42,"context_line":"            \u0027-e\u0027, \u0027--extra\u0027,"},{"line_number":43,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":44,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":45,"context_line":"            help\u003d\"Record arbitrary key/value metadata. \""}],"source_content_type":"text/x-python","patch_set":26,"id":"7a2fa921_7613fe0d","line":42,"updated":"2015-10-07 16:56:10.000000000","message":"Use the term \"property\" for consistency with  OSC\n\nExample:\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v2/image.py#L191-L197","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"61ff7147c06a79d6af0a94be51b49fc86b0dcc1f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            metavar\u003d\u0027\u003caddress\u003e\u0027,"},{"line_number":40,"context_line":"            help\u003d\u0027MAC address for this port.\u0027)"},{"line_number":41,"context_line":"        parser.add_argument("},{"line_number":42,"context_line":"            \u0027-e\u0027, \u0027--extra\u0027,"},{"line_number":43,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":44,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":45,"context_line":"            help\u003d\"Record arbitrary key/value metadata. \""}],"source_content_type":"text/x-python","patch_set":26,"id":"7a2fa921_505cbfec","line":42,"in_reply_to":"7a2fa921_7613fe0d","updated":"2015-10-07 20:36:14.000000000","message":"Please don\u0027t. On nodes objects we have both properties and extra field. Here extra field is the same thing, calling it property will bring confusion.","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3466193560191cf97316a6e7ecc99116810b51be","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        fields \u003d dict((k, v) for (k, v) in vars(parsed_args).items()"},{"line_number":56,"context_line":"                      if k in field_list and v is not None)"},{"line_number":57,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":58,"context_line":"        port \u003d baremetal_client.port.create(fields)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        data \u003d dict([(f, getattr(port, f, \u0027\u0027)) for f in fields])"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3a29b11f_fd4ed76d","line":58,"updated":"2015-10-21 14:53:30.000000000","message":"**fields, not fields: http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.port.html#ironicclient.v1.port.PortManager.create\n\nnot sure why it worked in your testing, but for me it fails with:\n\n ERROR: openstack create() takes exactly 1 argument (2 given)","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"55a177058e42a6553c69ac7f71b12858ad754935","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \u0027node_uuid\u0027,"},{"line_number":35,"context_line":"            metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":36,"context_line":"            help\u003d\u0027UUID of the node that this port belongs to.\u0027)"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027address\u0027,"},{"line_number":39,"context_line":"            metavar\u003d\u0027\u003caddress\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa69d971_d9f523ed","line":36,"updated":"2016-01-05 14:30:46.000000000","message":"The spec says this should be --node","commit_id":"45088a31962aa1bc4968c32999098903b618efba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"78e0679ad6402b039adc91040fed2cbc49128a3c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \u0027node_uuid\u0027,"},{"line_number":35,"context_line":"            metavar\u003d\u0027\u003cnode\u003e\u0027,"},{"line_number":36,"context_line":"            help\u003d\u0027UUID of the node that this port belongs to.\u0027)"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027address\u0027,"},{"line_number":39,"context_line":"            metavar\u003d\u0027\u003caddress\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"7af24918_54c1e97f","line":36,"updated":"2016-03-01 13:55:06.000000000","message":"on the spec we have a --node-argument instead","commit_id":"ba8f60a49abacf33399449b4481ee1e6ac07fea0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":45,"id":"9abb7d3a_142bdb34","line":1,"updated":"2016-06-02 16:19:07.000000000","message":"Unless this is needed, we don\u0027t put it in. (There was a huge discussion about this awhile ago.)","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"b9761ae1307cb683e3b88812d1642928ffd9e7c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_c9ec0bca","line":1,"in_reply_to":"9abb7d3a_142bdb34","updated":"2016-06-06 13:29:57.000000000","message":"Done","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":45,"id":"9abb7d3a_0fed868e","line":3,"updated":"2016-06-02 16:19:07.000000000","message":"Is the copyright the date it was written or when it merges? I\u0027m assuming when it was initially written.","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"b9761ae1307cb683e3b88812d1642928ffd9e7c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_29f94f81","line":3,"in_reply_to":"9abb7d3a_0fed868e","updated":"2016-06-06 13:29:57.000000000","message":"Don\u0027t think it matters much. But yeah, I would say it should be when first written.","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetalPort\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def take_action(self, parsed_args):"},{"line_number":31,"context_line":"        self.log.debug(\"take_action(%s)\" % parsed_args)"},{"line_number":32,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"9abb7d3a_b445afb4","line":30,"updated":"2016-06-02 16:19:07.000000000","message":"for the baremetal node commands, you had the get_parser() method before the take_action().\n\nIt\u0027d be nice if it was consistent, and I find with the get_parser() first, I can see what the args are, then see that they are handled here.","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"b9761ae1307cb683e3b88812d1642928ffd9e7c3","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateBaremetalPort\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def take_action(self, parsed_args):"},{"line_number":31,"context_line":"        self.log.debug(\"take_action(%s)\" % parsed_args)"},{"line_number":32,"context_line":"        baremetal_client \u003d self.app.client_manager.baremetal"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_49c2db34","line":30,"in_reply_to":"9abb7d3a_b445afb4","updated":"2016-06-06 13:29:57.000000000","message":"Done","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027--node\u0027,"},{"line_number":53,"context_line":"            dest\u003d\u0027node_uuid\u0027,"},{"line_number":54,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":55,"context_line":"            help\u003d\u0027UUID of the node that this port belongs to.\u0027)"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027--extra\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","}],"source_content_type":"text/x-python","patch_set":45,"id":"9abb7d3a_cf025eb4","line":55,"updated":"2016-06-02 16:19:07.000000000","message":"this is required. Hmm, the CLI doesn\u0027t enforce this :-(","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"b9761ae1307cb683e3b88812d1642928ffd9e7c3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027--node\u0027,"},{"line_number":53,"context_line":"            dest\u003d\u0027node_uuid\u0027,"},{"line_number":54,"context_line":"            metavar\u003d\u0027\u003cuuid\u003e\u0027,"},{"line_number":55,"context_line":"            help\u003d\u0027UUID of the node that this port belongs to.\u0027)"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027--extra\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_89e203d4","line":55,"in_reply_to":"9abb7d3a_cf025eb4","updated":"2016-06-06 13:29:57.000000000","message":"I can make it required.","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"81698313b99fc13b82d966a2aa78c3b8eaab2a75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_25d787c0","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":18},"updated":"2016-06-07 07:05:32.000000000","message":"nit: 2016","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7b10aca8c23beca3c9533560742cb7547a6e0ce1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_78b487d0","line":2,"in_reply_to":"7aa08908_25d787c0","updated":"2016-06-07 11:40:23.000000000","message":"This code was begun in 2015.","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"81698313b99fc13b82d966a2aa78c3b8eaab2a75","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":45,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":46,"context_line":"            help\u003d\"Record arbitrary key/value metadata. \""},{"line_number":47,"context_line":"                 \"Can be specified multiple times.\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        return parser"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_e05badf4","line":47,"updated":"2016-06-07 07:05:32.000000000","message":"ironicclient supports defining port uuid, not sure if we want to keep this.\nhttps://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/port_shell.py#L155","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef2b330efe097f98b08f2ec3817075e99aaff490","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":45,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":46,"context_line":"            help\u003d\"Record arbitrary key/value metadata. \""},{"line_number":47,"context_line":"                 \"Can be specified multiple times.\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        return parser"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_bfc78a43","line":47,"updated":"2016-06-14 15:02:05.000000000","message":"would be cool to support UUID, but not blocking this patch based on that","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"474e68d38dd0515a3e398971b6b67997757efe3c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":45,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":46,"context_line":"            help\u003d\"Record arbitrary key/value metadata. \""},{"line_number":47,"context_line":"                 \"Can be specified multiple times.\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        return parser"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_ff07b619","line":47,"in_reply_to":"7aa08908_98ffb366","updated":"2016-06-07 13:33:07.000000000","message":"Things have changed since the spec was approved. I think that after Brad gets his patches in, we need to revisit the REST API, the CLI and OSC to make sure they are all in sync, so I am not too worried now about adding port uuid.","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7b10aca8c23beca3c9533560742cb7547a6e0ce1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":45,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":46,"context_line":"            help\u003d\"Record arbitrary key/value metadata. \""},{"line_number":47,"context_line":"                 \"Can be specified multiple times.\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        return parser"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_98ffb366","line":47,"in_reply_to":"7aa08908_e05badf4","updated":"2016-06-07 11:40:23.000000000","message":"It was not part of the blueprint.","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef2b330efe097f98b08f2ec3817075e99aaff490","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":59,"context_line":"        port \u003d baremetal_client.port.create(**fields)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        data \u003d dict([(f, getattr(port, f, \u0027\u0027)) for f in fields])"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        return self.dict2columns(data)"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_1fc33e39","line":61,"updated":"2016-06-14 15:02:05.000000000","message":"we should also show new port UUID and extra items. The \"fields\" list is filtered on line 56, we should not do it for output. So here s/fields/fields_list + [\u0027uuid\u0027]/","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0664739fc2462002dded652e88238d53777b85c8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":59,"context_line":"        port \u003d baremetal_client.port.create(**fields)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        data \u003d dict([(f, getattr(port, f, \u0027\u0027)) for f in fields])"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        return self.dict2columns(data)"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_953f0d86","line":61,"in_reply_to":"7aa08908_1fc33e39","updated":"2016-06-14 15:23:06.000000000","message":"Good catch!","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5f9a2928c1775c2f61ac8e7b5f5dd78edaada8b5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":59,"context_line":"        port \u003d baremetal_client.port.create(**fields)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        data \u003d dict([(f, getattr(port, f, \u0027\u0027)) for f in fields])"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        return self.dict2columns(data)"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_fcd0cb2d","line":61,"in_reply_to":"7aa08908_953f0d86","updated":"2016-06-15 12:36:23.000000000","message":"++\n\nAlso, what about created_at and updated_at?\n\nCan we use https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/resource_fields.py#L186 instead of listing them all here? (looking at https://github.com/openstack/python-ironicclient/blob/c1ef66c7b63f3082f7475de4ed19823947958cd2/ironicclient/v1/port_shell.py#L21-L26)","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e019ffd2706a0ce16b0324a6cc19833e04612851","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        fields \u003d utils.args_array_to_dict(fields, \u0027extra\u0027)"},{"line_number":59,"context_line":"        port \u003d baremetal_client.port.create(**fields)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        data \u003d dict([(f, getattr(port, f, \u0027\u0027)) for f in fields])"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        return self.dict2columns(data)"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_52ec5892","line":61,"in_reply_to":"7aa08908_fcd0cb2d","updated":"2016-06-15 16:49:14.000000000","message":"Right, I forgot about that. We should use PORT_DETAILED_RESOURCE.","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"}],"ironicclient/tests/unit/osc/v1/fakes.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f58efa90c79723fc3f2530b83919162c0bc5ffb5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027links\u0027: []"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"baremetal_port_uuid \u003d \u0027zzz-zzzzzz-zzzz\u0027"},{"line_number":40,"context_line":"baremetal_port_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"},{"line_number":41,"context_line":"baremetal_port_extra \u003d {}"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"da85f559_443d392a","line":39,"updated":"2015-11-09 15:08:51.000000000","message":"Just a comment but, I find it a bit odd that the UUID here is not actually a valid UUID (even the format is wrong)\n\nIt should be 5 groups of characters with the length of each being 8-4-4-4-12.\n\nbaremetal_port_uuid \u003d \u0027bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb\u0027\n\n(I can see the node uuid is also wrong there)","commit_id":"45088a31962aa1bc4968c32999098903b618efba"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027links\u0027: []"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"baremetal_port_uuid \u003d \u0027zzz-zzzzzz-zzzz\u0027"},{"line_number":40,"context_line":"baremetal_port_address \u003d \u0027AA:BB:CC:DD:EE:FF\u0027"},{"line_number":41,"context_line":"baremetal_port_extra \u003d {}"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"9abb7d3a_8f3e9627","line":39,"updated":"2016-06-02 16:19:07.000000000","message":"i\u0027d like to use a valid UUID. but i see that the precedent has already been set :-(","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"}],"ironicclient/tests/unit/osc/v1/test_baremetal_port.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f2f693d919c509cafd299cd35e0489f7ce59af15","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a4dcd0f_edc7d595","line":3,"updated":"2015-08-13 05:47:42.000000000","message":"I\u0027m not sure those copyright and author information necessary or not. Because I got a comment regarding the copyright concern in my code review, and removed the copyright [1].\n\n[1] L.127 https://review.openstack.org/#/c/187082/10/ironic/drivers/modules/irmc/vendor.py","commit_id":"a95ca58ae177a19fa7288cd970691302464c2d17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e563b276f404c02c611cad879eb75435f531b2b5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.baremetal_mock.port.create.assert_called_with("},{"line_number":73,"context_line":"            **args"},{"line_number":74,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba15a1d1_46cad76f","line":73,"updated":"2015-09-22 15:29:39.000000000","message":"nit: ** is not needed, you can provide explicit arguments","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"0905c2c927b8f10e2d9d3722ca9ae54ebf838c63","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.baremetal_mock.port.create.assert_called_with("},{"line_number":73,"context_line":"            **args"},{"line_number":74,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba15a1d1_585cb918","line":73,"in_reply_to":"ba15a1d1_46cad76f","updated":"2015-09-23 17:08:36.000000000","message":"I assume this means that the actual call should also be without \u0027**\u0027?","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"416ad196fe5e4fda9f815a213ab1dfbdde859e8b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironicclient.osc.v1 import baremetal_port"},{"line_number":21,"context_line":"from ironicclient.tests.unit.osc.v1 import fakes as baremetal_fakes"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# from openstackclient.tests import utils as oscutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestBaremetalPort(baremetal_fakes.TestBaremetal):"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a2fa921_b678b690","line":23,"updated":"2015-10-07 16:56:10.000000000","message":"remove unused code","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6666a2dd9ee7f99a1249436030509c04fd8955d6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironicclient.osc.v1 import baremetal_port"},{"line_number":21,"context_line":"from ironicclient.tests.unit.osc.v1 import fakes as baremetal_fakes"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# from openstackclient.tests import utils as oscutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestBaremetalPort(baremetal_fakes.TestBaremetal):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a29b11f_8ceb0278","line":23,"in_reply_to":"7a2fa921_b678b690","updated":"2015-10-21 12:38:10.000000000","message":"Done","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"416ad196fe5e4fda9f815a213ab1dfbdde859e8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestBaremetalPort, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        # Get a shortcut to the FlavorManager Mock"},{"line_number":32,"context_line":"        self.baremetal_mock \u003d self.app.client_manager.baremetal"},{"line_number":33,"context_line":"        self.baremetal_mock.reset_mock()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"7a2fa921_d6ba1223","line":31,"updated":"2015-10-07 16:56:10.000000000","message":"FlavorManager?","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6666a2dd9ee7f99a1249436030509c04fd8955d6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestBaremetalPort, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        # Get a shortcut to the FlavorManager Mock"},{"line_number":32,"context_line":"        self.baremetal_mock \u003d self.app.client_manager.baremetal"},{"line_number":33,"context_line":"        self.baremetal_mock.reset_mock()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3a29b11f_4c02ca3e","line":31,"in_reply_to":"7a2fa921_d6ba1223","updated":"2015-10-21 12:38:10.000000000","message":"Removed","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"416ad196fe5e4fda9f815a213ab1dfbdde859e8b","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        verifylist \u003d ["},{"line_number":57,"context_line":"            (\u0027node_uuid\u0027, \u0027xxx-xxxxxx-xxxx\u0027),"},{"line_number":58,"context_line":"            (\u0027address\u0027, \u0027AA:BB:CC:DD:EE:FF\u0027),"},{"line_number":59,"context_line":"        ]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a2fa921_16c64a9a","line":58,"updated":"2015-10-07 16:56:10.000000000","message":"instead of hardcoding the values, you can re-use the fake values","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6666a2dd9ee7f99a1249436030509c04fd8955d6","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        verifylist \u003d ["},{"line_number":57,"context_line":"            (\u0027node_uuid\u0027, \u0027xxx-xxxxxx-xxxx\u0027),"},{"line_number":58,"context_line":"            (\u0027address\u0027, \u0027AA:BB:CC:DD:EE:FF\u0027),"},{"line_number":59,"context_line":"        ]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a29b11f_4c772ad3","line":58,"in_reply_to":"7a2fa921_16c64a9a","updated":"2015-10-21 12:38:10.000000000","message":"Done","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"416ad196fe5e4fda9f815a213ab1dfbdde859e8b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Set expected values"},{"line_number":67,"context_line":"        args \u003d {"},{"line_number":68,"context_line":"            \u0027address\u0027: \u0027AA:BB:CC:DD:EE:FF\u0027,"},{"line_number":69,"context_line":"            \u0027node_uuid\u0027: \u0027xxx-xxxxxx-xxxx\u0027,"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.baremetal_mock.port.create.assert_called_with(args)"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a2fa921_f6baae09","line":69,"updated":"2015-10-07 16:56:10.000000000","message":"instead of hardcoding the values, you can re-use the fake values","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6666a2dd9ee7f99a1249436030509c04fd8955d6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Set expected values"},{"line_number":67,"context_line":"        args \u003d {"},{"line_number":68,"context_line":"            \u0027address\u0027: \u0027AA:BB:CC:DD:EE:FF\u0027,"},{"line_number":69,"context_line":"            \u0027node_uuid\u0027: \u0027xxx-xxxxxx-xxxx\u0027,"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.baremetal_mock.port.create.assert_called_with(args)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a29b11f_ac4cbe9e","line":69,"in_reply_to":"7a2fa921_f6baae09","updated":"2015-10-21 12:38:10.000000000","message":"Done","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"68f126a02e1978c4554640b4de75ae0f8ad602bb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironicclient.osc.v1 import baremetal_port"},{"line_number":21,"context_line":"from ironicclient.tests.unit.osc.v1 import fakes as baremetal_fakes"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# from openstackclient.tests import utils as oscutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestBaremetalPort(baremetal_fakes.TestBaremetal):"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa80f949_8b7333b1","line":23,"updated":"2015-11-04 12:14:57.000000000","message":"Seems like your change is not modified in this patch.","commit_id":"ef830411a729b4c51523a3714db4a49f36201700"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"68f126a02e1978c4554640b4de75ae0f8ad602bb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestBaremetalPort, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        # Get a shortcut to the FlavorManager Mock"},{"line_number":32,"context_line":"        self.baremetal_mock \u003d self.app.client_manager.baremetal"},{"line_number":33,"context_line":"        self.baremetal_mock.reset_mock()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"fa80f949_6b6e0fcb","line":31,"updated":"2015-11-04 12:14:57.000000000","message":"ditto","commit_id":"ef830411a729b4c51523a3714db4a49f36201700"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":45,"id":"9abb7d3a_8f53366c","line":1,"updated":"2016-06-02 16:19:07.000000000","message":"ditto","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"fe638d6030e87b51e21c07044fd0f6c59586ec7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_da0fabdf","line":1,"in_reply_to":"9abb7d3a_8f53366c","updated":"2016-06-06 14:01:33.000000000","message":"Done","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027node_uuid\u0027: baremetal_fakes.baremetal_uuid,"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.baremetal_mock.port.create.assert_called_with(**args)"}],"source_content_type":"text/x-python","patch_set":45,"id":"9abb7d3a_2b783d8f","line":69,"updated":"2016-06-02 16:19:07.000000000","message":"nit, s/called/called_once/","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"fe638d6030e87b51e21c07044fd0f6c59586ec7e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027node_uuid\u0027: baremetal_fakes.baremetal_uuid,"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.baremetal_mock.port.create.assert_called_with(**args)"}],"source_content_type":"text/x-python","patch_set":45,"id":"7aa08908_faf6e7d5","line":69,"in_reply_to":"9abb7d3a_2b783d8f","updated":"2016-06-06 14:01:33.000000000","message":"Done","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"9abb7d3a_cbf7f18a","line":70,"updated":"2016-06-02 16:19:07.000000000","message":"should we test --extra ?","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"81698313b99fc13b82d966a2aa78c3b8eaab2a75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_4503b342","line":2,"range":{"start_line":2,"start_character":14,"end_line":2,"end_character":18},"updated":"2016-06-07 07:05:32.000000000","message":"ditto","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"7b10aca8c23beca3c9533560742cb7547a6e0ce1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#   Copyright 2015 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":46,"id":"7aa08908_98369350","line":2,"in_reply_to":"7aa08908_4503b342","updated":"2016-06-07 11:40:23.000000000","message":"Ditto.","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"}],"releasenotes/notes/osc-plugin-ff0d897d8441a9e1.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7731f8c65a20abf8bf7276e1152b00d614a5da1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    * openstack baremetal node create"},{"line_number":6,"context_line":"    * openstack baremetal node delete - Supports deleting multiple nodes"},{"line_number":7,"context_line":"    * openstack baremetal node list"},{"line_number":8,"context_line":"    * openstack baremetal node port create"},{"line_number":9,"context_line":"    * openstack baremetal node set"},{"line_number":10,"context_line":"    * openstack baremetal node show"},{"line_number":11,"context_line":"    * openstack baremetal node unset"},{"line_number":12,"context_line":"    * openstack baremetal port create"},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Deprecating the following commands in favor of the new commands:"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"9abb7d3a_55ac4a35","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":37},"updated":"2016-06-02 13:36:36.000000000","message":"please create a separate release note for this change. While unlikely, if this change merges in a different release, the release notes will become broken.","commit_id":"52f71048e4a14e74dfe3acbaa4a7f8058f74eb5d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"142d6e518cfd2d7e4f16b215352cb9ffff5c7956","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    * openstack baremetal node set"},{"line_number":10,"context_line":"    * openstack baremetal node show"},{"line_number":11,"context_line":"    * openstack baremetal node unset"},{"line_number":12,"context_line":"    * openstack baremetal port create"},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Deprecating the following commands in favor of the new commands:"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"9abb7d3a_b02e64a3","line":12,"in_reply_to":"9abb7d3a_5069f824","updated":"2016-06-02 13:50:37.000000000","message":"Probably, I\u0027ll leave it up to other reviewers.","commit_id":"52f71048e4a14e74dfe3acbaa4a7f8058f74eb5d"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"77f04303432c4205dd4a1b6291cb91deaa2a611c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    * openstack baremetal node set"},{"line_number":10,"context_line":"    * openstack baremetal node show"},{"line_number":11,"context_line":"    * openstack baremetal node unset"},{"line_number":12,"context_line":"    * openstack baremetal port create"},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Deprecating the following commands in favor of the new commands:"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"9abb7d3a_5069f824","line":12,"in_reply_to":"9abb7d3a_55ac4a35","updated":"2016-06-02 13:48:22.000000000","message":"Can we hold off on that until it actually happens? Otherwise, it makes sense for these to be in the same release note.","commit_id":"52f71048e4a14e74dfe3acbaa4a7f8058f74eb5d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9536fada355ab3ad2236face1f9a888c6161abb6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    * openstack baremetal node create"},{"line_number":6,"context_line":"    * openstack baremetal node delete - Supports deleting multiple nodes"},{"line_number":7,"context_line":"    * openstack baremetal node list"},{"line_number":8,"context_line":"    * openstack baremetal node port create"},{"line_number":9,"context_line":"    * openstack baremetal node set"},{"line_number":10,"context_line":"    * openstack baremetal node show"},{"line_number":11,"context_line":"    * openstack baremetal node unset"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9abb7d3a_2b995d20","line":8,"updated":"2016-06-02 16:19:07.000000000","message":"this should be removed","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"070f38ad909674beba885e26454fb5655a84b66d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    * openstack baremetal node create"},{"line_number":6,"context_line":"    * openstack baremetal node delete - Supports deleting multiple nodes"},{"line_number":7,"context_line":"    * openstack baremetal node list"},{"line_number":8,"context_line":"    * openstack baremetal node port create"},{"line_number":9,"context_line":"    * openstack baremetal node set"},{"line_number":10,"context_line":"    * openstack baremetal node show"},{"line_number":11,"context_line":"    * openstack baremetal node unset"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"7aa08908_7aee7723","line":8,"in_reply_to":"9abb7d3a_2b995d20","updated":"2016-06-06 14:00:57.000000000","message":"Done","commit_id":"1c5ee176e5793cb2cff87cf856f2d685afcc1bbc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5f9a2928c1775c2f61ac8e7b5f5dd78edaada8b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    * openstack baremetal node set"},{"line_number":9,"context_line":"    * openstack baremetal node show"},{"line_number":10,"context_line":"    * openstack baremetal node unset"},{"line_number":11,"context_line":"    * openstack baremetal port create"},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    Deprecating the following commands in favor of the new commands:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"7aa08908_7cf7bbd4","line":11,"updated":"2016-06-15 12:36:23.000000000","message":"Should we be doing this? It will apear as port create was introduced in the same version as node unset, while it\u0027s not true.","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e019ffd2706a0ce16b0324a6cc19833e04612851","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    * openstack baremetal node set"},{"line_number":9,"context_line":"    * openstack baremetal node show"},{"line_number":10,"context_line":"    * openstack baremetal node unset"},{"line_number":11,"context_line":"    * openstack baremetal port create"},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    Deprecating the following commands in favor of the new commands:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"7aa08908_729cf45d","line":11,"in_reply_to":"7aa08908_7cf7bbd4","updated":"2016-06-15 16:49:14.000000000","message":"I think this is fine. When the client is released, it makes sense in the release notes to show which OSC commands were there. In one list. Otherwise, there will be bits of this spread out in different bullets.","commit_id":"aeae71649f2a201f3165cf92c1976f7b5e961c4b"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e563b276f404c02c611cad879eb75435f531b2b5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    baremetal \u003d ironicclient.osc.plugin"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack.baremetal.v1 \u003d"},{"line_number":32,"context_line":"    baremetal_add_port \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":33,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":34,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":35,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":24,"id":"ba15a1d1_26cfa380","line":32,"updated":"2015-09-22 15:29:39.000000000","message":"not sure what guidelines are, but I\u0027d prefer \u0027baremetal port create\u0027","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"01a926455cf946b3a84948214431f5d29a6b6880","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    baremetal \u003d ironicclient.osc.plugin"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack.baremetal.v1 \u003d"},{"line_number":32,"context_line":"    baremetal_add_port \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":33,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":34,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":35,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":24,"id":"7a2fa921_2a869c13","line":32,"in_reply_to":"ba15a1d1_182c0198","updated":"2015-10-07 02:30:52.000000000","message":"the guideline for OSC is \u003cnoun\u003e_\u003cverb\u003e, so baremetal port create would be more consistent, this also helps with usability.\n\nYou can find some commands here: https://github.com/openstack/python-openstackclient/blob/master/setup.cfg","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"0905c2c927b8f10e2d9d3722ca9ae54ebf838c63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    baremetal \u003d ironicclient.osc.plugin"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"openstack.baremetal.v1 \u003d"},{"line_number":32,"context_line":"    baremetal_add_port \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":33,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":34,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":35,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":24,"id":"ba15a1d1_182c0198","line":32,"in_reply_to":"ba15a1d1_26cfa380","updated":"2015-09-23 17:08:36.000000000","message":"The idea is \"Add a port to this baremetal host\". \u0027baremetal port create\u0027 implies that the port is the main target, but really the baremetal host is.","commit_id":"18977177bb5ccf3af9e5465762501d963303b315"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"416ad196fe5e4fda9f815a213ab1dfbdde859e8b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":33,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":34,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"},{"line_number":35,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":36,"context_line":"    baremetal_set \u003d ironicclient.osc.v1.baremetal:SetBaremetal"},{"line_number":37,"context_line":"    baremetal_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetal"},{"line_number":38,"context_line":"    baremetal_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":26,"id":"7a2fa921_f6306eea","line":35,"updated":"2015-10-07 16:56:10.000000000","message":"nit: it would be to move this to line 38, that way you can group the related command  baremetal_\u003cactions\u003e vs baremetal_port_\u003cactions\u003e","commit_id":"047532a651bcf80a1ebc38528b19b13fc56e120d"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"68f126a02e1978c4554640b4de75ae0f8ad602bb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":33,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":34,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"},{"line_number":35,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":36,"context_line":"    baremetal_set \u003d ironicclient.osc.v1.baremetal:SetBaremetal"},{"line_number":37,"context_line":"    baremetal_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetal"},{"line_number":38,"context_line":"    baremetal_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":27,"id":"fa80f949_8b5d73eb","line":35,"updated":"2015-11-04 12:14:57.000000000","message":"nit: Now that the port is added here named as \u0027baremetal_port\u0027, how about renaming the previous existing \u0027baremetal_*\u0027, which represents the node in baremetal, to \u0027baremetal_node\u0027 to be consistent.","commit_id":"ef830411a729b4c51523a3714db4a49f36201700"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"8689df75f5ee452df5ef5729ef8fb394149e4eb1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":33,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":34,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"},{"line_number":35,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":36,"context_line":"    baremetal_set \u003d ironicclient.osc.v1.baremetal:SetBaremetal"},{"line_number":37,"context_line":"    baremetal_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetal"},{"line_number":38,"context_line":"    baremetal_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":27,"id":"fa80f949_a785ea07","line":35,"in_reply_to":"fa80f949_46521d69","updated":"2015-11-06 02:57:52.000000000","message":"Thanks for your explanation, Brad.","commit_id":"ef830411a729b4c51523a3714db4a49f36201700"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"d94d73480a8c4acbb22d46cf29837afb08000f24","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":33,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":34,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"},{"line_number":35,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":36,"context_line":"    baremetal_set \u003d ironicclient.osc.v1.baremetal:SetBaremetal"},{"line_number":37,"context_line":"    baremetal_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetal"},{"line_number":38,"context_line":"    baremetal_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":27,"id":"fa80f949_e6779100","line":35,"in_reply_to":"fa80f949_8b5d73eb","updated":"2015-11-04 13:28:47.000000000","message":"I don\u0027t think that\u0027s something we want to do. This follows with the naming conventions of other osc plugins.","commit_id":"ef830411a729b4c51523a3714db4a49f36201700"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"b0815d2c3ca6bf3e6cd91479790d8b00ce937f69","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    baremetal_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetal"},{"line_number":33,"context_line":"    baremetal_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetal"},{"line_number":34,"context_line":"    baremetal_list \u003d ironicclient.osc.v1.baremetal:ListBaremetal"},{"line_number":35,"context_line":"    baremetal_port_create \u003d ironicclient.osc.v1.baremetal_port:CreateBaremetalPort"},{"line_number":36,"context_line":"    baremetal_set \u003d ironicclient.osc.v1.baremetal:SetBaremetal"},{"line_number":37,"context_line":"    baremetal_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetal"},{"line_number":38,"context_line":"    baremetal_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetal"}],"source_content_type":"text/x-ttcn-cfg","patch_set":27,"id":"fa80f949_46521d69","line":35,"in_reply_to":"fa80f949_e6779100","updated":"2015-11-04 13:29:19.000000000","message":"Also, it would be disruptive to do so. These commands have already been merged.","commit_id":"ef830411a729b4c51523a3714db4a49f36201700"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"003d0b76fdfd99e9ee8dd301ea873c6a8ba33f84","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    baremetal_node_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetalNode"},{"line_number":35,"context_line":"    baremetal_node_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetalNode"},{"line_number":36,"context_line":"    baremetal_node_list \u003d ironicclient.osc.v1.baremetal:ListBaremetalNode"},{"line_number":37,"context_line":"    baremetal_node_port_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetalPortNode"},{"line_number":38,"context_line":"    baremetal_node_set \u003d ironicclient.osc.v1.baremetal:SetBaremetalNode"},{"line_number":39,"context_line":"    baremetal_node_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetalNode"},{"line_number":40,"context_line":"    baremetal_node_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetalNode"}],"source_content_type":"text/x-ttcn-cfg","patch_set":32,"id":"5aef4532_e998e51d","line":37,"updated":"2016-03-08 08:47:01.000000000","message":"nit: this does not match the spec, but I think this variant is correct","commit_id":"a9b090e4e9732f781071e32e878c30d72e42a260"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6abacfce87ef33be02bd2adb2117a1c9c4e12ddd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    baremetal_node_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetalNode"},{"line_number":35,"context_line":"    baremetal_node_delete \u003d ironicclient.osc.v1.baremetal:DeleteBaremetalNode"},{"line_number":36,"context_line":"    baremetal_node_list \u003d ironicclient.osc.v1.baremetal:ListBaremetalNode"},{"line_number":37,"context_line":"    baremetal_node_port_create \u003d ironicclient.osc.v1.baremetal:CreateBaremetalPortNode"},{"line_number":38,"context_line":"    baremetal_node_set \u003d ironicclient.osc.v1.baremetal:SetBaremetalNode"},{"line_number":39,"context_line":"    baremetal_node_show \u003d ironicclient.osc.v1.baremetal:ShowBaremetalNode"},{"line_number":40,"context_line":"    baremetal_node_unset \u003d ironicclient.osc.v1.baremetal:UnsetBaremetalNode"}],"source_content_type":"text/x-ttcn-cfg","patch_set":32,"id":"5aef4532_25e93b81","line":37,"in_reply_to":"5aef4532_e998e51d","updated":"2016-03-08 16:52:56.000000000","message":"No, it should be baremetal node create port (According to OSC guidelines)","commit_id":"a9b090e4e9732f781071e32e878c30d72e42a260"}]}
